Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mjpegdec: Always reset got_picture at the beginnig of decoding

2022-04-15 Thread Michael Niedermayer
On Thu, Apr 14, 2022 at 05:56:30PM +0200, Andreas Rheinhardt wrote: > Said field is set when parsing a SOF; yet a picture is only allocated > if skip_frame is != AVDISCARD_ALL. This leads to a crash in the > following case: If a jpeg is split into two parts, the first containing > everything before

Re: [FFmpeg-devel] [PATCH v2 1/1] lavc/aarch64: add some neon pix_abs functions

2022-04-15 Thread Martin Storsjö
On Thu, 14 Apr 2022, Swinney, Jonathan wrote: - ff_pix_abs16_neon - ff_pix_abs16_xy2_neon In direct micro benchmarks of these ff functions verses their C implementations, these functions performed as follows on AWS Graviton 2: ff_pix_abs16_neon: c: benchmark ran 10 iterations in 0.955383

Re: [FFmpeg-devel] [PATCH v2 0/1] lavc/aarch64: add some neon pix_abs functions

2022-04-15 Thread Martin Storsjö
On Thu, 14 Apr 2022, Swinney, Jonathan wrote: Thanks Martin for the review. I made some updates according to the suggestions you made. I added a checkasm function, but I'm new to the test framework, so it may need some work still. Thanks for putting in the effort to make a test - that adds

Re: [FFmpeg-devel] [PATCH v14 4/4] avformat/image2: add Jpeg XL as image2 format

2022-04-15 Thread Andreas Rheinhardt
Leo Izen: > > On 4/15/22 07:34, Andreas Rheinhardt wrote: >> Leo Izen: >>> +static int jpegxl_probe(const AVProbeData *p) >>> +{ >>> +    const uint8_t *b = p->buf; >>> + >>> +    /* ISOBMFF-based container */ >>> +    /* 0x4a584c20 == "JXL " */ >>> +    if (AV_RL64(b) == FF_JPEGXL_CONTAINER_SIGNA

Re: [FFmpeg-devel] [PATCH v14 4/4] avformat/image2: add Jpeg XL as image2 format

2022-04-15 Thread Leo Izen
On 4/15/22 07:34, Andreas Rheinhardt wrote: Leo Izen: +static int jpegxl_probe(const AVProbeData *p) +{ +const uint8_t *b = p->buf; + +/* ISOBMFF-based container */ +/* 0x4a584c20 == "JXL " */ +if (AV_RL64(b) == FF_JPEGXL_CONTAINER_SIGNATURE_LE) +return AVPROBE_SCORE_EX

Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-04-15 Thread Leo Izen
On 4/15/22 06:39, Anton Khirnov wrote: Quoting Leo Izen (2022-04-15 03:37:20) On 4/14/22 13:49, Anton Khirnov wrote: Quoting Leo Izen (2022-04-12 07:53:32) + +while (1) { +jret = JxlEncoderProcessOutput(ctx->encoder, &next_out, &available); +if (jret == JXL_ENC_ERROR) { +

Re: [FFmpeg-devel] [PATCH v14 2/4] avcodec/libjxl: add Jpeg XL decoding via libjxl

2022-04-15 Thread Leo Izen
On 4/15/22 07:08, Andreas Rheinhardt wrote: Leo Izen: +return avpkt->size - remaining; If this decoder is supposed to produce multiple frames from one packet of input, it needs to use the receive_frame-callback. For video decoders, it is only checked whether the return value is >=

Re: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output

2022-04-15 Thread Wang Cao
On Tue, Apr 12, 2022 at 12:40 PM Paul B Mahol wrote: > On Mon, Apr 11, 2022 at 10:59 PM Wang Cao < > wangcao-at-google@ffmpeg.org> > wrote: > > > On Sat, Apr 9, 2022 at 5:35 AM Paul B Mahol wrote: > > > > > On Fri, Apr 8, 2022 at 10:41 PM Wang Cao < > > wangcao-at-google@ffmpeg.org > > >

[FFmpeg-devel] [PATCH] avfilter/alimiter: Add an option "comp_delay" that removes the delay introduced by lookahead buffer

2022-04-15 Thread Wang Cao
1. The option also flushes all the valid audio samples in the lookahead buffer so the audio integrity is preserved. Previously the the output audio will lose the amount of audio samples equal to the size of lookahead buffer 2. Add a FATE test to verify that when the filter is working as

Re: [FFmpeg-devel] Request For Comment no Matroska specs

2022-04-15 Thread Martijn van Beurden
As a gentle reminder, the Matroska specification can be commented on until the 22th of this month, so for another 7 days, before it is finalized and submitted to the IETF to start their review process. See the message below for details > Op vr 1 apr. 2022 14:53 schreef Steve Lhomme : >> >> On 2022

Re: [FFmpeg-devel] [PATCH v2 1/1] lavc/aarch64: add some neon pix_abs functions

2022-04-15 Thread Michael Niedermayer
On Thu, Apr 14, 2022 at 04:22:58PM +, Swinney, Jonathan wrote: > - ff_pix_abs16_neon > - ff_pix_abs16_xy2_neon > > In direct micro benchmarks of these ff functions verses their C > implementations, > these functions performed as follows on AWS Graviton 2: > > ff_pix_abs16_neon: > c: bench

[FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char *

2022-04-15 Thread Tristan Matthews
This avoids having to do one pass to calculate the full length to allocate followed by a second pass to actually append values. --- libavformat/librtmp.c | 124 +++--- 1 file changed, 33 insertions(+), 91 deletions(-) diff --git a/libavformat/librtmp.c b/libavf

Re: [FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char *

2022-04-15 Thread Tristan Matthews
On Wed, Apr 13, 2022 at 3:40 PM Marton Balint wrote: > > > On Wed, 13 Apr 2022, Martin Storsjö wrote: > > > On Mon, 11 Apr 2022, Tristan Matthews wrote: > > > >> This avoids having to do one pass to calculate the full length to > allocate > >> followed by a second pass to actually append values

Re: [FFmpeg-devel] [PATCH v14 4/4] avformat/image2: add Jpeg XL as image2 format

2022-04-15 Thread Andreas Rheinhardt
Leo Izen: > This commit adds support to libavformat for muxing > and demuxing Jpeg XL images as image2 streams. > --- > MAINTAINERS| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/img2.c | 1 + > libavformat/img2dec.c

Re: [FFmpeg-devel] [PATCH v14 2/4] avcodec/libjxl: add Jpeg XL decoding via libjxl

2022-04-15 Thread Andreas Rheinhardt
Leo Izen: > This commit adds decoding support to libavcodec > for Jpeg XL images via the external library libjxl. > --- > MAINTAINERS | 1 + > configure | 5 + > doc/general_contents.texi | 7 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c|

Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-04-15 Thread Anton Khirnov
Quoting Leo Izen (2022-04-15 03:37:20) > > On 4/14/22 13:49, Anton Khirnov wrote: > > Quoting Leo Izen (2022-04-12 07:53:32) > >> + > >> +while (1) { > >> +jret = JxlEncoderProcessOutput(ctx->encoder, &next_out, > >> &available); > >> +if (jret == JXL_ENC_ERROR) { > >> +

[FFmpeg-devel] [PATCH] avformat/nut: add float pixel formats support

2022-04-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/raw.c | 9 + libavformat/nut.c| 9 + tests/ref/fate/filter-pixdesc-gbrapf32be | 2 +- tests/ref/fate/filter-pixdesc-gbrapf32le | 2 +- tests/ref/fate/filter-pixdesc-gbrpf32be | 2 +- t

Re: [FFmpeg-devel] [PATCH v8 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-04-15 Thread nil-admirari
No longer applies. New version are at: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295391.html From: Nil Admirari To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v8 5/6] fftools: Enable long path support on Windows (fixes #8885) Date: 28/03/2022 22:43:38 Europe/Moscow --- f

[FFmpeg-devel] [PATCH v9 6/6] fftools: Use UTF-8 on Windows

2022-04-15 Thread Nil Admirari
--- fftools/fftools.manifest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest index 30b7d8fe..d1ac1e4e 100644 --- a/fftools/fftools.manifest +++ b/fftools/fftools.manifest @@ -3,8 +3,10 @@ -http://schemas.micro

[FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-04-15 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c remove MAX_PATH limit. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 90f0

[FFmpeg-devel] [PATCH v9 4/6] fftools/cmdutils.c: Remove MAX_PATH limit and replace fopen with av_fopen_utf8

2022-04-15 Thread Nil Admirari
--- fftools/cmdutils.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 5d7cdc3e..a66dbb22 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -37,6 +37,7 @@ #include "libswresample/sw

[FFmpeg-devel] [PATCH v9 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-04-15 Thread Nil Admirari
--- compat/w32dlfcn.h | 78 ++- 1 file changed, 64 insertions(+), 14 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94efa..0f41f50b 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfcn.h @@ -25,6 +25,30 @@ #if (_WIN32_WINNT <

[FFmpeg-devel] [PATCH v9 2/6] libavformat/avisynth.c: Remove MAX_PATH limit

2022-04-15 Thread Nil Admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8ba2bdea..f7bea8c3 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -34,6 +34,7 @@ /* Platform-specific directives.

[FFmpeg-devel] [PATCH v9 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-04-15 Thread Nil Admirari
--- fftools/Makefile | 5 + fftools/fftools.manifest | 10 ++ fftools/manifest.rc | 3 +++ 3 files changed, 18 insertions(+) create mode 100644 fftools/fftools.manifest create mode 100644 fftools/manifest.rc diff --git a/fftools/Makefile b/fftools/Makefile index 81ad6