[FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: add main10sp support to hevc_qsv

2022-08-16 Thread Wenbin Chen
Main10sp is a combination of Main10 and one_pic_only flag. This profile encode 10bit single still picture. A option "main10sp" is added to ffmpeg-qsv. This option set MFX_PROFILE_HEVC_MAIN10 profile and MFX_HEVC_CONSTR_REXT_ONE_PICTURE_ONLY flag to enable main10sp in ffmpeg-qsv. Signed-off-by: We

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-16 Thread Marton Balint
On Mon, 15 Aug 2022, Thilo Borgmann wrote: diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 18e768b386..22ba654bb0 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -131,6 +131,22 @@ int64_t parse_time_or_die(const char *context, const char *timestr, return us; } +

Re: [FFmpeg-devel] [PATCH] qsvenc_{hevc,h264}: add scenario option

2022-08-16 Thread Xiang, Haihao
On Tue, 2022-08-16 at 12:32 +0200, Anton Khirnov wrote: > Quoting Xiang, Haihao (2022-08-12 06:52:53) > > +#define QSV_OPTION_SCENARIO \ > > +{ "scenario", "A hint to encoder about the scenario for the encoding > > session", OFFSET(qsv.scenario), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 8, VE, > > "scenar

Re: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-16 Thread Gyan Doshi
On 2022-08-17 04:36 am, Stefano Sabatini wrote: On date Tuesday 2022-08-16 00:04:10 +0530, Gyan Doshi wrote: c11fb46731 led to a regression whereby the return code for missing input or input probe is overridden by writer close return code and hence not conveyed in the exit code. --- fftools

[FFmpeg-devel] [PATCH v3] libavcodec/cbs_av1: Add size check before parse obu

2022-08-16 Thread Wenbin Chen
cbs_av1_write_unit() check pbc size after parsing obu frame, and return AVERROR(ENOSPC) if pbc is small. pbc will be reallocated and this obu frame will be parsed again, but this may cause error because CodedBitstreamAV1Context has already been updated, for example ref_order_hint is updated and wil

Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-16 Thread Zhao Zhili
On Tue, 2022-08-16 at 17:32 +0100, Derek Buitenhuis wrote: > On 8/16/2022 5:21 PM, Zhao Zhili wrote: > > get_frag_time() can be called with an mp4 file which has no sidx at > > all. In that case, > > dst_st should have a higher priority than other streams, even if > > sc->has_sidx is false. > > And

Re: [FFmpeg-devel] Patch: fftools/ffprobe.c: avoid overriding error code.

2022-08-16 Thread Stefano Sabatini
Related to: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs On date Monday 2022-07-18 20:40:03 +, Yubo Xie wrote: > fftools/ffprobe.c: avoid overriding error code. > From 7c28459fa1e8d0a375a239257601bb4e47460053 Mon Sep 17 00:00:00 2001 > From: xyb > Date: Mon,

Re: [FFmpeg-devel] Patch: fftools/ffprobe.c: avoid overriding error code.

2022-08-16 Thread Stefano Sabatini
Similar approach as: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs On date Monday 2022-07-18 20:40:03 +, Yubo Xie wrote: > From 7c28459fa1e8d0a375a239257601bb4e47460053 Mon Sep 17 00:00:00 2001 > From: xyb > Date: Mon, 18 Jul 2022 13:31:51 -0700 > Subject: [PA

Re: [FFmpeg-devel] API enhancements / broken promises

2022-08-16 Thread Stefano Sabatini
On date Monday 2022-08-15 18:47:34 +0200, Nicolas George wrote: > Hi. > > Over the years, I have promised quite a few enhancement to FFmpeg's API, > some of them connecting to user interface: stored error messages instead > of just logging, universal serialization of objects into various formats >

Re: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-16 Thread Stefano Sabatini
On date Tuesday 2022-08-16 00:04:10 +0530, Gyan Doshi wrote: > c11fb46731 led to a regression whereby the return code for missing > input or input probe is overridden by writer close return code and > hence not conveyed in the exit code. > --- > fftools/ffprobe.c | 6 +- > 1 file changed, 5 in

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/mpegpicture: Don't copy unnecessarily, fix race

2022-08-16 Thread Michael Niedermayer
On Tue, Aug 16, 2022 at 10:38:55PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sat, Aug 13, 2022 at 05:03:04PM +0200, Andreas Rheinhardt wrote: > >> mpegvideo uses an array of Pictures and when it is done with using > >> them, it only unreferences them incompletely: Some buffers

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/mpegpicture: Don't copy unnecessarily, fix race

2022-08-16 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Aug 13, 2022 at 05:03:04PM +0200, Andreas Rheinhardt wrote: >> mpegvideo uses an array of Pictures and when it is done with using >> them, it only unreferences them incompletely: Some buffers are kept >> so that they can be reused lateron if the same slot in the Pictu

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/mpegpicture: Don't copy unnecessarily, fix race

2022-08-16 Thread Michael Niedermayer
On Sat, Aug 13, 2022 at 05:03:04PM +0200, Andreas Rheinhardt wrote: > mpegvideo uses an array of Pictures and when it is done with using > them, it only unreferences them incompletely: Some buffers are kept > so that they can be reused lateron if the same slot in the Picture > array is reused, maki

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom

2022-08-16 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 08:14:42PM -0300, James Almer wrote: > This duration is equal to the longest duration in all track's tkhd atoms, > which > may be comprised of the sum of all edit lists in each track. Empty edit lists > in tracks represent start_time, and the actual media duration is stored

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: move stream-dependent starttime correction to transcode_init()

2022-08-16 Thread Michael Niedermayer
On Sat, Aug 13, 2022 at 12:01:30PM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Tue Aug 9 > 09:51:25 2022 +0200| [86e9cef77ba8a1481a6b83fd73638f24b645bdb4] | committer: > Anton Khirnov > > fftools/ffmpeg: move stream-dependent starttime correction to transcode_init()

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-16 Thread Thilo Borgmann
Am 16.08.22 um 16:10 schrieb Anton Khirnov: Quoting Thilo Borgmann (2022-08-15 22:02:09) $subject -Thilo From fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= Date: Mon, 15 Aug 2022 21:09:27 +0200 Subject: [PATCH v2 2/4] ffmpeg: Add displa

Re: [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles

2022-08-16 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 03:23:29PM -0700, Philip Langdale wrote: > On Tue, 16 Aug 2022 00:10:49 +0200 > Michael Niedermayer wrote: > > > On Sun, Aug 14, 2022 at 02:33:12PM -0700, Philip Langdale wrote: > > > With the necessary pixel formats defined, we can now expose support > > > for the remaini

Re: [FFmpeg-devel] [PATCH 5/5] ffmpeg: Add {h, v}scale argument to display_matrix option to allow for scaling via the display matrix

2022-08-16 Thread Andreas Rheinhardt
Thilo Borgmann: > --- > doc/ffmpeg.texi | 4 > fftools/ffmpeg_filter.c | 15 +++ > fftools/ffmpeg_opt.c| 10 ++ > libavutil/display.c | 21 + > libavutil/display.h | 28 > 5 files changed, 78 insertions(

Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-16 Thread Derek Buitenhuis
On 8/16/2022 5:21 PM, Zhao Zhili wrote: > get_frag_time() can be called with an mp4 file which has no sidx at all. In > that case, > dst_st should have a higher priority than other streams, even if sc->has_sidx > is false. > And first_tfra_pts might be used here, which makes the check of sc->has_

Re: [FFmpeg-devel] [PATCH] lavu/tx: implement aarch64 NEON SIMD

2022-08-16 Thread Paul B Mahol
On Tue, Aug 16, 2022 at 1:07 PM Anton Khirnov wrote: > Quoting Lynne (2022-08-14 06:31:50) > > New - Total for len 131072 reps 4096 = 1.942836 s > > Old - Segfaults > > ??? > It is trivial. The fft code in lavc crashes in such case. > > -- > Anton Khirnov > __

Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-16 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel-boun...@ffmpeg.org On > Behalf Of Derek Buitenhuis > Sent: 2022年8月16日 22:49 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time > base when seeking a stream without a corresponding sidx >

Re: [FFmpeg-devel] [PATCH 4/5] ffmpeg: Allow printing of option arguments in help output

2022-08-16 Thread Andreas Rheinhardt
Thilo Borgmann: > --- > fftools/cmdutils.c | 5 + > libavutil/opt.c| 14 +- > libavutil/opt.h| 8 > 3 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 22ba654bb0..dae018f83a 100644 > --- a/fftools/cm

Re: [FFmpeg-devel] [PATCH 2/5] ffmpeg: Add display_matrix option

2022-08-16 Thread Andreas Rheinhardt
Thilo Borgmann: > From: Jan Ekström > > This enables overriding the rotation as well as horizontal/vertical > flip state of a specific video stream on the input side. > > Additionally, switch the singular test that was utilizing the rotation > metadata to instead override the input display rotat

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: store a separate copy of input codec parameters

2022-08-16 Thread Anton Khirnov
Quoting James Almer (2022-08-16 14:21:31) > On 8/13/2022 12:36 PM, Anton Khirnov wrote: > > Use it instead of AVStream.codecpar in the main thread. While > > AVStream.codecpar is documented to only be updated when the stream is > > added or avformat_find_stream_info(), it is actually updated during

Re: [FFmpeg-devel] [PATCH 2/5] ffmpeg: Add display_matrix option

2022-08-16 Thread Andreas Rheinhardt
Thilo Borgmann: > From: Jan Ekström > > This enables overriding the rotation as well as horizontal/vertical > flip state of a specific video stream on the input side. > > Additionally, switch the singular test that was utilizing the rotation > metadata to instead override the input display rotat

[FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-16 Thread Derek Buitenhuis
Some muxers, such as GPAC, create files with only one sidx, but two streams muxed into the same fragments pointed to by this sidx. Prevously, in such a case, when we seeked in such files, we fell back to, for example, using the sidx associated with the video stream, to seek the audio stream, leavi

Re: [FFmpeg-devel] [PATCH v2] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-16 Thread Derek Buitenhuis
On 8/14/2022 7:55 AM, Zhao Zhili wrote: > Or just continue the loop, and print a warning message maybe? Done, and v3 sent. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-16 Thread Michael Niedermayer
On Mon, Aug 15, 2022 at 11:47:53PM +0200, Michael Niedermayer wrote: [...] > If one was concerned that using a default gateway could be seen > as endorsment by us. Be concerned please about how FFmpeg looks > when its developers attack other projects on its official development IRC > channels. iv

Re: [FFmpeg-devel] [PATCH 1/5] fftools: Add support for dictionary options

2022-08-16 Thread Andreas Rheinhardt
Thilo Borgmann: > From: Jan Ekström > > --- > fftools/cmdutils.c | 18 ++ > fftools/cmdutils.h | 2 ++ > fftools/ffmpeg_opt.c | 11 +-- > 3 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 18e768b386..2

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-16 Thread Anton Khirnov
Quoting Thilo Borgmann (2022-08-15 22:02:09) > $subject > > -Thilo > From fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= > Date: Mon, 15 Aug 2022 21:09:27 +0200 > Subject: [PATCH v2 2/4] ffmpeg: Add display_matrix option > > This enables

Re: [FFmpeg-devel] [PATCH 5/5] ffmpeg: Add {h, v}scale argument to display_matrix option to allow for scaling via the display matrix

2022-08-16 Thread Thilo Borgmann
Am 16.08.22 um 15:30 schrieb Thilo Borgmann: --- doc/ffmpeg.texi | 4 fftools/ffmpeg_filter.c | 15 +++ fftools/ffmpeg_opt.c| 10 ++ libavutil/display.c | 21 + libavutil/display.h | 28 5 files

[FFmpeg-devel] [PATCH 5/5] ffmpeg: Add {h, v}scale argument to display_matrix option to allow for scaling via the display matrix

2022-08-16 Thread Thilo Borgmann
--- doc/ffmpeg.texi | 4 fftools/ffmpeg_filter.c | 15 +++ fftools/ffmpeg_opt.c| 10 ++ libavutil/display.c | 21 + libavutil/display.h | 28 5 files changed, 78 insertions(+) diff --git a/doc/ffmpeg.te

[FFmpeg-devel] [PATCH 4/5] ffmpeg: Allow printing of option arguments in help output

2022-08-16 Thread Thilo Borgmann
--- fftools/cmdutils.c | 5 + libavutil/opt.c| 14 +- libavutil/opt.h| 8 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 22ba654bb0..dae018f83a 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c

[FFmpeg-devel] [PATCH 3/5] ffmpeg: Deprecate display rotation override with a metadata key

2022-08-16 Thread Thilo Borgmann
From: Jan Ekström Now that we have proper options for defining display matrix overrides, this should no longer be required. fftools does not have its own versioning, so for now the define is just set to 1 and disables the functionality if set to zero. --- fftools/ffmpeg.c | 2 ++ fftools/f

[FFmpeg-devel] [PATCH 2/5] ffmpeg: Add display_matrix option

2022-08-16 Thread Thilo Borgmann
From: Jan Ekström This enables overriding the rotation as well as horizontal/vertical flip state of a specific video stream on the input side. Additionally, switch the singular test that was utilizing the rotation metadata to instead override the input display rotation, thus leading to the same

[FFmpeg-devel] [PATCH 1/5] fftools: Add support for dictionary options

2022-08-16 Thread Thilo Borgmann
From: Jan Ekström --- fftools/cmdutils.c | 18 ++ fftools/cmdutils.h | 2 ++ fftools/ffmpeg_opt.c | 11 +-- 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 18e768b386..22ba654bb0 100644 --- a/fftools/cmdut

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: store a separate copy of input codec parameters

2022-08-16 Thread Andreas Rheinhardt
James Almer: > On 8/13/2022 12:36 PM, Anton Khirnov wrote: >> Use it instead of AVStream.codecpar in the main thread. While >> AVStream.codecpar is documented to only be updated when the stream is >> added or avformat_find_stream_info(), it is actually updated during >> demuxing. Accessing it from

Re: [FFmpeg-devel] [PATCH v3] lavc/aarch64: hevc_add_res add 12bit variants

2022-08-16 Thread Martin Storsjö
On Tue, 16 Aug 2022, J. Dekker wrote: hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7 hevc_add_res_32x32_12_neon: 261.0 Signed-o

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: store a separate copy of input codec parameters

2022-08-16 Thread James Almer
On 8/13/2022 12:36 PM, Anton Khirnov wrote: Use it instead of AVStream.codecpar in the main thread. While AVStream.codecpar is documented to only be updated when the stream is added or avformat_find_stream_info(), it is actually updated during demuxing. Accessing it from a different thread then c

[FFmpeg-devel] [PATCH v3] lavc/aarch64: hevc_add_res add 12bit variants

2022-08-16 Thread J. Dekker
hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7 hevc_add_res_32x32_12_neon: 261.0 Signed-off-by: J. Dekker --- libavcodec/aarch6

Re: [FFmpeg-devel] [PATCH v2] lavc/aarch64: hevc_add_res add 12bit variants

2022-08-16 Thread Martin Storsjö
On Tue, 16 Aug 2022, J. Dekker wrote: hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7 hevc_add_res_32x32_12_neon: 261.0 Signed-o

Re: [FFmpeg-devel] [PATCH v1 2/3] lavc/decode: Add internal surface re-allocate method for hwaccel

2022-08-16 Thread Anton Khirnov
Quoting Fei Wang (2022-08-12 14:55:44) > From: Linjie Fu > > Add HWACCEL_CAP_INTERNAL_ALLOC flag to indicate hwaccels are able to > re-allocate surface internally through ff_decode_get_hw_frames_ctx. > > Signed-off-by: Linjie Fu > Signed-off-by: Fei Wang > --- The commit message should explai

Re: [FFmpeg-devel] [PATCH v1 1/3] lavc/decode: Add get_hw_config function

2022-08-16 Thread Anton Khirnov
The commit message is misleading - you are not adding code, you are moving code. Quoting Fei Wang (2022-08-12 14:55:43) > From: Linjie Fu > > Wrap the procedure of getting the hardware config from a pixel format > into a function. > > Signed-off-by: Linjie Fu > Signed-off-by: Fei Wang > --- >

Re: [FFmpeg-devel] [PATCH 2/2] RFC: checkasm: motion: Test different h parameters

2022-08-16 Thread Martin Storsjö
On Thu, 4 Aug 2022, Martin Storsjö wrote: On Wed, 13 Jul 2022, Martin Storsjö wrote: Previously, the checkasm test always passed h=8, so no other cases were tested. Out of the me_cmp functions, in practice, some functions are hardcoded to always assume a 8x8 block (ignoring the h parameter),

Re: [FFmpeg-devel] [PATCH] lavu/tx: implement aarch64 NEON SIMD

2022-08-16 Thread Anton Khirnov
Quoting Lynne (2022-08-14 06:31:50) > New  - Total for len 131072 reps 4096 = 1.942836 s > Old  - Segfaults ??? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

Re: [FFmpeg-devel] [PATCH v3 0/3] checkasm: updated tests for sw_scale

2022-08-16 Thread Martin Storsjö
On Sat, 13 Aug 2022, Swinney, Jonathan wrote: We don't generally use stdbool in ffmpeg, even if it's C99 - just use a plain int and 0/1. Updated this. Other than that, the checkasm changes look fine (I coauthored part of them - and your cleanup of my WIP patch looks good!). Yes, thank you fo

Re: [FFmpeg-devel] [PATCH] qsvenc_{hevc,h264}: add scenario option

2022-08-16 Thread Anton Khirnov
Quoting Xiang, Haihao (2022-08-12 06:52:53) > +#define QSV_OPTION_SCENARIO \ > +{ "scenario", "A hint to encoder about the scenario for the encoding > session", OFFSET(qsv.scenario), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 8, VE, > "scenario" }, \ The default should probably be one of the MFX_SCEN

Re: [FFmpeg-devel] [PATCH] tools: Make sure to create the tools directory before building decode_simple.o

2022-08-16 Thread Anton Khirnov
Quoting Martin Storsjö (2022-08-08 10:59:51) > This directory dependency is normally added implicitly by rules > in ffbuild/common.mak; for tools it's created by a rule for TOOLOBJS. > TOOLOBJS is populated implicitly from TOOLS, and decode_simple.o > doesn't end up there because it's an odd occurr

Re: [FFmpeg-devel] [PATCH v2] libswscale/aarch64: add another hscale specialization

2022-08-16 Thread Martin Storsjö
On Sat, 13 Aug 2022, Swinney, Jonathan wrote: This specialization handles the case where filtersize is 4 mod 8, e.g. 12, 20, etc. Aarch64 was previously using the c function for this case. This implementation speeds up that case significantly. hscale_8_to_15__fs_12_dstW_512_c: 6234.1 hscale_8_t

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom

2022-08-16 Thread zhilizhao(赵志立)
> On Aug 16, 2022, at 7:14 AM, James Almer wrote: > > This duration is equal to the longest duration in all track's tkhd atoms, > which > may be comprised of the sum of all edit lists in each track. Empty edit lists > in tracks represent start_time, and the actual media duration is stored in

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr

2022-08-16 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Aug 15, 2022 at 01:49:24PM +0200, Andreas Rheinhardt wrote: >> It is done later in ff_mpv_frame_start() (and nobody uses >> current_picture_ptr between setting it in ff_mpv_frame_start()). >> >> (The reason the vsynth*-h263-obmc code changes is because >> the call to