On Sat, Aug 27, 2022 at 12:04 AM James Darnley wrote:
>
> Has there been a discussion about which features should go with which flag?
I think the feature selection is fine as-is, if you want to clarify
the comments go ahead. AVX512 wouldn't be useful with a subset even
smaller then what the
Signed-off-by: Andreas Rheinhardt
---
libavformat/hevc.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavformat/hevc.c b/libavformat/hevc.c
index 13951bd9f2..1841dd5785 100644
--- a/libavformat/hevc.c
+++ b/libavformat/hevc.c
@@ -728,18 +728,18 @@
The HEVC code currently uses an array of arrays of NALUs; one such array
contains all the SPS NALUs, one all PPS NALUs etc. The array of arrays
is grown dynamically via av_reallocp_array(), but given that the latter
function automatically frees its buffer upon reallocation error,
it may only be
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Friday, August 26, 2022 10:47 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022
>
> Quoting Soft Works (2022-08-25
While cherry-picking some stuff for avx512 I have noticed that ffmpeg
has a discrepancy in the comments for the two avx512 flags.
Lets start with the public header
libavutil/cpu.h
56│ #define AV_CPU_FLAG_AVX512 0x10 ///< AVX-512 functions: requires
OS support even if YMM/ZMM
Quoting Soft Works (2022-08-25 00:19:33)
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Jean-Baptiste Kempf
> > Sent: Monday, August 22, 2022 4:39 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022
> >
> > On
On Thu, Aug 25, 2022 at 03:35:12PM +0200, Dawid Kozinski wrote:
> - Provided AVInputFormat structure describing EVC input format
> (ff_evc_demuxer)
>
> Signed-off-by: Dawid Kozinski
> ---
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/evcdec.c | 142
This fixes building for arm targets with optimizations disabled.
---
libavutil/arm/intmath.h | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/libavutil/arm/intmath.h b/libavutil/arm/intmath.h
index 5311a7d52b..f19b21e98d 100644
---
On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
> > wrote:
> >>
> >> Steven Liu:
> >>> fix CID: 1512414
> >>> And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
> >>> incorrect in
Pierre-Anthony Lemieux:
> On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
> wrote:
>>
>> Steven Liu:
>>> fix CID: 1512414
>>> And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
>>> incorrect in imf_read_packet;
>>>
>>> Signed-off-by: Steven Liu
>>> ---
>>>
On Fri, Aug 26, 2022 at 1:22 AM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
> > wrote:
> >>
> >> Improves the test; also should fix Coverity issue #1512408.
> >>
> >> Signed-off-by: Andreas Rheinhardt
> >> ---
> >>
On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
wrote:
>
> Steven Liu:
> > fix CID: 1512414
> > And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
> > incorrect in imf_read_packet;
> >
> > Signed-off-by: Steven Liu
> > ---
> > libavformat/imfdec.c | 7 +--
> > 1
On 8/26/2022 5:34 AM, Martin Storsjö wrote:
These inline assembly functions rely on being inlined into the
caller, so that the parameter "int p" can be a known assembly time
constant, instead of a variable parameter.
__OPTIMIZE__ is a built-in define which is set by both GCC and Clang
(the two
Adds an option to use constant bitrate instead of average bitrate to the
videotoolbox encoders. This is enabled via -constant_bit_rate true.
macOS 13 is required for this option to work.
Signed-off-by: Sebastian Beckmann
---
Changes the name of vtenc_constant_bit_rate_enabled to
On Fri, Aug 26, 2022 at 1:42 PM Sebastian Beckmann
wrote:
>
> Adds an option to use constant bitrate instead of average bitrate to the
> videotoolbox encoders. This is enabled via -constant_bit_rate true.
> macOS 13 is required for this option to work.
>
> Signed-off-by: Sebastian Beckmann
> ---
Adds an option to use constant bitrate instead of average bitrate to the
videotoolbox encoders. This is enabled via -constant_bit_rate true.
macOS 13 is required for this option to work.
Signed-off-by: Sebastian Beckmann
---
libavcodec/videotoolboxenc.c | 37 +---
Steven Liu:
> fix CID: 1512414
> And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
> incorrect in imf_read_packet;
>
> Signed-off-by: Steven Liu
> ---
> libavformat/imfdec.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git
These inline assembly functions rely on being inlined into the
caller, so that the parameter "int p" can be a known assembly time
constant, instead of a variable parameter.
__OPTIMIZE__ is a built-in define which is set by both GCC and Clang
(the two main compilers supporting our inline assembly)
Pierre-Anthony Lemieux:
> On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
> wrote:
>>
>> Improves the test; also should fix Coverity issue #1512408.
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> libavformat/tests/imf.c | 10 ++
>> 1 file changed, 6 insertions(+), 4 deletions(-)
fix CID: 1512414
And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
incorrect in imf_read_packet;
Signed-off-by: Steven Liu
---
libavformat/imfdec.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
Pierre-Anthony Lemieux 于2022年8月26日周五 11:52写道：
>
> Since we are protecting against the algorithm within
> get_next_track_with_minimum_timestamp() return NULL, should this patch
> also include immediately returning from imf_read_packet() if
> get_next_track_with_minimum_timestamp() returns NULL?
21 matches
Mail list logo
