Re: [FFmpeg-devel] [PATCH] tests/fate/truehd: Add test for shortened Ticket1726 tesetcase

On Fri, Sep 30, 2022 at 07:03:07PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tests/fate/truehd.mak | 5 + > 1 file changed, 5 insertions(+) will apply this, more tests are always good [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fix compilation

On 9/30/2022 2:23 PM, Andreas Rheinhardt wrote: Regression since 9a494b82d998823d0de68cb6b8db83cc451d1781. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mlpdec: add max channels check

On Fri, Sep 30, 2022 at 10:00:57AM +0200, Paul B Mahol wrote: > On 9/30/22, Michael Niedermayer wrote: > > Fixes: out of array access > > Fixes: > > 51648/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-4644322217164800 > > > > > Make sure that this "fix" > does not break

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fix compilation

Regression since 9a494b82d998823d0de68cb6b8db83cc451d1781. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 85d1129f30..3374ae71bd 100644 ---

[FFmpeg-devel] [PATCH 7/7] avcodec/fraps: Fix segfault with negative linesizes

Using unsigned and negative linesizes doesn't really work. Use ptrdiff_t instead. This fixes the fraps-v0 and fraps-v1 FATE tests with negative linesizes. Signed-off-by: Andreas Rheinhardt --- libavcodec/fraps.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[FFmpeg-devel] [PATCH 6/7] avcodec/escape124: Fix segfault with negative linesizes

Use ptrdiff_t instead of unsigned for linesizes. Fixes the armovie-escape124 FATE test with negative linesizes. Signed-off-by: Andreas Rheinhardt --- libavcodec/escape124.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/escape124.c b/libavcodec/escape124.c

[FFmpeg-devel] [PATCH 5/7] avcodec/c93: Fix segfault when using negative linesizes

c93.c used an int for the stride and an unsigned for the current linenumber. This does not work when using negative linesizes. So use ptrdiff_t for stride and int for linenumber. This fixes the cyberia-c93 FATE test when using negative linesizes. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 4/7] avcodec/sgidec: Use planar pixel formats

The data in SGI images is stored planar, so exporting it via planar pixel formats is natural. Signed-off-by: Andreas Rheinhardt --- libavcodec/sgidec.c | 123 -- tests/ref/fate/sgi-rgb24 | 2 +- tests/ref/fate/sgi-rgb24-rle | 2 +-

[FFmpeg-devel] [PATCH 3/7] avcodec/sgidec: Avoid redundant private context

SGI is intra-frame only; the decoder therefore does not maintain any state between frames, so remove the private context. Also rename depth to nb_components. Signed-off-by: Andreas Rheinhardt --- libavcodec/sgidec.c | 158 1 file changed, 73

[FFmpeg-devel] [PATCH 2/7] avcodec/sgidec: Support negative linesizes

The earlier code used "p->data[0] + p->linesize[0] * s->height" with the latter being unsigned, which gives the wrong value for negative linesizes. There is also a not so obvious problem with this: In case of negative linesizes, the last line is the start of the allocated buffer, so using the line

[FFmpeg-devel] [PATCH] tests/fate/truehd: Add test for shortened Ticket1726 tesetcase

Signed-off-by: Michael Niedermayer --- tests/fate/truehd.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/truehd.mak b/tests/fate/truehd.mak index 7da8c93cffd..2a9e94b1cc8 100644 --- a/tests/fate/truehd.mak +++ b/tests/fate/truehd.mak @@ -13,5 +13,10 @@

[FFmpeg-devel] [PATCH 1/7] avcodec/sunrast: Use ptrdiff_t for stride

Fixes segfaults with negative linesizes; in particular, this affected the sunraster-(1|8|24)bit-(raw|rle) and sunraster-8bit_gray-raw FATE tests. Signed-off-by: Andreas Rheinhardt --- libavcodec/sunrast.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc/opusdsp: RISC-V F deemphasis

Le torstaina 29. syyskuuta 2022, 22.51.59 EEST r...@remlab.net a écrit : > From: Rémi Denis-Courmont > > This saves almost exactly 25% on SiFive U74. > > deemphasis_c: 11536.2 > deemphasis_rvf: 8654.2 One can get the same result with the C version using -ffast-math. Forget this patch. --

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

On Fri, Sep 30, 2022 at 7:08 AM Richard Ayres wrote: > > We had an issue where ffmpeg was unable to unpack the EKLV of an encrypted 3D > SMPTE DC MXF. > > The patch adds the SMPTE UL for EKLV packets > (060e2b34.02040101.0d010301.027e0100), to mxfdec.c in order to unpack an EKLV > packet found

[FFmpeg-devel] [PATCH] avcodec/dvdsub_parser: Fix length check for short packets

The DVD subtitle parser handles two types of packets: "normal" packets with a 16-bit length, and HD-DVD packets that set the 16-bit length to 0 and encode a 32-bit length in the next four bytes. This implies that HD-DVD packets are at least six bytes long, but the code didn't actually verify this.

Re: [FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources

Quoting Chema Gonzalez (2022-09-28 18:20:22) > Hi, > > On Wed, Sep 28, 2022 at 8:09 AM Anton Khirnov wrote: > > > if (isBayer(srcFormat)) { > > > +c->dst_slice_align = 2; > > > > IMO it's better to put this next to the line that sets dst_slice_align > > for non-bayer cases, makes it

[FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

We had an issue where ffmpeg was unable to unpack the EKLV of an encrypted 3D SMPTE DC MXF. The patch adds the SMPTE UL for EKLV packets (060e2b34.02040101.0d010301.027e0100), to mxfdec.c in order to unpack an EKLV packet found within an Encrypted SMPTE Digital Cinema MXF. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890)

On Fri, Sep 23, 2022 at 3:04 PM Tristan Matthews wrote: > > On Fri, Sep 23, 2022 at 8:15 AM Andreas Rheinhardt > wrote: > > > > Tristan Matthews: > > > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews > > > wrote: > > > > > >> This adds a fate test for a sample with LBRR packets. > > >> > > >>

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse the last moof box when mp4 segment format

> On Sep 30, 2022, at 18:22, zhilizhao(赵志立) wrote: > > > >> On Sep 30, 2022, at 17:50, wangyaqiang <1035567...@qq.com> wrote: >> >> >> >>> 2022年9月29日 16:29，zhilizhao(赵志立) >> > 写道： >>> >>> >>> On Sep 1, 2022, at 18:22, 1035567...@qq.com

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse the last moof box when mp4 segment format

> On Sep 30, 2022, at 17:50, wangyaqiang <1035567...@qq.com> wrote: > > > >> 2022年9月29日 16:29，zhilizhao(赵志立) > > 写道： >> >> >> >>> On Sep 1, 2022, at 18:22, 1035567...@qq.com >>> wrote: >>> >>> From: Wang Yaqiang >>

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse the last moof box when mp4 segment format

> 2022年9月29日 16:29，zhilizhao(赵志立) > 写道： > > > >> On Sep 1, 2022, at 18:22, 1035567...@qq.com wrote: >> >> From: Wang Yaqiang > > >> >> In the format of mp4 segment, the bitrate calculation of >>

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mlpdec: add max channels check

On 9/30/22, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 51648/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-4644322217164800 > Make sure that this "fix" does not break Mono.thd decoding. The sample is on trac ticket. Thanks. > Found-by: continuous