Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-05 Thread Tomas Härdin
mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > Thanks, Pierre-Anthony. I've updated the patch to remove the > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV > packet. > > Signed-off-by: Richard Ayres > --- >  libavformat/mxfdec.c | 4 ++-- >  1 file changed, 2 inse

Re: [FFmpeg-devel] [PATCH 1/6] fate/vcodec: Add speedhq tests

2022-10-05 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The vsynth3 tests are disabled, because the encoder produces garbage. > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate/vcodec.mak | 9 - > tests/ref/vsynth/vsynth1-speedhq-420p | 4 > tests/ref/vsynth/vsynth1-speedhq-422p | 4

Re: [FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed

2022-10-05 Thread Andreas Rheinhardt
Steven Liu: > "zhilizhao(赵志立)" 于2022年8月22日周一 10:49写道: >> >> >> >>> On Aug 19, 2022, at 11:14 PM, James Almer wrote: >>> >>> On 6/24/2022 4:05 AM, Steven Liu wrote: "zhilizhao(赵志立)" 于2022年6月24日周五 14:59写道: > > > >> On Jun 24, 2022, at 1:59 PM, Steven Liu wrote: >> >>

Re: [FFmpeg-devel] [PATCH v2] lavc/cbs_av1: restore CodedBitstreamAV1Context when AVERROR(ENOSPC)

2022-10-05 Thread James Almer
On 9/27/2022 10:39 PM, Xiang, Haihao wrote: From: Haihao Xiang The current pbc might be small for an obu frame, so a new pbc is required then parse this obu frame again. Because CodedBitstreamAV1Context has already been updated for this obu frame, we need to restore CodedBitstreamAV1Context, ot

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-05 Thread Richard Ayres
> > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > Thanks, Pierre-Anthony. I've updated the patch to remove the > > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV > > packet. > > > > Signed-off-by: Richard Ayres > > --- > > libavformat/mxfdec.c | 4 ++-- > > 1 f

[FFmpeg-devel] [PATCH v2 0/2] libavformat/mov: Add support for exporting poster time.

2022-10-05 Thread ffmpegagent
Export the poster_time_location if available. The poster_time_location is calculated using the poster_time / time_scale = X seconds. The value of poster_time_location indicates where in the video the poster frame is. Addresses feedback from https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg1

[FFmpeg-devel] [PATCH v2 1/2] libavformat/mov: Add support for exporting poster time.

2022-10-05 Thread Bryce Chester Newman
From: Bryce Chester Newman Export the poster_time_location if available. The poster_time_location is calculated using the poster_time / time_scale = X seconds. The value of poster_time_location indicates where in the video the poster frame is. Addresses feedback from https://www.mail-archive.com

[FFmpeg-devel] [PATCH v2 2/2] ibavformat/mov: Add support for exporting poster time.

2022-10-05 Thread Bryce Chester Newman
From: Bryce Chester Newman Change demuxer option name from poster_time_location to export_poster_time_location. Export the poster_time_location if available. The poster_time_location is calculated using the poster_time / time_scale = X seconds. The value of poster_time_location indicates where i

[FFmpeg-devel] [PATCH] avformat/hls: fix spelling and grammar on wrap warning

2022-10-05 Thread Tristan Matthews
--- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index e622425e80..402eb2b5a0 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1527,7 +1527,7 @@ reload: return AVERROR_EOF; }

Re: [FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed

2022-10-05 Thread Steven Liu
Andreas Rheinhardt 于2022年10月5日周三 20:14写道: > > Steven Liu: > > "zhilizhao(赵志立)" 于2022年8月22日周一 10:49写道: > >> > >> > >> > >>> On Aug 19, 2022, at 11:14 PM, James Almer wrote: > >>> > >>> On 6/24/2022 4:05 AM, Steven Liu wrote: > "zhilizhao(赵志立)" 于2022年6月24日周五 14:59写道: > > > > > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix spelling and grammar on wrap warning

2022-10-05 Thread Steven Liu
Tristan Matthews 于2022年10月5日周三 22:44写道: > > --- > libavformat/hls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index e622425e80..402eb2b5a0 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -1527,7 +1527,7 @@ relo

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

2022-10-05 Thread Gavin Smith
On 09/09/2022 16:33, Gavin Smith wrote: On 09/09/2022 10:45, Tomas Härdin wrote: ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: On 06/08/2022 21:44, Tomas Härdin wrote: fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: Some NLVEs may insert a KLV packet for EIA-608 data even thoug

[FFmpeg-devel] [PATCHv2 0/4] RISC-V V Opus postfilter

2022-10-05 Thread Rémi Denis-Courmont
Hello, This should address the issues found in the previous version, and vectors loading the unfiltered data. The following changes since commit 451b310d4f0ba5a38c3f67ec2ce39bcb62fcf59b: avcodec/fraps: Fix segfault with negative linesizes (2022-10-05 14:39:10 +0200) are available in

[FFmpeg-devel] [PATCH 2/4] lavu/riscv: helper macro for VTYPE encoding

2022-10-05 Thread Rémi Denis-Courmont
On most cases, the vector type (VTYPE) for the RISC-V Vector extension is supplied as an immediate value, with either of the VSETVLI or VSETIVLI instructions. There is however a third instruction VSETVL which takes the vector type from a general purpose register. That is so the type can be selected

[FFmpeg-devel] [PATCH 1/4] lavc/opusdsp: RISC-V V (128-bit) postfilter

2022-10-05 Thread Rémi Denis-Courmont
This is implemented for a vector size of 128-bit. Since the scalar product in the inner loop covers 5 samples or 160 bits, we need a group multipler of 2. To avoid reconfiguring the vector type, the outer loop, which loads multiple input samples sticks to the same multipler. Consequently, the oute

[FFmpeg-devel] [PATCH 3/4] lavc/opusdsp: RISC-V V (256-bit) postfilter

2022-10-05 Thread Rémi Denis-Courmont
This adds a variant of the postfilter for use with 256-bit vectors. As a single vector is then large enough to perform the scalar product, the group multipler is reduced to just one at run-time. The different vector type is passed via register. Unfortunately, there is no VSETIVL instruction, so th

[FFmpeg-devel] [PATCH 4/4] lavc/opusdsp: RISC-V V (512-bit) postfilter

2022-10-05 Thread Rémi Denis-Courmont
This adds a variant of the postfilter for use with 512-bit vectors. Half a vector is enough to perform the scalar product. Normally a whole vector would be used anyhow. Indeed fractional multiplers are no faster than the unit multipler. But in this particular function, a full vector makes up 16 sa

Re: [FFmpeg-devel] [PATCH 1/3] lavc/encode: make sure frame timebase matches encoder, when set

2022-10-05 Thread Marton Balint
On Tue, 4 Oct 2022, Anton Khirnov wrote: Quoting Marton Balint (2022-09-28 21:54:11) On Wed, 28 Sep 2022, Anton Khirnov wrote: AVFrame.time_base has been added recently, but is currently not used for anything. Prepare for its use in encoders by rejecting frames where time_base is set, bu

[FFmpeg-devel] [PATCH 1/9] avcodec/x86/simple_idct: Empty MMX state in ff_simple_idct_mmx

2022-10-05 Thread Andreas Rheinhardt
We currently mostly do not empty the MMX state in our MMX DSP functions; instead we only do so before code that might be using x87 code. This is a violation of the System V i386 ABI (and maybe of other ABIs, too): "The CPU shall be in x87 mode upon entry to a function. Therefore, every function tha

[FFmpeg-devel] [PATCH 2/9] avcodec/mjpegenc_common: Don't check luma/chroma matrices unnecessarily

2022-10-05 Thread Andreas Rheinhardt
These matrices are only used for MJPEG, not for LJPEG. So only check them for the former. This is in preparation for removing said matrices from LJPEG altogether (i.e. sending NULL matrices). Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc_common.c | 15 +++ 1 file changed,

[FFmpeg-devel] [PATCH 3/9] avcodec/ljpegenc: Remove unused IDCTDSPContext

2022-10-05 Thread Andreas Rheinhardt
It is basically write-only. Signed-off-by: Andreas Rheinhardt --- configure | 2 +- libavcodec/ljpegenc.c | 14 ++ 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/configure b/configure index 957b7fe13e..ab6ff27249 100755 --- a/configure +++ b/configure @@

[FFmpeg-devel] [PATCH 4/9] avcodec/ljpegenc: Remove unnecessary emms_c()

2022-10-05 Thread Andreas Rheinhardt
This encoder does not use any DSP function at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/ljpegenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/ljpegenc.c b/libavcodec/ljpegenc.c index 4b88218990..81c52a7c78 100644 --- a/libavcodec/ljpegenc.c +++ b/libavcodec/ljpeg

[FFmpeg-devel] [PATCH 5/9] avcodec/asvdec: Remove unnecessary emms_c()

2022-10-05 Thread Andreas Rheinhardt
This codec uses BswapDSP, BlockDSP and IDCTDSP. The former never used MMX, the latter does not use it for idct_put since bfb28b5ce89f3e950214b67ea95b45e3355c2caf and BlockDSP does not use it since commit ee551a21ddcbf81afe183d9489c534ee80f263a0. Therefore this emms_c() is can be removed. (It was a

[FFmpeg-devel] [PATCH 6/9] avcodec/me_cmp: Mark ff_square_tab as hidden

2022-10-05 Thread Andreas Rheinhardt
ff_square_tab is always used with an offset; if this table is marked as hidden, the compiler can infer that it and therefore also ff_square_tab + 256 have a fixed offset from the code. This allows to avoid performing "+ 256" at runtime by baking it into the offset from the code to the table. Signe

[FFmpeg-devel] [PATCH 8/9] avcodec/speedhqenc: Remove unnecessary headers

2022-10-05 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/speedhqenc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/speedhqenc.h b/libavcodec/speedhqenc.h index 5100bb2d34..0c52e6a380 100644 --- a/libavcodec/speedhqenc.h +++ b/libavcodec/speedhqenc.h @@ -31,10 +31,7 @@ #include -

[FFmpeg-devel] [PATCH 9/9] avcodec/mjpegenc_common: Don't flush unnecessarily

2022-10-05 Thread Andreas Rheinhardt
The PutBitContext has already been flushed a few lines above and nothing has been written to it in the meantime. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mjpegenc_common.c b/libavcodec/mjpegenc_common.c index

[FFmpeg-devel] [PATCH 7/9] avcodec/vc2enc: Don't use bitcount when byte-aligned

2022-10-05 Thread Andreas Rheinhardt
(There is a small issue that is now being treated differently: The earlier code would record a position in a buffer that is being written to via put_bits(), then write data, then overwrite the byte at the position recorded earlier and only then flush the PutBitContext. In case there was no writeout

Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: Add support for multipass encoding

2022-10-05 Thread Gustav Grusell
Any chance of someone finding the time to have a look at this? /Gustav On Tue, Sep 27, 2022 at 11:06 PM Gustav Grusell wrote: > Implements support for 2-pass CRF and 3-pass VBR by implementing > reading and writing of stats file, and passing the pass number on > to the encoder. For 3-pass VBR,