Re: [FFmpeg-devel] [PATCH] Update sample upload instructions

pushed -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

On Sun, Oct 09, 2022 at 11:36:09AM +1100, Peter Ross wrote: > Reviewed-by: Andreas Rheinhardt > Reviewed-by: Tomas Härdin > --- > > Thanks for reviews. All suggestions implemented. > > Changelog | 1 + > doc/general_contents.texi | 1 + > libavcodec/Makefile | 1 + >

[FFmpeg-devel] [PATCH] lavc/audiodsp: fix RISC-V V scalar product (again)

The loop uses a 32-bit accumulator. The current code would only zero the lower 16 bits thereof. --- libavcodec/riscv/audiodsp_rvv.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/audiodsp_rvv.S b/libavcodec/riscv/audiodsp_rvv.S index 8e8bbd2058..af1e07bef9 100

Re: [FFmpeg-devel] [PATCH v13 2/9] avcodec/evc_parser: Added parser implementaion for EVC format

Quoting Dawid Kozinski (2022-10-07 11:11:13) > + > +static int get_nalu_type(const uint8_t *bits, int bits_size, AVCodecContext > *avctx) You seem to be doing custom bitreading here and in read_nal_unit_length(). You should use either the get_bits.h API for bitreading or bytestream2 API for byte

Re: [FFmpeg-devel] [PATCH v3 10/54] avutil/channel_layout: Group deprecated functions

Quoting Marvin Scholz (2022-09-25 02:10:37) > Makes it a bit easier to spot the deprecated ones when > looking at the overview. > --- > libavutil/channel_layout.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h > index 070c9

[FFmpeg-devel] [PATCH 1/9] avcodec/(ffv1|h264|png|snow)dec: Remove comment out DRAW_HORIZ_BAND cap

Signed-off-by: Andreas Rheinhardt --- libavcodec/ffv1dec.c | 2 +- libavcodec/h264dec.c | 2 +- libavcodec/pngdec.c | 4 ++-- libavcodec/snowdec.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index d4bc60a7da..9a610c2ff9 10064

[FFmpeg-devel] [PATCH 2/9] avcodec/vc1_block: Remove dead calls to ff_mpeg_draw_horiz_band()

The VC-1 decoders don't support draw_horiz_band at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/dxva2_vc1.c | 2 -- libavcodec/vaapi_vc1.c | 2 -- libavcodec/vc1_block.c | 23 --- 3 files changed, 27 deletions(-) diff --git a/libavcodec/dxva2_vc1.c b/libavcodec/dx

[FFmpeg-devel] [PATCH 3/9] avcodec/mpegvideo: Don't check for draw_horiz_band

Some parts of mpegvideo.c behave differently depending upon whether AVCodecContext.draw_horiz_band is set or not. This differing behaviour makes lots of FATE tests fail and leads to garbage output, although setting this callback is not supposed to change the output at all. These checks have been a

[FFmpeg-devel] [PATCH 4/9] avcodec/mpegvideo: Reindent after the last commit

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index ad13832fff..87dae1b098 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -1584,16

[FFmpeg-devel] [PATCH 5/9] avcodec/h261: Use ptrdiff_t for stride

Signed-off-by: Andreas Rheinhardt --- libavcodec/h261.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/h261.c b/libavcodec/h261.c index 7dfaee7dc4..8e0e13459a 100644 --- a/libavcodec/h261.c +++ b/libavcodec/h261.c @@ -30,9 +30,9 @@ #define IS_FI

[FFmpeg-devel] [PATCH 6/9] avcodec/mpegvideo: Move VIDEO_FORMAT_* defines to mpeg12enc.c

Forgotten in f899e3b51bc85c45f54f7ac64abfbde6b2cd7d3d. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 6 ++ libavcodec/mpegvideo.h | 6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 01cfd1c1fa..c3df

[FFmpeg-devel] [PATCH 8/9] avcodec/mpegutils: Reindent after the previous commit

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegutils.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c index afbb16e201..36d75b9633 100644 --- a/libavcodec/mpegutils.c +++ b/liba

[FFmpeg-devel] [PATCH 9/9] avcodec/ffv1: Move ffv1_template.c inclusion to dec/enc templates

Both the FFV1 decoder and encoder use a template of their own to generate code multiple times. They also use a common template, used by both decoder and encoder templates which is currently instantiated in ffv1.h (and therefore also in ffv1.c, which doesn't need it at all). All these templates hav

[FFmpeg-devel] [PATCH 7/9] avcodec/mpegutils: Return early in ff_draw_horiz_band()

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegutils.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c index ff9418232b..afbb16e201 100644 --- a/libavcodec/mpegutils.c +++ b/libavcodec/mpegutils.c @@ -53

[FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideo: Ignore skip_idct for encoders

It is documented to be unused for encoders. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 5095149eaa..448b65bb96 100644 --- a/libavcodec/mpegvideo.c +++ b/liba

[FFmpeg-devel] [PATCH 2/6] avcodec/mpegvideo: Make inlining is_mpeg12 more flexible

There are two types of checks for whether the current codec is MPEG-1/2 in mpv_reconstruct_mb_internal(): Those that are required for correctness and those that are not; an example of the latter is "is_mpeg12 || (s->codec_id != AV_CODEC_ID_WMV2)". The reason for the existence of such checks is that

[FFmpeg-devel] [PATCH 3/6] avcodec/mpegvideo: Inline is_encoder in mpv_reconstruct_mb_internal()

Up until now, we inlined lowres_flag as well as is_mpeg12 independently (unless CONFIG_SMALL was true); this commit changes this to instead inline mpv_reconstruct_mb_internal() (at most) four times, namely once for encoders, once for decoders using lowres and once for non-lowres mpeg-1/2 decoders a

[FFmpeg-devel] [PATCH 4/6] avcodec/mpegvideo: Split ff_mpv_reconstruct_mb() into de/encoder part

This has the advantage of not having to check for whether a given MpegEncContext is actually a decoder or an encoder context at runtime. To do so, mpv_reconstruct_mb_internal() is moved into a new template file that is included by both mpegvideo_enc.c and mpegvideo_dec.c; the decoder-only code (ma

[FFmpeg-devel] [PATCH 5/6] avcodec/mpeg12dec: Remove always-true check

mpeg12dec.c is a decoder-only file. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index df76a90c6c..56bf73df11 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/m

[FFmpeg-devel] [PATCH 6/6] avcodec/mpv_reconstruct_mb_template: Optimize dead code away

None of the MPEG-1/2 codecs support frame threading, so one can optimize the check for it away. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpv_reconstruct_mb_template.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpv_reconstruct_mb_template.c b/libavco

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: fill the padding area

On Mon, 2022-10-10 at 16:05 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > qsvenc makes a copy when the input in system memory is not padded as the > SDK requires, however the padding area is not filled with right data > > Signed-off-by: Haihao Xiang > --- > libavcodec/qsvenc.c | 69

[FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

Fixes ticket #128. The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped in our SVQ1 implementation, resulting in visible artifacts for some videos. This patch unswaps the order of these two symbols. The most noticable example of the artiacts caused by this error can be observ

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

Peter Ross: > Fixes ticket #128. > > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped > in our SVQ1 implementation, resulting in visible artifacts for some videos. > This patch unswaps the order of these two symbols. > > The most noticable example of the artiacts caused b