Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ac3dec: don't export Matrix Encoding side data when no such info is coded

2023-01-12 Thread Andreas Rheinhardt
James Almer: > No point inserting the side data to all frames just to say there's no > coded matrix encoding. > > Signed-off-by: James Almer > --- > libavcodec/ac3dec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index

Re: [FFmpeg-devel] [PATCH v6 1/2] libavformat/hlsenc: Enable HTTP persistent connections for hls_delete_file

2023-01-12 Thread Steven Liu
Basel Sayeh 于2023年1月7日周六 08:22写道： > > V6: > - Removed the const for filename in "hls_delete_file" to >fix compilation warnings > > - Removed the unnecessary calls to ff_format_io_close >this patch introduced in hls_delete_file and in >dashenc_delete_file > > V1-V5: >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread zhilizhao(赵志立)
> On Jan 13, 2023, at 04:45, Vignesh Venkatasubramanian > wrote: > > The HEIF specification permits specifying the looping behavior of > animated sequences by using the EditList (elst) box. The track > duration will be set to the total duration of all the loops (or > infinite) and the

[FFmpeg-devel] [PATCH 2/2] lavfi/overlay_vaapi: remove unnecessary code

2023-01-12 Thread Xiang, Haihao
From: Haihao Xiang VA-API filter is not required. Signed-off-by: Haihao Xiang --- libavfilter/vf_overlay_vaapi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c index 79cf66d068..16d1e0e211 100644 ---

[FFmpeg-devel] [PATCH 1/2] lavfi/vaapi: remove duplicated code

2023-01-12 Thread Xiang, Haihao
From: Haihao Xiang Add a ff_ function to handle mulitple pipeline parameters. No functional changes. Signed-off-by: Haihao Xiang --- libavfilter/vaapi_vpp.c| 90 libavfilter/vaapi_vpp.h| 5 ++ libavfilter/vf_overlay_vaapi.c | 122

Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol

2023-01-12 Thread zhilizhao(赵志立)
> On Jan 13, 2023, at 03:13, Rémi Denis-Courmont wrote: > > Le keskiviikkona 11. tammikuuta 2023, 10.52.08 EET Paul B Mahol a écrit : >>> Sorry for the break, I’m trying to figure out how to make it compatible >>> with Windows. >> >> Is this even portable? > > If you build FFmpeg correctly,

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/xpmdec: Check size before allocation to avoid truncation

2023-01-12 Thread James Almer
On 1/12/2023 9:01 PM, Michael Niedermayer wrote: Fixes:OOM Fixes:out of array access (no testcase) Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-6573323838685184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 5/5] avcodec/sonic: avoid integer overflow on quantization parameter

2023-01-12 Thread Michael Niedermayer
Fixes: signed integer overflow: -1094995529 * 16 cannot be represented in type 'int' Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-6681622236233728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/5] avcodec/motionpixels: Mask pixels to valid values

2023-01-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-672420335220 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/motionpixels.c |

[FFmpeg-devel] [PATCH 3/5] avcodec/012v: Order operations for odd size handling

2023-01-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZERO12V_fuzzer-6714182078955520.fuzz Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZERO12V_fuzzer-6698145212137472.fuzz Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 2/5] avcodec/xpmdec: Check size before allocation to avoid truncation

2023-01-12 Thread Michael Niedermayer
Fixes:OOM Fixes:out of array access (no testcase) Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-6573323838685184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/5] avcodec/wbmpdec: use remaining size not whole size

2023-01-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WBMP_fuzzer-6652634692190208 Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WBMP_fuzzer-6653703453278208 Fixes:

[FFmpeg-devel] [PATCH 2/2] avcodec/ac3dec: export downmix info side data only when no downmix is done by the decoder

2023-01-12 Thread James Almer
Same as with Matrix Encoding, add a check to ensure the decoder is not doing a downmix of its own. Signed-off-by: James Almer --- libavcodec/ac3dec.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index

[FFmpeg-devel] [PATCH 1/2] avcodec/ac3dec: don't export Matrix Encoding side data when no such info is coded

2023-01-12 Thread James Almer
No point inserting the side data to all frames just to say there's no coded matrix encoding. Signed-off-by: James Almer --- libavcodec/ac3dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index 0b120e6140..7a84f3c85d 100644 ---

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread Vignesh Venkatasubramanian
The HEIF specification permits specifying the looping behavior of animated sequences by using the EditList (elst) box. The track duration will be set to the total duration of all the loops (or infinite) and the duration of a single loop will be set in the edit list box. The default behavior is to

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-12 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 05:09:18PM +0100, Paul B Mahol wrote: > On 1/12/23, Michael Niedermayer wrote: > > On Thu, Jan 12, 2023 at 03:20:06PM +0100, Paul B Mahol wrote: > >> On 1/8/23, Michael Niedermayer wrote: > >> > On Fri, Jan 06, 2023 at 07:04:59PM +0100, Paul B Mahol wrote: > >> >> On Fri,

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread Vignesh Venkatasubramanian
On Fri, Jan 6, 2023 at 1:45 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 6, 2023, at 01:34, Vignesh Venkatasubramanian > > wrote: > > > > On Thu, Jan 5, 2023 at 1:45 AM "zhilizhao(赵志立)" > > wrote: > >> > >> > >> > >>> On Jan 5, 2023, at 06:16, Vignesh Venkatasubramanian > >>> wrote: > >>> >

Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol

2023-01-12 Thread Rémi Denis-Courmont
Le keskiviikkona 11. tammikuuta 2023, 10.52.08 EET Paul B Mahol a écrit : > > Sorry for the break, I’m trying to figure out how to make it compatible > > with Windows. > > Is this even portable? If you build FFmpeg correctly, so that all the FFmpeg libraries and the application code share the

[FFmpeg-devel] [PATCH] avformat/teeproto: setup max_packet_size

2023-01-12 Thread Zhao Zhili
From: Zhao Zhili It's the minimum of all child protocols max_packet_size. Can be used like this: ffmpeg -re -i cctv.mp4 -c copy -f mpegts \ -protocol_whitelist 'tee,file,udp' \ 'tee:out.ts|udp://127.0.0.1:?pkt_size=1316' Signed-off-by: Zhao Zhili --- libavformat/teeproto.c | 12

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-12 Thread Paul B Mahol
On 1/12/23, Michael Niedermayer wrote: > On Thu, Jan 12, 2023 at 03:20:06PM +0100, Paul B Mahol wrote: >> On 1/8/23, Michael Niedermayer wrote: >> > On Fri, Jan 06, 2023 at 07:04:59PM +0100, Paul B Mahol wrote: >> >> On Fri, Jan 6, 2023 at 7:01 PM Paul B Mahol wrote: >> >> >> >> > >> >> > >> >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-12 Thread Jeffrey Chapuis
Le 10/01/2023 à 16:45, Paul B Mahol a écrit : > On 1/10/23, Jeffrey CHAPUIS wrote: >> Hello, >> I decided to continue on a simpler path without 'reset/reset_count', it was >> only to experiment anyway, 'limit' is the main goal. >> 'limit' is added to the metadata to control that the result is

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-12 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 03:20:06PM +0100, Paul B Mahol wrote: > On 1/8/23, Michael Niedermayer wrote: > > On Fri, Jan 06, 2023 at 07:04:59PM +0100, Paul B Mahol wrote: > >> On Fri, Jan 6, 2023 at 7:01 PM Paul B Mahol wrote: > >> > >> > > >> > > >> > On Fri, Jan 6, 2023 at 6:25 PM Michael

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-12 Thread Michael Niedermayer
On Sun, Jan 08, 2023 at 04:18:44PM +0100, Paul B Mahol wrote: > On 1/8/23, Michael Niedermayer wrote: > > On Fri, Jan 06, 2023 at 07:01:06PM +0100, Paul B Mahol wrote: > >> On Fri, Jan 6, 2023 at 6:25 PM Michael Niedermayer > >> > >> wrote: > >> > >> > On Thu, Jan 05, 2023 at 11:08:25PM +0100,

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/utils: allocate a line more for VC1 and WMV3

2023-01-12 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 08:38:08AM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: out of array read on 32bit > > Fixes: > > 54857/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5840588224462848 > > > > The chroma MC code reads over the currently allocated frame.

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/bonk: Check ntaps against buffer size

2023-01-12 Thread Michael Niedermayer
On Wed, Jan 11, 2023 at 10:06:19PM +0100, Paul B Mahol wrote: > On 1/11/23, Michael Niedermayer wrote: > > Fixes: out of array read > > Fixes: > > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-6739246658748416 > > > > Note: This issue was assigned to a unrelated theora bug >

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/bonk: Avoid undefined overflow in quant

2023-01-12 Thread Michael Niedermayer
On Wed, Jan 11, 2023 at 10:06:44PM +0100, Paul B Mahol wrote: > On 1/11/23, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -2889074 * 2048 cannot be represented in > > type 'int' > > Fixes: > > 51363/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-5660734784143360 >

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/sgidec: do not forget the number of components in read_uncompressed_sgi()

2023-01-12 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 01:02:57AM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: out of array access > > Fixes: > > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGI_fuzzer-6704753329700864 > > Fixes: > >

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-12 Thread Paul B Mahol
On 1/8/23, Michael Niedermayer wrote: > On Fri, Jan 06, 2023 at 07:04:59PM +0100, Paul B Mahol wrote: >> On Fri, Jan 6, 2023 at 7:01 PM Paul B Mahol wrote: >> >> > >> > >> > On Fri, Jan 6, 2023 at 6:25 PM Michael Niedermayer >> > >> > wrote: >> > >> >> On Thu, Jan 05, 2023 at 11:08:25PM +0100,

[FFmpeg-devel] [PATCH] trailing padding

2023-01-12 Thread Paul B Mahol
Patches attached, ffmpeg.c should really not ignore initial padding and trailing padding. From 6fc1c0dfcfe5203355423d658f21a8f6c7cbfe83 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 12 Jan 2023 09:56:57 +0100 Subject: [PATCH 1/2] avformat/dtshddec: also read trailing padding in samples