Re: [FFmpeg-devel] [PATCH 5/5] avcodec/sonic: avoid integer overflow on quantization parameter

2023-01-13 Thread Paul B Mahol
On 1/13/23, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1094995529 * 16 cannot be represented in > type 'int' > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-6681622236233728 > > Found-by: continuous fuzzing process > https://github.com/google/oss-

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ac3dec: don't export Matrix Encoding side data when no such info is coded

2023-01-13 Thread James Almer
On 1/13/2023 4:09 AM, Andreas Rheinhardt wrote: James Almer: No point inserting the side data to all frames just to say there's no coded matrix encoding. Signed-off-by: James Almer --- libavcodec/ac3dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ac3de

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: use av_frame_side_data_name() to print side data names

2023-01-13 Thread James Almer
On 1/11/2023 4:31 PM, James Almer wrote: This ensures all defined types are supported, even if only to report their presence and print their size if a custom implementation is not added. Signed-off-by: James Almer --- This patch supersedes: [PATCH 1/2] avfilter/vf_showinfo: remove superfluous l

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: use av_frame_side_data_name() to print side data names

2023-01-13 Thread Jan Ekström
On Wed, Jan 11, 2023 at 9:31 PM James Almer wrote: > > This ensures all defined types are supported, even if only to report > their presence and print their size if a custom implementation is > not added. > > Signed-off-by: James Almer > --- > This patch supersedes: > [PATCH 1/2] avfilter/vf_show

Re: [FFmpeg-devel] [PATCH] lavf/spdifdec: support EAC3

2023-01-13 Thread Aman Karmani
On Tue, Jan 10, 2023 at 6:49 PM rcombs wrote: > Parsing should probably be enabled for all codecs, at least for headers, > but e.g. the AAC parser produces 1-byte packets of zero padding with it, > so I'm just enabling it for EAC3 for the moment. > --- > libavformat/spdifdec.c | 19 +-

[FFmpeg-devel] [PATCH] lavf/matroska: add support for ARIB captions

2023-01-13 Thread rcombs
Not yet ready for merge, pending finalization of the standard proposal for this mapping: https://github.com/ietf-wg-cellar/matroska-specification/pull/724 --- libavformat/matroska.c| 1 + libavformat/matroskadec.c | 30 ++ libavformat/matroskaenc.c | 23 ++

Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol

2023-01-13 Thread Rémi Denis-Courmont
Le perjantaina 13. tammikuuta 2023, 5.37.36 EET zhilizhao(赵志立) a écrit : > > On Jan 13, 2023, at 03:13, Rémi Denis-Courmont wrote: > > > > Le keskiviikkona 11. tammikuuta 2023, 10.52.08 EET Paul B Mahol a écrit : > >>> Sorry for the break, I’m trying to figure out how to make it compatible > >>>

Re: [FFmpeg-devel] [PATCH] lavf/matroska: add support for ARIB captions

2023-01-13 Thread Pierre-Anthony Lemieux
On Fri, Jan 13, 2023 at 9:27 AM rcombs wrote: > > Not yet ready for merge, pending finalization of the standard proposal for > this mapping: > https://github.com/ietf-wg-cellar/matroska-specification/pull/724 Is sample ARIB caption available? > --- > libavformat/matroska.c| 1 + > libavfo

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/cbs_{h2645, sei}: add support for Ambient Viewing Environment SEI

2023-01-13 Thread Jan Ekström
On Wed, Jan 11, 2023 at 8:57 PM Jan Ekström wrote: > > Defined by H.274, this SEI message is utilized by iPhones to save > the nominal ambient viewing environment for the display of recorded > HDR content. > --- Applied the set as the initial version was generally OK'd, and all nits were poked.

Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

2023-01-13 Thread Rémi Denis-Courmont
Le keskiviikkona 11. tammikuuta 2023, 0.57.13 EET Mark Reid a écrit : > > Are you really duplicating a whole bunch of files from lavc in sws? I > > don't think that's anywhere remotely close to acceptable. > > This was what I was suggested to do > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-Dece

[FFmpeg-devel] [NOT FOR MERGE] [PATCH] lavc/bswapdsp: do not assume aligned input on RISC-V

2023-01-13 Thread Rémi Denis-Courmont
This fixes the RISC-V B code not to assume alignment. Unfortunately, the whole idea behind the optimisation does not really work if the input is unaligned, and the C code works just as well. Notes: - This does not fix the call prototypes, whose second parameter is expected to change to `const vo

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/xpmdec: Check size before allocation to avoid truncation

2023-01-13 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 09:11:35PM -0300, James Almer wrote: > > > On 1/12/2023 9:01 PM, Michael Niedermayer wrote: > > Fixes:OOM > > Fixes:out of array access (no testcase) > > Fixes: > > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-6573323838685184 > > > > Found-by: cont

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/xpmdec: Check size before allocation to avoid truncation

2023-01-13 Thread James Almer
On 1/13/2023 5:49 PM, Michael Niedermayer wrote: On Thu, Jan 12, 2023 at 09:11:35PM -0300, James Almer wrote: On 1/12/2023 9:01 PM, Michael Niedermayer wrote: Fixes:OOM Fixes:out of array access (no testcase) Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-657332383

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/xpmdec: Check size before allocation to avoid truncation

2023-01-13 Thread Michael Niedermayer
On Fri, Jan 13, 2023 at 05:53:20PM -0300, James Almer wrote: > On 1/13/2023 5:49 PM, Michael Niedermayer wrote: > > On Thu, Jan 12, 2023 at 09:11:35PM -0300, James Almer wrote: > > > > > > > > > On 1/12/2023 9:01 PM, Michael Niedermayer wrote: > > > > Fixes:OOM > > > > Fixes:out of array access (

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: use av_frame_side_data_name() to print side data names

2023-01-13 Thread James Almer
On 1/13/2023 11:38 AM, Jan Ekström wrote: On Wed, Jan 11, 2023 at 9:31 PM James Almer wrote: This ensures all defined types are supported, even if only to report their presence and print their size if a custom implementation is not added. Signed-off-by: James Almer --- This patch supersedes:

[FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add support for Ambient Viewing Environment side data

2023-01-13 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index d5edbd2f0a..e55625b338 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -42,6 +42,7 @@

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-13 Thread Vignesh Venkatasubramanian
On Thu, Jan 12, 2023 at 8:40 PM "zhilizhao(赵志立)" wrote: > > > > > On Jan 13, 2023, at 04:45, Vignesh Venkatasubramanian > > wrote: > > > > The HEIF specification permits specifying the looping behavior of > > animated sequences by using the EditList (elst) box. The track > > duration will be set

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

2023-01-13 Thread Rui Ueyama
Hey Martin, It's nice to see you on this mailing list! Sorry about sending this email as a reply to a wrong email, as I didn't receive your mail and thus couldn't send this as a reply to your mail. > On Sat, 7 Jan 2023, Rui Ueyama wrote: > > > It looks like compiler-generated code always uses `b