[FFmpeg-devel] [PATCH] libavcodec/hevc: add hevc idct4x4 neon of aarch64 after fixed

2023-02-23 Thread xufuji456
--- libavcodec/aarch64/hevcdsp_idct_neon.S| 40 +++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 4 +++ 2 files changed, 44 insertions(+) diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S b/libavcodec/aarch64/hevcdsp_idct_neon.S index 124c50998a..f5135160b6 100644 ---

Re: [FFmpeg-devel] [PATCH v1] lavu/hwcontext_vaapi: sync surface before export its DRM handle

2023-02-23 Thread zhilizhao(赵志立)
> On Feb 24, 2023, at 13:45, Fei Wang > wrote: > > According to description of vaExportSurfaceHandle in libva, vaSyncSurface > must be called if the contents of the surface will be read. > > Fixes ticket #9967. > > Signed-off-by: Fei Wang > --- > libavutil/hwcontext_vaapi.c | 11

[FFmpeg-devel] [PATCH v1] lavu/hwcontext_vaapi: sync surface before export its DRM handle

2023-02-23 Thread Fei Wang
According to description of vaExportSurfaceHandle in libva, vaSyncSurface must be called if the contents of the surface will be read. Fixes ticket #9967. Signed-off-by: Fei Wang --- libavutil/hwcontext_vaapi.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 3/6] avformat/isom_tags: remove ipcm from movaudio_tags

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili ipcm is defined by ISO/IEC 23003-5, not defined by quicktime. After adding ISO/IEC 23003-5 support, we don't need it for ticket #9219. Signed-off-by: Zhao Zhili --- libavformat/isom_tags.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/isom_tags.c

[FFmpeg-devel] [PATCH 6/6] fate/mov: add PCM in mp4 test

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- tests/fate/mov.mak | 12 tests/filtergraphs/mov-mp4-pcm | 5 + tests/ref/fate/mov-mp4-pcm | 27 +++ tests/ref/fate/mov-mp4-pcm-float | 7 +++ 4 files changed, 51 insertions(+)

[FFmpeg-devel] [PATCH 5/6] avformat/movenc: write ChannelLayout box for PCM

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavformat/movenc.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 99b93c1d5b..2b84ed1afa 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 2/6] avformat/mov: fix ISO/IEC 23003-5 support

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili Missing floating-point formats support. Signed-off-by: Zhao Zhili --- libavformat/mov.c | 32 1 file changed, 32 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6ab43b00c6..b125343f84 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH 1/6] avformat/movenc: add PCM in mp4 support

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili It's defined by ISO/IEC 23003-5. Fixes ticket #10185 Signed-off-by: Zhao Zhili --- libavformat/movenc.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

[FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavformat/mov.c | 79 +++- libavformat/mov_chan.c | 265 + libavformat/mov_chan.h | 26 3 files changed, 369 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH 0/6] add PCM in mp4 support

2023-02-23 Thread Zhao Zhili
From: Zhao Zhili This patchset adds support of demux/mux PCM in mp4, and related channel layout information. PCM in mp4 is defined by ISO/IEC 23003-5. The channel layout tag 'chn' is defined by ISO/IEC 14496-12 with reference to ISO/IEC 23001-8. We have partially support of demux PCM in mp4

Re: [FFmpeg-devel] [PATCH v7 01/10] lavc/avcodec: Add HEVC Screen Content Coding Extensions profile

2023-02-23 Thread Xiang, Haihao
On So, 2023-02-19 at 02:10 +, Xiang, Haihao wrote: > On Do, 2023-02-16 at 13:46 +0800, Fei Wang wrote: > > From: Linjie Fu > > > > Described in HEVC spec A.3.7. Bump minor version and add APIchanges > > entry for new added profile. > > > > Signed-off-by: Linjie Fu > > Signed-off-by: Fei

Re: [FFmpeg-devel] FFmpeg 6.0

2023-02-23 Thread Gyan Doshi
On 2023-02-21 09:28 pm, Michael Niedermayer wrote: On Tue, Feb 21, 2023 at 02:20:26PM +0100, Jean-Baptiste Kempf wrote: On Tue, 21 Feb 2023, at 12:38, Michael Niedermayer wrote: On Fri, Feb 10, 2023 at 06:47:03PM +0100, Michael Niedermayer wrote: Hi all i plan to branch off release/6.0

[FFmpeg-devel] libavfilter/x86/vf_convolution.asm- fix missing decelerator for AVX512ICL sobel

2023-02-23 Thread Felix LeClair
Fixes: Compilation of Sobel with AVX512ICL Caused: Comment left without deleniator in AVX512ICL version of SOBEL Testing:Confirmed working on AVX512 Alderlake (AKA SPR without AMX) From 2b12db24d2bbe8a1544a9a7f3a08e1a693a6c2ce Mon Sep 17 00:00:00 2001 From: "Felix LeClair (FCLC)" Date: Thu, 23

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Enable 444 encoding for RGB input

2023-02-23 Thread Xiang, Haihao
On Di, 2023-01-03 at 11:00 +0800, wenbin.chen-at-intel@ffmpeg.org wrote: > From: Wenbin Chen > > MSDK/VPL uses 420 chroma format as default to encode RGB, and this is > not a proper usage. Now enable 444 encoding for RGB input by default. > RGB is encoded using 444 chroma format when user

Re: [FFmpeg-devel] [PATCH 1/3] avfilter: move bwdif's filter_line init into a dedicated function

2023-02-23 Thread Thomas Mundt
Hi James, James Darnley schrieb am Mo., 20. Feb. 2023, 13:59: > --- > libavfilter/bwdif.h | 3 ++- > libavfilter/vf_bwdif.c | 13 + > libavfilter/x86/vf_bwdif_init.c | 4 +--- > 3 files changed, 12 insertions(+), 8 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/motionpixels: Mask pixels to valid values

2023-02-23 Thread Michael Niedermayer
On Fri, Jan 13, 2023 at 01:01:37AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-672420335220 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/utils: allocate a line more for VC1 and WMV3

2023-02-23 Thread Michael Niedermayer
On Wed, Jan 11, 2023 at 09:42:16PM +0100, Michael Niedermayer wrote: > Fixes: out of array read on 32bit > Fixes: > 54857/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5840588224462848 > > The chroma MC code reads over the currently allocated frame. > Alternative fixes would be

[FFmpeg-devel] [PATCH 3/3] decklink: Fix unused variable compiler warnings

2023-02-23 Thread Devin Heitmueller
Due to refactoring, the ctx/cctx variables are never actually used in ff_decklink_write_packet(), so just remove them. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavdevice/decklink_enc.cpp

[FFmpeg-devel] [PATCH 2/3] decklink: Fix setting of last_pts to only be set for video

2023-02-23 Thread Devin Heitmueller
The ff_decklink_write_packet() was always caching the last pts received, to be used when calling StopScheduledPlayback(). However because audio and video are on different timebases and the call to StopScheduledPlayback() expects the video timebase, we'll end up sending a weird value to the stop

[FFmpeg-devel] [PATCH 1/3] decklink: Don't take for granted that first frame to decklink output will be PTS 0

2023-02-23 Thread Devin Heitmueller
The existing code assumed that the first frame received by the decklink output would always be PTS zero. However if running in other timing modes than the default of CBR, items such as frame dropping at the beginning may result in starting at a non-zero PTS. For example, in our setup because we

[FFmpeg-devel] [PATCH 0/3] Minor decklink output fixes

2023-02-23 Thread Devin Heitmueller
The following patch series contains several small fixes to the decklink output support. Devin Heitmueller (3): decklink: Don't take for granted that first frame to decklink output will be PTS 0 decklink: Fix setting of last_pts to only be set for video decklink: Fix unused variable

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/videodsp_template: Adjust pointers to avoid undefined pointer things

2023-02-23 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 12:54:31AM +0100, Michael Niedermayer wrote: > Fixes: subtraction of unsigned offset from 0xf6602770 overflowed to 0xf6638c80 > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-495074400600064 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: dont skip/read chunk twice

2023-02-23 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 12:54:29AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PNG_fuzzer-6668158952144896.fuzz > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/pngdec: Check deloco index more exactly

2023-02-23 Thread Michael Niedermayer
On Thu, Jan 12, 2023 at 12:54:28AM +0100, Michael Niedermayer wrote: > Fixes: out of array access: > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PNG_fuzzer-6716193709096960 > > Alternatively it should be possible to limit this to 3 plane RGB 8 /16bit to > ensure the size is

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ffv1dec: Check that num h/v slices is supported

2023-02-23 Thread Michael Niedermayer
On Sun, Feb 19, 2023 at 12:18:48AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 55597/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-4898293416329216 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mov: Check samplesize and offset to avoid integer overflow

2023-02-23 Thread Michael Niedermayer
Hi On Mon, Feb 20, 2023 at 08:29:24PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775584 + 536870912 cannot be > represented in type 'long' > Fixes: > 55844/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-510613920664780 > > Found-by: continuous

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-23 Thread Michael Niedermayer
On Thu, Feb 23, 2023 at 04:27:38PM +0100, Stefano Sabatini wrote: > On Thu, Feb 23, 2023 at 1:47 PM Thilo Borgmann wrote: > > > > Am 23.02.23 um 10:44 schrieb Stefano Sabatini: > > > On Mon, Feb 6, 2023 at 4:17 AM Thilo Borgmann > > > wrote: > > >> > > >> Hi, > > >> > > >> the M2 chip recently

Re: [FFmpeg-devel] GSoC 2023

2023-02-23 Thread Thilo Borgmann
Hi, Am 15.12.22 um 15:42 schrieb Thilo Borgmann: [...] The application deadline is January 23rd, I will aim for sending an application mid January. [1] https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2022/Results [2] https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2023 we've

[FFmpeg-devel] How to use threads inside custom encoder

2023-02-23 Thread Alex
Hi! I write custom encoder codec and want to use threads to speed up encoding process. I know what ffmpeg have frame level threads and slices threads, but in my case best option is to use frame level threads with FF_CODEC_ENCODE_CB() function. But I have couple of questions: 1) Then I add 

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-23 Thread Stefano Sabatini
On Thu, Feb 23, 2023 at 1:47 PM Thilo Borgmann wrote: > > Am 23.02.23 um 10:44 schrieb Stefano Sabatini: > > On Mon, Feb 6, 2023 at 4:17 AM Thilo Borgmann > > wrote: > >> > >> Hi, > >> > >> the M2 chip recently made it from the laptops into the mini as well. > >> It's the generation of the

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread Hendrik Leppkes
On Thu, Feb 23, 2023 at 3:37 PM copypaste wrote: > It gets included because this platform does indeed have Video4Linux so some > of the aarch64 stuff is relevant. Furthermore I think that the HEVC stuff > includes it. > If its relevant for V4L or other hardware integration is fine and all ...

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread copypaste
Sorry Anton, I stupidly misread your message. You are telling me not to start my identifiers with underscores not talking about Android. Well, I can certainly change it but just making them lowercase will not fix the issue because those collide with ffmpeg's variables. Perhaps what I

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread copypaste
It gets included because this platform does indeed have Video4Linux so some of the aarch64 stuff is relevant. Furthermore I think that the HEVC stuff includes it. I have attached the file, whether or not it is not allowed seems immaterial because it is done by Android whether we like

Re: [FFmpeg-devel] [PATCH] Fix broken build on Android due to broken asm-generic/termbits.h include

2023-02-23 Thread Anton Khirnov
Quoting copypaste (2023-02-22 10:12:08) > Applied to libavcodec/aaccoder.c: > :%s/\([*]\)\?\([ \t]\{-}\)\?\(\<[BD-Z]\([0-9]*\)\)\>/\1\2_\3/g > > This stops B0 and B1 from colliding with a define in > /usr/include/asm-generic/termbits.h: Why is that file even being included? Also > All

Re: [FFmpeg-devel] [PATCH v2 1/4] cbs_av1: Add tracing headers for metadata types

2023-02-23 Thread James Almer
On 1/24/2023 7:46 PM, Mark Thompson wrote: Make it a little easier to interpret metadata in trace output. --- libavcodec/cbs_av1_syntax_template.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-23 Thread Thilo Borgmann
Am 23.02.23 um 10:44 schrieb Stefano Sabatini: On Mon, Feb 6, 2023 at 4:17 AM Thilo Borgmann wrote: Hi, the M2 chip recently made it from the laptops into the mini as well. It's the generation of the Chip, I think we should buy one and have that running FATE as well. Kieran agreed on

[FFmpeg-devel] [PATCH v7 3/4] lavf/mpegts.c: set some properties for ARIB caption

2023-02-23 Thread TADANO Tokumei
Some additional properties are set for ARIB caption. * need_parsing = 0 ARIB caption doesn't require any parser. This avoids "parser not found" warning message. * need_context_update = 1 When any profiles are changed, set this flag to notify. --- libavformat/mpegts.c | 6 +- 1 file

[FFmpeg-devel] [PATCH v7 4/4] doc/decoders.texi: add document of aribcaption decoder

2023-02-23 Thread TADANO Tokumei
--- doc/decoders.texi | 150 ++ 1 file changed, 150 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index 5ba85cf9b1..4888735016 100644 --- a/doc/decoders.texi +++ b/doc/decoders.texi @@ -353,6 +353,156 @@ Enabled by default. @end

[FFmpeg-devel] [PATCH v7 2/4] lavc/codec_desc.c: remove AV_CODEC_PROP_TEXT_SUB property

2023-02-23 Thread TADANO Tokumei
To support bitmap type of subtitles, remove AV_CODEC_PROP_TEXT_SUB property from codec descriptor for AV_CODEC_ID_ARIB_CAPTION. It is similar way to `libavcodec/libzvbi-teletextdec.c` (AV_CODEC_ID_DVB_TELETEXT). Instead, each subtitle decoder has to specify subtitile format.

[FFmpeg-devel] [PATCH v7 1/4] lavc/libaribcaption.c: add ARIB caption decoder using libaribcaption

2023-02-23 Thread TADANO Tokumei
This patch add another ARIB caption decoder using libaribcaption external library. Unlike libaribb24, it supports 3 types of subtitle outputs: * text: plain text * ass: ASS formatted text * bitmap: bitmap image Default subtitle type is ass as same as libaribb24. Advantages compared with

[FFmpeg-devel] [PATCH v7 0/4] add ARIB caption decoder using libaribcaption

2023-02-23 Thread TADANO Tokumei
Ping with rebased patch set. Some chages are added to reflect review results from outside of this ML. --- This patch set add another ARIB caption decoder using libaribcaption external library: https://github.com/xqq/libaribcaption The library decodes subtitles of ISDB-based TV broadcasting. It is

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-23 Thread Stefano Sabatini
On Mon, Feb 6, 2023 at 4:17 AM Thilo Borgmann wrote: > > Hi, > > the M2 chip recently made it from the laptops into the mini as well. > It's the generation of the Chip, I think we should buy one and have that > running FATE as well. > > Kieran agreed on hosting this one like he does for the

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: add hevc idct_4x4_neon of aarch64

2023-02-23 Thread Martin Storsjö
On Tue, 14 Feb 2023, xufuji456 wrote: --- libavcodec/aarch64/hevcdsp_idct_neon.S| 51 +++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 4 ++ 2 files changed, 55 insertions(+) This looks mostly fine, but there's a couple issues that breaks it when built with toolchains

[FFmpeg-devel] [PATCH] aarch64: hevcdsp_idct: Reuse preexisting macros for transposes

2023-02-23 Thread Martin Storsjö
Signed-off-by: Martin Storsjö --- libavcodec/aarch64/hevcdsp_idct_neon.S | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S b/libavcodec/aarch64/hevcdsp_idct_neon.S index 124c50998a..c61fcb175d 100644 ---

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Added ability to set a input burst time before readrate is enforced

2023-02-23 Thread Davy Durham
Implemented is the -irb flag (i.e. "initial read burst") that causes ffmpeg to read the specified number of seconds of input before a given readrate starts to be enforced. All inputs have to reach this point before the readrate is enforced. The reason for this change is, in the scenario of