Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-06 Thread myais
Hi, Martin, I updated the patches again.  These patches passed fate-hevc tests . fate-hevc did help to find some bugs, which have been fixed now, please help to review again. Thanks. 在 2023/5/5 23:27, myais 写道: Hi Martin, I updated these patches based on your comments, please help to revi

[FFmpeg-devel] [PATCH v1] avformat/imf: clean-up logging

2023-05-06 Thread pal
From: Pierre-Anthony Lemieux * consistently use the IMF demuxer AVFormatContext in av_log() * remove extraneous logging --- libavformat/imf.h | 5 +- libavformat/imf_cpl.c | 183 +++- libavformat/imfdec.c| 2 +- libavformat/tests/imf.c | 4 +

Re: [FFmpeg-devel] [PATCH 2/3] avformat/imfdec: fail on probing non xml file extension

2023-05-06 Thread Pierre-Anthony Lemieux
On Sat, May 6, 2023 at 6:25 AM Michael Niedermayer wrote: > > Its unexpected that a .avi or other "standard" file turns into a playlist. > The goal of this patch is to avoid this unexpected behavior and possible > privacy or security differences. Per the IMF specification, a CPL can have any exte

[FFmpeg-devel] [PATCH 4/4] fate/vcodec: add bitpacked tests

2023-05-06 Thread James Almer
Signed-off-by: James Almer --- tests/fate/vcodec.mak | 13 - tests/ref/vsynth/vsynth1-bitpacked-uyvy422 | 4 tests/ref/vsynth/vsynth1-bitpacked-yuv422p10le | 4 tests/ref/vsynth/vsynth2-bitpacked-uyvy422 | 4 tests/ref

[FFmpeg-devel] [PATCH 3/4] aformat/rawvideodec: don't force the rawvideo decoder for uyvy422 bitpacked streams

2023-05-06 Thread James Almer
The bitpacked decoder can handle it. Signed-off-by: James Almer --- libavformat/rawvideodec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/rawvideodec.c b/libavformat/rawvideodec.c index 514e4e044f..d58e54ce24 100644 --- a/libavformat/rawvideodec.c +++ b/libavformat/rawvideodec

[FFmpeg-devel] [PATCH 2/4] avcodec/bitpacked_dec: add missing props to decoded uyvy422 streams

2023-05-06 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bitpacked_dec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/bitpacked_dec.c b/libavcodec/bitpacked_dec.c index c88f861993..064cc29e7a 100644 --- a/libavcodec/bitpacked_dec.c +++ b/libavcodec/bitpacked_dec.c @@ -27,6 +27,7 @@ */

[FFmpeg-devel] [PATCH 1/4] avcodec/bitpacked_enc: add support for uyvy422 encoding

2023-05-06 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bitpacked_enc.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavcodec/bitpacked_enc.c b/libavcodec/bitpacked_enc.c index 3c4e11293d..cbca38006b 100644 --- a/libavcodec/bitpacked_enc.c +++ b/libavcodec/b

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/flacdec: Fix signed integre overflow

2023-05-06 Thread James Almer
On 5/6/2023 12:08 PM, Michael Niedermayer wrote: On Fri, May 05, 2023 at 07:36:05PM -0300, James Almer wrote: On 4/16/2023 1:48 PM, Michael Niedermayer wrote: Fixes: signed integer overflow: 3011809745540902265 + 6323452730883571725 cannot be represented in type 'long' Fixes: 45982/clusterfuz

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/flacdec: Fix signed integre overflow

2023-05-06 Thread Michael Niedermayer
On Fri, May 05, 2023 at 07:36:05PM -0300, James Almer wrote: > On 4/16/2023 1:48 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 3011809745540902265 + 6323452730883571725 > > cannot be represented in type 'long' > > Fixes: > > 45982/clusterfuzz-testcase-minimized-ffmpeg_AV_CODE

[FFmpeg-devel] [PATCH 3/3] avformat/mpeg: Fix filename extension check for subtitle file

2023-05-06 Thread Michael Niedermayer
This fixes undefined behavior and other issues. No testcase, this was found by code review Signed-off-by: Michael Niedermayer --- libavformat/mpeg.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index 781c3162d6..fdc808dc50 1

[FFmpeg-devel] [PATCH 2/3] avformat/imfdec: fail on probing non xml file extension

2023-05-06 Thread Michael Niedermayer
Its unexpected that a .avi or other "standard" file turns into a playlist. The goal of this patch is to avoid this unexpected behavior and possible privacy or security differences. This is similar to the same change to hls Signed-off-by: Michael Niedermayer --- libavformat/imfdec.c | 5 + 1

[FFmpeg-devel] [PATCH 1/3] avformat/dashdec: fail on probing non mpd file extension

2023-05-06 Thread Michael Niedermayer
Its unexpected that a .avi or other "standard" file turns into a playlist. The goal of this patch is to avoid this unexpected behavior and possible privacy or security differences. This is similar to the same change to hls Signed-off-by: Michael Niedermayer --- libavformat/dashdec.c | 11 ++

Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance

2023-05-06 Thread Devin Heitmueller
On Sat, May 6, 2023 at 8:16 AM James Almer wrote: > Can you bench with the START_TIMER and STOP_TIMER macros in timer.h? > Also, define CACHED_BITSTREAM_READER in bitpacked_dec.c before including > git_bits.h and test the actual implementation again, to see if it makes > any difference. Original

Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance

2023-05-06 Thread James Almer
On 5/6/2023 9:13 AM, Devin Heitmueller wrote: I added some instrumentation via the attached patch. You can see the benefits here: Before=1683378057.243350 After 1683378057.264239 Before=1683378083.335424 After 1683378083.356440 Before=1683378089.675400 After 1683378089.696512 Before=1683378151.

Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance

2023-05-06 Thread Devin Heitmueller
I added some instrumentation via the attached patch. You can see the benefits here: Before=1683378057.243350 After 1683378057.264239 Before=1683378083.335424 After 1683378083.356440 Before=1683378089.675400 After 1683378089.696512 Before=1683378151.792324 After 1683378151.813579 21 ms per run Af

Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance

2023-05-06 Thread Paul B Mahol
On Sat, May 6, 2023 at 1:32 PM Lance Wang wrote: > On Sat, May 6, 2023 at 4:58 AM Devin Heitmueller < > devin.heitmuel...@ltnglobal.com> wrote: > > > Rework the code a bit to speed up the 10-bit bitpacked decoding > > routine. This is probably about as fast as I can get it without > > switching

Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance

2023-05-06 Thread Devin Heitmueller
Hi Lance, On Sat, May 6, 2023 at 7:32 AM Lance Wang wrote: > FYI, on my development system, I run two time for the original and modified > version and no obvious difference: Simply running "time" against the binary isn't an accurate way to measure a 60ms difference for a single frame being proce

Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance

2023-05-06 Thread Lance Wang
On Sat, May 6, 2023 at 4:58 AM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > Rework the code a bit to speed up the 10-bit bitpacked decoding > routine. This is probably about as fast as I can get it without > switching to assembly language. > > Demonstratable with: > > ./ffmpeg -f

[FFmpeg-devel] [PATCH] avfilter/f_ebur128: export results into read-only options

2023-05-06 Thread Paul B Mahol
Attached. From fd7b20023fd8fe19d9559c23f5927a66e75513c1 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 6 May 2023 12:28:10 +0200 Subject: [PATCH] avfilter/f_ebur128: export results into read-only options Signed-off-by: Paul B Mahol --- doc/filters.texi| 18 ++ li

Re: [FFmpeg-devel] [PATCH v3 0/2] JPEG XL Animation Support

2023-05-06 Thread Leo Izen
On 4/27/23 09:09, Leo Izen wrote: Changes from v2: - Bumped libavformat minor version - Rebased onto master Leo Izen (2): avcodec/libjxldec: add animated decode support avformat/jpegxl_anim_dec: add animated JPEG XL demuxer MAINTAINERS | 1 + libavcodec/libjxldec.c