Re: [FFmpeg-devel] [PATCH 01/14] vvcdec: add thread executor

2023-05-22 Thread Nuo Mi
On Tue, May 23, 2023 at 12:29 AM Rémi Denis-Courmont wrote: > Le sunnuntaina 21. toukokuuta 2023, 17.24.56 EEST Nuo Mi a écrit : > > > > + > > > > +typedef struct ThreadInfo { > > > > +int idx; > > > > +VVCExecutor *e; > > > > +pthread_t thread; > > > > +} ThreadInfo; > > > > + > > >

[FFmpeg-devel] [PATCH v4] avfilter/vf_subtitles: add wrap_unicode option

2023-05-22 Thread Zhao Zhili
From: Zhao Zhili So CJK can be wrapped automatically. Signed-off-by: Zhao Zhili --- v4: add doc doc/filters.texi | 7 +++ libavfilter/version.h | 2 +- libavfilter/vf_subtitles.c | 18 ++ 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/doc/f

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: add CBP/CHP profile

2023-05-22 Thread xufuji456
The Constrained_Baseline and Constrained_High profile of H264 has available in iOS 15.0 Signed-off-by: xufuji456 <839789...@qq.com> --- libavcodec/videotoolboxenc.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libav

[FFmpeg-devel] [PATCH 6/6] avcodec/kbdwin: Remove low precision intermediate in ff_kbd_window_init_fixed()

2023-05-22 Thread Michael Niedermayer
Previously floats where scaled up to 32bit int, but floats do not have 32bits in their mantisse so a quarter of the bits where nonsense. It seems no fate test is affected by this change, which is interresting Signed-off-by: Michael Niedermayer --- libavcodec/kbdwin.c | 20 +++-

[FFmpeg-devel] [PATCH 5/6] avcodec/kbdwin: Avoid computing bessel values twice

2023-05-22 Thread Michael Niedermayer
Also reduce neeeded temporary storage by half Signed-off-by: Michael Niedermayer --- libavcodec/kbdwin.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/libavcodec/kbdwin.c b/libavcodec/kbdwin.c index 5dff334250..e2f6491124 100644 --- a/libavcod

[FFmpeg-devel] [PATCH 4/6] avcodec/kbdwin: Use av_bessel_i0()

2023-05-22 Thread Michael Niedermayer
Old code used about 7 times as many cpu cycles as new Signed-off-by: Michael Niedermayer --- libavcodec/kbdwin.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/kbdwin.c b/libavcodec/kbdwin.c index bf32aeb317..5dff334250 100644 --- a/libavcodec/kbdwin.c +++ b/

[FFmpeg-devel] [PATCH 3/6] avfilter/window_func: Use av_bessel_i0()

2023-05-22 Thread Michael Niedermayer
Old code needed about 6 times as long as new with defaults in afftfilt Signed-off-by: Michael Niedermayer --- libavfilter/window_func.h | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/libavfilter/window_func.h b/libavfilter/window_func.h index 02b5def9dd

[FFmpeg-devel] [PATCH 2/6] avfilter/asrc_sinc: Use av_bessel_i0()

2023-05-22 Thread Michael Niedermayer
The new function is much more precise For default beta it is slightly slower, but its speed is already at the worst case in that comparison while the replaced function becomes much slower for larger beta Signed-off-by: Michael Niedermayer --- libavfilter/asrc_sinc.c | 21 ++--- 1

[FFmpeg-devel] [PATCH 1/6] Move bessel_i0() from swresample/resample to avutil/mathematics

2023-05-22 Thread Michael Niedermayer
0th order modified bessel function of the first kind are used in multiple places, lets avoid having 3+ different implementations I picked this one as its accurate and quite fast, it can be replaced if a better one is found Signed-off-by: Michael Niedermayer --- doc/APIchanges | 3 ++

[FFmpeg-devel] [PATCH] fftools/ffmpeg_dec: abort if avcodec_send_packet() returns EAGAIN

2023-05-22 Thread James Almer
As the comment in the code mentions, EAGAIN is not an expected value here because we call avcodec_receive_frame() until all frames have been returned. avcodec_send_packet() returning EAGAIN means a packet is still buffered, which hints that the underlying decoder is buggy and not fetching packets a

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

2023-05-22 Thread James Almer
On 5/22/2023 1:19 PM, Paul B Mahol wrote: On 5/21/23, Paul B Mahol wrote: Attached patches. This finally removes giant hacks in gif demuxer and allows using gif files via pipe reliably. Hopefully final version. Should be ok. ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets

2023-05-22 Thread James Almer
On 5/20/2023 2:23 PM, James Almer wrote: Fixes decoding packets containing split temporal units, as generated for example by the av1_frame_split bsf. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 39 --- 1 file changed, 28 insertions(+), 11 deleti

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_subtitles: add wrap_unicode option

2023-05-22 Thread Oneric
On Mon, May 22, 2023 at 21:26:02 +0800, Zhao Zhili wrote: > From: Zhao Zhili > > So CJK can be wrapped automatically. > > Signed-off-by: Zhao Zhili > --- > v3: Fix build error with older libass > v2: Don't overwrite wrap automatically for native ASS > libavfilter/version.h | 2 +- > liba

Re: [FFmpeg-devel] [PATCH v3] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

2023-05-22 Thread Lynne
May 22, 2023, 16:48 by arnie.ch...@sifive.com: > Optimize the put and avg filtering for 8x8 chroma blocks > > Signed-off-by: Arnie Chang > --- > V3: > 1. Use a macro to extract repetitive segments > 2. Fix coding style issues > 3. Use macros in riscv/asm.S to handle function declarations > 4. Rep

Re: [FFmpeg-devel] [PATCH v3] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

2023-05-22 Thread Rémi Denis-Courmont
Le maanantaina 22. toukokuuta 2023, 17.48.40 EEST Arnie Chang a écrit : > --- /dev/null > +++ b/libavcodec/riscv/h264_chroma_init_riscv.c > @@ -0,0 +1,40 @@ > +/* > + * Copyright (c) 2023 SiFive, Inc. All rights reserved. > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software;

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter/vf_tpad: use enum for start/stop_mode

2023-05-22 Thread Niklas Haas
On Mon, 22 May 2023 12:14:32 +0200 Marvin Scholz wrote: > --- > libavfilter/vf_tpad.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) > > diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > index f0c065f0c3..d0fa7df8be 100644 > --- a/libavfilter/vf_tpad

Re: [FFmpeg-devel] [PATCH 01/14] vvcdec: add thread executor

2023-05-22 Thread Rémi Denis-Courmont
Le sunnuntaina 21. toukokuuta 2023, 17.24.56 EEST Nuo Mi a écrit : > > > + > > > +typedef struct ThreadInfo { > > > +int idx; > > > +VVCExecutor *e; > > > +pthread_t thread; > > > +} ThreadInfo; > > > + > > > +struct VVCExecutor { > > > +VVCTaskCallbacks cb; > > > +ThreadInfo *t

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

2023-05-22 Thread Paul B Mahol
On 5/21/23, Paul B Mahol wrote: > Attached patches. > > This finally removes giant hacks in gif demuxer and allows using gif > files via pipe reliably. > Hopefully final version. From 4dee724ff112967b8aa2e8ca5a45ec2726a7f409 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 21 May 2023 02:1

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

2023-05-22 Thread Anton Khirnov
Quoting James Almer (2023-05-22 18:07:50) > On 5/22/2023 12:49 PM, Paul B Mahol wrote: > > On 5/21/23, Paul B Mahol wrote: > >> Attached patches. > >> > >> This finally removes giant hacks in gif demuxer and allows using gif > >> files via pipe reliably. > >> > > > > Now with smaller diff. > > [

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

2023-05-22 Thread James Almer
On 5/22/2023 12:49 PM, Paul B Mahol wrote: On 5/21/23, Paul B Mahol wrote: Attached patches. This finally removes giant hacks in gif demuxer and allows using gif files via pipe reliably. Now with smaller diff. [...] From f3d6eea43df686b4211601b194fac81f032eb273 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

2023-05-22 Thread James Almer
On 5/22/2023 12:49 PM, Paul B Mahol wrote: On 5/21/23, Paul B Mahol wrote: Attached patches. This finally removes giant hacks in gif demuxer and allows using gif files via pipe reliably. Now with smaller diff. [...] From 208d1e83ae9aef8e9b37007df16569cdd4cf25d2 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

2023-05-22 Thread Paul B Mahol
On 5/21/23, Paul B Mahol wrote: > Attached patches. > > This finally removes giant hacks in gif demuxer and allows using gif > files via pipe reliably. > Now with smaller diff. From f3d6eea43df686b4211601b194fac81f032eb273 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 21 May 2023 02:15:

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: activate & dr

2023-05-22 Thread James Almer
On 5/22/2023 11:55 AM, James Almer wrote: On 5/22/2023 11:48 AM, Anton Khirnov wrote: Quoting Paul B Mahol (2023-05-18 12:22:07)  From af73b69a0be9033fddf222b6e9ac60799de85691 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 15 May 2023 21:54:25 +0200 Subject: [PATCH 26/27] avfilter/src_

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: activate & dr

2023-05-22 Thread James Almer
On 5/22/2023 11:48 AM, Anton Khirnov wrote: Quoting Paul B Mahol (2023-05-18 12:22:07) From af73b69a0be9033fddf222b6e9ac60799de85691 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 15 May 2023 21:54:25 +0200 Subject: [PATCH 26/27] avfilter/src_movie: dr support Signed-off-by: Paul B Ma

[FFmpeg-devel] [PATCH v3] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

2023-05-22 Thread Arnie Chang
Optimize the put and avg filtering for 8x8 chroma blocks Signed-off-by: Arnie Chang --- V3: 1. Use a macro to extract repetitive segments 2. Fix coding style issues 3. Use macros in riscv/asm.S to handle function declarations 4. Replace vslidedown with vslide1down checkasm: using random seed 2379

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: activate & dr

2023-05-22 Thread Anton Khirnov
Quoting Paul B Mahol (2023-05-18 12:22:07) > From af73b69a0be9033fddf222b6e9ac60799de85691 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Mon, 15 May 2023 21:54:25 +0200 > Subject: [PATCH 26/27] avfilter/src_movie: dr support > > Signed-off-by: Paul B Mahol > --- > libavfilter/src_movie.

Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks

2023-05-22 Thread Arnie Chang
On Sat, May 20, 2023 at 1:12 AM Rémi Denis-Courmont wrote: > > +lit4, 0 > > +lit2, 0 > > +addia5, t3, 1 > > +sllit3, a2, 2 > > +.LBB0_3:# if (xy != 0) > > +adda4, a1, t4 > > +vsetvlizero, a5, e8, m1, ta, ma > > +a

[FFmpeg-devel] [PATCH] avformat/mov: decrease probe score for a random tag

2023-05-22 Thread Zhao Zhili
From: Zhao Zhili The tag comes from samples/ffmpeg/mov/unrecognized/bartjones.mov really looks like some random data. Now the random tag matched another file, which isn't a mov. --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c inde

[FFmpeg-devel] [PATCH v3] avfilter/vf_subtitles: add wrap_unicode option

2023-05-22 Thread Zhao Zhili
From: Zhao Zhili So CJK can be wrapped automatically. Signed-off-by: Zhao Zhili --- v3: Fix build error with older libass v2: Don't overwrite wrap automatically for native ASS libavfilter/version.h | 2 +- libavfilter/vf_subtitles.c | 18 ++ 2 files changed, 19 insertions

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_subtitles: add wrap_unicode option

2023-05-22 Thread zhilizhao(赵志立)
> On May 22, 2023, at 19:03, Lance Wang wrote: > > On Mon, May 22, 2023 at 12:05 PM Zhao Zhili wrote: > >> From: Zhao Zhili >> >> So CJK can be wrapped automatically. >> >> Signed-off-by: Zhao Zhili >> --- >> v2: Don't overwrite wrap automatically for native ASS >> >> libavfilter/version

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_subtitles: add wrap_unicode option

2023-05-22 Thread Lance Wang
On Mon, May 22, 2023 at 12:05 PM Zhao Zhili wrote: > From: Zhao Zhili > > So CJK can be wrapped automatically. > > Signed-off-by: Zhao Zhili > --- > v2: Don't overwrite wrap automatically for native ASS > > libavfilter/version.h | 2 +- > libavfilter/vf_subtitles.c | 14 ++ >

[FFmpeg-devel] [PATCH v3 2/2] avfilter/vf_tpad: accept hardware frames in clone-only mode

2023-05-22 Thread Marvin Scholz
When no drawing is to be performed, tpad can work fine with hardware frames, so advertise this in the query_formats callback and ensure the drawing context is never initialised when just cloning frames. --- libavfilter/vf_tpad.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-)

[FFmpeg-devel] [PATCH v3 1/2] avfilter/vf_tpad: use enum for start/stop_mode

2023-05-22 Thread Marvin Scholz
--- libavfilter/vf_tpad.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c index f0c065f0c3..d0fa7df8be 100644 --- a/libavfilter/vf_tpad.c +++ b/libavfilter/vf_tpad.c @@ -27,6 +27,12 @@ #include "formats.h"

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low-latency decoding

2023-05-22 Thread xufuji456
The low-latency decoding mode has available in Android api 30. It will keep less buffer internally, and output frame as fast as possible. See https://developer.android.google.cn/reference/android/media/MediaCodec?hl=en#PARAMETER_KEY_LOW_LATENCY Signed-off-by: xufuji456 <839789...@qq.com> --- lib

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding

2023-05-22 Thread ??????
Ok, I will remove checking about api. -- Original -- From: ""zhilizhao(??)""

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-22 Thread Marvin Scholz
On 22 May 2023, at 1:52, Stefano Sabatini wrote: > On date Monday 2023-05-01 13:44:54 +0200, Marvin Scholz wrote: >> This new API allows to remove an entry and obtain ownership of the >> key/value that was associated with the removed entry. Thanks for the review! >> --- >> doc/APIchanges

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-22 Thread Carotti, Elias
Hi Stefano, thanks for checking the patch. Please find it attached in the required format. Best, Elias On Mon, 2023-05-22 at 01:17 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding

2023-05-22 Thread zhilizhao(赵志立)
> On May 22, 2023, at 14:52, xufuji456 <839789...@qq.com> wrote: > > The low-latency decoding mode has available in Android api 30. > See > https://developer.android.google.cn/reference/android/media/MediaCodec?hl=en#PARAMETER_KEY_LOW_LATENCY > > Signed-off-by: xufuji456 <839789...@qq.com> >

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/vf_libplacebo: switch to new gamut mapping API

2023-05-22 Thread Niklas Haas
On Sun, 21 May 2023 14:24:35 +0200 Niklas Haas wrote: > From: Niklas Haas > > Upstream deprecated the old ad-hoc, enum/intent-based gamut mapping API > and added a new API based on colorimetrically accurate gamut mapping > functions. > > The relevant change for us is the addition of several new

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libplacebo: add RGB colorspace sanity

2023-05-22 Thread Niklas Haas
On Sun, 21 May 2023 15:54:20 +0200 Niklas Haas wrote: > From: Niklas Haas > > Explicitly forbid using a non-RGB colorspace with RGB pixel format or > vice versa. This mirrors identical logic from vf_scale. > --- > libavfilter/vf_libplacebo.c | 7 +++ > 1 file changed, 7 insertions(+) > > d

Re: [FFmpeg-devel] [PATCH] lavfi/libplacebo: properly handle EOF

2023-05-22 Thread Niklas Haas
On Sun, 21 May 2023 13:13:52 +0200 Niklas Haas wrote: > From: Niklas Haas > > The current code relied on pl_queue eventually returning EOF back to the > caller, which didn't work in all situations (e.g. single frame input). > Also, the current code assumed that ff_inlink_acknowledge_status only

Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering

2023-05-22 Thread Lynne
Planning on pushing this partially (no encoding) tomorrow unless there are more comments. All known issues have been fixed, and if there are more issues, they can be found as users test it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://f

Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove hScale8To19_vsx

2023-05-22 Thread Martin Storsjö
On Thu, 18 May 2023, Lynne wrote: Fails checkasm on a Power9 DD2.2 02CY771 system. The assembly doesn't seem to have been independently tested at all. https://paste.sr.ht/~ky0ko/fe255ff73fab49b0c6d335437d894c1db626289e Patch attached. FWIW, I don't know about the PPC functions, but... swscal