Re: [FFmpeg-devel] [RESEND PATCH] avcodec/v4l2_context: always log POLLERR when buffers are uninitialized

2023-07-21 Thread Richard Acayan
Will this patch be applied or receive any comments? I have been waiting more than 2 weeks since the original submission (https://ffmpeg.org/pipermail/ffmpeg-devel/2023-July/311580.html) and have not received a response since. I am trying to get mpv to work again with the v4l2_m2m codec, as it star

Re: [FFmpeg-devel] [PATCH 1/7] lavu: add ecinfo sidedata

2023-07-21 Thread Lynne
Jul 21, 2023, 15:38 by j...@itanimul.li: > Add sidedata for passing basic Error Concealment information helpful to > a renderer or end user attempting to filter or conceal video decoding > errors and artifacts. > > Co-Authored-By: Thomas Guillem > Signed-off-by: J. Dekker > --- > libavutil/Make

Re: [FFmpeg-devel] [PATCH 08/14] tests: Add avradio/sdrdemux tests

2023-07-21 Thread Michael Niedermayer
On Fri, Jul 21, 2023 at 08:42:59PM +0200, Michael Niedermayer wrote: > On Tue, Jul 18, 2023 at 11:45:36PM +0200, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > tests/Makefile| 1 + > > tests/fate/sdr.mak| 11 + > > tests/ref/fate/sdr-am | 55 +++

Re: [FFmpeg-devel] [PATCH 1/7] lavu: add ecinfo sidedata

2023-07-21 Thread Michael Niedermayer
On Fri, Jul 21, 2023 at 03:37:40PM +0200, J. Dekker wrote: > Add sidedata for passing basic Error Concealment information helpful to > a renderer or end user attempting to filter or conceal video decoding > errors and artifacts. The exported information seems too basic to perform error concealment

Re: [FFmpeg-devel] [PATCH] libavutil: Remove TOMI CPU

2023-07-21 Thread James Almer
On 7/21/2023 8:21 PM, Kieran Kunhya wrote: On Sun, 18 Dec 2022 at 00:42, Kieran Kunhya wrote: On Sat, 17 Dec 2022 at 23:44, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: Is this code broken or stand in the way of progress? - Andreas I believe this CPU only exists on paper.

Re: [FFmpeg-devel] [PATCH] libavutil: Remove TOMI CPU

2023-07-21 Thread Kieran Kunhya
On Sun, 18 Dec 2022 at 00:42, Kieran Kunhya wrote: > On Sat, 17 Dec 2022 at 23:44, Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Is this code broken or stand in the way of progress? >> >> - Andreas >> > > I believe this CPU only exists on paper. > > Kieran > ping ___

[FFmpeg-devel] [RFC][PATCH 3/3] decklink: Add support for output of HDR metadata

2023-07-21 Thread Devin Heitmueller
Add HDR support to the decklink output for cards that support such functionality. This includes setting the EOTF, the colorspace, the mastering info, and the content light level info. Both the Payload Identification HANC data as well as the SMPTE ST 2108-1 VANC data are being set. Tested with in

[FFmpeg-devel] [RFC][PATCH 2/3] v210enc: Add HDR metadata passthrough

2023-07-21 Thread Devin Heitmueller
In order to implement HDR output for decklink we need to expose the side data containing the mastering and light level info. Add the two additional types of side table to those which are passed through. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 2 ++ 1 file changed, 2 insertio

[FFmpeg-devel] [RFC][PATCH 1/3] v210enc: Refactor side data passthrough

2023-07-21 Thread Devin Heitmueller
As the number of side-data items we pass through increases, refactor the values into a table in the same manner as done in decode.c. In the future it might make sense to make this a shared function which can be reused by other encoders. But for now keep it local. Signed-off-by: Devin Heitmueller

[FFmpeg-devel] [RFC][PATCH 0/3] Add support for decklink HDR metadata output

2023-07-21 Thread Devin Heitmueller
This patch series includes support for output of HDR metadata, as well as a change to the v210 encoder to ensure it is passed through to the decklink libavdevice. Comments/feedback are welcome. Devin Heitmueller (3): v210enc: Refactor side data passthrough v210enc: Add HDR metadata passthroug

[FFmpeg-devel] [PATCH v3 4/4] bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when reclocking

2023-07-21 Thread Devin Heitmueller
Because SCTE-35 messages are represented in TS streams as sections rather than PES packets, we cannot rely on ffmpeg's standard mechanisms to adjust PTS values if reclocking the stream. This filter will leverage the SCTE-35 pts_adjust field to compensate for any change in the PTS values in the stre

[FFmpeg-devel] [PATCH v3 3/4] mpegtsenc: Add support for output of SCTE-35 streams over TS

2023-07-21 Thread Devin Heitmueller
Introduce the ability to pass through SCTE-35 packets when creating MPEG transport streams. Note that this patch makes no effort to change the PTS values in the SCTE-35 packets, and thus only works when not reclocking the stream (i.e. using -copyts). A subsequent patch includes a BSF to recompute

[FFmpeg-devel] [PATCH v3 1/4] avcodec: Add new side data type to contain original PTS value

2023-07-21 Thread Devin Heitmueller
In order to properly process SCTE-35 packets, we need the original PTS value from the demux (i.e. not mangled by the application or reclocked for the output). This allows us to set the pts_adjustment field in an BSF on the output side. Introduce a new side data type to store the original PTS. Si

[FFmpeg-devel] [PATCH v3 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-07-21 Thread Devin Heitmueller
We need the original PTS value in order to do subsequent processing, so set it as packet side data. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 0b3edda.

[FFmpeg-devel] [PATCH v3 0/4] Add passthrough support for SCTE-35

2023-07-21 Thread Devin Heitmueller
Properly set up the MPEG-TS mux and recalculate the pts_adjust field in SCTE_35 packets, such that a user can transparently pass through SCTE-35 streams when both the input and output are MPEG-TS. This patch series rebased against master and a patch to hack around periodic PCR retransmission has b

Re: [FFmpeg-devel] [PATCH 08/14] tests: Add avradio/sdrdemux tests

2023-07-21 Thread Michael Niedermayer
On Tue, Jul 18, 2023 at 11:45:36PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tests/Makefile| 1 + > tests/fate/sdr.mak| 11 + > tests/ref/fate/sdr-am | 55 +++ > tests/ref/fate/sdr-fm | 25 ++

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vulkan_decode: use a single execution pool per thread

2023-07-21 Thread Lynne
Jul 19, 2023, 06:17 by d...@lynne.ee: > The spec says command buffer pools must be externally synchronized > objects, which caused us to fail validation when decoding. > > This still lets us pool some resources, just not as much. > > Patch attached. > Pushed. _

Re: [FFmpeg-devel] [PATCH 1/7] lavu: add ecinfo sidedata

2023-07-21 Thread Devin Heitmueller
On Fri, Jul 21, 2023 at 9:38 AM J. Dekker wrote: > > Add sidedata for passing basic Error Concealment information helpful to > a renderer or end user attempting to filter or conceal video decoding > errors and artifacts. > > Co-Authored-By: Thomas Guillem > Signed-off-by: J. Dekker > --- > liba

Re: [FFmpeg-devel] [PATCH v5 0/4] JPEG XL Parser

2023-07-21 Thread Leo Izen
On 7/10/23 19:57, Leo Izen wrote: Changes from v4: - Added an entropy decoder and full parser, which finds the boundaries between files correctly - Removed unnecessary logging in libjxldec Changes from v3: - Don't remove AV_CODEC_CAP_DR1 from libjxldec - jpegxl_parse.o added to STLIBOBJS

[FFmpeg-devel] [PATCH 6/7 v1.1] tools/ffprobe: add ecinfo frame side data

2023-07-21 Thread J. Dekker
Signed-off-by: J. Dekker --- fftools/ffprobe.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index a39185f6fe..572a5150cf 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -39,6 +39,7 @@ #include "libavutil/bprint.h" #include "

[FFmpeg-devel] [PATCH 6/7] tools/ffprobe: add ecinfo frame side data

2023-07-21 Thread J. Dekker
Signed-off-by: J. Dekker --- fftools/ffprobe.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index a39185f6fe..9b1f04e1be 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -39,6 +39,7 @@ #include "libavutil/bprint.h" #include "

[FFmpeg-devel] [PATCH 7/7] fate: add ecinfo sidedata test

2023-07-21 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/Makefile | 1 + tests/fate/ec.mak | 6 + tests/ref/fate/ec-sidedata-h264 | 332 3 files changed, 339 insertions(+) create mode 100644 tests/fate/ec.mak create mode 100644 tests/ref/fate/ec-sid

[FFmpeg-devel] [PATCH 5/7] lavc/h264: export ecinfo

2023-07-21 Thread J. Dekker
Export ecinfo to the user when AV_CODEC_EXPORT_DATA_ERROR is set. Co-Authored-By: Thomas Guillem Signed-off-by: J. Dekker --- libavcodec/h264_picture.c | 10 -- libavcodec/h264_slice.c | 16 +++- libavcodec/h264dec.c | 33 +++-- libavcodec/

[FFmpeg-devel] [PATCH 4/7] lavc: set decode_error_flags when ec active

2023-07-21 Thread J. Dekker
FF_DECODE_ERROR_CONCEALMENT_ACTIVE should be set when ec is active on supported decoders. Co-Authored-By: Thomas Guillem Signed-off-by: J. Dekker --- libavcodec/h263dec.c | 6 -- libavcodec/mpeg12dec.c | 3 ++- libavcodec/mss2.c | 8 +--- libavcodec/rv10.c | 10 --

[FFmpeg-devel] [PATCH 3/7] lavc/error_resilience: fill ecinfo

2023-07-21 Thread J. Dekker
Fill ECInfo inside error resilience using references set by the decoder. Co-Authored-By: Thomas Guillem Signed-off-by: J. Dekker --- libavcodec/error_resilience.c | 91 +-- libavcodec/error_resilience.h | 4 +- 2 files changed, 79 insertions(+), 16 deletions(-)

[FFmpeg-devel] [PATCH 1/7] lavu: add ecinfo sidedata

2023-07-21 Thread J. Dekker
Add sidedata for passing basic Error Concealment information helpful to a renderer or end user attempting to filter or conceal video decoding errors and artifacts. Co-Authored-By: Thomas Guillem Signed-off-by: J. Dekker --- libavutil/Makefile | 2 ++ libavutil/ec.c | 42 +

[FFmpeg-devel] [PATCH 2/7] lavc: add AV_CODEC_EXPORT_DATA_ERROR

2023-07-21 Thread J. Dekker
Add an option to avcodec to allow supported decoders to optionally output information about error resilience as sidedata. Co-Authored-By: Thomas Guillem Signed-off-by: J. Dekker --- libavcodec/avcodec.h | 5 + libavcodec/options_table.h | 1 + libavcodec/version.h | 2 +- 3 file

Re: [FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program()

2023-07-21 Thread Anton Khirnov
Quoting Anton Khirnov (2023-07-21 14:06:37) > Quoting Marton Balint (2023-07-20 22:35:23) > > > > > > On Sat, 15 Jul 2023, Anton Khirnov wrote: > > > > > Inline the relevant part of ffprobe_cleanup() into main() and drop the > > > rest. > > > --- > > > fftools/ffprobe.c | 22

Re: [FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program()

2023-07-21 Thread Anton Khirnov
Quoting Marton Balint (2023-07-20 22:35:23) > > > On Sat, 15 Jul 2023, Anton Khirnov wrote: > > > Inline the relevant part of ffprobe_cleanup() into main() and drop the > > rest. > > --- > > fftools/ffprobe.c | 22 -- > > 1 file changed, 8 insertions(+), 14 deletions(-) > > >

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: enable identifying TTML subtitle streams as such

2023-07-21 Thread Jan Ekström
On Mon, Jul 17, 2023 at 2:35 PM Jan Ekström wrote: > > On Wed, Jul 12, 2023 at 4:48 PM Jan Ekström wrote: > > > > From: Jan Ekström > > > > The contents are full TTML XML documents. TTML writing tests' > > results are updated as the streams are now properly identified > > as TTML ones. > > > > S

[FFmpeg-devel] [PATCH] lavfi/Makefile: add missing folder to clean target

2023-07-21 Thread J. Dekker
Signed-off-by: J. Dekker --- libavfilter/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index 9b7813575a..312e4c145b 100644 --- a/libavfilter/Makefile +++ b/libavfilter/Makefile @@ -656,8 +656,8 @@ TESTPROGS = drawutils

Re: [FFmpeg-devel] [PATCH v4 3/3] tests/fate/flvenc: add av1 in enhanced flv test case

2023-07-21 Thread Steven Liu
Steven Liu 于2023年7月21日周五 15:54写道: > > Michael Niedermayer 于2023年7月21日周五 05:51写道: > > > > On Thu, Jul 20, 2023 at 07:00:02PM +0800, Steven Liu wrote: > > > Signed-off-by: Steven Liu > > > --- > > > tests/fate/flvenc.mak | 4 > > > tests/ref/fate/enhanced-flv-av1 | 32

Re: [FFmpeg-devel] [PATCH v4 3/3] tests/fate/flvenc: add av1 in enhanced flv test case

2023-07-21 Thread Steven Liu
Michael Niedermayer 于2023年7月21日周五 05:51写道: > > On Thu, Jul 20, 2023 at 07:00:02PM +0800, Steven Liu wrote: > > Signed-off-by: Steven Liu > > --- > > tests/fate/flvenc.mak | 4 > > tests/ref/fate/enhanced-flv-av1 | 32 > > 2 files changed, 36 inser