Re: [FFmpeg-devel] [PATCH v2] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces

2023-08-11 Thread Random Joe
Only update ulMaxNumDecodeSurfaces if necessary. As for the stutter , I can't tell for sure , maybe it's a race condition somewhere in the driver. 402d98c decoupled cuvid parser and decoder number of decode buffers , with parser buffers set to be always CUVID_DEFAULT_NUM_SURFACES (5). In NVDEC Prog

Re: [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang

2023-08-11 Thread Brad Smith
Just FYI, we have had this in the OpenBSD and FreeBSD packages for quite awhile to be able to build on powerpc64. On 2023-08-07 9:02 p.m., Brad Smith wrote: lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang libswscale/ppc/yuv2rgb_altivec.c:288:36: error: redeclaration of '

[FFmpeg-devel] [PATCH 11/11] fate/matroska: Fix requirements of fate-matroska-alac-remux test

2023-08-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/matroska.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index 16285a2dc8..44f5c535e4 100644 --- a/tests/fate/matroska.mak +++ b/tests/fate/matroska.mak @@ -34,7 +34,7 @@ fat

[FFmpeg-devel] [PATCH 10/11] fate/matroska: Add test for stereo 3D

2023-08-11 Thread Andreas Rheinhardt
Just mark a non-stereo file as stereo to test the code. Signed-off-by: Andreas Rheinhardt --- This test would not pass on master as-is due to the anaglyph modes which are broken on master. I intend to apply it before 4/9 so that fixing the anaglyph modes is visible in the changes to FATE. test

Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for VP8 codec bitstream READ methods

2023-08-11 Thread Andreas Rheinhardt
Dai, Jianhui J: > This commit adds VP8 into cbs supported codec list, and enables the > `trace_headers` bitstream filters to support VP8, besides existing AV1, > H.264, H.265 and VP9. It can be useful to debug VP8 stream issues. > > Only the READ methods `read_unit` and `split_fragment` are implem

Re: [FFmpeg-devel] [PATCH v2] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces

2023-08-11 Thread Timo Rothenpieler
On 11.08.2023 19:50, Random Joe wrote: Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c. Signed-off-by: Random Joe ---  libavcodec/cuviddec.c | 13 +++--  1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH v2] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces

2023-08-11 Thread Random Joe
Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c. Signed-off-by: Random Joe --- libavcodec/cuviddec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index

[FFmpeg-devel] [PATCH] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces

2023-08-11 Thread Random Joe
Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c. Signed-off-by: Random Joe --- libavcodec/cuviddec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index

Re: [FFmpeg-devel] [PATCH] exclude currently unused 0.17% of fate samples from rsync

2023-08-11 Thread Vittorio Giovara
On Thu, Aug 10, 2023 at 5:27 PM Michael Niedermayer wrote: > Several developers where upset, that from the over 1gb of fate samples 2mb > are only used > by the ffmpeg branch with SDR support in https://git.ffmpeg.org/libavradio > > This avoids these samples from being downloaded or synchronized.

[FFmpeg-devel] [PATCH] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces

2023-08-11 Thread Random Joe
Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c . Signed-off-by: Random Joe --- libavcodec/cuviddec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Decode URL parameter strings

2023-08-11 Thread Armin Hasitzka
I think accepting URL params in first place isn't inherently bad (depending on the use case, it might make certain interactions easier). I expected regressions to be brought up and just want to point out that, while absolutely possible, actual regressions will likely be fairly rare: - any "un

Re: [FFmpeg-devel] [PATCH 8/9] avformat/matroskadec: Use named constants instead of their value

2023-08-11 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 9/9] avformat/riffdec: Pass logctx as void* instead of AVFormatContext*

2023-08-11 Thread Andreas Rheinhardt
Also stop second-guessing error codes from ff_get_extradata(). Signed-off-by: Andreas Rheinhardt --- libavformat/riff.h| 3 ++- libavformat/riffdec.c | 22 -- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/libavformat/riff.h b/libavformat/riff.h index 8

[FFmpeg-devel] [PATCH 8/9] avformat/matroskadec: Use named constants instead of their value

2023-08-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index e6797b2f57..21f52ccab2 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3038,

[FFmpeg-devel] [PATCH 7/9] avformat/matroskadec: Replace switch with array

2023-08-11 Thread Andreas Rheinhardt
This simplification reduces codesize. (It even reduces the size of .rodata here, because the jump table used by the compiler is bigger than the actual array.) Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 47 +-- 1 file changed, 11 insertio

[FFmpeg-devel] [PATCH 6/9] avformat/matroska: Move ff_mkv_stereo3d_conv() to demuxer

2023-08-11 Thread Andreas Rheinhardt
It is now its only user; also make it static. Signed-off-by: Andreas Rheinhardt --- libavformat/matroska.c| 58 --- libavformat/matroska.h| 2 -- libavformat/matroskadec.c | 58 ++- 3 files changed, 57 insertions(+)

[FFmpeg-devel] [PATCH 5/9] avformat/matroskaenc: Improve message for WebM-incompatible StereoModes

2023-08-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 20d3af3b42..c4be6791ab 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -158

[FFmpeg-devel] [PATCH 4/9] avformat/matroskaenc: Don't add side-data to input stream

2023-08-11 Thread Andreas Rheinhardt
When muxing, the AVStreams' side-data is typically set by the caller before avformat_write_header(); it is not documented to be else. Yet the Matroska muxer added an AVStereo3D side data if certain metadata was present: Since commit 4d686fb721b485ebbc4c7779d927d876c1e630f7 (adding support for AVSt

[FFmpeg-devel] [PATCH 3/9] avformat/matroska: Add macro for stereomode<->AVStereo3D correspondence

2023-08-11 Thread Andreas Rheinhardt
It will allow to create tables for easy conversion from AVStereo3D to stereomode and back again as well as derive the properties of a given stereomode. Signed-off-by: Andreas Rheinhardt --- libavformat/matroska.h | 37 + 1 file changed, 37 insertions(+) diff

[FFmpeg-devel] [PATCH 2/9] avformat/matroska: Move ff_matroska_video_stereo_plane to demuxer

2023-08-11 Thread Andreas Rheinhardt
Only used there. Signed-off-by: Andreas Rheinhardt --- libavformat/matroska.c| 6 -- libavformat/matroska.h| 1 - libavformat/matroskadec.c | 8 +++- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 79b2d09984..a

[FFmpeg-devel] [PATCH 1/9] avformat/matroskaenc: Avoid atoi()

2023-08-11 Thread Andreas Rheinhardt
It has undefined behaviour in case the value does not fit into an int. Also stop allowing to override a stream level "alpha_mode" tag by an AVFormatContext one and properly check that the stereo_mode number given via a tag is actually in the range 0..14: Negative values would have been treated as z

[FFmpeg-devel] [PATCH] pssh: add a flag for writing pssh boxes

2023-08-11 Thread Malek Assaad
Hi all, I would like to add an option to create pssh boxes with ffmpeg. I have included my implementation for review. I consulted the standard: ISO/IEC 23001-7:2022 and I am looking forward for the feedback. Add a flag to create Protection System Specific Header boxes in a movie box in coherence