Re: [FFmpeg-devel] [PATCH v1] avformat/rtmpproto: support fourCcList property in enhanced rtmp

2023-08-23 Thread Steven Liu
Marton Balint 于2023年8月24日周四 01:43写道: > > > > On Wed, 23 Aug 2023, Martin Storsjö wrote: > > > On Wed, 23 Aug 2023, Jean-Baptiste Kempf wrote: > > > >> Hello, > >> > >> On Mon, 21 Aug 2023, at 03:35, Steven Liu wrote: > >>> Jean-Baptiste Kempf 于2023年8月20日周日 16:29写道: > > Hello, > >>>

[FFmpeg-devel] [PATCH v1 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-23 Thread Steven Liu
add option named rtmp_enhanced_codec, it would support hvc1,av01,vp09 now, the fourcc is using Array of strings. Signed-off-by: Steven Liu --- doc/protocols.texi | 6 ++ libavformat/rtmpproto.c | 38 ++ 2 files changed, 44 insertions(+) diff --git a

[FFmpeg-devel] [PATCH v1 1/2] avformat/rtmppkt: add ff_amf_write_array for write array strings

2023-08-23 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/rtmppkt.c | 6 ++ libavformat/rtmppkt.h | 8 2 files changed, 14 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index 4b97c0833f..cd0c68ec8a 100644 --- a/libavformat/rtmppkt.c +++ b/libavformat/rtmppkt.c @@ -40,6 +4

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-23 Thread Paul B Mahol
On Thu, Aug 24, 2023 at 12:36 AM Michael Niedermayer wrote: > On Wed, Aug 23, 2023 at 09:04:35PM +0200, Paul B Mahol wrote: > > On Wed, Aug 23, 2023 at 9:02 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Wed, Aug 16, 2023 at 06:53:42PM +0200, Paul B Mahol wrote: > > >

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-23 Thread Michael Niedermayer
On Wed, Aug 23, 2023 at 09:04:35PM +0200, Paul B Mahol wrote: > On Wed, Aug 23, 2023 at 9:02 PM Michael Niedermayer > wrote: > > > On Wed, Aug 16, 2023 at 06:53:42PM +0200, Paul B Mahol wrote: > > > On Wed, Aug 16, 2023 at 6:38 PM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: > >

Re: [FFmpeg-devel] [PATCH v2] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang

2023-08-23 Thread Michael Niedermayer
On Fri, Aug 18, 2023 at 10:14:04PM -0400, Brad Smith wrote: > lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang > > Add a check for the existence of the vec_xl() function. Clang provides > the function even with VSX not enabled. > > v2: test for function if AltiVec is enabled

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/xvididct: Fix integer overflow in idct_row()

2023-08-23 Thread Michael Niedermayer
On Mon, Aug 07, 2023 at 02:49:47AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1403461578 + -843974775 cannot be > represented in type 'int' > Fixes: > 60868/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-4599793035378688 > > Found-by: continuous fuz

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-23 Thread Kyle Swanson
Hi, Thank you Timo for the review. Took your suggestions, updated patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

[FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_decode: print also codec header name

2023-08-23 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- libavcodec/vulkan_decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c index 7607edf52e..0d561b7450 100644 --- a/libavcodec/vulkan_decode.c +++ b/libavcodec/vulkan_decode.c @@ -863,6 +863,9 @@ s

[FFmpeg-devel] [PATCH 2/3] avcodec/vulkan_decode: check specVersion to avoid using incompatible implementations

2023-08-23 Thread Kacper Michajłow
Fixes: VUID-VkVideoSessionCreateInfoKHR-pStdHeaderVersion-07190 VUID-VkVideoSessionCreateInfoKHR-pStdHeaderVersion-07191 As a bonus avoids crashing AMD video driver on Windows, which currently doesn't advertise support. Signed-off-by: Kacper Michajłow --- libavcodec/vulkan_decode.c | 5 + 1

[FFmpeg-devel] [PATCH 1/3] avcodec/vulkan_decode: fix struct type for h265_profile

2023-08-23 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- libavcodec/vulkan_decode.c | 2 +- libavcodec/vulkan_decode.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c index f20733fb39..04350578f9 100644 --- a/libavcodec/vulkan_decode.c +++

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-23 Thread Paul B Mahol
On Wed, Aug 23, 2023 at 9:02 PM Michael Niedermayer wrote: > On Wed, Aug 16, 2023 at 06:53:42PM +0200, Paul B Mahol wrote: > > On Wed, Aug 16, 2023 at 6:38 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Tue, Aug 15, 2023 at 04:49:05PM +0200, Paul B Mahol wrote: > > > >

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-23 Thread Michael Niedermayer
On Wed, Aug 16, 2023 at 06:53:42PM +0200, Paul B Mahol wrote: > On Wed, Aug 16, 2023 at 6:38 PM Michael Niedermayer > wrote: > > > On Tue, Aug 15, 2023 at 04:49:05PM +0200, Paul B Mahol wrote: > > > Attached > > > > [...] > > > adpcm.c |2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(

Re: [FFmpeg-devel] [PATCH v2] avformat/mp3dec: Subtract known padding from duration

2023-08-23 Thread Ulrik Mikaelsson
> This still fails fate-seek-extra-mp3 I noticed. Apologies for the noise, I'm unfamiliar with the FATE suite and failed to realize "make fate" won't run the _whole_ thing. I have just submitted a 3d revision of this patch, fixing the review comments and fully passing `make fate SAMPLES=./fate-su

[FFmpeg-devel] [PATCH v3] avformat/mp3dec: Subtract known padding from duration

2023-08-23 Thread Ulrik Mikaelsson
When an Info-tag is present, marking initial and trailing samples as padding, those samples should not be included in the calculation of track duration. This solves a surprising user experience where converting a WAV->MP3->WAV, ffprobe will show the duration of the mp3 as slightly longer than both

Re: [FFmpeg-devel] [PATCH v1] avformat/rtmpproto: support fourCcList property in enhanced rtmp

2023-08-23 Thread Marton Balint
On Wed, 23 Aug 2023, Martin Storsjö wrote: On Wed, 23 Aug 2023, Jean-Baptiste Kempf wrote: Hello, On Mon, 21 Aug 2023, at 03:35, Steven Liu wrote: Jean-Baptiste Kempf 于2023年8月20日周日 16:29写道: Hello, Hi On Sun, 20 Aug 2023, at 06:10, Steven Liu wrote: > As the enhanced rtmp Exten

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-23 Thread Paul B Mahol
Will apply ASAP! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] avformat/rtmpproto: support fourCcList property in enhanced rtmp

2023-08-23 Thread Martin Storsjö
On Wed, 23 Aug 2023, Jean-Baptiste Kempf wrote: Hello, On Mon, 21 Aug 2023, at 03:35, Steven Liu wrote: Jean-Baptiste Kempf 于2023年8月20日周日 16:29写道: Hello, Hi On Sun, 20 Aug 2023, at 06:10, Steven Liu wrote: > As the enhanced rtmp Extending NetConnection connect Command section > said, the

Re: [FFmpeg-devel] [PATCH v1] avformat/rtmpproto: support fourCcList property in enhanced rtmp

2023-08-23 Thread Jean-Baptiste Kempf
Hello, On Mon, 21 Aug 2023, at 03:35, Steven Liu wrote: > Jean-Baptiste Kempf 于2023年8月20日周日 16:29写道: >> >> Hello, > Hi >> >> On Sun, 20 Aug 2023, at 06:10, Steven Liu wrote: >> > As the enhanced rtmp Extending NetConnection connect Command section >> > said, the rtmp should add a property named f

Re: [FFmpeg-devel] [PATCH v2] avformat/mp3dec: Subtract known padding from duration

2023-08-23 Thread Tomas Härdin
ons 2023-08-23 klockan 11:55 +0200 skrev Ulrik Mikaelsson: > When an Info-tag is present, marking initial and trailing samples as > padding, those samples should not be included in the calculation of > track > duration. > > This solves a surprising user experience where converting a WAV->MP3- > >W

[FFmpeg-devel] [PATCH] GSoC 2023: Add Audio Overlay Filter

2023-08-23 Thread Harshit Karwal
1. Added af_aoverlay.c 2. Updated filter documentation 3. Included the filter in libavfilter/Makefile and libavfilter/allfilters.c Signed-off-by: Harshit Karwal --- doc/filters.texi | 40 +++ libavfilter/Makefile | 1 + libavfilter/af_aoverlay.c | 623 +++

[FFmpeg-devel] [PATCH v2] avformat/mp3dec: Subtract known padding from duration

2023-08-23 Thread Ulrik Mikaelsson
When an Info-tag is present, marking initial and trailing samples as padding, those samples should not be included in the calculation of track duration. This solves a surprising user experience where converting a WAV->MP3->WAV, ffprobe will show the duration of the mp3 as slightly longer than both

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec:Subtract known padding from duration

2023-08-23 Thread Ulrik Mikaelsson
> > --- > > libavformat/mp3dec.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > > index 05c13228bc..c8c3b298ab 100644 > > --- a/libavformat/mp3dec.c > > +++ b/libavformat/mp3dec.c > > @@ -350,7 +350,8 @@ static int mp3

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec:Subtract known padding from duration

2023-08-23 Thread Tomas Härdin
tis 2023-08-22 klockan 14:03 +0200 skrev Ulrik Mikaelsson: > When an Info-tag is present, marking initial and trailing samples as > padding, those samples should not be included in the calculation of > track > duration. > > This solves a surprising user experience where converting a WAV->MP3- > >W