[FFmpeg-devel] [PATCH v4 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-27 Thread Steven Liu
add option named rtmp_enhanced_codec, it would support hvc1,av01,vp09 now, the fourcc is using Array of strings. Signed-off-by: Steven Liu --- doc/protocols.texi | 11 +++ libavformat/rtmpproto.c | 34 ++ 2 files changed, 45 insertions(+) diff --git

[FFmpeg-devel] [PATCH v4 1/2] avformat/rtmppkt: add ff_amf_write_array for write

2023-08-27 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/rtmppkt.c | 6 ++ libavformat/rtmppkt.h | 8 2 files changed, 14 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index 4b97c0833f..a602bf6a96 100644 --- a/libavformat/rtmppkt.c +++ b/libavformat/rtmppkt.c @@ -40,6

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/apedec: Implement interim mode detection

2023-08-27 Thread Michael Niedermayer
On Sat, Aug 26, 2023 at 06:53:50PM +0200, Michael Niedermayer wrote: > Fixes: NoLegacy.ape > Found-by: Matt Ashland > Signed-off-by: Michael Niedermayer > --- > libavcodec/apedec.c | 106 +++- > 1 file changed, 84 insertions(+), 22 deletions(-) Also, the

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/apedec: Implement interim mode detection

2023-08-27 Thread Michael Niedermayer
On Sat, Aug 26, 2023 at 08:07:14PM +0200, Michael Niedermayer wrote: > On Sat, Aug 26, 2023 at 07:55:10PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-08-26 18:53:50) > > > Fixes: NoLegacy.ape > > > > Can you make a FATE test? > > The file seems 34mb, ill try to cut it down

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/apedec: Implement interim mode detection

2023-08-27 Thread Michael Niedermayer
On Sat, Aug 26, 2023 at 07:29:40PM +0200, Paul B Mahol wrote: > On Sat, Aug 26, 2023 at 6:54 PM Michael Niedermayer > wrote: > > > Fixes: NoLegacy.ape > > Found-by: Matt Ashland > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/apedec.c | 106

[FFmpeg-devel] [PATCH] avfilter/vf_pad: respect frame colorspace tag in RGB to YUV conversion

2023-08-27 Thread Leo Izen
vf_pad calls ff_draw_init, which assumes BT.709 and TV range for its YUV matricies. Since the filter only accepts RGB inputs for the color argument, it needs to convert them to YUV for YUV input video, and it should respect the tagged colormatrix when doing such a conversion, but it does not. It

[FFmpeg-devel] sending RTSP keep alive even when paused

2023-08-27 Thread Tmc Tmc
Hi All, I found a bug in ffmpeg's RTSP implementation. The workflow is as follows: 1. Have a RTSP server that supports Pause. 2. Have ffmpeg play a video from that server (rtsp://:...). 3. Pause the video in ffmpeg. 4. ffmpeg does NOT properly send the keep alive when Paused (either

Re: [FFmpeg-devel] [PATCH 6/6] doc/developer: deduplicate commit message rules

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > The patches/committing section currently contains several > partially-overlapping rules on commit messages. Merge and simplify them > into one item. > --- > doc/developer.texi | 41 ++--- > 1 file changed,

Re: [FFmpeg-devel] [PATCH 5/6] doc/developer: drop an outdated item

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > It dates back to pre-2005 days, when people generally tended to commit > their work directly without going through the mailing list. Few > developers do it today, and never outside of their standalone modules. > This item is thus confusing

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > Document our longstanding de facto policies on things like correctness, > thread-safety, UB, etc. > UB? --- > doc/developer.texi | 50 +- > 1 file changed, 36 insertions(+), 14 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 3/6] doc/developer: fix a nonsense statement

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > Adding new fields to _functions_ makes no sense, it was supposed to be > structs. > --- > doc/developer.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index

Re: [FFmpeg-devel] [PATCH 2/6] doc/developer: merge the 'contributing code' section into its parent chapter

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > The section consistes of a single short paragraph linking to other > chapters. The enclosing chapter also has no other sections, all other > text is placed in the chapter directly. > Keeping a separate section for this paragraph just adds

Re: [FFmpeg-devel] [PATCH 1/6] doc/developer: move a sentence to a more appropriate place

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > It's targeted at our users, not developers, so it makes more sense to > group it with other text targeted at our users. > --- > doc/developer.texi | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/vf_libplacebo: switch to new pl_options struct

2023-08-27 Thread Niklas Haas
On Fri, 18 Aug 2023 18:50:43 +0200 Niklas Haas wrote: > From: Niklas Haas > > This new upstream struct simplifies params struct management by allowing > them to all be contained in a single dynamically allocated struct. This > commit switches to the new API in a backwards-compatible way. > >

[FFmpeg-devel] [PATCH 04/18 v2] fftools/ffmpeg_mux: stop rescaling timestamps in of_streamcopy()

2023-08-27 Thread Anton Khirnov
This function converts packet timestamps from the input stream timebase to OutputStream.mux_timebase, which may or may not be equal to the actual output AVStream timebase (and even when it is, this may not always be the optimal choice due to bitstream filtering). Just keep the timestamps in input