[FFmpeg-devel] [PATCH v2 1/1] lavc/qsvdec: fix dead loop of qsv decoding

2023-08-29 Thread Ting Hu
From: tinghu3 MFXVideoDECODE_DecodeFrameAsync always return MFX_WRN_DEVICE_BUSY in special scenario. Signed-off-by: tinghu3 --- libavcodec/qsvdec.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index da700f25e9..6

Re: [FFmpeg-devel] [PATCH 00/12 v2] AVCodecContext and AVCodecParameters side data

2023-08-29 Thread Anton Khirnov
Quoting James Almer (2023-08-28 14:34:52) > This is an updated version of the set i sent last month. > Changes since the first version: > - Renamed the field in AVCodecContext to not conflict with Jan Ekström's > patchset introducing a similar struct for frame side data. > - AVCodecContext.coded_

Re: [FFmpeg-devel] [PATCH v2 1/1] lavc/qsvdec: fix dead loop of qsv decoding

2023-08-29 Thread Anton Khirnov
Quoting Ting Hu (2023-08-29 09:49:06) > From: tinghu3 > > MFXVideoDECODE_DecodeFrameAsync always return MFX_WRN_DEVICE_BUSY in special > scenario. "special scenario"? What special scenario? Is this documented anywhere? This seems like a bug in libmfx/libvpl. -- Anton Khirnov _

Re: [FFmpeg-devel] [PATCH 10/18] fftools/ffmpeg: move derivation of frame duration from filter framerate

2023-08-29 Thread Anton Khirnov
I'm dropping this patch for now due to it causing issues in some cases. I'll probably resend a version of it later. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-08-29 Thread Anton Khirnov
Quoting Stefano Sabatini (2023-08-27 14:38:44) > Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > > > Document our longstanding de facto policies on things like correctness, > > thread-safety, UB, etc. > > > > UB? undefined behavior > > --- > > doc/developer.texi | 50 ++

[FFmpeg-devel] [PATCH] lavf: deprecate AVFMT_FLAG_SHORTEST

2023-08-29 Thread Anton Khirnov
It was added in cb114ed4640 with the comment "This will allow fixing several bugs with the -shortest option". Since * there is no explanation of what these bugs are * libavformat is not the place to work around ffmpeg CLI bugs * there is no indication that this feature is actually in use deprecate

[FFmpeg-devel] [PATCH] Build failed with newer glslang

2023-08-29 Thread Luca Bonissi
Newer glslang does no more provide static libraries libOSDependent.a and libOGLCompiler.a. These libraries are only used in configure's test to detect spirv_compiler, but are no more necessary even with older glslang. The following patch fixes the build issue. Signed-off-by: Luca Bonissi --

Re: [FFmpeg-devel] [PATCH 00/12 v2] AVCodecContext and AVCodecParameters side data

2023-08-29 Thread James Almer
On 8/29/2023 4:55 AM, Anton Khirnov wrote: Quoting James Almer (2023-08-28 14:34:52) This is an updated version of the set i sent last month. Changes since the first version: - Renamed the field in AVCodecContext to not conflict with Jan Ekström's patchset introducing a similar struct for fra

Re: [FFmpeg-devel] [PATCH] lavf: deprecate AVFMT_FLAG_SHORTEST

2023-08-29 Thread James Almer
On 8/29/2023 6:07 AM, Anton Khirnov wrote: It was added in cb114ed4640 with the comment "This will allow fixing several bugs with the -shortest option". Since * there is no explanation of what these bugs are * libavformat is not the place to work around ffmpeg CLI bugs * there is no indication t

[FFmpeg-devel] [PATCH v6] vvcdec: add thread executor

2023-08-29 Thread Nuo Mi
The executor design pattern was introduced by java it also adapted by python Compared to handcrafted thread pool management, it greatly simpl

Re: [FFmpeg-devel] [PATCH v5] vvcdec: add thread executor

2023-08-29 Thread Nuo Mi
On Tue, Aug 29, 2023 at 1:06 AM Michael Niedermayer wrote: > On Tue, Aug 22, 2023 at 09:32:28PM +0800, Nuo Mi wrote: > > The executor design pattern was inroduced by java > > inTroduced > > > > < > https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/concurrent/Executor.html > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error

2023-08-29 Thread zhilizhao(赵志立)
> On Aug 28, 2023, at 15:14, Tong Wu wrote: > > Compiler: MSVC 14.35.32215 > Error type: error C2099: initializer is not a constant > Related commit: 0c0dd23 avcodec/jpegxl_parser: add JPEG XL parser > > Signed-off-by: Tong Wu > --- > libavcodec/jpegxl_parser.c | 2 +- > 1 file changed, 1 ins

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error

2023-08-29 Thread James Almer
On 8/28/2023 4:14 AM, Tong Wu wrote: Compiler: MSVC 14.35.32215 Error type: error C2099: initializer is not a constant Related commit: 0c0dd23 avcodec/jpegxl_parser: add JPEG XL parser Signed-off-by: Tong Wu --- libavcodec/jpegxl_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] Question about ffmpeg support of sph files with embedded-shorten-v2.00 coding

2023-08-29 Thread Don Resnik
ffmpeg, I have a sph file that ffmpeg will not process. I am using ffmpeg 6.0, which I believe is the latest version. I am actually running ffprobe on the file. Here is the file header: NIST_1A 1024 sample_count -i 10612160 sample_n_bytes -i 1 channel_count -i 2 sample_byte_format -s1 1 sa

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-29 Thread Kyle Swanson
Hi, On Mon, Aug 28, 2023 at 1:16 PM Kyle Swanson wrote: > Ah, you're right, I think ffnvcodec is the right option to use, I'll > switch this in the next patch version. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data __

Re: [FFmpeg-devel] Question about ffmpeg support of sph files with embedded-shorten-v2.00 coding

2023-08-29 Thread Peter Ross
On Tue, Aug 29, 2023 at 12:45:57PM -0400, Don Resnik wrote: > ffmpeg, > > I have a sph file that ffmpeg will not process. I am using ffmpeg 6.0, > which I believe is the latest version. I am actually running ffprobe on > the file. > > Here is the file header: ... > and here is the output: >

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Fix writing of markers

2023-08-29 Thread Martin Storsjö
On Mon, 28 Aug 2023, Martin Storsjö wrote: On Mon, 28 Aug 2023, Steinar H. Gunderson wrote: When the marker writing code was merged from libav to FFmpeg in dc62016c, it failed to take into account that the meaning of cluster_pos had changed in bda5b662; in particular, the special value for “I'

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: replace monotonous with monotonic

2023-08-29 Thread Leo Izen
The word "monotonous" means "spoken in a monotone" which is not what we mean here. We mean "monotonic" i.e. nondecreasing. Signed-off-by: Leo Izen --- fftools/ffmpeg_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 24cdf0

Re: [FFmpeg-devel] [PATCH v7 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-29 Thread Lynne
Aug 29, 2023, 06:15 by tong1.wu-at-intel@ffmpeg.org: > + > +/** > + * Specifed by sync=1 when init d3d12va > + * > + * Execute commands as sync mode > + */ > +int sync; > This is not needed, particularly in the public API. > +    if (download) { > +    ID3D12Graph

Re: [FFmpeg-devel] [PATCH 08/12] avcodec/decode: check for global side data in AVCodecContext side data

2023-08-29 Thread James Almer
On 8/29/2023 3:24 AM, Pavel Koshevoy wrote: On Mon, Aug 28, 2023, 06:38 James Almer wrote: Signed-off-by: James Almer --- libavcodec/decode.c | 56 + libavcodec/decode.h | 2 +- 2 files changed, 47 insertions(+), 11 deletions(-) diff --git a/l

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-29 Thread Paul B Mahol
Now with always bitexact output and other improvements and fixes. From 208265707d57dbc14fec886629307c239f01090b Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Tue, 27 Jun 2023 19:51:54 +0200 Subject: [PATCH 2/2] avformat: add OSQ demuxer Signed-off-by: Paul B Mahol --- libavformat/Makefile

Re: [FFmpeg-devel] Question about ffmpeg support of sph files with embedded-shorten-v2.00 coding

2023-08-29 Thread Don Resnik
Peter, Thanks for your response. I mentioned that I am using ffmpeg 6.0, isn't that the latest version? I will submit on the bug tracker side. After doing some research, I think the issue is that in https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/nistspheredec.c#L73 The only embedded-

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-29 Thread Andreas Rheinhardt
Kyle Swanson: > +#ifdef CONFIG_LIBVMAF_CUDA > +#include > + > +#include "libavutil/hwcontext.h" > +#include "libavutil/hwcontext_cuda_internal.h" > +#endif > + The CONFIG_* variables are always defined; you need to check via "#if", not "#ifdef". - Andreas ___

Re: [FFmpeg-devel] [PATCH] lavf: deprecate AVFMT_FLAG_SHORTEST

2023-08-29 Thread Andreas Rheinhardt
Anton Khirnov: > It was added in cb114ed4640 with the comment > "This will allow fixing several bugs with the -shortest option". > > Since > * there is no explanation of what these bugs are > * libavformat is not the place to work around ffmpeg CLI bugs > * there is no indication that this feature

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-29 Thread Andreas Rheinhardt
Paul B Mahol: > +st->codecpar->sample_rate = AV_RL32(st->codecpar->extradata + 4); > +if (st->codecpar->sample_rate <= 0) > +return AVERROR_INVALIDDATA; > +av_channel_layout_uninit(&st->codecpar->ch_layout); Unnecessary: This channel layout belongs to an AVCodecParameters from

Re: [FFmpeg-devel] [PATCH v7 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-29 Thread Wu, Tong1
>Aug 29, 2023, 06:15 by tong1.wu-at-intel@ffmpeg.org: > >> + >> +/** >> + * Specifed by sync=1 when init d3d12va >> + * >> + * Execute commands as sync mode >> + */ >> +int sync; >> > >This is not needed, particularly in the public API. > >> +    if (download) { >> +

[FFmpeg-devel] [PATCH v8 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-29 Thread Tong Wu
From: Wu Jianhua Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 5 + doc/APIchanges | 7 + libavutil/Makefile | 3 + libavutil/hwcontext.c | 4 + libavutil/hwcontext.h

[FFmpeg-devel] [PATCH v8 2/9] avcodec: add D3D12VA hardware accelerated H264 decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua The implementation is based on: https://learn.microsoft.com/en-us/windows/win32/medfound/direct3d-12-video-overview With the Direct3D 12 video decoding support, we can render or process the decoded images by the pixel shaders or compute shaders directly without the extra copy ov

[FFmpeg-devel] [PATCH v8 3/9] avcodec: add D3D12VA hardware accelerated HEVC decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_hevc.c | 211 +++

[FFmpeg-devel] [PATCH v8 4/9] avcodec: add D3D12VA hardware accelerated VP9 decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_vp9.c| 176 +++

[FFmpeg-devel] [PATCH v8 5/9] avcodec: add D3D12VA hardware accelerated AV1 decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/av1dec.c | 10 ++ libavcodec/d3d12va_

[FFmpeg-devel] [PATCH v8 6/9] avcodec: add D3D12VA hardware accelerated MPEG-2 decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_mpeg2.c | 191 +++

[FFmpeg-devel] [PATCH v8 9/9] avcodec/d3d12va_hevc: enable allow_profile_mismatch flag for d3d12va msp profile

2023-08-29 Thread Tong Wu
Same as d3d11va, this flag enables main still picture profile for d3d12va. User should add this flag when decoding main still picture profile. Signed-off-by: Tong Wu --- libavcodec/d3d12va_hevc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/d3d12va_hevc

[FFmpeg-devel] [PATCH v8 7/9] avcodec: add D3D12VA hardware accelerated VC1 decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 3 + libavcodec/Makefile | 1 + libavcodec/d3d12va_vc1.c| 214 +++

[FFmpeg-devel] [PATCH v8 8/9] Changelog: D3D12VA hardware accelerated H264, HEVC, VP9, AV1, MPEG-2 and VC1 decoding

2023-08-29 Thread Tong Wu
From: Wu Jianhua Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index c010e86159..bdac4cb034 100644 --- a/Changelog +++ b/Changelog @@ -30,7 +30,7 @@ version : - support for the P_SKIP hi