Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
IIRC each regex give -10 so multiple matches give more. Let's assume we have a long keyword like "concretevictoria". Nobody uses this keyword in a normal text. A false positive is almost impossible. I could search for "concretevictoria", "concretevictori." and "concretevictor.." and get

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread epirat07
On 19 Oct 2023, at 21:05, Michael Koch wrote: >> IIRC each regex give -10 so multiple matches give more. > > So far, the search strings contain only combinations of keywords, for example > "concretevictoria". > False positives are almost impossible. > > I could add shorter keywords, for

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
IIRC each regex give -10 so multiple matches give more. So far, the search strings contain only combinations of keywords, for example "concretevictoria". False positives are almost impossible. I could add shorter keywords, for example "concrete" and "victoria". Then we would get multiple

Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

2023-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2023 at 07:42:30PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-10-19 18:33:13) > > On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-10-15 02:13:23) > > > > Fixes: Assertion failure > > > > Fixes: > > > >

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2023 at 07:49:10PM +0200, Michael Koch wrote: > > > You would have to read the trac source probably and maybe do local tests > tracing through the code what happens > but a non spammer posting spam > setting up trac locally is easy, it comes with its own deamon you dont > even

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
You would have to read the trac source probably and maybe do local tests tracing through the code what happens but a non spammer posting spam setting up trac locally is easy, it comes with its own deamon you dont even need a webserver That sounds too complicated for me. What about my other

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Niedermayer
On Wed, Oct 18, 2023 at 07:28:33PM +0200, Michael Koch wrote: > please delete: > comment 14 in ticket 2104 > comment 6 in ticket 2776 > user "bristleback" done thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you

Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

2023-10-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-10-19 18:33:13) > On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-10-15 02:13:23) > > > Fixes: Assertion failure > > > Fixes: > > > 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784 >

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2023 at 07:05:28PM +0200, Michael Koch wrote: > > > Iam not aware of any delay, did you see a delay ? > > I did change the search string (2nd from end of list) and 19 minutes later I > made a test posting in ticket 2776. > I have no idea why the pattern wasn't found. You would

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: Check klv offset

2023-10-19 Thread Michael Niedermayer
On Wed, Oct 18, 2023 at 08:29:16PM +0200, Tomas Härdin wrote: > ons 2023-10-18 klockan 02:49 +0200 skrev Michael Niedermayer: > > Fixes: Assertion klv_offset >= mxf->run_in failed at > > libavformat/mxfdec.c:736 > > Fixes: 62936/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > >

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
Iam not aware of any delay, did you see a delay ? I did change the search string (2nd from end of list) and 19 minutes later I made a test posting in ticket 2776. I have no idea why the pattern wasn't found. Michael ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Dont leave invalid cpb_cnt_minus1 in the context

2023-10-19 Thread Michael Niedermayer
On Wed, Oct 18, 2023 at 03:17:41PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: index 32 out of bounds for type 'uint32_t [32]' > > Fixes: > > 63003/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4685160840560640 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2023 at 04:21:44PM +0200, Michael Koch wrote: > When I edit the BadContent list, do the new search strings immediately > become effective, or must I wait some time? Iam not aware of any delay, did you see a delay ? thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] amfenc: Use a blocking call instead of sleeping and polling

2023-10-19 Thread Evgeny Pavlov
On Wed, Oct 18, 2023 at 10:36 PM Mark Thompson wrote: > --- > On 17/10/2023 18:11, Evgeny Pavlov wrote: > > The reason for using av_usleep() here is that AMF API doesn’t provide an > > API for explicit wait. There are two modes to get output from encoder: > > > > 1. Polling with some sleep to

Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

2023-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-10-15 02:13:23) > > Fixes: Assertion failure > > Fixes: > > 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field

2023-10-19 Thread Anton Khirnov
Quoting Lynne (2023-10-19 14:49:46) > Oct 19, 2023, 10:39 by an...@khirnov.net: > > > Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and > > AVCodecContext.skip_samples seems unncecessarily complicated to me and > > you're just making it worse. > > > > Is there any reason we can't drop

Re: [FFmpeg-devel] [PATCH 2/2] aacdec: padding skip improvements

2023-10-19 Thread Anton Khirnov
Quoting Lynne (2023-10-19 14:48:06) > Oct 19, 2023, 10:40 by an...@khirnov.net: > > > Quoting Lynne (2023-10-19 04:38:51) > > > >> @@ -3471,6 +3478,9 @@ static const AVOption options[] = { > >> { "coded","order in which the channels are coded in the bitstream", > >> 0, AV_OPT_TYPE_CONST, {

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
When I edit the BadContent list, do the new search strings immediately become effective, or must I wait some time? Michael ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
I've just tested the regex filter with a posting in ticket 2776. This test was not successful. I thought that the second entry from the end of the list should have matched: (?i)regards.{0,5}http In words: Switch to case insensitive, search for "regards" followed by 0 to 5 of any characters,

Re: [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field

2023-10-19 Thread James Almer
On 10/19/2023 5:39 AM, Anton Khirnov wrote: Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and AVCodecContext.skip_samples seems unncecessarily complicated to me and you're just making it worse. Is there any reason we can't drop AVCodecContext.skip_samples entirely and signal it purely

Re: [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field

2023-10-19 Thread Lynne
Oct 19, 2023, 10:39 by an...@khirnov.net: > Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and > AVCodecContext.skip_samples seems unncecessarily complicated to me and > you're just making it worse. > > Is there any reason we can't drop AVCodecContext.skip_samples entirely > and signal it

Re: [FFmpeg-devel] [PATCH 2/2] aacdec: padding skip improvements

2023-10-19 Thread Lynne
Oct 19, 2023, 10:40 by an...@khirnov.net: > Quoting Lynne (2023-10-19 04:38:51) > >> @@ -3471,6 +3478,9 @@ static const AVOption options[] = { >> { "coded","order in which the channels are coded in the bitstream", >> 0, AV_OPT_TYPE_CONST, { .i64 = CHANNEL_ORDER_CODED }, .flags = >>

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-19 Thread Anton Khirnov
Quoting Carotti, Elias via ffmpeg-devel (2023-10-13 18:35:14) > I see. Wouldn't not outputting the SSE values when csp_to_pixfmt() > returns AV_PIX_FMT_NONE work better? > That wouldn't be worse than it is today (meaning that right now we > don't get those values for any pix_fmt). It would work

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-19 Thread Anton Khirnov
Quoting Carotti, Elias via ffmpeg-devel (2023-09-23 12:04:28) > Hi, > please find attached a patch to propagate the SSE for a frame into the > encoder stats. > Since libx264 already provides PSNR values, this is done by basically > inverting the formula to recover the SSE values. Thanks, pushed.

Re: [FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined

2023-10-19 Thread Michael Niedermayer
On Wed, Oct 18, 2023 at 01:18:54PM -0400, Sean McGovern wrote: > On Sat, Oct 14, 2023, 23:27 Sean McGovern wrote: > > > It was not introduced until glibc 2.18. > > --- > > This should fix the ppc32 FATE node. > > --- > > libavutil/ppc/cpu.c | 5 - > > 1 file changed, 4 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

2023-10-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-10-15 02:13:23) > Fixes: Assertion failure > Fixes: > 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] trac spam

2023-10-19 Thread Michael Koch
Please have a look at the Spam Filtering / Monitoring page. One of the spammer's postings was rejected, because it contained a blacklisted pattern in Regex filter and got -10 points. But 20 seconds later the same posting was accepted, because the spammer was successfully verified by Captcha and

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec: LEAD MCMP decoder

2023-10-19 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] aacdec: padding skip improvements

2023-10-19 Thread Anton Khirnov
Quoting Lynne (2023-10-19 04:38:51) > @@ -3471,6 +3478,9 @@ static const AVOption options[] = { >{ "coded","order in which the channels are coded in the bitstream", > 0, AV_OPT_TYPE_CONST, { .i64 = CHANNEL_ORDER_CODED }, .flags = > AACDEC_FLAGS, "channel_order" }, > > +

Re: [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field

2023-10-19 Thread Anton Khirnov
Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and AVCodecContext.skip_samples seems unncecessarily complicated to me and you're just making it worse. Is there any reason we can't drop AVCodecContext.skip_samples entirely and signal it purely through side data? Then decoders could fully