Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-11-27 Thread Rémi Denis-Courmont
Le 28 novembre 2023 01:22:14 GMT+02:00, Michael Niedermayer a écrit : >On Mon, Nov 27, 2023 at 05:46:40PM +0200, Rémi Denis-Courmont wrote: >[...] >> Also FWIW, RV broke due to misaligned accesses and illegal vector types that >> QEMU tolerated. That is rather an argument against QEMU than

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: extra members for GA v2

2023-11-27 Thread Anton Khirnov
Hi all, the vote has ended, with the result that ALL proposed candidates are added to GA. See [1] for more details. Raw votes in CSV format are attached for posterity (also downloadable from [1]). [1] https://vote.ffmpeg.org/cgi-bin/civs/results.pl?id=E_d0b225b9aa8d45d5 Cheers, -- Anton

[FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection

2023-11-27 Thread Xiang, Haihao
From: Haihao Xiang It is possible that renderD128 doesn't exist but renderD129 is available in a system (see [1]). This change can make sure the default DRM device selection works even if renderD128 doesn't exist. [1]

[FFmpeg-devel] [PATCH v2 3/3] lavu/hwcontext_qsv: Make sure hardware vendor is Intel for qsv on d3d11va

2023-11-27 Thread Xiang, Haihao
From: Haihao Xiang When multiple hardwares are available, the default one might not be Intel Hardware. We can use option vendor_id to choose the required vendor. Tested-by: Artem Galin Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 6 ++ 1 file changed, 6 insertions(+) diff

[FFmpeg-devel] [PATCH v2 2/3] doc/ffmpeg: Update the description about d3d11va

2023-11-27 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- doc/ffmpeg.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 68363ae045..145cbb1032 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1165,6 +1165,21 @@ Choose the first

[FFmpeg-devel] [PATCH v2 1/3] lavu/hwcontext_d3d11va: Add option vendor_id

2023-11-27 Thread Xiang, Haihao
From: Artem Galin User may choose the hardware via option vendor_id when multiple hardwares are available. Signed-off-by: Artem Galin Signed-off-by: Haihao Xiang --- libavutil/hwcontext_d3d11va.c | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 11/13] avformat/demux: support inserting bitstream filters in demuxing scenarios

2023-11-27 Thread Gyan Doshi
On 2023-11-28 12:13 am, James Almer wrote: Packets will be passed to the bsf immediately after being generated by a demuxer, and no further data will be read from the input until all packets have been returned by the bsf. Do you plan to add a lib/cli option for user-specified insertions?

Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode_av1: Add qp option explicitly to set base q index

2023-11-27 Thread Xiang, Haihao
On Ma, 2023-11-27 at 13:36 +, Mark Thompson wrote: > On 27/11/2023 00:58, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Keep same way with librav1e/libsvtav1/qsv_av1.. to make it more > > acceptable instead of using global option "-global_quality". > > > > Fix #10615

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection

2023-11-27 Thread Xiang, Haihao
> Quoting Xiang, Haihao (2023-11-27 05:42:20) > > > > > > Also, the else is unnecessary since the if() block ends with continue. > > > > > > > I wanted to print a message if all devices don't exist. I'll remove it in > > the > > new version if you think such info is unnecessary. > > I don't

Re: [FFmpeg-devel] [PATCH 1/2] lavc/cbs_h265: Add sps_multilayer_extension support

2023-11-27 Thread myp...@gmail.com
On Tue, Nov 28, 2023 at 1:59 AM Mark Thompson wrote: > > On 17/11/2023 13:03, Jun Zhao wrote: > > Add sps_multilayer_extensio support. > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/cbs_h265.h | 3 +++ > > libavcodec/cbs_h265_syntax_template.c | 12 +++- > >

Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-11-27 Thread Michael Niedermayer
On Mon, Nov 27, 2023 at 05:46:40PM +0200, Rémi Denis-Courmont wrote: [...] > Also FWIW, RV broke due to misaligned accesses and illegal vector types that > QEMU tolerated. That is rather an argument against QEMU than against this MR > but still. has someone reported this to qemu ? (seems like a

Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-11-27 Thread Alexander Strasser
Hi Martin, patch looks technically good to me. On 2023-11-27 17:46 +0200, Rémi Denis-Courmont wrote: > Le maanantaina 27. marraskuuta 2023, 14.31.18 EET Martin Storsjö a écrit : > > This can be useful if doing testing of uncommon CPU extensions by > > running tests with QEMU (by configuring with

Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-11-27 Thread Martin Storsjö
On Mon, 27 Nov 2023, Rémi Denis-Courmont wrote: Le maanantaina 27. marraskuuta 2023, 14.31.18 EET Martin Storsjö a écrit : This can be useful if doing testing of uncommon CPU extensions by running tests with QEMU (by configuring with e.g. "target_exec=qemu-aarch64"), by only running the

Re: [FFmpeg-devel] [PATCH 10 bit support v5 1/3] avcodec/amfenc: Fixes the color information in the output.

2023-11-27 Thread Mark Thompson
On 31/10/2023 18:57, Evgeny Pavlov wrote: From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input

[FFmpeg-devel] [PATCH 13/13] avformat/mov: add support for Immersive Audio Model and Formats in ISOBMFF

2023-11-27 Thread James Almer
Signed-off-by: James Almer --- libavformat/Makefile | 3 +- libavformat/isom.h | 6 + libavformat/mov.c| 290 +++ 3 files changed, 272 insertions(+), 27 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index

[FFmpeg-devel] [PATCH 12/13] avformat/mov: make MOVStreamContext refcounted

2023-11-27 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 257 ++ 1 file changed, 145 insertions(+), 112 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 34ca8095c2..d1f214a441 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@

[FFmpeg-devel] [PATCH 11/13] avformat/demux: support inserting bitstream filters in demuxing scenarios

2023-11-27 Thread James Almer
Packets will be passed to the bsf immediately after being generated by a demuxer, and no further data will be read from the input until all packets have been returned by the bsf. Signed-off-by: James Almer --- libavformat/avformat.c | 47 libavformat/demux.c| 162

[FFmpeg-devel] [PATCH 10/13] avcodec: add an Immersive Audio Model and Formats frame split bsf

2023-11-27 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/iamf_stream_split_bsf.c | 807 + 3 files changed, 809 insertions(+) create mode 100644 libavcodec/iamf_stream_split_bsf.c diff --git

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Kyle Swanson
Hi, On Mon, Nov 27, 2023 at 10:15 AM Gyan Doshi wrote: > Do you mean in the lib? Because in ffmpeg git master, in the wrapper, > the option remains available and undeprecated. > > Regards, > Gyan Oops, you're right. Ignore everything I just said, sorry for the noise. Thanks, Kyle

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Gyan Doshi
On 2023-11-27 11:38 pm, Kyle Swanson wrote: Hi, On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi wrote: Will push soon. This filter can take any number of models now, each defining their own pooling methods. Looking at the docs now, I can see that it's not clear how to do this, I'll need to send

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Kyle Swanson
Hi, On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi wrote: > > Will push soon. This filter can take any number of models now, each defining their own pooling methods. Looking at the docs now, I can see that it's not clear how to do this, I'll need to send a patch on that. The global `pool` option

Re: [FFmpeg-devel] [PATCH 1/2] lavc/cbs_h265: Add sps_multilayer_extension support

2023-11-27 Thread Mark Thompson
On 17/11/2023 13:03, Jun Zhao wrote: Add sps_multilayer_extensio support. Signed-off-by: Jun Zhao --- libavcodec/cbs_h265.h | 3 +++ libavcodec/cbs_h265_syntax_template.c | 12 +++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 02/25] avfilter: always call ff_default_query_formats

2023-11-27 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:34) > From: Niklas Haas > > Even if a query func is set. This is safe to do, because > ff_default_query_formats is documented not to touch any filter lists > that were already set by the query func. > > The reason to do this is because it allows us to

Re: [FFmpeg-devel] [PATCH 04/25] fftools/ffmpeg_filter: don't clear buffersrc params

2023-11-27 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:36) > From: Niklas Haas > > This memset is bogus, it accomplishes nothing in the best case and > regresses future additions to AVBufferSrcParameters in the worst case. > --- > fftools/ffmpeg_filter.c | 3 --- > 1 file changed, 3 deletions(-) Looks very ok.

Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: declare function argument as const

2023-11-27 Thread Zhao Zhili
> 在 2023年11月23日,下午10:38,Leo Izen 写道: > > Declaring the function argument as const fixes a warning down the line > that the const parameter is stripped. We don't modify this argument. > > Signed-off-by: Leo Izen > --- > fftools/ffplay_renderer.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-11-27 Thread Rémi Denis-Courmont
Le maanantaina 27. marraskuuta 2023, 14.31.18 EET Martin Storsjö a écrit : > This can be useful if doing testing of uncommon CPU extensions by > running tests with QEMU (by configuring with e.g. > "target_exec=qemu-aarch64"), by only running the checkasm tests, > to get a reasonable test coverage

[FFmpeg-devel] [FOSDEM] Call For Participation: Open Media devroom

2023-11-27 Thread Kieran Kunhya
Dear FFmpeg community. Please see FOSDEM Open Media Devroom invite: Hey all, The Open Media devroom returns at FOSDEM 2024, and we are looking for propositions of talks and panels. FOSDEM is one of the largest (8,000+ hackers!) gatherings of Free and Open Source Software contributors in the

[FFmpeg-devel] [PATCH v2 3/3] fate/jpegxl: add parser test for extboxes and small files

2023-11-27 Thread Leo Izen
Add a fate test for the above commits fixing extremely small files or files with extended box sizes. Signed-off-by: Leo Izen --- tests/fate/jxl.mak | 8 tests/ref/fate/jxl-small-ext-box | 9 + 2 files changed, 17 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH v2 2/3] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-27 Thread Leo Izen
This patch allows the JXL parser to parse sequences of extremely small files concatenated together. (e.g. smaller than the parser buffer) Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 1/3] avcodec/jpegxl_parse{, r}: use correct ISOBMFF extended size location

2023-11-27 Thread Leo Izen
According to ISO/IEC 14996-12, size == 1 means a 64-bit extended-size field occurs *after* the 32-bit box type, not before. This fix should allow correct parsing of JXL files with extended-size boxes. Signed-off-by: Leo Izen --- libavcodec/jpegxl_parse.c | 6 +++--- libavcodec/jpegxl_parser.c

[FFmpeg-devel] [PATCH v2 0/3] JPEG XL parser bug fixes

2023-11-27 Thread Leo Izen
Two bug fixes related to the JPEG XL parser. They're not exactly related and don't need to be applied in sequence. v2 change: patches themselves are identical, but now there's a FATE test. Leo Izen (3): avcodec/jpegxl_parse{,r}: use correct ISOBMFF extended size location

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

2023-11-27 Thread Henrik Gramner via ffmpeg-devel
On Mon, Nov 27, 2023 at 2:42 PM Mark Thompson wrote: > Is it reasonable to set this global state from a library without the parent > program knowing? We'd really prefer not to affect the global state > unexpectedly. CreateWaitableTimerExW() with the CREATE_WAITABLE_TIMER_HIGH_RESOLUTION flag

Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-11-27 Thread Paul B Mahol
On Mon, Nov 27, 2023 at 2:49 PM Nicolas George wrote: > Paul B Mahol (12023-11-27): > > Looks unrelated issue I just fixed, and sent patch to ML. > > No, it does not change anything, still “queued = 1081”. You could have > tested. > I tested it, it passed: -bash: mkvmerge: command not found

Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-11-27 Thread Nicolas George
Paul B Mahol (12023-11-27): > Looks unrelated issue I just fixed, and sent patch to ML. No, it does not change anything, still “queued = 1081”. You could have tested. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] hwcontext_d3d11: Add BGR0 support

2023-11-27 Thread Mark Thompson
On 22/10/2023 15:54, Mark Thompson wrote: The 8-bit four-component DXGI container is also used for three-component RGB without alpha. --- This list is only used for AV->DXGI mapping, so it doesn't matter that there are duplicate DXGI formats in the list.  libavutil/hwcontext_d3d11va.c | 1 +  

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

2023-11-27 Thread Mark Thompson
On 13/11/2023 14:37, Evgeny Pavlov wrote: This commit increase precision of Sleep() function on Windows. This fix reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. Fix for issue #10622 v2: use timeBeginPeriod/timeEndPeriod for increasing

Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode_av1: Add qp option explicitly to set base q index

2023-11-27 Thread Mark Thompson
On 27/11/2023 00:58, fei.w.wang-at-intel@ffmpeg.org wrote: From: Fei Wang Keep same way with librav1e/libsvtav1/qsv_av1.. to make it more acceptable instead of using global option "-global_quality". Fix #10615 Signed-off-by: Fei Wang --- doc/encoders.texi | 1 +

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-27 Thread Mark Thompson
On 26/11/2023 14:40, Dmitrii Ovchinnikov wrote: The code looks significantly duplicated. This is not moved to amfenc.c since the property has different names for different encoders, and many other properties (also common to different encoders, but with different names) are separated in this

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-27 Thread Mark Thompson
On 23/11/2023 09:41, Evgeny Pavlov wrote: This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances.

Re: [FFmpeg-devel] [PATCH] cbs_av1: Reject thirty-two zero bits in uvlc code

2023-11-27 Thread Mark Thompson
On 25/10/2023 21:55, Michael Niedermayer wrote: On Sun, Oct 22, 2023 at 07:35:52PM +0100, Mark Thompson wrote: The spec allows at least thirty-two zero bits followed by a one to mean 2^32-1, with no constraint on the number of zeroes. The libaom reference decoder does not match this, instead

Re: [FFmpeg-devel] [PATCH] checkasm: add test for dcmul_add

2023-11-27 Thread Paul B Mahol
On Mon, Nov 27, 2023 at 1:53 PM flow gg wrote: > In this email, I first attached the original patch, and then sent the > content of this patch in the second reply. > So I tried downloading the attached original patch and running git am > without any issues. > then I tried copying the content

Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-11-27 Thread Paul B Mahol
On Mon, Nov 27, 2023 at 10:43 AM Nicolas George wrote: > Nicolas George (12023-11-27): > > Just as I warned you, it breaks the test case I suggested: > > > > ./ffmpeg_g -xerror -i /tmp/dummy_with_sub.mkv -preset ultrafast -lavfi > '[0:s]setpts=PTS+60/TB[s] ; [0:v][s]overlay' -y

Re: [FFmpeg-devel] [PATCH] checkasm: add test for dcmul_add

2023-11-27 Thread flow gg
In this email, I first attached the original patch, and then sent the content of this patch in the second reply. So I tried downloading the attached original patch and running git am without any issues. then I tried copying the content from the second reply into the patch and then running git am

[FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-11-27 Thread Martin Storsjö
This can be useful if doing testing of uncommon CPU extensions by running tests with QEMU (by configuring with e.g. "target_exec=qemu-aarch64"), by only running the checkasm tests, to get a reasonable test coverage without excessive test runtime. For such a config, setting

Re: [FFmpeg-devel] [PATCH] checkasm: add test for dcmul_add

2023-11-27 Thread Rémi Denis-Courmont
Le 26 novembre 2023 22:54:28 GMT+02:00, flow gg a écrit : >This is a bit confusing for me.. I tried pulling the latest code, and then >used `git am checkasm-test-for-dcmul_add.patch` without any patch >corruption. Did you try with the actual sent email or only with the original patch file?

[FFmpeg-devel] [PATCH] avfilter/framesync: fix OOM case

2023-11-27 Thread Paul B Mahol
Attached. From 8ce6bd0090666ef94b0455b7f8f4d3c05e273093 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 27 Nov 2023 13:04:16 +0100 Subject: [PATCH] avfilter/framesync: fix OOM case Fixes OOM when caller keeps adding frames into filtergraph that reached EOF by other means, for example EOF

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-27 Thread Thilo Borgmann via ffmpeg-devel
On 27.11.23 00:33, Leo Izen wrote: On 11/26/23 13:07, Thilo Borgmann wrote: Am 26.11.2023 um 14:47 schrieb Leo Izen : On 11/26/23 05:56, Anton Khirnov wrote: Would be nice to have tests for these. I have a sample at: https://buzo.us/l.jxl It would test both of these patches. I can

Re: [FFmpeg-devel] [PATCH v2 0/6] WebRTC sub-second live streaming support

2023-11-27 Thread Nicolas George
Michael Riedl (12023-11-27): > Regardless, this will only test the implementation against itself. If that > makes > sense and sounds reasonable, I will add the server support to this patch > series. Thanks. It will not be enough in a perfect world, but it still is a very good start and much

Re: [FFmpeg-devel] [PATCH v2 0/6] WebRTC sub-second live streaming support

2023-11-27 Thread Michael Riedl
On 11/15/23 22:45, Michael Niedermayer wrote: > On Tue, Nov 14, 2023 at 01:59:48PM +0100, Michael Riedl wrote: >> On 11/14/23 11:05, Tomas Härdin wrote: >>> This patchset is missing tests. I know that we for some reason don't >>> really have tests for protocols, but I feel the issue is worthwhile

Re: [FFmpeg-devel] [PATCH 01/13] lavfi/buffersink: avoid leaking peeked_frame on uninit

2023-11-27 Thread Nicolas George
Anton Khirnov (12023-11-23): > --- > libavfilter/buffersink.c | 9 + > 1 file changed, 9 insertions(+) LGTM, thanks. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-11-27 Thread Nicolas George
Nicolas George (12023-11-27): > Just as I warned you, it breaks the test case I suggested: > > ./ffmpeg_g -xerror -i /tmp/dummy_with_sub.mkv -preset ultrafast -lavfi > '[0:s]setpts=PTS+60/TB[s] ; [0:v][s]overlay' -y /tmp/dummy_with_hardsub.mkv > > (/tmp/dummy_with_sub.mkv is created like I told

Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-11-27 Thread Nicolas George
Anton Khirnov (12023-11-23): > Avoid making decisions based on current graph input state, which makes > the output dependent on the order in which the frames from different > inputs are interleaved. > > Makes the output of fate-filter-overlay-dvdsub-2397 more correct - the > subtitle appears two

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Gyan Doshi
Will push soon. On 2023-11-26 04:08 pm, Gyan Doshi wrote: 3d29724c00 removed the doc entry for the option pool while adding a parser function for it at the same time! The option remains available and undeprecated. --- doc/filters.texi | 4 1 file changed, 4 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection

2023-11-27 Thread Anton Khirnov
Quoting Xiang, Haihao (2023-11-27 05:42:20) > > > > Also, the else is unnecessary since the if() block ends with continue. > > > > I wanted to print a message if all devices don't exist. I'll remove it in the > new version if you think such info is unnecessary. I don't object to the message,

[FFmpeg-devel] [PATCH] configure: don't warn deprecated symbols from libvpl

2023-11-27 Thread Xiang, Haihao
From: Haihao Xiang libvpl deprecated some symbols (e.g. MFX_EXTBUFF_VPP_DENOISE2 is used to replace MFX_EXTBUFF_VPP_DENOISE), however the new symbols aren't support by MediaSDK runtime. In order to support the combination of libvpl and MediaSDK runtime on legacy devices, we continue to use the