Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-04 Thread Nicolas George
Vittorio Giovara (12023-12-04): > It's almost 2024, when will you be able to drop it? Never. When will YOU be able to drop bickering about parts of the code that do no harm and do not bother you? -- Nicolas George ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v12 7/9] avcodec: add D3D12VA hardware accelerated VC1 decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 3 + libavcodec/Makefile | 1 + libavcodec/d3d12va_vc1.c| 214

[FFmpeg-devel] [PATCH v12 9/9] avcodec/d3d12va_hevc: enable allow_profile_mismatch flag for d3d12va msp profile

2023-12-04 Thread Tong Wu
Same as d3d11va, this flag enables main still picture profile for d3d12va. User should add this flag when decoding main still picture profile. Signed-off-by: Tong Wu --- libavcodec/d3d12va_hevc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH v12 8/9] Changelog: D3D12VA hardware accelerated H264, HEVC, VP9, AV1, MPEG-2 and VC1 decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index f00bc27ca4..d4f8bd42b7 100644 --- a/Changelog +++ b/Changelog @@ -7,6 +7,7 @@ version : - EVC encoding using external library

[FFmpeg-devel] [PATCH v12 6/9] avcodec: add D3D12VA hardware accelerated MPEG-2 decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_mpeg2.c | 191

[FFmpeg-devel] [PATCH v12 5/9] avcodec: add D3D12VA hardware accelerated AV1 decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/av1dec.c | 10 ++

[FFmpeg-devel] [PATCH v12 4/9] avcodec: add D3D12VA hardware accelerated VP9 decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_vp9.c| 171

[FFmpeg-devel] [PATCH v12 3/9] avcodec: add D3D12VA hardware accelerated HEVC decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_hevc.c | 208

[FFmpeg-devel] [PATCH v12 2/9] avcodec: add D3D12VA hardware accelerated H264 decoding

2023-12-04 Thread Tong Wu
From: Wu Jianhua The implementation is based on: https://learn.microsoft.com/en-us/windows/win32/medfound/direct3d-12-video-overview With the Direct3D 12 video decoding support, we can render or process the decoded images by the pixel shaders or compute shaders directly without the extra copy

[FFmpeg-devel] [PATCH v12 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-12-04 Thread Tong Wu
From: Wu Jianhua Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- Compared to v11, v12 set the initial value to 0 for the fence value, fixing a potential dynamic pool sync issue. Hence removed the non zero initial_pool_size for d3d12va decoder. Some other minor error message changes.

Re: [FFmpeg-devel] [PATCH] lavc/vc1dsp: R-V V inv_trans

2023-12-04 Thread flow gg
Okay, after using zext, can delete two vset, which is better than splat. I have updated the patch in this reply. Rémi Denis-Courmont 于2023年12月4日周一 23:15写道: > Le maanantaina 4. joulukuuta 2023, 10.48.56 EET flow gg a écrit : > > > Probably missing VLENB checks. > > > > Changed. > > > > > You can

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-04 Thread Vittorio Giovara
On Mon, Dec 4, 2023 at 1:53 PM Nicolas George wrote: > Anton Khirnov (12023-12-02): > > Its author not only failed to add any tests, as is required by the > > development rules, but continues to actively refuse to do so. > > > > Untested decoders are worse than useless, so remove it. > > Only

Re: [FFmpeg-devel] [PATCH 2/2] aacdec: fix single-sample delay for SBR streams

2023-12-04 Thread Michael Niedermayer
On Mon, Dec 04, 2023 at 08:52:06AM +0100, Lynne wrote: > Our SBR implementation introduces a single sample of latency into the > output, which is currently never skipped. > This delay is separate from any container skip value and always present, > as it is from an additional part of the decoding

Re: [FFmpeg-devel] [PATCH] libavfilter/asrc_flite: fixes and improvements

2023-12-04 Thread Paul B Mahol
On Tue, Dec 5, 2023 at 12:27 AM Stefano Sabatini wrote: > On date Sunday 2023-12-03 23:23:48 +0100, Paul B Mahol wrote: > > Attached. > > > From fe1ece70c0ecbe6fb24e0823fe46db57242396e4 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Sun, 3 Dec 2023 21:38:08 +0100 > > Subject: [PATCH

Re: [FFmpeg-devel] [PATCH] libavfilter/asrc_flite: fixes and improvements

2023-12-04 Thread Stefano Sabatini
On date Sunday 2023-12-03 23:23:48 +0100, Paul B Mahol wrote: > Attached. > From fe1ece70c0ecbe6fb24e0823fe46db57242396e4 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sun, 3 Dec 2023 21:38:08 +0100 > Subject: [PATCH 1/2] avfilter/asrc_flite: switch to activate > > Allows to set EOF

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: test for abs_pow34

2023-12-04 Thread flow gg
Because there was a conflict, the patch was updated in the reply flow gg 于2023年12月1日周五 04:25写道: > Okay, I splited and attached > > > > Rémi Denis-Courmont 于2023年11月30日周四 23:31写道: > >> Le tiistaina 28. marraskuuta 2023, 18.59.38 EET flow gg a écrit : >> > >> >> Since nobody else commented, I

Re: [FFmpeg-devel] [PATCH 2/2] avformat/flvdec: support enhanced flv PacketTypeMetadata

2023-12-04 Thread James Almer
On 11/15/2023 11:40 AM, zhupengfei via ffmpeg-devel wrote: From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvdec.c | 171 ++- 1 file changed, 170 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: support enhanced flv PacketTypeMetadata

2023-12-04 Thread James Almer
On 11/15/2023 11:40 AM, zhupengfei via ffmpeg-devel wrote: From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvenc.c | 158 +++ 1 file changed, 158 insertions(+) diff --git a/libavformat/flvenc.c

Re: [FFmpeg-devel] [PATCH] lavc/vc1dsp: R-V V inv_trans

2023-12-04 Thread flow gg
I found that in the case of nosplat, an additional vset can be removed, and the time is basically the same, so I updated the patch. Rémi Denis-Courmont 于2023年12月4日周一 23:15写道: > Le maanantaina 4. joulukuuta 2023, 10.48.56 EET flow gg a écrit : > > > Probably missing VLENB checks. > > > >

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-04 Thread Jean-Baptiste Kempf
Hi, On Sat, 2 Dec 2023, at 19:55, Paul B Mahol wrote: > Its not hard to add/write test, and even its easy to upload test sample to > server, but last time I did it people complained of too big samples. What is too big a sample? What's the problem with large samples? What is the documented

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-04 Thread Nicolas George
Anton Khirnov (12023-12-02): > Its author not only failed to add any tests, as is required by the > development rules, but continues to actively refuse to do so. > > Untested decoders are worse than useless, so remove it. Only tested manually ≠ untested. A code that works is better than no code

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: small cleanup for style, whitespace, unused

2023-12-04 Thread Kyle Swanson
On Fri, Dec 1, 2023 at 1:57 PM Kyle Swanson wrote: > Small cleanup patch for vf_libvmaf.c. Will apply soon. Pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH] avformat/mov: Ignore duplicate ftyp

2023-12-04 Thread Dale Curtis
Thanks! lgtm, defer to you on FF_COMPLIANCE_STRICT. On Fri, Dec 1, 2023 at 3:59 PM wrote: > > > On 2 Dec 2023, at 0:26, Michael Niedermayer wrote: > > > Fixes: switch_1080p_720p.mp4 > > Found-by: Dale Curtis > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 6 -- > >

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-04 Thread Anton Khirnov
Quoting Nicolas George (2023-12-04 17:37:23) > Anton Khirnov (12023-12-04): > > broken. If that extra buffering is an actual problem for someone, it can > > be easily avoided by opening the file twice. > > Not a solution if the file is streamed or generated. > > > As I said before, your command

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-04 Thread Nicolas George
Anton Khirnov (12023-12-04): > broken. If that extra buffering is an actual problem for someone, it can > be easily avoided by opening the file twice. Not a solution if the file is streamed or generated. > As I said before, your command does NOT work. Its output changes > unpredictably depending

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-04 Thread Anton Khirnov
Quoting Nicolas George (2023-12-04 16:25:52) > Anton Khirnov (12023-12-01): > > I can definitely say it is broken and I already told you why. But if you > > want something more specific: > > * the output of your example with the current master changes depending > > on the number of decoder frame

Re: [FFmpeg-devel] [PATCH] lavfi/af_pan: fix sscanf return value check

2023-12-04 Thread Paul B Mahol
Ping? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-04 Thread Nil Fons Miret via ffmpeg-devel
The libvmaf filter was doing substring checks in place of string equality comparisons. This led to a bug when the user specified the pooling method "harmonic_mean", since "mean" was checked first and the substring comparison returned true. This patch changes all substring comparisons for string

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-04 Thread Nicolas George
Anton Khirnov (12023-12-01): > I can definitely say it is broken and I already told you why. But if you > want something more specific: > * the output of your example with the current master changes depending > on the number of decoder frame threads; my patch fixes that > * in

[FFmpeg-devel] [PATCH] tests/fate: add asegment filter tests

2023-12-04 Thread Paul B Mahol
Attached. From 1dbb5c6a072317794c32e2dcb03af592d1aa58a7 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 4 Dec 2023 16:06:02 +0100 Subject: [PATCH] tests/fate: add asegment filter tests Signed-off-by: Paul B Mahol --- tests/fate/filter-audio.mak | 17 ++

Re: [FFmpeg-devel] [PATCH] lavc/vc1dsp: R-V V inv_trans

2023-12-04 Thread Rémi Denis-Courmont
Le maanantaina 4. joulukuuta 2023, 10.48.56 EET flow gg a écrit : > > Probably missing VLENB checks. > > Changed. > > > You can multiply by 3, 5 or 9 with shift-and-add. By 12 with shift-and-add > > then shift, and by 17 with shift then add. You don't need multiplications. > > Changed. > > >

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace AVCaptureDevice with new api

2023-12-04 Thread epirat07
On 4 Dec 2023, at 13:47, xufuji456 via ffmpeg-devel wrote: > Building with iOS platform, the compiler has a warning: > "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use > AVCaptureDeviceDiscoverySession instead" > > Signed-off-by: xufuji456 <839789...@qq.com> Thanks

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace AVCaptureDevice with new api

2023-12-04 Thread Thilo Borgmann via ffmpeg-devel
Am 04.12.23 um 13:47 schrieb xufuji456 via ffmpeg-devel: Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <839789...@qq.com> ---

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace AVCaptureDevice with new api

2023-12-04 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <839789...@qq.com> --- libavdevice/avfoundation.m | 81 +++--- 1

[FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2023-12-04 Thread Mikhail Nitenko
Benchmarks A53 A55 A72 A76 avg_h264_qpel_8_mc01_10_c:936.5924.0 656.0 504.7 avg_h264_qpel_8_mc01_10_neon: 234.7202.0 120.763.2 avg_h264_qpel_8_mc02_10_c:921.0920.0 669.2 493.7 avg_h264_qpel_8_mc02_10_neon: 202.0

Re: [FFmpeg-devel] [PATCH] lavc/vc1dsp: R-V V inv_trans

2023-12-04 Thread flow gg
> Probably missing VLENB checks. Changed. > You can multiply by 3, 5 or 9 with shift-and-add. By 12 with shift-and-add > then shift, and by 17 with shift then add. You don't need multiplications. Changed. > Do you really need to splat? Can't .vx or .wx be used instead? Okay, for example in

Re: [FFmpeg-devel] avfilter/avfilter: fix OOM case for default activate

2023-12-04 Thread Nicolas George
Paul B Mahol (12023-12-03): > ffmpeg | branch: master | Paul B Mahol | Fri Dec 1 > 16:59:07 2023 +0100| [d9e41ead82263e96ebd14d4d88d6e7f858dd944c] | committer: > Paul B Mahol > > avfilter/avfilter: fix OOM case for default activate > > Fixes OOM when caller keeps adding frames into

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: fix OOM case for default activate

2023-12-04 Thread Nicolas George
Paul B Mahol (12023-12-03): > Will apply soon. Must you really act like an asshole each time? You will wait for review. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To