Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-12 Thread Zhao Zhili
> 在 2023年12月13日,上午2:04,Nicolas George 写道: > > Zhao Zhili (12023-12-13): >> Now it's time to talk about the libavdevice/sdl issue. >> >> SDL output is broken with ffmpeg multithread refactor. > > And OpenGL, since it depends on SDL for its stand-alone setup. > > But do not expect it to be

[FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add udu_sei_as_ascii option

2023-12-12 Thread Zhao Zhili
From: Zhao Zhili Some encoders (e.g., libx264) dump encoder configuration as user data unregistered SEI message. This option try to print it as ascii character when possible. --- doc/filters.texi | 4 libavfilter/version.h | 2 +- libavfilter/vf_showinfo.c | 14

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields

2023-12-12 Thread Michael Niedermayer
On Wed, Dec 13, 2023 at 12:13:36AM +0100, Michael Niedermayer wrote: > On Mon, Dec 11, 2023 at 08:06:53PM +0100, Clément Bœsch wrote: > > This byte represents 4 reserved bits followed by 4 alpha_channel_type bits. > > > > alpha_channel_type currently has 3 differents defined values: 0 (no > >

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields

2023-12-12 Thread Michael Niedermayer
On Mon, Dec 11, 2023 at 08:06:53PM +0100, Clément Bœsch wrote: > This byte represents 4 reserved bits followed by 4 alpha_channel_type bits. > > alpha_channel_type currently has 3 differents defined values: 0 (no > alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are > reserved. This

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-12 Thread Michael Niedermayer
On Tue, Dec 12, 2023 at 12:23:38PM +0100, Anton Khirnov wrote: > Quoting Marton Balint (2023-12-08 00:11:21) > > Wipe reminds me of the wipe effect. How about 'predecode_clear'? > > Fine with me I guess. > > > > > > >> + */ > > >> +#define AV_CODEC_FLAG_CLEAR (1 << 12) > > >> /** > >

Re: [FFmpeg-devel] [PATCH 2/2] lavc/lpc: R-V V compute_autocorr

2023-12-12 Thread Rémi Denis-Courmont
Le tiistaina 12. joulukuuta 2023, 23.02.40 EET Rémi Denis-Courmont a écrit : > The loop iterates over the length of the vector, not the order. This is > to avoid reloading the same data for each lag value. However this means > the loop only works if the maximum order is no larger than VLENB. > >

[FFmpeg-devel] [PATCH 2/2] lavc/lpc: R-V V compute_autocorr

2023-12-12 Thread Rémi Denis-Courmont
The loop iterates over the length of the vector, not the order. This is to avoid reloading the same data for each lag value. However this means the loop only works if the maximum order is no larger than VLENB. The loop is roughly equivalent to: for (size_t j = 0; j < lag; j++)

[FFmpeg-devel] [PATCH 1/2] checkasm/lpc: test compute_autocorr

2023-12-12 Thread Rémi Denis-Courmont
--- tests/checkasm/lpc.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..4d84defec3 100644 --- a/tests/checkasm/lpc.c +++ b/tests/checkasm/lpc.c @@ -57,10 +57,41 @@ static

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libjxlenc: Move image initialization code into libjxl_encode_init_image

2023-12-12 Thread Leo Izen
On 12/11/23 12:05, Zsolt Vadász via ffmpeg-devel wrote: --- libavcodec/libjxlenc.c | 69 +++--- 1 file changed, 45 insertions(+), 24 deletions(-) diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c index 92a458d51a..6110c42a7c 100644 ---

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libjxlenc: Move JxlBasicInfo to LibJxlEncodeContext

2023-12-12 Thread Leo Izen
On 12/11/23 12:05, Zsolt Vadász via ffmpeg-devel wrote: --- libavcodec/libjxlenc.c | 45 +- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c index d707f3a61b..92a458d51a 100644 Why?

[FFmpeg-devel] [PATCH] avcodec/pngdec: improve handling of bad cICP range tags

2023-12-12 Thread Leo Izen
FFmpeg doesn't support tv-range RGB throughout most of its pipeline, so we should keep the warning. However, in case something does support it we should at least keep it tagged properly. Additionally, the encoder writes this tag if the space is tagged as such so this makes a round trip work as it

Re: [FFmpeg-devel] [PATCH v3 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-12 Thread Marton Balint
On Tue, 12 Dec 2023, Stefano Sabatini wrote: On date Saturday 2023-12-09 20:25:07 +0100, Marton Balint wrote: v3: added flags argument. Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/imgutils.c | 6 +++--- libavutil/imgutils.h | 31

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-12 Thread Marton Balint
On Tue, 12 Dec 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-12-08 00:11:21) Wipe reminds me of the wipe effect. How about 'predecode_clear'? Fine with me I guess. + */ +#define AV_CODEC_FLAG_CLEAR (1 << 12) /** * Only decode/encode grayscale. */ diff --git

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-12 Thread Nicolas George
Zhao Zhili (12023-12-13): > Now it's time to talk about the libavdevice/sdl issue. > > SDL output is broken with ffmpeg multithread refactor. And OpenGL, since it depends on SDL for its stand-alone setup. But do not expect it to be fixed, they have hated lavd for ever and now they have all the

[FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-12 Thread Zhao Zhili
Now it's time to talk about the libavdevice/sdl issue. SDL output is broken with ffmpeg multithread refactor. SDL 'muxer' write_header and write_packet must be run in the same thread. And to make it work portable and reliable, SDL 'muxer' must be run in main thread. It's a common requirement for

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Rémi Denis-Courmont
Le 12 décembre 2023 16:07:28 GMT+02:00, Nicolas George a écrit : >Lena via ffmpeg-devel (12023-12-12): >> The documentation for `strtol` says that on error, 0 is returned. This >> makes it impossible to specify a window handle of 0 (the whole >> desktop), but that case is already covered by

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Nicolas George
Lena via ffmpeg-devel (12023-12-12): > The documentation for `strtol` says that on error, 0 is returned. This > makes it impossible to specify a window handle of 0 (the whole > desktop), but that case is already covered by the "desktop" input > filename, so it should be fine. The correct way to

[FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Lena via ffmpeg-devel
Added the change to the documentation and added error checking on `strtol`, according to the stdlib documentation. The documentation for `strtol` says that on error, 0 is returned. This makes it impossible to specify a window handle of 0 (the whole desktop), but that case is already covered by

Re: [FFmpeg-devel] [PATCH 13/25] avfilter/buffersink: add color space/range accessors

2023-12-12 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:45) > From: Niklas Haas > > Needed for fftools. > --- > doc/APIchanges | 3 +++ > libavfilter/buffersink.c | 2 ++ > libavfilter/buffersink.h | 2 ++ > libavfilter/version.h| 2 +- > 4 files changed, 8 insertions(+), 1 deletion(-) Looks

Re: [FFmpeg-devel] [PATCH v7 3/7] avcodec/webp_parser: parse each frame into one packet

2023-12-12 Thread Thilo Borgmann via ffmpeg-devel
Am 08.12.23 um 03:02 schrieb Cosmin Stejerean via ffmpeg-devel: On Dec 7, 2023, at 9:42 AM, Andreas Rheinhardt wrote: According to https://developers.google.com/speed/webp/docs/riff_container#extended_file_format metadata chunks are stored after the image data; if you split the data into

[FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: merge DemuxPktData into FrameData

2023-12-12 Thread Anton Khirnov
This way we can propagate arbitrary data from the demuxer all the way into the muxer, using a single struct. --- fftools/ffmpeg.c | 28 fftools/ffmpeg.h | 13 +++-- fftools/ffmpeg_demux.c | 9 - fftools/ffmpeg_mux.c | 4 ++-- 4 files

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: attach wallclock timing information to packets and frames

2023-12-12 Thread Anton Khirnov
Will become useful in following commits. --- fftools/ffmpeg.c| 3 +++ fftools/ffmpeg.h| 13 + fftools/ffmpeg_dec.c| 14 -- fftools/ffmpeg_demux.c | 26 -- fftools/ffmpeg_enc.c| 16 fftools/ffmpeg_filter.c |

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_mux: print latency information in -debug_ts muxing output

2023-12-12 Thread Anton Khirnov
--- fftools/ffmpeg_mux.c | 87 +++- 1 file changed, 77 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 62925be8d0..ca1996622d 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -25,10 +25,12 @@

Re: [FFmpeg-devel] [PATCH 2/8] avformat: introduce AVStreamGroup

2023-12-12 Thread Anton Khirnov
Quoting James Almer (2023-12-11 13:53:40) > On 12/11/2023 8:03 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-12-05 23:43:56) > >> +/** > >> + * Remove a stream group from its AVFormatContext and free it. > >> + * The group must be the last stream of the AVFormatContext. > >> + */ > >>

Re: [FFmpeg-devel] [PATCH 3/8] ffmpeg: add support for muxing AVStreamGroups

2023-12-12 Thread Anton Khirnov
Quoting James Almer (2023-12-11 13:46:36) > AVStreamGroup.type is not setteable through AVOptions, but it of course > needs to be supported by the CLI. So i catch it and remove it from the > dict that will be used for avformat_stream_group_create(). > > I can change the comment to "'type' is

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-12 Thread Anton Khirnov
Quoting Marton Balint (2023-12-08 00:11:21) > Wipe reminds me of the wipe effect. How about 'predecode_clear'? Fine with me I guess. > > > >> + */ > >> +#define AV_CODEC_FLAG_CLEAR (1 << 12) > >> /** > >> * Only decode/encode grayscale. > >> */ > >> diff --git

[FFmpeg-devel] [PATCH] swr/swresample: avoid reapplication of firstpts

2023-12-12 Thread Gyan Doshi
During a resampling operation where 1) user has specified first_pts 2) SWR_FLAG_RESAMPLE is not set initially (directly or otherwise) 3) first_pts has been fulfilled (always using hard compensation) then upon first encountering a delay where a soft compensation is required, swr_set_compensation

Re: [FFmpeg-devel] [PATCH 05/35] avcodec/proresenc_kostya: remove one LUT indirection for run/level to codebook mapping

2023-12-12 Thread Stefano Sabatini
On date Monday 2023-12-11 02:35:06 +0100, Clément Bœsch wrote: > This is following the same logic as proresenc_anatoliy. > --- > libavcodec/proresenc_kostya.c | 47 +++ > 1 file changed, 14 insertions(+), 33 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 04/35] avcodec/proresenc_anatoliy: move run/lev to codebook LUT to shared proresdata

2023-12-12 Thread Stefano Sabatini
On date Monday 2023-12-11 02:35:05 +0100, Clément Bœsch wrote: > This is going to be shared with proresenc_kostya in the upcoming commit. > --- > libavcodec/proresdata.c | 6 ++ > libavcodec/proresdata.h | 2 ++ > libavcodec/proresenc_anatoliy.c | 9 ++--- > 3 files

Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter

2023-12-12 Thread Nicolas George
Vittorio Giovara (12023-12-11): > This is an older filter I wrote and never got around publishing. > It can be used to generate a distortion effect like > https://vimeo.com/104938599?share=copy > Please see attached. Your code is doing in request_frame() what should be done in filter_frame().