Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Anton Khirnov
Quoting Stefano Sabatini (2023-12-14 01:47:44) > On date Wednesday 2023-12-13 10:08:45 +0100, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-12 18:27:39) > [...] > > Honestly I don't see how this could be done in ffmpeg CLI without > > disgusting hacks, but before that the question is: > >

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04) > Am 13.12.23 um 17:28 schrieb Anton Khirnov: > > It is bad practice to design library features around the needs and > > limitations of a single specific caller. > > The callers here would be the CLI and this filter. First, public

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-13 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-12-14 03:07:13) > On Thu, Dec 14, 2023 at 12:16:14AM +0100, Michael Niedermayer wrote: > > On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > > > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > > > 16:37:52 2023 +0200|

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-13 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-12-14 00:16:14) > On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > > 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | > > committer: Anton Khirnov > > > > fftools/ffmpeg:

Re: [FFmpeg-devel] [PATCH v2 03/15] avfilter: add negotiation API for color space/range

2023-12-13 Thread Michael Niedermayer
On Wed, Dec 13, 2023 at 02:12:00PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Motivated by YUVJ removal. This change will allow full negotiation > between color ranges and matrices as needed. By default, all ranges and > matrices are marked as supported. > > Because grayscale formats are

[FFmpeg-devel] [PATCH 4/4] libavfilter/vf_dnn_detect: Set used pointer to NULL

2023-12-13 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Set used pointer to NULL in case it leaks the storage. Signed-off-by: Wenbin Chen --- libavfilter/vf_dnn_detect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index 5668b8b017..3464af86c8 100644 ---

[FFmpeg-devel] [PATCH 3/4] libavfilter/vf_dnn_detect: Fix uninitialized variables error

2023-12-13 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Signed-off-by: Wenbin Chen --- libavfilter/vf_dnn_detect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index b2e9b8d4c6..5668b8b017 100644 --- a/libavfilter/vf_dnn_detect.c +++

[FFmpeg-devel] [PATCH 2/4] libavfilter/vf_dnn_detect: Add NULL pointer check

2023-12-13 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Signed-off-by: Wenbin Chen --- libavfilter/vf_dnn_detect.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index b82916ce6d..b2e9b8d4c6 100644 --- a/libavfilter/vf_dnn_detect.c +++ b/libavfilter/vf_dnn_detect.c

[FFmpeg-devel] [PATCH 1/4] libavfilter/vf_dnn_detect: Fix an incorrect expression

2023-12-13 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Signed-off-by: Wenbin Chen --- libavfilter/vf_dnn_detect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index 7ac3bb0b58..b82916ce6d 100644 --- a/libavfilter/vf_dnn_detect.c +++

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-13 Thread Michael Niedermayer
On Thu, Dec 14, 2023 at 12:16:14AM +0100, Michael Niedermayer wrote: > On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > > 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | > > committer: Anton Khirnov > >

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Stefano Sabatini
On date Wednesday 2023-12-13 10:08:45 +0100, Anton Khirnov wrote: > Quoting Zhao Zhili (2023-12-12 18:27:39) [...] > Honestly I don't see how this could be done in ffmpeg CLI without > disgusting hacks, but before that the question is: > why is there an SDL > "muxer" and why would anyone want to

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-13 Thread Michael Niedermayer
On Thu, Dec 14, 2023 at 12:16:14AM +0100, Michael Niedermayer wrote: > On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > > 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | > > committer: Anton Khirnov > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a threaded architecture

2023-12-13 Thread Michael Niedermayer
On Tue, Dec 12, 2023 at 07:41:18AM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Tue Jul 18 > 16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | committer: > Anton Khirnov > > fftools/ffmpeg: convert to a threaded architecture > > Change the main loop

[FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-13 Thread Zsolt Vadász via ffmpeg-devel
--- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 214 + 3 files changed, 177 insertions(+), 39 deletions(-) diff --git a/configure b/configure index 7d2ee66000..a334a9b1e0 100755 --- a/configure +++ b/configure

[FFmpeg-devel] [PATCH v2 0/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-13 Thread Zsolt Vadász via ffmpeg-devel
This patchset adds support for encoding animated JPEG XL images via a new encoder (libjxl_animated). When using the encoder, the output format needs to be set to raw video, as shown below: `ffmpeg -i sample.gif -c:v libjxl_animated -f rawvideo out.jxl` V2 changes: - This version doesn't move the

Re: [FFmpeg-devel] [PATCH] fate: Allow running multiple rounds of tests with differing settings

2023-12-13 Thread Martin Storsjö
On Wed, 13 Dec 2023, Rémi Denis-Courmont wrote: Le tiistaina 12. joulukuuta 2023, 0.14.06 EET Martin Storsjö a écrit : This can be used to run tests multple times, with e.g. differing QEMU settings, by adding something like this to the FATE configuration file:

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-13 Thread Nicolas George
Marth64 (12023-12-09): > I am hoping and willing to improve this to be a robust demuxer > wherever possible, but to that extent there is still an issue I can't > figure out how to solve: Dealing with DTS discontinuities and PTS > generation. The dvd2concat script manages it by shifting the times

[FFmpeg-devel] [PATCH] avcodec/bitpacked_dec: optimize bitpacked_decode_yuv422p10

2023-12-13 Thread Marton Balint
From: Devin Heitmueller Rework the code a bit to speed up the 10-bit bitpacked decoding routine. This is probably about as fast as I can get it without switching to assembly language. Demonstratable with: ./ffmpeg -f lavfi -i "smptehdbars=size=3840x2160" -c bitpacked -f image2 -frames:v 1

[FFmpeg-devel] [PATCH 09/12] fftools/ffmpeg: drop OutputFile.sq_encode

2023-12-13 Thread Anton Khirnov
It is unused since d119ae2fd82a494d9430ff4d4fc262961a68c598 --- fftools/ffmpeg.h | 2 -- fftools/ffmpeg_mux.c | 1 - 2 files changed, 3 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 5c061ef0f4..b7ec6085d3 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -607,8

[FFmpeg-devel] [PATCH 08/12] fftools/ffmpeg_mux: move OutputStream.sq_idx_mux to private data

2023-12-13 Thread Anton Khirnov
It should not be accessed outside of ffmpeg_mux* --- fftools/ffmpeg.h | 2 -- fftools/ffmpeg_mux.c | 12 ++-- fftools/ffmpeg_mux.h | 2 ++ fftools/ffmpeg_mux_init.c | 12 ++-- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 07/12] fftools/ffmpeg_demux: move InputFile.readrate to private data

2023-12-13 Thread Anton Khirnov
It is not used outside of ffmpeg_demux. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_demux.c | 19 ++- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 3db3d87dfe..2963d2d5d4 100644 --- a/fftools/ffmpeg.h +++

[FFmpeg-devel] [PATCH 06/12] fftools/ffmpeg: drop unused InputFile.eof_reached

2023-12-13 Thread Anton Khirnov
--- fftools/ffmpeg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index f214e4efcb..3db3d87dfe 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -407,7 +407,6 @@ typedef struct InputFile { int format_nots; AVFormatContext *ctx; -int

[FFmpeg-devel] [PATCH 10/12] fftools/ffmpeg_sched: move trailing_dts() higher up

2023-12-13 Thread Anton Khirnov
Will be useful in following commit. --- fftools/ffmpeg_sched.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index 69f8c0c3c0..ab14d6233e 100644 --- a/fftools/ffmpeg_sched.c +++

[FFmpeg-devel] [PATCH 05/12] fftools/ffmpeg: move InputStream.codec_desc to private data

2023-12-13 Thread Anton Khirnov
It is not used outside of ffmpeg_demux. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_demux.c | 8 +--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 0bab44cefc..f214e4efcb 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@

[FFmpeg-devel] [PATCH 12/12] fftools/ffmpeg_sched: track dts+duration as last_dts

2023-12-13 Thread Anton Khirnov
This should be slightly (probably negligibly) more accurate for scheduling, but mainly it improves the final reported time. Reported-by: Paul B Mahol --- fftools/ffmpeg_sched.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_sched.c

[FFmpeg-devel] [PATCH 11/12] fftools/ffmpeg: update the reported timestamp at the end

2023-12-13 Thread Anton Khirnov
Reported-by: microchip --- fftools/ffmpeg.c | 2 +- fftools/ffmpeg_sched.c | 13 - fftools/ffmpeg_sched.h | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 8077248254..4c706eb46a 100644 --- a/fftools/ffmpeg.c +++

[FFmpeg-devel] [PATCH 03/12] fftools/ffmpeg: replace OutputStream.file_index by a pointer

2023-12-13 Thread Anton Khirnov
Reduces the need to use the output_files global array. --- fftools/ffmpeg.c | 12 ++-- fftools/ffmpeg.h | 4 +++- fftools/ffmpeg_enc.c | 21 +++-- fftools/ffmpeg_filter.c | 22 +++--- fftools/ffmpeg_mux.c | 11 +--

[FFmpeg-devel] [PATCH 01/12] fftools/ffmpeg_filter: move FilterGraph.graph to FilterGraphThread

2023-12-13 Thread Anton Khirnov
The AVFilterGraph is fully owned by the filtering thread and should never be accessed outside of it. --- fftools/ffmpeg.h| 2 - fftools/ffmpeg_filter.c | 120 +--- 2 files changed, 64 insertions(+), 58 deletions(-) diff --git a/fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 04/12] fftools/ffmpeg: move InputStream.discard to private data

2023-12-13 Thread Anton Khirnov
It is not used outside of ffmpeg_demux. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_demux.c | 23 +++ 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 63e72e4fbc..0bab44cefc 100644 --- a/fftools/ffmpeg.h +++

[FFmpeg-devel] [PATCH 02/12] fftools/ffmpeg: replace InputStream.file_index by a pointer

2023-12-13 Thread Anton Khirnov
Reduces the need to use the input_files global array. --- fftools/ffmpeg.c | 6 +++--- fftools/ffmpeg.h | 4 +++- fftools/ffmpeg_dec.c | 10 +- fftools/ffmpeg_demux.c| 9 - fftools/ffmpeg_filter.c | 14 +++--- fftools/ffmpeg_mux_init.c | 10

Re: [FFmpeg-devel] [PATCH] fate: Allow running multiple rounds of tests with differing settings

2023-12-13 Thread Rémi Denis-Courmont
Le tiistaina 12. joulukuuta 2023, 0.14.06 EET Martin Storsjö a écrit : > This can be used to run tests multple times, with e.g. differing > QEMU settings, by adding something like this to the FATE configuration > file: > > target_exec="qemu-aarch64-static" > fate_targets="fate-checkasm

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: avoid indirection when accessing avctx

2023-12-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/mjpegdec.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 8191606f43..81f724d230 100644 --- a/libavcodec/mjpegdec.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: use memset to clear alpha

2023-12-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/mjpegdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 8676155ecf..8191606f43 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -2793,8 +2793,8 @@ the_end:

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Thilo Borgmann via ffmpeg-devel
Am 13.12.23 um 17:28 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:50:09) Am 13.12.23 um 13:39 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:15:27) Am 13.12.23 um 13:08 schrieb Anton Khirnov: Quoting Thilo Borgmann via

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libjxlenc: Move JxlBasicInfo to LibJxlEncodeContext

2023-12-13 Thread Zsolt Vadász via ffmpeg-devel
On Tuesday, December 12th, 2023 at 9:17 PM, Leo Izen wrote: > On 12/11/23 12:05, Zsolt Vadász via ffmpeg-devel wrote: > > > --- > > libavcodec/libjxlenc.c | 45 +- > > 1 file changed, 23 insertions(+), 22 deletions(-) > > > > diff --git

[FFmpeg-devel] Mailinglist conduct [was: [RFC] fftools/ffmpeg and libavdevice/sdl issue]

2023-12-13 Thread Ronald S. Bultje
Hi Nicolas, On Tue, Dec 12, 2023 at 1:04 PM Nicolas George wrote: > But do not expect it to be fixed, they have hated lavd for ever and now > they have all the control. > Your message promotes conspiracy theories ("they have all control", "they have hated lavd for ever", etc.) and suggests

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-13 Thread Marton Balint
On Wed, 13 Dec 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-12-12 19:37:57) On Tue, 12 Dec 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-12-08 00:11:21) Wipe reminds me of the wipe effect. How about 'predecode_clear'? Fine with me I guess. + */ +#define

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:50:09) > Am 13.12.23 um 13:39 schrieb Anton Khirnov: > > Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:15:27) > >> Am 13.12.23 um 13:08 schrieb Anton Khirnov: > >>> Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:05:35) >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/flvdec: support enhanced flv PacketTypeMetadata

2023-12-13 Thread 朱鹏飞 via ffmpeg-devel
> 2023年12月5日 05:32,James Almer 写道: > > On 11/15/2023 11:40 AM, zhupengfei via ffmpeg-devel wrote: >> From: Zhu Pengfei <411294...@qq.com> >> Signed-off-by: Zhu Pengfei <411294...@qq.com> >> --- >> libavformat/flvdec.c | 171 ++- >> 1 file changed, 170

[FFmpeg-devel] [PATCH v2 11/15] avfilter/vf_libplacebo: switch to colorspace negotiation API

2023-12-13 Thread Niklas Haas
From: Niklas Haas --- libavfilter/vf_libplacebo.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index b6e82a61e0..a9a3d884ce 100644 --- a/libavfilter/vf_libplacebo.c +++

[FFmpeg-devel] [PATCH v2 12/15] avfilter/buffersink: add color space/range accessors

2023-12-13 Thread Niklas Haas
From: Niklas Haas Needed for fftools. --- doc/APIchanges | 3 +++ libavfilter/buffersink.c | 2 ++ libavfilter/buffersink.h | 2 ++ libavfilter/version.h| 2 +- 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH v2 10/15] avfilter/vf_libplacebo: don't force dovi frames to bt.2020-ncl

2023-12-13 Thread Niklas Haas
From: Niklas Haas This is at odds with the YUV matrix negotiation API, in which such dynamic changes in YUV encoding are no longer easily possible. There is also no really strong motivating reason to do this, since the choice of YUV matrix is essentially arbitrary and not actually related to the

[FFmpeg-devel] [PATCH v2 09/15] avfilter/vf_zscale: switch to colorspace negotiation API

2023-12-13 Thread Niklas Haas
From: Niklas Haas Following the same design as vf_scale. --- libavfilter/vf_zscale.c | 44 +++-- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index f76c9954cd..3b14ce4f33 100644 ---

[FFmpeg-devel] [PATCH v2 08/15] avfilter/vf_zscale: remove unused variables

2023-12-13 Thread Niklas Haas
From: Niklas Haas Only assigned, never read. --- libavfilter/vf_zscale.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 788870ffaf..f76c9954cd 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@

[FFmpeg-devel] [PATCH v2 07/15] vf_scale: use colorspace negotiation API

2023-12-13 Thread Niklas Haas
From: Niklas Haas This filter will always accept any input format, even if the user sets a specific in_range/in_color_matrix. This is to preserve status quo with current behavior, where passing a specific in_color_matrix merely overrides the incoming frames' attributes. (Use `vf_format` to force

[FFmpeg-devel] [PATCH v2 06/15] fftools/ffmpeg_filter: configure buffersrc with csp/range

2023-12-13 Thread Niklas Haas
From: Niklas Haas Propagates input metadata to the input filter graph. --- fftools/ffmpeg_filter.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index e5b00123f2..2da6d307a0 100644 ---

[FFmpeg-devel] [PATCH v2 05/15] avfilter/buffersrc: add color_space/range parameters

2023-12-13 Thread Niklas Haas
From: Niklas Haas To allow adding proper negotiation, in particular, to fftools. These values will simply be negotiated downstream for YUV formats, and ignored otherwise. --- doc/filters.texi| 10 ++ libavfilter/buffersrc.c | 74 -

[FFmpeg-devel] [PATCH v2 15/15] avfilter/vf_format: allow empty pix_fmts list

2023-12-13 Thread Niklas Haas
From: Niklas Haas Which will impose no restriction. This makes sense when using e.g. `color_ranges=pc` to limit the color range, without also limiting the pixel format. --- libavfilter/vf_format.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 13/15] avfilter/vf_format: re-use AVFilterFormats for pix_fmt parsing

2023-12-13 Thread Niklas Haas
From: Niklas Haas Rewrite the format parsing code to make it more easily generalizable. In particular, `invert_formats` does not depend on the type of format list passed to it, which allows me to re-use this helper in an upcoming commit. Slightly shortens the code, at the sole cost of doing

[FFmpeg-devel] [PATCH v2 14/15] avfilter/vf_format: add color_ranges/spaces

2023-12-13 Thread Niklas Haas
From: Niklas Haas Needed for fftools/ffmpeg_filter to be able to force specific output formats via the filter chain. --- doc/filters.texi| 8 libavfilter/vf_format.c | 42 ++--- 2 files changed, 47 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 04/15] fftools/ffmpeg_filter: don't clear buffersrc params

2023-12-13 Thread Niklas Haas
From: Niklas Haas This memset is bogus, it accomplishes nothing in the best case and regresses future additions to AVBufferSrcParameters in the worst case. --- fftools/ffmpeg_filter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index

[FFmpeg-devel] [PATCH v2 03/15] avfilter: add negotiation API for color space/range

2023-12-13 Thread Niklas Haas
From: Niklas Haas Motivated by YUVJ removal. This change will allow full negotiation between color ranges and matrices as needed. By default, all ranges and matrices are marked as supported. Because grayscale formats are currently handled very inconsistently (and in particular, assumed as

[FFmpeg-devel] [PATCH v2 02/15] avfilter: always call ff_default_query_formats

2023-12-13 Thread Niklas Haas
From: Niklas Haas Even if a query func is set. This is safe to do, because ff_default_query_formats is documented not to touch any filter lists that were already set by the query func. The reason to do this is because it allows us to extend AVFilterFormatsConfig without having to touch every

[FFmpeg-devel] [PATCH v2 01/15] avfilter/formats: document ff_default_query_formats

2023-12-13 Thread Niklas Haas
From: Niklas Haas In particular, make it clear that this function will not touch format lists which were already set by the caller before calling into this function. --- libavfilter/formats.h | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/formats.h b/libavfilter/formats.h

[FFmpeg-devel] [PATCH v2 00/15] YUV colorspace filter negotiation

2023-12-13 Thread Niklas Haas
Split off from my YUVJ removal series. This implements all of the libavfilter changes needed to fully deprecate YUVJ, but does not yet remove YUVJ, nor add an AVCodec API for advertising colorspace support. Update includes all of the feedback that was brought up by Anton. the major change from v1

[FFmpeg-devel] [PATCH] configure: check VTPixelTransferSessionCreate for scale_vt

2023-12-13 Thread Zhao Zhili
From: Zhao Zhili It's available on macOS since 10.8, but not available on iOS until 16.0. --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 7d2ee66000..8b99af223d 100755 --- a/configure +++ b/configure @@ -3836,7 +3836,7 @@

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Thilo Borgmann via ffmpeg-devel
Am 13.12.23 um 13:39 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:15:27) Am 13.12.23 um 13:08 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:05:35) Am 13.12.23 um 13:00 schrieb Anton Khirnov: Quoting Thilo Borgmann via

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:15:27) > Am 13.12.23 um 13:08 schrieb Anton Khirnov: > > Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:05:35) > >> Am 13.12.23 um 13:00 schrieb Anton Khirnov: > >>> Quoting Thilo Borgmann via ffmpeg-devel (2023-12-11 16:07:22) >

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Thilo Borgmann via ffmpeg-devel
Am 13.12.23 um 13:08 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:05:35) Am 13.12.23 um 13:00 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-11 16:07:22) --- fftools/ffmpeg.h | 31 +-- fftools/ffmpeg_enc.c | 3

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Nicolas George
Thilo Borgmann via ffmpeg-devel (12023-12-11): > --- > fftools/ffmpeg.h | 31 +-- > fftools/ffmpeg_enc.c | 3 +- > fftools/ffmpeg_mux_init.c | 152 +++- > libavutil/parseutils.c| 176 ++ >

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 13:05:35) > Am 13.12.23 um 13:00 schrieb Anton Khirnov: > > Quoting Thilo Borgmann via ffmpeg-devel (2023-12-11 16:07:22) > >> --- > >> fftools/ffmpeg.h | 31 +-- > >> fftools/ffmpeg_enc.c | 3 +- > >>

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Thilo Borgmann via ffmpeg-devel
Am 13.12.23 um 13:00 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-11 16:07:22) --- fftools/ffmpeg.h | 31 +-- fftools/ffmpeg_enc.c | 3 +- fftools/ffmpeg_mux_init.c | 152 +++- libavutil/parseutils.c| 176

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

2023-12-13 Thread Anton Khirnov
Quoting Thilo Borgmann via ffmpeg-devel (2023-12-11 16:07:22) > --- > fftools/ffmpeg.h | 31 +-- > fftools/ffmpeg_enc.c | 3 +- > fftools/ffmpeg_mux_init.c | 152 +++- > libavutil/parseutils.c| 176 ++ >

Re: [FFmpeg-devel] [PATCH 16/25] avfilter/vf_format: allow empty pix_fmts list

2023-12-13 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:48) > From: Niklas Haas > > Which will impose no restriction. This makes sense when using e.g. > `color_ranges=pc` to limit the color range, without also limiting the > pixel format. > --- > libavfilter/vf_format.c | 9 ++--- > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH 15/25] avfilter/vf_format: add color_ranges/spaces

2023-12-13 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:47) > From: Niklas Haas > > Needed for fftools/ffmpeg_filter to be able to force specific output > formats via the filter chain. > --- > doc/filters.texi| 8 > libavfilter/vf_format.c | 44 + > 2

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Anton Khirnov
Quoting Zhao Zhili (2023-12-13 11:37:52) > > > > On Dec 13, 2023, at 18:06, Anton Khirnov wrote: > > > > Quoting Zhao Zhili (2023-12-13 10:31:38) > >> > >>> On Dec 13, 2023, at 17:08, Anton Khirnov wrote: > >>> > >>> Quoting Zhao Zhili (2023-12-12 18:27:39) > Now it's time to talk

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Nicolas George
Zhao Zhili (12023-12-13): > The latency issue may be real or not The latency is obviously real and obviously unavoidable, since there is a muxer, a protocol, an OS buffer, a protocol and a demuxer in the chain that are not necessary with a device. We can try to make it as small as possible, but

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Zhao Zhili
> On Dec 13, 2023, at 18:06, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-13 10:31:38) >> >>> On Dec 13, 2023, at 17:08, Anton Khirnov wrote: >>> >>> Quoting Zhao Zhili (2023-12-12 18:27:39) Now it's time to talk about the libavdevice/sdl issue. SDL output is broken

Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter

2023-12-13 Thread Vittorio Giovara
On Tue, Dec 12, 2023 at 3:00 AM Nicolas George wrote: > Vittorio Giovara (12023-12-11): > > This is an older filter I wrote and never got around publishing. > > It can be used to generate a distortion effect like > > https://vimeo.com/104938599?share=copy > > Please see attached. > > Your code

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Anton Khirnov
Quoting Zhao Zhili (2023-12-13 10:31:38) > > > On Dec 13, 2023, at 17:08, Anton Khirnov wrote: > > > > Quoting Zhao Zhili (2023-12-12 18:27:39) > >> Now it's time to talk about the libavdevice/sdl issue. > >> > >> SDL output is broken with ffmpeg multithread refactor. SDL 'muxer' > >>

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-13 Thread Nicolas George
Rémi Denis-Courmont (12023-12-12): > ...and test for overflow errors in errno.m (which shall have been > zeroed beforehand). AFAIK, you need to do both if you want strict > error detection. Or we can consider that 30064771114 is just another valid way if writing 42 = 042 = 0x2a. It would be

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Nicolas George
Anton Khirnov (12023-12-13): > Honestly I don't see how this could be done in ffmpeg CLI without > disgusting hacks, As I said: do not expect it to be fixed. Or we could revert the whole half-baked series. > but before that the question is: why is there an SDL > "muxer" and

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Zhao Zhili
> On Dec 13, 2023, at 17:08, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-12 18:27:39) >> Now it's time to talk about the libavdevice/sdl issue. >> >> SDL output is broken with ffmpeg multithread refactor. SDL 'muxer' >> write_header >> and write_packet must be run in the same

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-13 Thread Anton Khirnov
Quoting Zhao Zhili (2023-12-12 18:27:39) > Now it's time to talk about the libavdevice/sdl issue. > > SDL output is broken with ffmpeg multithread refactor. SDL 'muxer' > write_header > and write_packet must be run in the same thread. And to make it work portable > and reliable, SDL 'muxer' must

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-13 Thread Anton Khirnov
Quoting Marton Balint (2023-12-12 19:37:57) > > > On Tue, 12 Dec 2023, Anton Khirnov wrote: > > > Quoting Marton Balint (2023-12-08 00:11:21) > >> Wipe reminds me of the wipe effect. How about 'predecode_clear'? > > > > Fine with me I guess. > > > >>> > + */ > +#define

Re: [FFmpeg-devel] [PATCH 14/25] avfilter/vf_format: re-use AVFilterList for pix_fmt parsing

2023-12-13 Thread Anton Khirnov
Quoting Niklas Haas (2023-11-09 13:19:46) >Subject: avfilter/vf_format: re-use AVFilterList for pix_fmt parsing You mean AVFilterFormats > From: Niklas Haas > > Rewrite the format parsing code to make it more easily generalizable. In >