[FFmpeg-devel] [PATCH 4/4] avcodec/mpegvideo_enc: Use ptrdiff_t for stride

2023-12-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index b369c3c735d..c192be6ca40 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo_enc: Dont copy beyond the image

2023-12-29 Thread Michael Niedermayer
Fixes: out of array access Fixes: tickets/10754/poc17ffmpeg Discovered by Zeng Yunxiang. Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_minterpolate: Check pts before division

2023-12-29 Thread Michael Niedermayer
Fixes: FPE Fixes: tickets/10758/poc20ffmpeg Discovered by Zeng Yunxiang Signed-off-by: Michael Niedermayer --- libavfilter/vf_minterpolate.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_minterpolate.c index

[FFmpeg-devel] [PATCH 1/4] avfilter/avf_showwaves: Check history_nb_samples

2023-12-29 Thread Michael Niedermayer
Fixes: out of array access Fixes: tickets/10756/poc18ffmpeg Discovered by Zeng Yunxiang Signed-off-by: Michael Niedermayer --- libavfilter/avf_showwaves.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vaapi_encode: Avoid double AVERRORS

2023-12-29 Thread Michael Niedermayer
On Mon, Oct 02, 2023 at 05:31:01PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vaapi_encode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply patchset [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/af_alimiter: Check nextpos before use

2023-12-29 Thread Michael Niedermayer
On Fri, Dec 22, 2023 at 10:44:59PM +0100, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: tickets/10744/poc11ffmpeg > > Found-by: Li Zeyuan and Zeng Yunxiang. > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_alimiter.c | 7 --- > 1 file changed, 4 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/proresenc: fix alpha plane encoding bitstream

2023-12-29 Thread Clément Bœsch
On Wed, Dec 27, 2023 at 01:29:58PM +0100, Stefano Sabatini wrote: [...] > LGTM, thanks. Thank you for the review. I will add to the commit description that this change was made possible because of paid work for the jitter company (https://jitter.video). If there is no objection, I will push this

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_filter: log an information message about filter graph reconfigurations

2023-12-29 Thread Marton Balint
Filter graph reconfigurations can cause nontrivial issues, e.g. PTS discontinuities, so it is better to warn the user about them. Signed-off-by: Marton Balint --- fftools/ffmpeg_filter.c | 50 - 1 file changed, 40 insertions(+), 10 deletions(-) diff

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_filter: honor -reinit_filters 0 even on changed display matrix

2023-12-29 Thread Marton Balint
Not sure about honoring it also in case of a hwaccel change, so left that as is for now. Signed-off-by: Marton Balint --- fftools/ffmpeg_filter.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index

[FFmpeg-devel] [PATCH 1/3] all: use av_channel_layout_describe_bprint instead of av_channel_layout_describe in a few places

2023-12-29 Thread Marton Balint
Where an AVBPrint buffer is used later anyway. Signed-off-by: Marton Balint --- libavcodec/avcodec.c| 7 +-- libavfilter/af_amerge.c | 7 ++- libavfilter/graphdump.c | 4 +--- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/f_reverse: Apply PTS compensation only when pts is available

2023-12-29 Thread Michael Niedermayer
On Sun, Dec 24, 2023 at 02:49:49AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: tickets/10753/poc16ffmpeg > > Regression since: 45dc668aea0edac34969b5a1ff76cf9ad3a09be1 > Found-by: Zeng Yunxiang > Signed-off-by: Michael Niedermayer > --- > libavfilter/f_reverse.c | 3

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/af_stereowiden: Check length

2023-12-29 Thread Michael Niedermayer
On Sun, Dec 24, 2023 at 11:40:31AM +0100, Paul B Mahol wrote: > This is highly suboptimal, use rounding-up. changing the rounding does not fix the issue, a float can still evaluate to 0 so 0 needs to be checked thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix MSAN issue with stsd_id

2023-12-29 Thread Michael Niedermayer
On Fri, Nov 17, 2023 at 06:13:35PM +0100, Michael Niedermayer wrote: > From: Thomas Guilbert > > Fixes: use of uninitialized value > Fixes: bbb-320x240-2video-2audio.mp4 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 1 + > 1 file changed, 1 insertion(+) will apply [...]

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpegxl_parser: Check get_vlc2()

2023-12-29 Thread Michael Niedermayer
On Wed, Nov 08, 2023 at 03:12:44AM +0100, Michael Niedermayer wrote: > Fixes: shift exponent -1 is negative > Fixes: > 63889/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6009343056936960 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpegutils: print axis in debug_info2

2023-12-29 Thread Michael Niedermayer
On Sat, Dec 30, 2023 at 01:20:16AM +0800, Zhao Zhili wrote: > From: Zhao Zhili > > For example, > > ./ffmpeg -nostats -threads 1 -debug qp \ > -export_side_data +venc_params \ > -i reinit-small_420_9-to-small_420_8.h264 \ > -frames 2 \ > -f null - > > New frame, type: B

Re: [FFmpeg-devel] [PATCH 3/6] Add CRYO APC muxer

2023-12-29 Thread Michael Niedermayer
On Thu, Dec 28, 2023 at 11:31:05AM +0100, Tomas Härdin wrote: > tis 2023-12-26 klockan 23:30 +0100 skrev Michael Niedermayer: > > Hi > > > > On Tue, Dec 26, 2023 at 04:52:47PM +0100, Tomas Härdin wrote: > > > > > > > [...] > > > + > > > +static int apc_write_header(AVFormatContext *s) > > > +{

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread Martin Storsjö
On Fri, 29 Dec 2023, James Almer wrote: On 12/29/2023 9:16 AM, Martin Storsjö wrote: On Fri, 29 Dec 2023, flow gg wrote: Tests on x86 might fail, possibly due to a 16-bit sub overflow If this only happens in checkasm but not in real life use, it means that the checkasm test input is out

[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: specify color range for hw frame ctx

2023-12-29 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/videotoolbox.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 43fd2e3fea..f2269766a2 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -549,6 +549,7 @@ static int

[FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_videotoolbox: add frame hwctx to specify color range

2023-12-29 Thread Zhao Zhili
From: Zhao Zhili VideoToolbox use different identifiers for the same pixel format with different color range, like kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange kCVPixelFormatType_420YpCbCr8BiPlanarFullRange. Before the patch, vt_pool_alloc() always use limited range, and it will fail for

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread James Almer
On 12/29/2023 9:16 AM, Martin Storsjö wrote: On Fri, 29 Dec 2023, flow gg wrote: Tests on x86 might fail, possibly due to a 16-bit sub overflow If this only happens in checkasm but not in real life use, it means that the checkasm test input is out of range, and we should try to mimic the

Re: [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version

2023-12-29 Thread Tomas Härdin
fre 2023-12-29 klockan 00:30 +0100 skrev Michael Niedermayer: > On Thu, Dec 28, 2023 at 10:21:23PM +0100, Tomas Härdin wrote: > > tor 2023-12-28 klockan 21:29 +0100 skrev Michael Niedermayer: > > > On Thu, Dec 28, 2023 at 07:43:09PM +0100, Tomas Härdin wrote: > > > > libcodec2 has reached 1.X so

Re: [FFmpeg-devel] [PATCH 6/6] Add FATE tests for codec2, codec2raw and libcodec2 wrapper

2023-12-29 Thread Tomas Härdin
fre 2023-12-29 klockan 11:40 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > Tests all modes, both demuxers, the muxer, the decoder and the > > encoder. > > Also tests both well-formed files and slightly broken truncated > > files > > > > The raw files are just the .c2 files with the header

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread Martin Storsjö
On Fri, 29 Dec 2023, flow gg wrote: Tests on x86 might fail, possibly due to a 16-bit sub overflow If this only happens in checkasm but not in real life use, it means that the checkasm test input is out of range, and we should try to mimic the real input data. If the issue is off-by-one

[FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2023-12-29 Thread flow gg
C908 ssd_int8_vs_int16_c: 207.7 ssd_int8_vs_int16_rvv_i32: 28.0 From 0fd1b7a34ab8794868d80233c35f70c8ad42b9fa Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 29 Dec 2023 13:27:31 +0800 Subject: [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16 C908 ssd_int8_vs_int16_c: 207.7

Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter

2023-12-29 Thread Stefano Sabatini
On date Wednesday 2023-12-27 21:57:19 -0300, James Almer wrote: > On 12/27/2023 8:20 PM, Stefano Sabatini wrote: [...] > > > I really think this should be ported as a native filter. It's not big and > > > complex like a scaler (sws, zscale) which should not live within > > > libavfilter. > > > >

[FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread flow gg
Tests on x86 might fail, possibly due to a 16-bit sub overflow From 8bde7750ec7adc2437843e14d4be85fb900d1b16 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 29 Dec 2023 13:09:21 +0800 Subject: [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test --- tests/checkasm/Makefile | 1 +

[FFmpeg-devel] [PATCH 1/3] lvac/svqenc: add ff_svq1enc_init

2023-12-29 Thread flow gg
From 55fe9e001545ed3ae1f2c64666d07aebaeb83a2a Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 29 Dec 2023 13:08:25 +0800 Subject: [PATCH 1/3] lvac/svqenc: add ff_svq1enc_init This is for clarity and use in testing, consistent with other parts of the code --- libavcodec/svq1enc.c| 18

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/setpts: introduce rand() function in expression

2023-12-29 Thread Stefano Sabatini
On date Thursday 2023-12-28 22:25:08 +0100, Michael Niedermayer wrote: > On Thu, Dec 28, 2023 at 07:49:18PM +0100, Stefano Sabatini wrote: > > On date Thursday 2023-12-28 16:00:57 +0100, Stefano Sabatini wrote: > > > On date Thursday 2023-12-28 12:02:59 +0100, Andreas Rheinhardt wrote: > > > >

Re: [FFmpeg-devel] [PATCH 6/6] Add FATE tests for codec2, codec2raw and libcodec2 wrapper

2023-12-29 Thread Andreas Rheinhardt
Tomas Härdin: > Tests all modes, both demuxers, the muxer, the decoder and the encoder. > Also tests both well-formed files and slightly broken truncated files > > The raw files are just the .c2 files with the header stripped. > Therefore the relevant tests reuse the .c2 ref files. > If they

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/dnn_backend_openvino: Add dynamic output support

2023-12-29 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > wenbin.chen-at-intel@ffmpeg.org > Sent: Wednesday, December 27, 2023 12:17 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/2] libavfilter/dnn_backend_openvino: Add > dynamic output support > > From:

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegutils: make debug_info2 thread safe

2023-12-29 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/mpegutils.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c index 5e76d7ac66..a565773c5e 100644 --- a/libavcodec/mpegutils.c +++ b/libavcodec/mpegutils.c @@ -20,6 +20,7 @@

[FFmpeg-devel] [PATCH 2/2] avcodec/mpegutils: print axis in debug_info2

2023-12-29 Thread Zhao Zhili
From: Zhao Zhili For example, ./ffmpeg -nostats -threads 1 -debug qp \ -export_side_data +venc_params \ -i reinit-small_420_9-to-small_420_8.h264 \ -frames 2 \ -f null - New frame, type: B 0 64 128 192 0 313131313131313131313131313129 16