Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Gyan Doshi
On 2024-01-08 08:23 am, Zhao Zhili wrote: On Jan 7, 2024, at 20:05, Stefano Sabatini wrote: On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: [...] I'm not blocking the patch, however, I'm not sure whether the gain outweighs the effort for such large code changes. It's very unli

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Zhao Zhili
> On Jan 7, 2024, at 20:05, Stefano Sabatini wrote: > > On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: > [...] >> I'm not blocking the patch, however, I'm not sure whether the gain >> outweighs the effort for such large code changes. It's very >> unlikely to introduce new issues,

Re: [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option

2024-01-07 Thread James Almer
On 1/7/2024 10:43 PM, Steven Liu wrote: James Almer 于2024年1月8日周一 05:31写道: Hi James, Similar to filter_complex_script. Should make setting stream groups easier. Signed-off-by: James Almer --- fftools/ffmpeg_mux_init.c | 2 +- fftools/ffmpeg_opt.c | 3 +++ 2 files changed, 4 insertion

Re: [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option

2024-01-07 Thread Steven Liu
James Almer 于2024年1月8日周一 05:31写道: Hi James, > > Similar to filter_complex_script. Should make setting stream groups > easier. > > Signed-off-by: James Almer > --- > fftools/ffmpeg_mux_init.c | 2 +- > fftools/ffmpeg_opt.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff -

Re: [FFmpeg-devel] [PATCH 27/35] avcodec/proresenc_anatoliy: remove TO_GOLOMB2()

2024-01-07 Thread Clément Bœsch
On Sun, Dec 24, 2023 at 12:43:32AM +0100, Stefano Sabatini wrote: > On date Monday 2023-12-11 02:35:28 +0100, Clément Bœsch wrote: > > A few cosmetics aside, this makes the function identical to the one with > > the same name in proresenc_kostya. > > --- > > libavcodec/proresenc_anatoliy.c | 6 ++-

[FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests

2024-01-07 Thread James Almer
Covers muxing from raw pcm audio input into FLAC, using several scalable layouts, and demuxing the result. Signed-off-by: James Almer --- tests/Makefile | 7 +- tests/fate/iamf.mak| 31 ++ tests/filtergraphs/iamf_5_1|

[FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option

2024-01-07 Thread James Almer
Similar to filter_complex_script. Should make setting stream groups easier. Signed-off-by: James Almer --- fftools/ffmpeg_mux_init.c | 2 +- fftools/ffmpeg_opt.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c inde

[FFmpeg-devel] [PATCH 2/4] fftools/cmdutils: add OPT_TYPE_FILE

2024-01-07 Thread James Almer
Same as OPT_TYPE_STRING, except it takes a file argument whose contents are read as a string. Signed-off-by: James Almer --- fftools/cmdutils.c | 34 ++ fftools/cmdutils.h | 3 +++ fftools/ffmpeg.h | 1 - fftools/ffmpeg_opt.c | 32 +++

[FFmpeg-devel] [PATCH 1/4] avformat/iamfenc: don't write empty packets

2024-01-07 Thread James Almer
And return an error if they are not side data only packets. Signed-off-by: James Almer --- libavformat/iamfenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c index 1de416b663..a02f84035a 100644 --- a/libavformat/iamfenc.c +++ b/lib

Re: [FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-07 Thread James Almer
On 1/7/2024 3:46 PM, Marton Balint wrote: On Sun, 7 Jan 2024, Stefano Sabatini wrote: On date Saturday 2024-01-06 15:49:56 -0600, Marth64 wrote: This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. A valid point was made, that the non-breaking space will cause this text to render b

Re: [FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-07 Thread Marton Balint
On Sun, 7 Jan 2024, Stefano Sabatini wrote: On date Saturday 2024-01-06 15:49:56 -0600, Marth64 wrote: This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. A valid point was made, that the non-breaking space will cause this text to render better by ensuring the unit never seperates

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields

2024-01-07 Thread Clément Bœsch
On Wed, Dec 13, 2023 at 12:16:56AM +0100, Michael Niedermayer wrote: > On Wed, Dec 13, 2023 at 12:13:36AM +0100, Michael Niedermayer wrote: > > On Mon, Dec 11, 2023 at 08:06:53PM +0100, Clément Bœsch wrote: > > > This byte represents 4 reserved bits followed by 4 alpha_channel_type > > > bits. > >

[FFmpeg-devel] [PATCH 5/5] avcodec/proresenc_anatoliy: do not write into chroma reserved bitfields

2024-01-07 Thread Clément Bœsch
The layout for the frame flags is as follow: chroma_format u(2) reserved u(2) interlace_mode u(2) reserved u(2) chroma_format has 2 allowed values: 0: reserved 1: reserved 2: 4:2:2 3: 4:4:4 interlace_mode has 3 allowed values: 0: progressive 1: tff 2

[FFmpeg-devel] [PATCH 4/5] avcodec/proresenc_anatoliy: do not write into alpha reserved bitfields

2024-01-07 Thread Clément Bœsch
This byte represents 4 reserved bits followed by 4 alpha_channel_type bits. alpha_channel_type currently has 3 differents defined values: 0 (no alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are reserved. The 4 initial reserved bits are expected to be 0. --- libavcodec/proresenc_an

[FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields

2024-01-07 Thread Clément Bœsch
This byte represents 4 reserved bits followed by 4 alpha_channel_type bits. alpha_channel_type currently has 3 differents defined values: 0 (no alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are reserved. This part is correctly written (alpha_bits>>3 does the correct thing), but the

[FFmpeg-devel] [PATCH 2/5] avcodec/proresenc_kostya: use a compatible bitstream version

2024-01-07 Thread Clément Bœsch
Quoting SMPTE RDD 36:2015: A decoder shall abort if it encounters a bitstream with an unsupported bitstream_version value. If 0, the value of the chroma_format syntax element shall be 2 (4:2:2 sampling) and the value of the alpha_channel_type element shall be 0 (no encoded alpha); if 1, any

[FFmpeg-devel] [PATCH 1/5] avcodec/proresenc_anatoliy: use a compatible bitstream version

2024-01-07 Thread Clément Bœsch
Quoting SMPTE RDD 36:2015: A decoder shall abort if it encounters a bitstream with an unsupported bitstream_version value. If 0, the value of the chroma_format syntax element shall be 2 (4:2:2 sampling) and the value of the alpha_channel_type element shall be 0 (no encoded alpha); if 1, any

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new unsafe_output hwaccel_flag

2024-01-07 Thread Michael Niedermayer
On Sat, Dec 10, 2022 at 12:00:09AM +, Timo Rothenpieler wrote: > ffmpeg | branch: master | Timo Rothenpieler | Mon Dec > 5 22:32:46 2022 +0100| [7a8d78f7e358e5544395ba6084b83dfe18b4a84e] | > committer: Timo Rothenpieler > > lavc: add new unsafe_output hwaccel_flag > > > http://git.videola

Re: [FFmpeg-devel] [PATCH 1/2] doc/muxers: extend documentation for MOV muxers

2024-01-07 Thread Marth64
Update to that paragraph LGTM. Thanks! On Sun, Jan 7, 2024 at 9:05 AM Stefano Sabatini wrote: > On date Saturday 2024-01-06 14:43:47 -0600, Marth64 wrote: > > +This section covers formats belonging to the QuickTime / MOV family, > > +also named after the MPEG-4 Part 14 format, also named after t

[FFmpeg-devel] [PATCH v2] doc/faq: Use texi's @tie instead of 0xA0 for non-breaking space

2024-01-07 Thread Marth64
Nice find! Updated. Looks good here when rendered to HTML. Signed-off-by: Marth64 --- doc/faq.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/faq.texi b/doc/faq.texi index 5998e0d000..477cc60533 100644 --- a/doc/faq.texi +++ b/doc/faq.texi @@ -450,7 +450,7 @@ work wi

Re: [FFmpeg-devel] [PATCH v3] libavformat: add RCWT closed caption muxer

2024-01-07 Thread Stefano Sabatini
On date Sunday 2024-01-07 09:07:01 -0600, Marth64 wrote: > Thanks, long night. Should come together nicer now. > > Signed-off-by: Marth64 > --- > Changelog| 1 + > doc/muxers.texi | 22 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > li

[FFmpeg-devel] [PATCH] doc/muxers: add argo_asf

2024-01-07 Thread Stefano Sabatini
--- doc/muxers.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 1bafea0d12..5e4fbeb883 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -692,6 +692,24 @@ ffmpeg -i INPUT -final_delay 0.5 -plays 2 out.apng @end example @end

[FFmpeg-devel] [PATCH v3] libavformat: add RCWT closed caption muxer

2024-01-07 Thread Marth64
Thanks, long night. Should come together nicer now. Signed-off-by: Marth64 --- Changelog| 1 + doc/muxers.texi | 22 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rcwtenc.c| 202 +++ tests

Re: [FFmpeg-devel] [PATCH 1/2] doc/muxers: extend documentation for MOV muxers

2024-01-07 Thread Stefano Sabatini
On date Saturday 2024-01-06 14:43:47 -0600, Marth64 wrote: > +This section covers formats belonging to the QuickTime / MOV family, > +also named after the MPEG-4 Part 14 format, also named after the ISO > +base media file format (ISOBMFF). > + > +The MOV format was originally developed for the Appl

Re: [FFmpeg-devel] Fix incomplete implementation of framesync options for overlay filter

2024-01-07 Thread Stefano Sabatini
On date Friday 2024-01-05 11:36:21 +, Howard Peacock wrote: > Hi - first time posting, so apologies in advance if this breaks an etiquette > rule. > > Just a request / suggestion that the 'overlay' filter be updated to implement > all​ the framesync options - including ts_sync_mode. Currentl

Re: [FFmpeg-devel] [PATCH] doc/encoders: fix opus typo

2024-01-07 Thread Stefano Sabatini
On date Saturday 2024-01-06 16:24:54 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > doc/encoders.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index f65389f2a0..c9fe6d6143 100644 > --- a/doc/encoders.texi > +++ b/doc

Re: [FFmpeg-devel] [PATCH v4] doc/filters: add idet example

2024-01-07 Thread Stefano Sabatini
On date Saturday 2024-01-06 16:18:39 -0600, Marth64 wrote: > Thanks all, this should be much better now. > > Signed-off-by: Marth64 > --- > doc/filters.texi | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 09fa3264ea..20c91bab3a 10064

Re: [FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-07 Thread Stefano Sabatini
On date Sunday 2024-01-07 14:16:23 +0100, ffmpeg-devel Mailing List wrote: > Am 07.01.24 um 13:12 schrieb Stefano Sabatini: > > On date Saturday 2024-01-06 15:49:56 -0600, Marth64 wrote: > > > This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. > > > > > > A valid point was made, that th

Re: [FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-07 Thread Thilo Borgmann via ffmpeg-devel
Am 07.01.24 um 13:12 schrieb Stefano Sabatini: On date Saturday 2024-01-06 15:49:56 -0600, Marth64 wrote: This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. A valid point was made, that the non-breaking space will cause this text to render better by ensuring the unit never seperates

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter

2024-01-07 Thread Thilo Borgmann via ffmpeg-devel
Am 06.01.24 um 18:39 schrieb James Almer: On 12/16/2023 5:13 AM, Thilo Borgmann via ffmpeg-devel wrote: ---   Changelog    |   1 +   MAINTAINERS  |   1 +   configure    |   2 +   doc/filters.texi |  33 +   libavfilter/Makefile |   1 +   libavfi

Re: [FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-07 Thread Stefano Sabatini
On date Saturday 2024-01-06 15:49:56 -0600, Marth64 wrote: > This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. > > A valid point was made, that the non-breaking space will cause this text > to render better by ensuring the unit never seperates from the number. I'm not convinced the no

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

2024-01-07 Thread Stefano Sabatini
On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote: [...] > I'm not blocking the patch, however, I'm not sure whether the gain > outweighs the effort for such large code changes. It's very > unlikely to introduce new issues, but possible (e.g., typo while do > copy paste), and it's hard t

Re: [FFmpeg-devel] [PATCH v2] libavformat: add RCWT closed caption muxer

2024-01-07 Thread Stefano Sabatini
On date Saturday 2024-01-06 15:41:05 -0600, Marth64 wrote: > Signed-off-by: Marth64 > > Thank you for the good feedback and review. Most feedback is addressed. > > > nit: no need to shift > I left this alone only since I see it being done this way in lavf/ccfifo > and other documentation. I ass

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/buffersrc: add color_space/range parameters

2024-01-07 Thread Michael Niedermayer
On Sun, Dec 31, 2023 at 09:49:43PM +, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Fri Oct 20 16:55:43 > 2023 +0200| [2d555dc82d4ccd3c54c76e2fb3c861a8652de1c6] | committer: Niklas > Haas > > avfilter/buffersrc: add color_space/range parameters > > To allow adding proper neg

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2024-01-07 Thread flow gg
Alright, I learned a bit more, so should we not consider the internal implementation? I've added this version that reduces one vset in this reply. Rémi Denis-Courmont 于2024年1月7日周日 16:03写道: > Le sunnuntaina 7. tammikuuta 2024, 3.33.39 EET flow gg a écrit : > > I tested it, and indeed using vwsub

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2024-01-07 Thread Rémi Denis-Courmont
Le sunnuntaina 7. tammikuuta 2024, 3.33.39 EET flow gg a écrit : > I tested it, and indeed using vwsub is faster. Updated it in the reply. > > --- > > I have a question: if I tweak the load order a bit, using one less vset, it > leads to being slower (the patch I submitted is 13.2, if I make the