[FFmpeg-devel] [PATCH] avcodec/vaapi_encode: remove a duplicate av_freep

2024-02-19 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/vaapi_encode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 86f4110cd2..808b79c0c7 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -914,7 +914,6 @@ sta

[FFmpeg-devel] [PATCH] fftools/ffplay: Fix output color_spaces of filter

2024-02-19 Thread Zhao Zhili
From: Zhao Zhili The sdl_supported_color_spaces only meant for SDL builtin renderer. --- fftools/ffplay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 53e6fc0514..5b54fab492 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vvc/vvc_ps: Check before access

2024-02-19 Thread Nuo Mi
On Tue, Feb 20, 2024 at 7:24 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > max_bin_idx can be at most LMCS_MAX_BIN_SIZE - 1 here, > > so pivot[LCMS_MAX_BIN_SIZE + 1] may be accessed, > > but pivot has only LCMS_MAX_BIN_SIZE + 1 elements > > (unless the va

[FFmpeg-devel] [PATCH v3] libavfi/dnn: add LibTorch as one of DNN backend

2024-02-19 Thread wenbin . chen-at-intel . com
From: Wenbin Chen PyTorch is an open source machine learning framework that accelerates the path from research prototyping to production deployment. Official websit: https://pytorch.org/. We call the C++ library of PyTorch as LibTorch, the same below. To build FFmpeg with LibTorch, please take f

Re: [FFmpeg-devel] [PATCH v2] libavfi/dnn: add LibTorch as one of DNN backend

2024-02-19 Thread Chen, Wenbin
> > Hello, > > > > On Fri, 2 Feb 2024, at 08:26, wenbin.chen-at-intel@ffmpeg.org wrote: > > > +static void infer_completion_callback(void *args) { > > > +THRequestItem *request = (THRequestItem*)args; > > > +LastLevelTaskItem *lltask = request->lltask; > > > +TaskItem *task = lltask

Re: [FFmpeg-devel] [PATCH v2] libavfi/dnn: add LibTorch as one of DNN backend

2024-02-19 Thread Chen, Wenbin
> Hello, > > On Fri, 2 Feb 2024, at 08:26, wenbin.chen-at-intel@ffmpeg.org wrote: > > +static void infer_completion_callback(void *args) { > > +THRequestItem *request = (THRequestItem*)args; > > +LastLevelTaskItem *lltask = request->lltask; > > +TaskItem *task = lltask->task; > > +

Re: [FFmpeg-devel] [PATCH 1/3] tools: Add target_sws_fuzzer.c

2024-02-19 Thread James Almer
On 2/19/2024 11:49 PM, Michael Niedermayer wrote: +int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { +int srcW= 48, srcH = 48; +int dstW= 48, dstH = 48; +int srcHShift, srcVShift; +int dstHShift, dstVShift; +unsigned flags = 1; +int srcStride[AV_VIDEO_MAX_PLAN

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Vittorio Giovara
On Mon, Feb 19, 2024 at 4:40 PM Gyan Doshi wrote: > > > On 2024-02-19 08:00 pm, Vittorio Giovara wrote: > > On Mon, Feb 19, 2024 at 6:11 AM Gyan Doshi wrote: > > > >> The TC is invoked when there's an intractable dispute. So the dispute > >> precedes the TC activity hence the parties to the disp

[FFmpeg-devel] [PATCH 3/3] libswscale/utils: Fix bayer to yuvj

2024-02-19 Thread Michael Niedermayer
Fixes: out of array access. Earlier code assumes that a unscaled bayer to yuvj420 converter exists but the later code then skips yuvj420 Signed-off-by: Michael Niedermayer --- libswscale/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscal

[FFmpeg-devel] [PATCH 2/3] Revert "swscale: fix sws_setColorspaceDetails after sws_init_context"

2024-02-19 Thread Michael Niedermayer
Suggested by: Niklas Haas in Ticket10824 Fixes: Assertion failure Fixes: Ticket10824 This reverts commit cedf589c09c567b72bf4c1a58db53d94622567e1. --- libswscale/swscale.c | 2 +- libswscale/utils.c | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libswscale/sws

[FFmpeg-devel] [PATCH 1/3] tools: Add target_sws_fuzzer.c

2024-02-19 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_sws_fuzzer.c | 193 ++ 3 files changed, 199 insertions(+) create mode 100644 tools/target_sws_fuzzer.c diff --git a/Makefile b/Makefile i

[FFmpeg-devel] [PATCH v1] avfilter/tonemap_vaapi: Remove duplicate format check

2024-02-19 Thread fei . w . wang-at-intel . com
From: Fei Wang Supported formats are checked in base function ff_vaapi_vpp_config_output. Signed-off-by: Fei Wang --- libavfilter/vf_tonemap_vaapi.c | 8 1 file changed, 8 deletions(-) diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c index 5de7faa8cc..0b76

[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: track metadata sets by their type

2024-02-19 Thread Marton Balint
We typically are only interesed in a single type of metadata set, so it is better to keep them separated instead of always filtering for them. Also use av_dynarray_add for increasing their array. Signed-off-by: Marton Balint --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 128 +

[FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: remove resolve_strong_ref usage with AnyType

2024-02-19 Thread Marton Balint
UUIDs do not have to be unique if their type sets them apart, so avoid using AnyType, since we are only interested in specific types. Signed-off-by: Marton Balint --- libavformat/mxf.h| 3 +-- libavformat/mxfdec.c | 54 2 files changed, 20 insert

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: Remove empty flush callback

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This callback is optional and should therefore only be set > if it actually does something. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_vp8.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c > index

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vvc/vvc_ps: Check before access

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > max_bin_idx can be at most LMCS_MAX_BIN_SIZE - 1 here, > so pivot[LCMS_MAX_BIN_SIZE + 1] may be accessed, > but pivot has only LCMS_MAX_BIN_SIZE + 1 elements > (unless the values of pivot were so that it is always > assured that pivot[LCMS_MAX_BIN_SIZE] is always < sample > (w

Re: [FFmpeg-devel] [PATCH] avutil/tests/pixelutils: Remove dead code

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in e6b125e3be19fb341fd9a759ad0af3b39ba35e0c. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/tests/pixelutils.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/libavutil/tests/pixelutils.c b/libavutil/tests/pixelutils.c > index f5ddeb329d.

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/assenc: Use size_t for length of string

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/assenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/assenc.c b/libavcodec/assenc.c > index e548b9fd3b..e734522729 100644 > --- a/libavcodec/assenc.c > +++ b/libavcodec/assenc.c

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Deprecate AV_INPUT_BUFFER_MIN_SIZE

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It used to be used with preallocated packet buffers with > the old encode API, but said API is no more and therefore > there is no reason for this to be public any more. > So deprecate it and use an internal replacement > for the encoders using it as an upper bound for the > s

Re: [FFmpeg-devel] [PATCH] avutil/common: Move includes to the beginning of the file

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavutil/common.h | 20 +++- > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/libavutil/common.h b/libavutil/common.h > index de2140a678..57c87f1919 100644 > --- a/libavutil/common.h > +++ b/libav

Re: [FFmpeg-devel] [PATCH] avutil/version: Remove outdated checks

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavutil/version.c | 16 > 1 file changed, 16 deletions(-) > > diff --git a/libavutil/version.c b/libavutil/version.c > index 75c5c0d1a8..baead7c4a0 100644 > --- a/libavutil/version.c > +++ b/libavutil/version.c >

[FFmpeg-devel] [PATCH] avfilter/af_pan: Uninitialize channel layout

2024-02-19 Thread Andreas Rheinhardt
Fixes a leak in the mov-mp4-pcm-float FATE test. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_pan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index cfed9f146a..d8431a51d9 100644 --- a/libavfilter/af_pan.c +++ b/libavfilter/af_pan.c @@

Re: [FFmpeg-devel] [PATCH v2 5/6] avformat/iamf_writer: Return proper error codes

2024-02-19 Thread James Almer
On 2/19/2024 7:17 PM, Andreas Rheinhardt wrote: Surprisingly the return value of add_param_definition() (a pointer) has only been used to check for success and not to actually access the pointee; nonsuccess was equated with ENOMEM, although there is a non-enomem error path in this function. Chan

Re: [FFmpeg-devel] [PATCH 1/5] avformat/iamf_writer: Don't leak on error when adding ParamDefinition

2024-02-19 Thread James Almer
On 2/19/2024 6:51 PM, Andreas Rheinhardt wrote: Fix this by postponing the allocation. Fixes Coverity issue #1559545. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavf

Re: [FFmpeg-devel] [PATCH v2 6/6] avformat/iamf_writer: Fix leaks on error

2024-02-19 Thread James Almer
On 2/19/2024 7:17 PM, Andreas Rheinhardt wrote: Fixes Coverity issues #1559544 and #1559547. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 53 ++- 1 file changed, 36 insertions(+), 17 deletions(-) LGTM, thanks. ___

[FFmpeg-devel] [PATCH v2 6/6] avformat/iamf_writer: Fix leaks on error

2024-02-19 Thread Andreas Rheinhardt
Fixes Coverity issues #1559544 and #1559547. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 53 ++- 1 file changed, 36 insertions(+), 17 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index b12c7e77f9..a807f

[FFmpeg-devel] [PATCH v2 5/6] avformat/iamf_writer: Return proper error codes

2024-02-19 Thread Andreas Rheinhardt
Surprisingly the return value of add_param_definition() (a pointer) has only been used to check for success and not to actually access the pointee; nonsuccess was equated with ENOMEM, although there is a non-enomem error path in this function. Change this by returning an int. Signed-off-by: Andre

Re: [FFmpeg-devel] [PATCH 4/5] avformat/iamf: Don't mix ownership and non-ownership pointers

2024-02-19 Thread James Almer
On 2/19/2024 7:06 PM, Andreas Rheinhardt wrote: James Almer: On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: IAMFAudioElement and IAMFMixPresentation currently contain pointers to independently allocated objects that are sometimes owned by said structures and sometimes not. More precisely, upo

Re: [FFmpeg-devel] [PATCH 4/5] avformat/iamf: Don't mix ownership and non-ownership pointers

2024-02-19 Thread Andreas Rheinhardt
James Almer: > On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: >> IAMFAudioElement and IAMFMixPresentation currently contain >> pointers to independently allocated objects that are sometimes >> owned by said structures and sometimes not. >> >> More precisely, upon success the demuxer transfers owne

[FFmpeg-devel] [PATCH 1/5] avformat/iamf_writer: Don't leak on error when adding ParamDefinition

2024-02-19 Thread Andreas Rheinhardt
Fix this by postponing the allocation. Fixes Coverity issue #1559545. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 1a360dee2f..897b06310f 100

Re: [FFmpeg-devel] [PATCH 4/5] avformat/iamf: Don't mix ownership and non-ownership pointers

2024-02-19 Thread James Almer
On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: IAMFAudioElement and IAMFMixPresentation currently contain pointers to independently allocated objects that are sometimes owned by said structures and sometimes not. More precisely, upon success the demuxer transfers ownership of these other object

Re: [FFmpeg-devel] [PATCH 3/5] avformat/iamf_writer: Don't memset twice

2024-02-19 Thread James Almer
On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: This has been allocated via av_calloc() a few lines above. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index e0c47b5e9d

Re: [FFmpeg-devel] [PATCH 2/5] avformat/iamf_writer: Remove nonsense check

2024-02-19 Thread James Almer
On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: Checking whether a pointer to an element of an array is NULL makes no sense, as the pointer addition involved in getting the address would be undefined behaviour already if the array were NULL. In this case the array allocation has already been chec

Re: [FFmpeg-devel] [PATCH 5/5] avformat/iamf_writer: Fix leaks on error

2024-02-19 Thread James Almer
On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: Fixes Coverity issues #1559544 and #1559547. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 42 +++ 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/libavformat/iamf_writer.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Anton Khirnov (12024-02-19): > I am explaining all this in such detail because people in this thread > keep using this term apparently without realizing that in order to have > a conflict of interest there must in fact be multiple interests that are > in conflict, not just a person having multiple

[FFmpeg-devel] [PATCH 5/5] avformat/iamf_writer: Fix leaks on error

2024-02-19 Thread Andreas Rheinhardt
Fixes Coverity issues #1559544 and #1559547. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 42 +++ 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index e8a88b44c3..f6ebb

[FFmpeg-devel] [PATCH 4/5] avformat/iamf: Don't mix ownership and non-ownership pointers

2024-02-19 Thread Andreas Rheinhardt
IAMFAudioElement and IAMFMixPresentation currently contain pointers to independently allocated objects that are sometimes owned by said structures and sometimes not. More precisely, upon success the demuxer transfers ownership of these other objects newly created AVStreamGroups, but it keeps its p

[FFmpeg-devel] [PATCH 3/5] avformat/iamf_writer: Don't memset twice

2024-02-19 Thread Andreas Rheinhardt
This has been allocated via av_calloc() a few lines above. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index e0c47b5e9d..9a665dc002 100644 --- a/libavformat/iamf_writer.c

[FFmpeg-devel] [PATCH 2/5] avformat/iamf_writer: Remove nonsense check

2024-02-19 Thread Andreas Rheinhardt
Checking whether a pointer to an element of an array is NULL makes no sense, as the pointer addition involved in getting the address would be undefined behaviour already if the array were NULL. In this case the array allocation has already been checked a few lines before. Fixes Coverity issue #1559

[FFmpeg-devel] [PATCH v4 4/4] avocdec/ass: simplify linebreaks

2024-02-19 Thread Oneric
ff_ass_subtitle_header_* still used explicit CRLF linebreaks eventhough they will get normalised to LF later since commit 7bf1b9b35769b37684dd2f18a54f01d852a540c8. Just directly use LF. --- libavcodec/ass.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[FFmpeg-devel] [PATCH v4 3/4] avcodec/{ass, webvttdec}: more portable curly brace escapes

2024-02-19 Thread Oneric
Unlike what the old comment suggested, standard ASS has no character escape mechanism, but a closing curly bracket doesn't even need one. For manual authored sub files using a full-width variant of an apropiate font and with scaling and psacing modifiers is a common workaround. This is not an opti

[FFmpeg-devel] [PATCH v4 0/4] Fix some active sequences in subtitles

2024-02-19 Thread Oneric
Changes from v3: - None. Just rebased ontop of master to allow Patchwork to properly process the series now that 99d33cc661fbd04e8657831 was merged. Changes from v2: - rebased ontop of the recently pushed eol normalisation. As a result no more CRLFs in here and Patchwork should be happ

[FFmpeg-devel] [PATCH v4 2/4] avcodec/{ass, webvttdec}: fix handling of backslashes

2024-02-19 Thread Oneric
Backslashes cannot be escaped by a backslash in any ASS renderer, but unless followed by specific characters it is just printed out. Insert a word-joiner character after a backslash to break up active sequences without changing the visual output. --- libavcodec/ass.c | 9 - libavcode

[FFmpeg-devel] [PATCH v4 1/4] avcodec/webvttdec: honour bidi marks

2024-02-19 Thread Oneric
--- libavcodec/webvttdec.c | 2 +- tests/ref/fate/sub-webvtt2 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c index 690f00dc47..990d150f16 100644 --- a/libavcodec/webvttdec.c +++ b/libavcodec/webvttdec.c @@ -39,7 +39,7 @@ s

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-18 23:34:39) > More formally, you could define a "party to a disagreement" as > all minimal sets of people whos non existence would resolve the disagreement That is a useless definition in practice, because it is unknowable. It is very common that developers to

Re: [FFmpeg-devel] [PATCH] fate: use an even more exotic channel layout mov-mp4-pcm-float test

2024-02-19 Thread Marton Balint
On Sun, 18 Feb 2024, James Almer wrote: On 2/18/2024 3:38 PM, Marton Balint wrote: On Sun, 18 Feb 2024, James Almer wrote: On 2/18/2024 7:45 AM, Marton Balint wrote:  The old layout happened to be a native layout and therefore missed some  recently fixed layout parsing bugs.  Signe

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: do not use AnyType when resolving Descriptors and MultipleDescriptors

2024-02-19 Thread Marton Balint
On Mon, 19 Feb 2024, Tomas Härdin wrote: fre 2024-02-16 klockan 22:18 +0100 skrev Marton Balint: Using AnyType should not be a problem for proper MXF files because UIDs are supposed to be unique themselves. Unfortunately that is not the case for some broken files, so let's check the type more

Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c

2024-02-19 Thread Marton Balint
On Sun, 18 Feb 2024, Stone Chen wrote: Hi Marton, Thanks for the feedback! I'm not sure what dynamic reconfiguration is, from some searching I think it might be related to commands? Yeah, exactly. If you check the code, the process_command callback allows this, which eventually calls para

Re: [FFmpeg-devel] [PATCH v10 2/5] libavcodec/webp: add support for animated WebP

2024-02-19 Thread Andreas Rheinhardt
James Almer: > On 2/19/2024 1:50 PM, Andreas Rheinhardt wrote: >> a) Use the receive frame callback for this decoder. This will >> necessitate changes to pthread_frame.c (which currently can't handle >> receive_frame decoders) > > There's a patch for this that i think Anton wrote and then Timo > i

Re: [FFmpeg-devel] Subject: [PATCH 3/3] lavc/dnxhdenc: R-V V get_pixels_8x4_sym

2024-02-19 Thread Rémi Denis-Courmont
Le sunnuntaina 18. helmikuuta 2024, 14.27.56 EET flow gg a écrit : > ping Patch does not apply here. -- Rémi Denis-Courmont http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v10 4/5] libavformat/webp: add WebP demuxer

2024-02-19 Thread Andreas Rheinhardt
Thilo Borgmann via ffmpeg-devel: > From: Josef Zlomek > > Adds the demuxer of animated WebP files. > It supports non-animated, animated, truncated, and concatenated files. > Reading from a pipe (and other non-seekable inputs) is also supported. This demuxer uses lots of seeks, so that the above

Re: [FFmpeg-devel] [PATCH v10 2/5] libavcodec/webp: add support for animated WebP

2024-02-19 Thread James Almer
On 2/19/2024 1:50 PM, Andreas Rheinhardt wrote: a) Use the receive frame callback for this decoder. This will necessitate changes to pthread_frame.c (which currently can't handle receive_frame decoders) There's a patch for this that i think Anton wrote and then Timo improved. It was posted som

Re: [FFmpeg-devel] [PATCH v10 2/5] libavcodec/webp: add support for animated WebP

2024-02-19 Thread Andreas Rheinhardt
Thilo Borgmann via ffmpeg-devel: > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: > https://developers.google.com/speed/webp/docs/riff_container#animation > The frames of the ani

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Devin Heitmueller
On Mon, Feb 19, 2024 at 3:23 AM Hendrik Leppkes wrote: > Absolutely. > There have been WIP patches in the past that tried to do this, but > resorting to memcpy instead of updating the decoder to write to every > second line, and that should of course be avoided. > HEVC also has HWAccel, which shou

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Gyan Doshi
On 2024-02-19 08:00 pm, Vittorio Giovara wrote: On Mon, Feb 19, 2024 at 6:11 AM Gyan Doshi wrote: The TC is invoked when there's an intractable dispute. So the dispute precedes the TC activity hence the parties to the dispute are the main opposing participants at the venue of the dispute whe

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: increase precision of Sleep() on Windows

2024-02-19 Thread Evgeny Pavlov
On Mon, Nov 27, 2023 at 3:05 PM Henrik Gramner via ffmpeg-devel wrote: > > On Mon, Nov 27, 2023 at 2:42 PM Mark Thompson wrote: > > Is it reasonable to set this global state from a library without the parent > > program knowing? We'd really prefer not to affect the global state > > unexpectedl

Re: [FFmpeg-devel] [PATCH v2] {avcodec, tests}: rename the bundled Mesa AV1 vulkan video headers

2024-02-19 Thread Jan Ekström
On Sun, Feb 18, 2024 at 2:16 PM Jan Ekström wrote: > > On Thu, Feb 15, 2024 at 9:21 PM Lynne wrote: > > > > Feb 15, 2024, 20:18 by jee...@gmail.com: > > > > > This together with adjusting the inclusion define allows for the > > > build to not fail with latest Vulkan-Headers that contain the > > >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000: Simplify exp2fi for numbers used here

2024-02-19 Thread Tomas Härdin
mån 2024-02-19 klockan 15:14 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > lör 2024-02-17 klockan 21:05 +0100 skrev Andreas Rheinhardt: > > > The call to ff_exp2fi() here always uses arguments in the normal > > > range, so that the branches in ff_exp2fi() are unnecessary. > > > This is so bec

Re: [FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

2024-02-19 Thread Dennis Mungai
On Mon, 19 Feb 2024, 14:18 Evgeny Pavlov, wrote: > On Wed, Feb 14, 2024 at 5:26 PM Dennis Mungai wrote: > > > On Wed, 14 Feb 2024, 18:28 Evgeny Pavlov, wrote: > > > > > On Wed, Feb 14, 2024 at 4:08 PM Timo Rothenpieler < > t...@rothenpieler.org > > > > > > wrote: > > > > > > > On 14/02/2024 02:

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Vittorio Giovara (12024-02-19): > > By that reasoning, it could be argued that someone proposed the inclusion of > > this rule being discussed only to set up a backdoor in the process and > > thwart any chance of a functioning process for the community > As mentioned, it's just a hyperbole, extendi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Vittorio Giovara
On Mon, Feb 19, 2024 at 3:28 PM Nicolas George wrote: > Vittorio Giovara (12024-02-19): > > By that reasoning, someone could argue that you forced the inclusion of > > this rule being discussed only to set up a backdoor in the process and > > thwart any chance of a functioning process for the com

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Vittorio Giovara (12024-02-19): > There are many in the section snipped below the original email. You are making accusations. You know what it implies. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Vittorio Giovara
On Mon, Feb 19, 2024 at 3:30 PM Nicolas George wrote: > Vittorio Giovara (12024-02-19): > > I understand your concerns regarding the potential consequences of > changing > > this rule, and I acknowledge the importance of upholding the principles > > that underpin our project's governance. However

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Vittorio Giovara
On Mon, Feb 19, 2024 at 6:11 AM Gyan Doshi wrote: > > > On 2024-02-19 03:16 am, Vittorio Giovara wrote: > > On Sun, Feb 18, 2024 at 8:02 PM Gyan Doshi wrote: > > > >> > >> On 2024-02-18 11:33 pm, Anton Khirnov wrote: > >>> Quoting Gyan Doshi (2024-02-18 05:06:30) > b) what "maximalist" inte

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Vittorio Giovara (12024-02-19): > I understand your concerns regarding the potential consequences of changing > this rule, and I acknowledge the importance of upholding the principles > that underpin our project's governance. However, I must express my > disappointment in the insinuation that I am

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Vittorio Giovara (12024-02-19): > By that reasoning, someone could argue that you forced the inclusion of > this rule being discussed only to set up a backdoor in the process and > thwart any chance of a functioning process for the community Can you explain the part of your reasoning where you est

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Vittorio Giovara
On Mon, Feb 19, 2024 at 9:54 AM Nicolas George wrote: > Vittorio Giovara (12024-02-18): > > While I understand that you're referencing the existing rules that we've > > collectively agreed upon, I believe it's crucial for us to periodically > > review and refine these rules to ensure they remain

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Vittorio Giovara
On Mon, Feb 19, 2024 at 9:45 AM Nicolas George wrote: > Vittorio Giovara (12024-02-18): > > If it helps, I'll block the patch so that Anton can vote in the TC. > > Do you see how slippery (and insane) this interpretation of the rule > > becomes? > > The rules are written assuming people in the pr

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000: Simplify exp2fi for numbers used here

2024-02-19 Thread Andreas Rheinhardt
Tomas Härdin: > lör 2024-02-17 klockan 21:05 +0100 skrev Andreas Rheinhardt: >> The call to ff_exp2fi() here always uses arguments in the normal >> range, so that the branches in ff_exp2fi() are unnecessary. >> This is so because JPEG2000 itself only supports up to >> 128 bits per component per pix

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add a ts_id exported option

2024-02-19 Thread James Almer
On 2/19/2024 8:20 AM, Andreas Rheinhardt wrote: James Almer: Replaces AVFormatContext.ts_id Signed-off-by: James Almer --- To be pushed as part of the bump set. libavformat/avformat.h | 6 -- libavformat/mpegts.c | 9 +++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000: Simplify exp2fi for numbers used here

2024-02-19 Thread Tomas Härdin
lör 2024-02-17 klockan 21:05 +0100 skrev Andreas Rheinhardt: > The call to ff_exp2fi() here always uses arguments in the normal > range, so that the branches in ff_exp2fi() are unnecessary. > This is so because JPEG2000 itself only supports up to > 128 bits per component per pixel (we only support

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/jpeg2000dec: Avoid using GetByteContext.buffer directly

2024-02-19 Thread Tomas Härdin
lör 2024-02-17 klockan 21:05 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- >  libavcodec/jpeg2000dec.c | 8 +++- >  1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c > index 3d18d48e7c..1afc6b1e2d 10

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec, j2kenc: Constify where appropriate

2024-02-19 Thread Tomas Härdin
lör 2024-02-17 klockan 20:54 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- >  libavcodec/j2kenc.c  |  2 +- >  libavcodec/jpeg2000dec.c | 14 +++--- >  2 files changed, 8 insertions(+), 8 deletions(-) Should be fine /Tomas ___

[FFmpeg-devel] [PATCH] avcodec/cbs_vp8: Don't leave out ... in calls to variadic macros

2024-02-19 Thread Andreas Rheinhardt
It is undefined behaviour (see C11, 6.10.3 (4); see also 14dd0a9057019e97ff9438f6cc1502f6922acb85). Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_vp8.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index eabdef35

[FFmpeg-devel] [PATCH 2/2] avcodec/h264dec: Reindent after the previous commit

2024-02-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h264dec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 5cffeafc6b..b4973fce29 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -125,16 +125,16

[FFmpeg-devel] [PATCH 1/2] avcodec/h264dec: Return early in ff_h264_draw_horiz_band()

2024-02-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h264dec.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 9f5893c512..5cffeafc6b 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -104,9

Re: [FFmpeg-devel] [PATCH] avutil/intreadwrite: Remove obsolete warning

2024-02-19 Thread Martin Storsjö
On Mon, 19 Feb 2024, Andreas Rheinhardt wrote: Andreas Rheinhardt: Obsolete since 7ec2354c38978b918dc079b611393becb6c80bf7. Signed-off-by: Andreas Rheinhardt --- libavutil/intreadwrite.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavutil/intreadwrite.h b/libavut

Re: [FFmpeg-devel] [PATCH] avutil/intreadwrite: Remove obsolete warning

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Obsolete since 7ec2354c38978b918dc079b611393becb6c80bf7. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/intreadwrite.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavutil/intreadwrite.h b/libavutil/intreadwrite.h > index 21df7887f

Re: [FFmpeg-devel] [PATCH] flvdec: Honor the "flv_metadata" option for the "datastream" metadata field

2024-02-19 Thread Martin Storsjö
On Fri, 9 Feb 2024, Martin Storsjö wrote: By default the option "flv_metadata" (internally using the field name "trust_metadata") is set to 0, meaning that we don't allocate streams based on information in the metadata, only based on actual streams we encounter. However the "datastream" metadata

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec, j2kenc: Constify where appropriate

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/j2kenc.c | 2 +- > libavcodec/jpeg2000dec.c | 14 +++--- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c > index 789791f529..ebf21f6e7a 100644 >

Re: [FFmpeg-devel] [PATCH] configure, libavutil/version: Remove unused HAVE_MMX2

2024-02-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > configure | 1 - > libavutil/version.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/configure b/configure > index f72533b7d2..c7defd9bf3 100755 > --- a/configure > +++ b/configure > @@ -8091,7 +8091,6 @@ cat >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: do not use AnyType when resolving Descriptors and MultipleDescriptors

2024-02-19 Thread Tomas Härdin
fre 2024-02-16 klockan 22:18 +0100 skrev Marton Balint: > Using AnyType should not be a problem for proper MXF files because > UIDs are > supposed to be unique themselves. Unfortunately that is not the case > for some > broken files, so let's check the type more strictly. Here's what S377m-2004 sa

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Jerome Martinez
On 19/02/2024 12:08, Tomas Härdin wrote: mån 2024-02-19 klockan 00:14 +0100 skrev Tomas Härdin: tor 2024-02-15 klockan 16:02 +0100 skrev Jerome Martinez: On 05/02/2024 01:19, Tomas Härdin wrote: [...] Which entry in the table would the provided file correspond to? To me it seems none of them f

Re: [FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

2024-02-19 Thread Evgeny Pavlov
On Wed, Feb 14, 2024 at 5:26 PM Dennis Mungai wrote: > On Wed, 14 Feb 2024, 18:28 Evgeny Pavlov, wrote: > > > On Wed, Feb 14, 2024 at 4:08 PM Timo Rothenpieler > > > wrote: > > > > > On 14/02/2024 02:55, Dmitrii Ovchinnikov wrote: > > > > From: Evgeny Pavlov > > > > > > > > This commit adds tw

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add a ts_id exported option

2024-02-19 Thread Andreas Rheinhardt
James Almer: > Replaces AVFormatContext.ts_id > > Signed-off-by: James Almer > --- > To be pushed as part of the bump set. > > libavformat/avformat.h | 6 -- > libavformat/mpegts.c | 9 +++-- > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/libavformat/avformat.h b

[FFmpeg-devel] [PATCH] lavc/vp8dsp: R-V V put_vp8_pixels

2024-02-19 Thread flow gg
The reason for using m1+le8 instead of stride load + larger group multipliers is the same as in "[FFmpeg-devel] [PATCH 1/7] lavc/me_cmp: R-V V pix_abs." In the test, there is #define src (buf + 2 * SRC_BUF_STRIDE + 2 + 1) Therefore, not using e8 will result : (fatal signal 7: Bus error). From 6d

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: move resolving Descriptors to the multi descriptor resolve function

2024-02-19 Thread Tomas Härdin
fre 2024-02-16 klockan 22:18 +0100 skrev Marton Balint: > Also remove unused descriptor member from MXFPackage. > > Signed-off-by: Marton Balint > --- >  libavformat/mxfdec.c | 9 - >  1 file changed, 4 insertions(+), 5 deletions(-) Looks OK /Tomas ___

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Tomas Härdin
mån 2024-02-19 klockan 00:14 +0100 skrev Tomas Härdin: > tor 2024-02-15 klockan 16:02 +0100 skrev Jerome Martinez: > > On 05/02/2024 01:19, Tomas Härdin wrote: > > > [...] > > > Which entry in the table would the provided file correspond to? > > > To > > > me > > > it seems none of them fit. There'

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Tomas Härdin
mån 2024-02-19 klockan 12:05 +0100 skrev Tomas Härdin: > mån 2024-02-19 klockan 00:43 +0100 skrev Marton Balint: > > > > > > On Fri, 16 Feb 2024, Anton Khirnov wrote: > > > > > Quoting Tomas Härdin (2024-02-03 20:58:20) > > > > I think people with knowledge how interlacing is handled in > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Tomas Härdin
mån 2024-02-19 klockan 00:43 +0100 skrev Marton Balint: > > > On Fri, 16 Feb 2024, Anton Khirnov wrote: > > > Quoting Tomas Härdin (2024-02-03 20:58:20) > > > I think people with knowledge how interlacing is handled in other > > > formats and codecs might want to chime in. > > > > For MPEG code

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/bsf/hevc_mp4toannexb: Don't realloc when creating new extradata

2024-02-19 Thread Andreas Rheinhardt
James Almer: > On 2/17/2024 11:44 PM, Andreas Rheinhardt wrote: >> AVCodecParameters.extradata is supposed to be allocated with >> av_malloc(); av_realloc() and its wrappers do not guarantee >> the proper alignment. Therefore parse the extradata twice: >> Once to check its validity and to determine

Re: [FFmpeg-devel] [PATCH] [MXF] - Add "footer_with_hmd" option

2024-02-19 Thread Tomas Härdin
fre 2024-02-09 klockan 11:58 +0100 skrev Cédric Le Barz: > Add "footer_with_hmd" option: this option activates the writing of > the > header metadata in the footer partition. Sounds useful for writing MXF to a stream. Could use a test. /Tomas ___ ffmp

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Vittorio Giovara (12024-02-18): > While I understand that you're referencing the existing rules that we've > collectively agreed upon, I believe it's crucial for us to periodically > review and refine these rules to ensure they remain aligned with our > evolving community values and goals. This

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-19 Thread Nicolas George
Vittorio Giovara (12024-02-18): > If it helps, I'll block the patch so that Anton can vote in the TC. > Do you see how slippery (and insane) this interpretation of the rule > becomes? The rules are written assuming people in the project are working in good faith for the benefit of the project. Pr

[FFmpeg-devel] [PATCH] libavformat/rtpenc_jpeg.c: Added support for DRI frames in MJPEG RTP packetization

2024-02-19 Thread rayjay via ffmpeg-devel
Signed-off-by: rayjay <526528...@qq.com> --- libavformat/rtpenc_jpeg.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c index e4e95931f4..721c02ff76 100644 --- a/libavformat/rtpenc_jpeg.c +++ b/libavformat/rtpenc_jpeg.c @@ -3

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Hendrik Leppkes
On Mon, Feb 19, 2024 at 12:44 AM Marton Balint wrote: > > > > On Fri, 16 Feb 2024, Anton Khirnov wrote: > > > Quoting Tomas Härdin (2024-02-03 20:58:20) > >> I think people with knowledge how interlacing is handled in other > >> formats and codecs might want to chime in. > > > > For MPEG codecs ou