[FFmpeg-devel] [PATCH] avformat/mpegts: Don't use uninitialized value in av_log()

It is undefined behaviour in (at least) C11 (see C11 6.3.2.1 (2)). Fixes Coverity issue #1500314. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 3a5cb769ba..c66a1ea6e

[FFmpeg-devel] [PATCH 6/6] avformat/dhav: Check amount read

Prevents potential use of uninitialized data in the following memcmp(). Signed-off-by: Andreas Rheinhardt --- libavformat/dhav.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/dhav.c b/libavformat/dhav.c index 8e08274e68..b2ead99609 100644 --- a/libavformat/dh

[FFmpeg-devel] [PATCH 5/6] avformat/dhav: Check ffio_ensure_seekback()

Fixes Coverity issue #1492324. Signed-off-by: Andreas Rheinhardt --- libavformat/dhav.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/dhav.c b/libavformat/dhav.c index 303fb42bed..8e08274e68 100644 --- a/libavformat/dhav.c +++ b/libavformat/dhav.c @@ -273,8

[FFmpeg-devel] [PATCH 4/6] avformat/qoadec: Check ffio_ensure_seekback()

Fixes Coverity issue #1598406. Signed-off-by: Andreas Rheinhardt --- libavformat/qoadec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/qoadec.c b/libavformat/qoadec.c index 9cce5157fc..a9632c46c3 100644 --- a/libavformat/qoadec.c +++ b/libavformat/qoadec.c

[FFmpeg-devel] [PATCH 3/6] avformat/westwood_vqa: Check ffio_ensure_seekback()

Fixes Coverity issue #1598405. Signed-off-by: Andreas Rheinhardt --- libavformat/westwood_vqa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/westwood_vqa.c b/libavformat/westwood_vqa.c index 3a31e3f5e8..9755fcc9c1 100644 --- a/libavformat/westwood_vqa.c +++

[FFmpeg-devel] [PATCH 2/6] avformat/gifdec: Check ffio_ensure_seekback()

Fixes Coverity issue #1598400. Signed-off-by: Andreas Rheinhardt --- libavformat/gifdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/gifdec.c b/libavformat/gifdec.c index 294007682b..d5f06adc64 100644 --- a/libavformat/gifdec.c +++ b/libavformat/gifdec.c

[FFmpeg-devel] [PATCH 1/6] avformat/oggdec: Check ffio_ensure_seekback()

Fixes Coverity issue #1492327. Signed-off-by: Andreas Rheinhardt --- libavformat/oggdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c index 8ea81e5d45..5339fdd32c 100644 --- a/libavformat/oggdec.c +++ b/libavformat/oggdec.c @

Re: [FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

Stone Chen: > Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. > DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce > complexity, SAD is only calculated on even rows. This is calculated for all > video bitdepths, but the values passed to the func

Re: [FFmpeg-devel] [PATCH v2] avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc

Cosmin Stejerean via ffmpeg-devel: > From: Cosmin Stejerean > > These two fields are coded together into a single 16 bit integer with upper 8 > bits for ext_mapping_idc and lower 8 bits for el_bit_depth_minus8. > > Furthermore ext_mapping_idc has two components, upper 3 bits and lower 5 bits. H

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_av1: accept HDR metadata if have

From: Haihao Xiang The sdk av1 encoder can accept HDR metadata via mfxEncodeCtrl::ExtParam. Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_av1.c | 73 + 1 file changed, 73 insertions(+) diff --git a/libavcodec/qsvenc_av1.c b/libavcodec/qsvenc_av1.c i

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: update HDR side data on output AVFrame for AV1 decoding

From: Haihao Xiang The SDK may provide HDR metadata for HDR streams via mfxExtBuffer attached on output mfxFrameSurface1 Signed-off-by: Haihao Xiang --- libavcodec/qsvdec.c | 48 - 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/libavco

Re: [FFmpeg-devel] [PATCH v5 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

On 5/21/2024 9:00 PM, Stone Chen wrote: Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 50.3 vvc_sad_8x8_avx2: 0.3 vvc_sad_16x16_c: 250.3 vvc_sad_16x16_avx2: 10.3 vvc_sad_32x32_c: 1020.3 vvc_sad_32x32_avx2: 60.3 vvc_sad_64x64_c: 3850.3 vvc_sad_64x64_avx2:

Re: [FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

On Tue, 14 May 2024 19:07:59 -0700 Philip Langdale via ffmpeg-devel wrote: > On Wed, 15 May 2024 01:36:43 +0530 > llyyr.pub...@gmail.com wrote: > > > From: llyyr > > > > ab77b878f1 attempted to fix the issue of broken packets being sent > > to the decoder by implementing logic that kept attemp

Re: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation

>-Original Message- >From: ffmpeg-devel On Behalf Of >Andrew Sayers >Sent: Wednesday, May 22, 2024 12:32 AM >To: FFmpeg development discussions and patches de...@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add >Flags for resource creation > >(Only re

[FFmpeg-devel] [PATCH v10 13/13] Changelog: add D3D12VA HEVC encoder changelog

From: Tong Wu Signed-off-by: Tong Wu --- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 12770e4296..c5d57b3813 100644 --- a/Changelog +++ b/Changelog @@ -11,7 +11,7 @@ version : - vf_scale2ref deprecated - qsv_params option added for

[FFmpeg-devel] [PATCH v10 12/13] avcodec: add D3D12VA hardware HEVC encoder

From: Tong Wu This implementation is based on D3D12 Video Encoding Spec: https://microsoft.github.io/DirectX-Specs/d3d/D3D12VideoEncoding.html Sample command line for transcoding: ffmpeg.exe -hwaccel d3d12va -hwaccel_output_format d3d12 -i input.mp4 -c:v hevc_d3d12va output.mp4 Signed-off-by: T

[FFmpeg-devel] [PATCH v10 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation

From: Tong Wu Flags field is added to support diffferent resource creation. Signed-off-by: Tong Wu --- doc/APIchanges| 3 +++ libavutil/hwcontext_d3d12va.c | 2 +- libavutil/hwcontext_d3d12va.h | 8 libavutil/version.h | 2 +- 4 files changed, 13 insertions(+

[FFmpeg-devel] [PATCH v10 10/13] avcodec/vaapi_encode: extract a free funtion to base layer

From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 11 +++ libavcodec/hw_base_encode.h | 2 ++ libavcodec/vaapi_encode.c | 6 +- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index 42

[FFmpeg-devel] [PATCH v10 09/13] avcodec/vaapi_encode: extract a get_recon_format function to base layer

From: Tong Wu Surface size and block size parameters are also moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 58 +++ libavcodec/hw_base_encode.h | 12 + libavcodec/vaapi_encode.c | 81 - libavc

[FFmpeg-devel] [PATCH v10 06/13] avcodec/vaapi_encode: extract the init and close function to base layer

From: Tong Wu Related parameters such as device context, frame context are also moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 49 ++ libavcodec/hw_base_encode.h | 17 +++ libavcodec/vaapi_encode.c | 90 +++---

[FFmpeg-devel] [PATCH v10 05/13] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

From: Tong Wu Move receive_packet function to base. This requires adding *alloc, *issue, *output, *free as hardware callbacks. HWBaseEncodePicture is introduced as the base layer structure. The related parameters in VAAPIEncodeContext are also extracted to HWBaseEncodeContext. Then DPB management

[FFmpeg-devel] [PATCH v10 08/13] avcodec/vaapi_encode: extract set_output_property to base layer

From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 40 + libavcodec/hw_base_encode.h | 3 +++ libavcodec/vaapi_encode.c | 44 ++--- 3 files changed, 45 insertions(+), 42 deletions(-) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH v10 07/13] avcodec/vaapi_encode: extract gop configuration and two options to base layer

From: Tong Wu idr_interval and desired_b_depth are moved to HW_BASE_ENCODE_COMMON_OPTIONS. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 54 + libavcodec/hw_base_encode.h | 19 + libavcodec/vaapi_encode.c | 52 +++

[FFmpeg-devel] [PATCH v10 04/13] avcodec/vaapi_encode: move pic->input_surface initialization to encode_alloc

From: Tong Wu When allocating the VAAPIEncodePicture, pic->input_surface can be initialized right in the place. This movement simplifies the send_frame logic and is the preparation for moving vaapi_encode_send_frame to the base layer. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode.c | 8 +

[FFmpeg-devel] [PATCH v10 03/13] avcodec/vaapi_encode: add picture type name to base

From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 5 + libavcodec/vaapi_encode.c | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_encode.h index 5272f2836d..a578db8c06 100644 --- a/libavcodec/hw_

[FFmpeg-devel] [PATCH v10 02/13] avcodec/vaapi_encode: add async_depth to common options

From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 10 +- libavcodec/vaapi_encode.c | 13 - libavcodec/vaapi_encode.h | 7 --- libavcodec/vaapi_encode_av1.c | 1 + libavcodec/vaapi_encode_h264.c | 1 + libavcodec/vaapi_encode_h26

[FFmpeg-devel] [PATCH v10 01/13] avcodec/vaapi_encode: introduce a base layer for vaapi encode

From: Tong Wu Since VAAPI and future D3D12VA implementation may share some common parameters, a base layer encode context is introduced as vaapi context's base. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 56 + libavcodec/vaapi_encode.h | 39 +

Re: [FFmpeg-devel] [PATCH v5 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

Hi, On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote: > Adds checkasm for DMVR SAD AVX2 implementation. > > Benchmarks ( AMD 7940HS ) > vvc_sad_8x8_c: 50.3 > vvc_sad_8x8_avx2: 0.3 > vvc_sad_16x16_c: 250.3 > vvc_sad_16x16_avx2: 10.3 > vvc_sad_32x32_c: 1020.3 > vvc_sad_32x32_avx2: 60.3 > vvc_sad_6

Re: [FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

Hi, On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote: > Implements AVX2 DMVR (decoder-side motion vector refinement) SAD > functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. > To reduce complexity, SAD is only calculated on even rows. This is > calculated for all video bi

Re: [FFmpeg-devel] [PATCH v4 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

On Mon, May 20, 2024 at 7:23 AM Ronald S. Bultje wrote: > Hi, > > This is mostly good, the following is tiny nitpicks. > > On Sun, May 19, 2024 at 8:46 PM Stone Chen > wrote: > >> +%macro INIT_OFFSET 6 ; src1, src2, dxq, dyq, off1, off2 >> > > The macro is only used once, so you could inline it

Re: [FFmpeg-devel] [PATCH 13/13] avformat/flvdec: support all multi-track modes

On Tue, May 21, 2024 at 11:02:22AM +0200, Timo Rothenpieler wrote: > --- > libavformat/flvdec.c | 570 +++ > 1 file changed, 306 insertions(+), 264 deletions(-) infinite loops [flv @ 0x555e803d2940] Video codec (0) is not implemented. Update your FFmpeg v

[FFmpeg-devel] [PATCH v5 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 50.3 vvc_sad_8x8_avx2: 0.3 vvc_sad_16x16_c: 250.3 vvc_sad_16x16_avx2: 10.3 vvc_sad_32x32_c: 1020.3 vvc_sad_32x32_avx2: 60.3 vvc_sad_64x64_c: 3850.3 vvc_sad_64x64_avx2: 220.3 vvc_sad_128x128_c: 14100.3 vvc_sad_

[FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD is only calculated on even rows. This is calculated for all video bitdepths, but the values passed to the function are always 16bi

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On 21/05/2024 23:33, Hendrik Leppkes wrote: On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel wrote: It should be the case here, we shouldn't need reordering as NATIVE just lets you specify what order the elements appear in the bitstream. NATIVE means "the FFmpeg native ordering", not

Re: [FFmpeg-devel] [RFC] STF 2025

On 21.05.24 21:43, Rémi Denis-Courmont wrote: Le tiistaina 21. toukokuuta 2024, 22.42.00 EEST Rémi Denis-Courmont a écrit : And "I hope you realise that you are arguing for" Intel, Loongson, etc. employees to stop reviewing patches. P.S.: And FFlabs too, since it is a for-profit company. S

Re: [FFmpeg-devel] [RFC] STF 2025

On 21.05.24 21:42, Rémi Denis-Courmont wrote: Le tiistaina 21. toukokuuta 2024, 21.43.44 EEST Thilo Borgmann via ffmpeg-devel a écrit : Same as above about that we should and STF would. Especially since no corporate interest usually pays anyone for these tasks Sadly true, but... (in case o

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel wrote: > > > It should be the case here, we shouldn't need reordering as NATIVE just > lets you specify what order the elements appear in the bitstream. NATIVE means "the FFmpeg native ordering", not "bitstream order". CUSTOM lets you specify

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 21:40, Marton Balint wrote: On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 09:16, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  On 19/05/2024 21:39, Marton Balint wrote:

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On 21/05/2024 21:40, Marton Balint wrote: On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 09:16, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  On 19/05/2024 21:39, Marton Balint wrote:   On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:

Re: [FFmpeg-devel] [RFC] STF 2025

Le tiistaina 21. toukokuuta 2024, 22.42.00 EEST Rémi Denis-Courmont a écrit : > And "I hope you realise that you are arguing for" Intel, Loongson, etc. > employees to stop reviewing patches. P.S.: And FFlabs too, since it is a for-profit company. -- レミ・デニ-クールモン http://www.remlab.net/

Re: [FFmpeg-devel] [RFC] STF 2025

Le tiistaina 21. toukokuuta 2024, 21.43.44 EEST Thilo Borgmann via ffmpeg-devel a écrit : > >> Same as above about that we should and STF would. > >> Especially since no corporate interest usually pays anyone for these > >> tasks > > > > Sadly true, but... > > > >> (in case of reviews it might o

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 09:16, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: On 19/05/2024 21:39, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  This commit adds a decoder for the freque

[FFmpeg-devel] [PATCH] avfilter/framesync: fix forward EOF pts

Note1: when the EOF pts is not accurate enough, the last frame can be dropped by vf_fps with default rounding. Note2: vf_scale use framesync since e82a3997cdd6c0894869b33ba42430ac3, so this is a very commonplace scenario. For example: ./ffprobe -f lavfi testsrc=d=1,scale,fps -of flat \ -count_f

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

Reordered some here. 于2024年5月22日周三 03:24写道： > From: sunyuechi > > C908 X60 > avg_8_2x2_c:1.01.0 > avg_8_2x2_rvv_i32 :0.70.7 > avg_8_2x4_c

[FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

From: sunyuechi C908 X60 avg_8_2x2_c:1.01.0 avg_8_2x2_rvv_i32 :0.70.7 avg_8_2x4_c:2.02.0 avg_8_2x4_rvv_i

Re: [FFmpeg-devel] FFmpeg 7.0.1

On Thu, Apr 4, 2024 at 8:23 PM Michael Niedermayer wrote: > > Hi all > > i intend to make a 7.0.1 in a few weeks for all the bug fixes that didnt > make it in 7.0 Any update on this? -t > > thx > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > It is dangerous t

Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvenc: Implement support for multi-track video

> On May 21, 2024, at 11:54 AM, Cosmin Stejerean via ffmpeg-devel > wrote: > > > However I've found a workaround. By setting my git send-email from to just > "cos...@cosmin.at " rather than "Cosmin Stejerean > mailto:cos...@cosmin.at>>" then the emails that go out

Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvenc: Implement support for multi-track video

> On May 21, 2024, at 11:54 AM, Cosmin Stejerean via ffmpeg-devel > wrote: > > > However I've found a workaround. By setting my git send-email from to just > "cos...@cosmin.at " rather than "Cosmin Stejerean > mailto:cos...@cosmin.at>>" then the emails that go out

Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvenc: Implement support for multi-track video

> On May 21, 2024, at 11:48 AM, Dennis Sädtler via ffmpeg-devel > wrote: > >> From: Dennis Sädtler via ffmpeg-devel > > I wonder what happened here, did I make a mistake when submitting the > original patch to the ML so the actual commit author name/email got > lost? > > Should be the same

Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvenc: Implement support for multi-track video

On 21.05.2024 20:48, Dennis Sädtler wrote: From: Dennis Sädtler via ffmpeg-devel I wonder what happened here, did I make a mistake when submitting the original patch to the ML so the actual commit author name/email got lost? That's just what happens if your mailserver has strict SPF/DMARC co

Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvenc: Implement support for multi-track video

> From: Dennis Sädtler via ffmpeg-devel I wonder what happened here, did I make a mistake when submitting the original patch to the ML so the actual commit author name/email got lost? Should be the same as the signed-off section based on the repo I submitted it from: https://github.com/derrod/ff

Re: [FFmpeg-devel] [RFC] STF 2025

On 20.05.24 20:51, Rémi Denis-Courmont wrote: Le sunnuntaina 19. toukokuuta 2024, 14.29.43 EEST Thilo Borgmann via ffmpeg- devel a écrit : [...] * Fund administrative / maintainance work (one example is the mailman upgrade that is needed>> with the next OS upgrade on one of our servers (t

[FFmpeg-devel] [PATCH v2] avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc

From: Cosmin Stejerean These two fields are coded together into a single 16 bit integer with upper 8 bits for ext_mapping_idc and lower 8 bits for el_bit_depth_minus8. Furthermore ext_mapping_idc has two components, upper 3 bits and lower 5 bits. --- libavcodec/dovi_rpudec.c | 7 ++- libav

Re: [FFmpeg-devel] [PATCH v2 2/5] lavc/vp9dsp: R-V V mc bilin h v

Do macros definition also need a comma? I noticed that many of my old code and SiFive's code don't have a comma Rémi Denis-Courmont 于2024年5月22日周三 02:29写道： > Le tiistaina 21. toukokuuta 2024, 20.13.16 EEST u...@foxmail.com a écrit : > > From: sunyuechi > > > diff --git a/libavcodec/riscv/vp9_mc_

Re: [FFmpeg-devel] [PATCH v2 2/5] lavc/vp9dsp: R-V V mc bilin h v

Le tiistaina 21. toukokuuta 2024, 20.13.16 EEST u...@foxmail.com a écrit : > From: sunyuechi > diff --git a/libavcodec/riscv/vp9_mc_rvv.S b/libavcodec/riscv/vp9_mc_rvv.S > index 7cb38ec94a..739380d9a9 100644 > --- a/libavcodec/riscv/vp9_mc_rvv.S > +++ b/libavcodec/riscv/vp9_mc_rvv.S > @@ -53,6 +5

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On 21/05/2024 09:16, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: On 19/05/2024 21:39, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  This commit adds a decoder for the frequency-domain part of USAC.  [...]  +/* Finish later */  

[FFmpeg-devel] [PATCH 1/2] checkasm/riscv: test misaligned before V

Otherwise V functions mask scalar misaligned ones. --- tests/checkasm/checkasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 31ca9f6e2b..76835ab267 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checka

[FFmpeg-devel] [PATCH 2/2] lavc/pixblockdsp: add scalar get_pixels_unaligned

The code is already there, we just need to use it. get_pixels_unaligned_c: 2.2 get_pixels_unaligned_misaligned: 1.7 --- libavcodec/riscv/pixblockdsp_init.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/riscv/pixblockdsp_init.c b/libavcodec/riscv/pixblockdsp_init.c index b

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

> I would expect that you can get better performance by interleaving scalar and vector stuff, and possibly also vector loads and vector arithmetic. Okay, I will try > These labels lead to nowhere? If you actually mean to implicitly fall through to the next function, you can use the function name

Re: [FFmpeg-devel] [PATCH v2 1/5] lavc/vp9dsp: R-V V mc avg

> Please put commas between operands. > This should probably be ff_avg_vp9 or something slightly more specific. Updated here. 于2024年5月22日周三 01:14写道： > From: sunyuechi > > C908: > vp9_avg4_8bpp_c: 1.2 > vp9_avg4_8bpp_rvv_i64: 1.0 > vp9_avg8_8bpp_c: 3.7 > vp9_avg8_8bpp_rvv_i64: 1.5 > vp9_avg16_8

[FFmpeg-devel] [PATCH v2 5/5] lavc/vp9dsp: R-V V mc tap hv

From: sunyuechi C908 X60 vp9_avg_8tap_smooth_4hv_8bpp_c : 32.0 28.2 vp9_avg_8tap_smooth_4hv_8bpp_rvv_i32 : 15.0 13.2 vp9_avg_8tap_smooth_8hv_8bpp_c : 98.0 86.2 vp9_avg_8tap_smo

[FFmpeg-devel] [PATCH v2 4/5] lavc/vp9dsp: R-V V mc bilin hv

From: sunyuechi C908: vp9_avg_bilin_4hv_8bpp_c: 11.0 vp9_avg_bilin_4hv_8bpp_rvv_i64: 3.7 vp9_avg_bilin_8hv_8bpp_c: 38.7 vp9_avg_bilin_8hv_8bpp_rvv_i64: 7.2 vp9_avg_bilin_16hv_8bpp_c: 147.0 vp9_avg_bilin_16hv_8bpp_rvv_i64: 14.2 vp9_avg_bilin_32hv_8bpp_c: 574.5 vp9_avg_bilin_32hv_8bpp_rvv_i64: 42.7

[FFmpeg-devel] [PATCH v2 3/5] lavc/vp9dsp: R-V V mc tap h v

From: sunyuechi C908 X60 vp9_avg_8tap_smooth_4h_8bpp_c : 13.0 11.2 vp9_avg_8tap_smooth_4h_8bpp_rvv_i32:5.04.2 vp9_avg_8tap_smooth_4v_8bpp_c : 13.7 12.5 vp9_avg_8tap_smo

[FFmpeg-devel] [PATCH v2 2/5] lavc/vp9dsp: R-V V mc bilin h v

From: sunyuechi C908: vp9_avg_bilin_4h_8bpp_c: 5.2 vp9_avg_bilin_4h_8bpp_rvv_i64: 2.2 vp9_avg_bilin_4v_8bpp_c: 5.5 vp9_avg_bilin_4v_8bpp_rvv_i64: 2.2 vp9_avg_bilin_8h_8bpp_c: 20.0 vp9_avg_bilin_8h_8bpp_rvv_i64: 4.5 vp9_avg_bilin_8v_8bpp_c: 21.0 vp9_avg_bilin_8v_8bpp_rvv_i64: 4.2 vp9_avg_bilin_16h

[FFmpeg-devel] [PATCH v2 1/5] lavc/vp9dsp: R-V V mc avg

From: sunyuechi C908: vp9_avg4_8bpp_c: 1.2 vp9_avg4_8bpp_rvv_i64: 1.0 vp9_avg8_8bpp_c: 3.7 vp9_avg8_8bpp_rvv_i64: 1.5 vp9_avg16_8bpp_c: 14.7 vp9_avg16_8bpp_rvv_i64: 3.5 vp9_avg32_8bpp_c: 57.7 vp9_avg32_8bpp_rvv_i64: 10.0 vp9_avg64_8bpp_c: 229.0 vp9_avg64_8bpp_rvv_i64: 31.7 --- libavcodec/riscv/M

Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding

Hi, [...] Tests mostly work for me. There are a few images (that I reported earlier) that give: thanks for testing! Canvas change detected. The output will be damaged. Use -threads 1 to try decoding with best effort. They don't animate without that option and with it render incorrectly.

Re: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation

(Only reviewing documentation, not code) On Mon, May 20, 2024 at 10:52:20PM +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > Flags field is added to support diffferent resource creation. > > Signed-off-by: Tong Wu > --- > doc/APIchanges| 3 +++ > libavutil/h

[FFmpeg-devel] 回复: [PATCH] x86/vvc_alf: use the x86inc instruction macros

> 发件人: ffmpeg-devel 代表 James Almer > > 发送时间: 2024年5月21日 6:52 > 收件人: ffmpeg-devel@ffmpeg.org > 主题: [FFmpeg-devel] [PATCH] x86/vvc_alf: use the x86inc instruction macros > > Let its magic figure out the correct mnemonic based on target instruction set. > > Signed-off-by: James Almer > --- > li

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

Le tiistaina 21. toukokuuta 2024, 10.37.51 EEST u...@foxmail.com a écrit : > From: sunyuechi > --- > libavcodec/riscv/Makefile | 2 + > libavcodec/riscv/vvc_mc_rvv.S | 312 + > libavcodec/riscv/vvcdsp_init.c | 76 > libavcodec/vvc/dsp.c

Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/vp9dsp: R-V V mc avg

Le tiistaina 21. toukokuuta 2024, 18.36.02 EEST flow gg a écrit : > > Please put commas between operands. > > Okay > > > This should probably be ff_avg_vp9 or something slightly more specific. > > Is it necessary here? It works because VP9 is the odd one out doing this. All non-static symbols i

Re: [FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

On 21/05/2024 17:07, J. Dekker wrote: Lynne via ffmpeg-devel writes: Helps make sense of the possible noise in the results. --- tests/checkasm/checkasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 669f2be9c1..b1c175b95

Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/vp9dsp: R-V V mc avg

> Please put commas between operands. Okay > This should probably be ff_avg_vp9 or something slightly more specific. Is it necessary here? Many macros in the C file are copied from MIPS, where it is called ff_avg4_msa. Here, it has been simply changed to ff_avg4_rvv. Rémi Denis-Courmont 于2024年

Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/vp9dsp: R-V V mc avg

Le lauantaina 18. toukokuuta 2024, 21.15.29 EEST u...@foxmail.com a écrit : > From: sunyuechi > > C908: > vp9_avg4_8bpp_c: 1.2 > vp9_avg4_8bpp_rvv_i64: 1.0 > vp9_avg8_8bpp_c: 3.7 > vp9_avg8_8bpp_rvv_i64: 1.5 > vp9_avg16_8bpp_c: 14.7 > vp9_avg16_8bpp_rvv_i64: 3.5 > vp9_avg32_8bpp_c: 57.7 > vp9_avg

Re: [FFmpeg-devel] [PATCH] avcodec/dovi_rpudec - correctly read el_bit_depth_minus8 when ext_mapping_idc is non-zero

> On May 21, 2024, at 3:21 AM, Niklas Haas wrote: > > On Tue, 21 May 2024 01:17:32 + Cosmin Stejerean via ffmpeg-devel > wrote: >> From: Cosmin Stejerean >> >> It looks like the el_bitdepth_minus8 value in the header can also encode >> ext_mapping_idc in the upper 8 bits. >> >> Samples

Re: [FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

Lynne via ffmpeg-devel writes: > Helps make sense of the possible noise in the results. > --- > tests/checkasm/checkasm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index 669f2be9c1..b1c175b95d 100644 > --- a/tests/checka

[FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

Helps make sense of the possible noise in the results. --- tests/checkasm/checkasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 669f2be9c1..b1c175b95d 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -

Re: [FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench

Lynne via ffmpeg-devel writes: > [[PGP Signed Part:Undecided]] > On 21/05/2024 15:51, J. Dekker wrote: >> Some timers on certain device and test combinations can produce noisy >> results, affecting the reliability of performance measurements. One >> notable example of this is the Canaan K230 RI

Re: [FFmpeg-devel] [PATCH v4 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

Hi, On Sun, May 19, 2024 at 8:55 PM Stone Chen wrote: > Adds checkasm for DMVR SAD AVX2 implementation. > > Benchmarks ( AMD 7940HS ) > vvc_sad_8x8_c: 70.0 > vvc_sad_8x8_avx2: 10.0 > vvc_sad_16x16_c: 280.0 > vvc_sad_16x16_avx2: 20.0 > vvc_sad_32x32_c: 1020.0 > vvc_sad_32x32_avx2: 70.0 > vvc_sad_

Re: [FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench

On 21/05/2024 15:51, J. Dekker wrote: Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples by an exp

[FFmpeg-devel] [PATCH] x86/vvc_alf: use the x86inc instruction macros

Let its magic figure out the correct mnemonic based on target instruction set. Signed-off-by: James Almer --- libavcodec/x86/vvc/vvc_alf.asm | 202 - 1 file changed, 101 insertions(+), 101 deletions(-) diff --git a/libavcodec/x86/vvc/vvc_alf.asm b/libavcodec/x86/

[FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench

Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples by an exponent (--runs) has been added, allowing

Re: [FFmpeg-devel] [PATCH v2] checkasm: add sample argument to adjust during bench

On 21/05/2024 14:32, J. Dekker wrote: Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples (--sample

Re: [FFmpeg-devel] [PATCH v2] checkasm: add sample argument to adjust during bench

On Tue, May 21, 2024 at 2:33 PM J. Dekker wrote: > @@ -338,8 +338,9 @@ typedef struct CheckasmPerf { > uint64_t tsum = 0;\ > int ti, tcount = 0;\ > uint64_t t = 0; \ > +const uint64_t truns = bench_runs;\ > checkasm_set_signal_handler

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

On Tue, May 21, 2024 at 6:16 PM Martin Storsjö wrote: > On Tue, 21 May 2024, Martin Storsjö wrote: > > > Don't benchmark every single combination of widths and heights; > > only benchmark cases which are squares (like in vvc_mc.c). > > > > Contrary to vvc_mc, which increases sizes by doubling dim

[FFmpeg-devel] [PATCH v2] checkasm: add sample argument to adjust during bench

Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples (--samples) has been added, allowing developers t

Re: [FFmpeg-devel] [PATCH 18/18] Changelog: add DVB compatible information for VVC decoder

On Sun, May 19, 2024 at 9:39 PM Nuo Mi wrote: > see > https://dvb.org/specifications/verification-validation/vvc-test-content/ > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index dd25715d6b..12770e4296 100644 > --- a/Changelog > +++ b/Changelo

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

On Tue, May 21, 2024 at 7:11 PM Rémi Denis-Courmont wrote: > > > Le 21 mai 2024 13:04:29 GMT+03:00, "Martin Storsjö" a > écrit : > >Don't benchmark every single combination of widths and heights; > >only benchmark cases which are squares (like in vvc_mc.c). > > > >Contrary to vvc_mc, which incre

Re: [FFmpeg-devel] [PATCH 3/6] lavf/tls_mbedtls: hook up debug message callback

Le 21 mai 2024 13:14:59 GMT+03:00, sfan5 a écrit : >Am 17.05.24 um 11:51 schrieb Rémi Denis-Courmont: >> Le 17 mai 2024 11:34:35 GMT+03:00, Sfan5 a écrit : >>> Signed-off-by: sfan5 >>> --- >>> libavformat/tls_mbedtls.c | 14 ++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git

Re: [FFmpeg-devel] [PATCH] checkasm: h264dsp: Avoid out of buffer writes when benchmarking

Le 21 mai 2024 14:04:53 GMT+03:00, "Martin Storsjö" a écrit : >The loop filters can write before the pointer given to them; >the actual test invocations correctly used an offset, while >the benchmark calls were lacking an offset. Therefore, when >running with benchmarking, these tests could have

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

Le 21 mai 2024 13:04:29 GMT+03:00, "Martin Storsjö" a écrit : >Don't benchmark every single combination of widths and heights; >only benchmark cases which are squares (like in vvc_mc.c). > >Contrary to vvc_mc, which increases sizes by doubling dimensions, >vvc_alf tests all sizes in increments o

[FFmpeg-devel] [PATCH] checkasm: h264dsp: Avoid out of buffer writes when benchmarking

The loop filters can write before the pointer given to them; the actual test invocations correctly used an offset, while the benchmark calls were lacking an offset. Therefore, when running with benchmarking, these tests could have spurious failures. --- tests/checkasm/h264dsp.c | 4 ++-- 1 file ch

Re: [FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null pointer dereference

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Tuesday, May 21, 2024 3:12 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null > pointer dereference > > Zhao Zhili: > > From: Zhao Zhili >

Re: [FFmpeg-devel] [PATCH 4/6] lavf/tls_mbedtls: fix handling of certification validation failures

Am 18.05.24 um 21:53 schrieb Michael Niedermayer: On Fri, May 17, 2024 at 10:34:41AM +0200, Sfan5 wrote: We manually check the verification status after the handshake has completed using mbedtls_ssl_get_verify_result(). However with VERIFY_REQUIRED mbedtls_ssl_handshake() already returns an erro

Re: [FFmpeg-devel] [PATCH 1/6] lavf/tls_mbedtls: handle more error codes for human-readable message

Am 17.05.24 um 11:42 schrieb Andrew Sayers: On Fri, May 17, 2024 at 10:34:26AM +0200, Sfan5 wrote: Signed-off-by: sfan5 --- libavformat/tls_mbedtls.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index 1a182e735e..fd6ba0b1f5 1

Re: [FFmpeg-devel] [PATCH] avcodec/dovi_rpudec - correctly read el_bit_depth_minus8 when ext_mapping_idc is non-zero

On Tue, 21 May 2024 01:17:32 + Cosmin Stejerean via ffmpeg-devel wrote: > From: Cosmin Stejerean > > It looks like the el_bitdepth_minus8 value in the header can also encode > ext_mapping_idc in the upper 8 bits. > > Samples having a non-zero ext_mapping_idc fail validation currently becau

Re: [FFmpeg-devel] [PATCH] avcodec/dovi - disable metadata compression by default

On Tue, 21 May 2024 04:03:43 + Cosmin Stejerean via ffmpeg-devel wrote: > From: Cosmin Stejerean > > not all clients support metadata compression, make this an option and off by > default until we can verify output. > > vdr_dm_metadata_changed = 0 case fails the DV verifier so force this t

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

On Tue, 21 May 2024, Martin Storsjö wrote: Don't benchmark every single combination of widths and heights; only benchmark cases which are squares (like in vvc_mc.c). Contrary to vvc_mc, which increases sizes by doubling dimensions, vvc_alf tests all sizes in increments of 4. Limit benchmarking

Re: [FFmpeg-devel] [PATCH 3/6] lavf/tls_mbedtls: hook up debug message callback

Am 17.05.24 um 11:51 schrieb Rémi Denis-Courmont: Le 17 mai 2024 11:34:35 GMT+03:00, Sfan5 a écrit : Signed-off-by: sfan5 --- libavformat/tls_mbedtls.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index 24c3afd94c..9508

Re: [FFmpeg-devel] [PATCH v4 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

On Tue, 21 May 2024, Rémi Denis-Courmont wrote: Le 21 mai 2024 09:37:18 GMT+03:00, "Martin Storsjö" a écrit : On Tue, 21 May 2024, Rémi Denis-Courmont wrote: Hi, VVC benchmarks have increased checksam runtime by at least an order of magnitude. It's become so prohibitively slow that I cou

[FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

Don't benchmark every single combination of widths and heights; only benchmark cases which are squares (like in vvc_mc.c). Contrary to vvc_mc, which increases sizes by doubling dimensions, vvc_alf tests all sizes in increments of 4. Limit benchmarking to the cases which are powers of two. This re

  1   2   >