Re: [FFmpeg-devel] [PATCH 2/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-06-17 Thread Rémi Denis-Courmont
Le 17 juin 2024 19:52:10 GMT+02:00, Paul B Mahol a écrit : >On Mon, Jun 17, 2024 at 4:52 PM Rémi Denis-Courmont wrote: > >> >> >> Le 17 juin 2024 13:18:11 GMT+02:00, Yigithan Yigit < >> yigithanyigitde...@gmail.com> a écrit : >> >--- >> > libavfilter/af_volumedetect.c | 159

Re: [FFmpeg-devel] [PATCH 6/6] lavf/tls_mbedtls: add workaround for TLSv1.3 vs. verify=0

2024-06-17 Thread Anton Khirnov
Quoting sfan5 (2024-06-11 18:17:00) > Am 11.06.24 um 17:02 schrieb Anton Khirnov: > > Quoting Sfan5 (2024-05-17 10:34:50) > >> As of mbedTLS 3.6.0 TLSv1.3 is enabled by default and certificate > >> verification > >> is now mandatory. Our default configuration does not do verification, so > >> downg

[FFmpeg-devel] [PATCH] avformat/iamf_parse: add missing padding to AAC extradata

2024-06-17 Thread James Almer
Fixes: out of array access Fixes: 68863/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-4833546039525376 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: James Almer --- libavformat/iamf_parse.c | 5 - 1 file changed,

Re: [FFmpeg-devel] [PATCH 5/9] avformat/mov: Check extend and base offset

2024-06-17 Thread James Almer
On 6/16/2024 8:08 PM, Michael Niedermayer wrote: Fixes: signed integer overflow: 2314885530818453536 + 9151314442816847872 cannot be represented in type 'long' Fixes: 68359/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6571950311800832 Found-by: continuous fuzzing process https://githu

Re: [FFmpeg-devel] [PATCH 3/9] avformat/iamf_parse: Try to use less space after the array

2024-06-17 Thread James Almer
On 6/16/2024 8:08 PM, Michael Niedermayer wrote: Fixes: out of array access Fixes: 68584/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6256656668229632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 4/9] avformat/iamf_parse: Layer, thou shalt not be 0

2024-06-17 Thread James Almer
On 6/16/2024 8:08 PM, Michael Niedermayer wrote: Fixes: out of array access Fixes: 68302/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4665793796177920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/smcenc: width < 4 is unsupported

2024-06-17 Thread Michael Niedermayer
On Mon, Jun 17, 2024 at 09:50:18AM +0200, Paul B Mahol wrote: > On Mon, Jun 17, 2024 at 1:09 AM Michael Niedermayer > wrote: > > > Fixes: out of array read > > Fixes: > > 68939/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMC_fuzzer-587804104884224 > > > > Found-by: continuous fuzzing proces

Re: [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

2024-06-17 Thread Michael Niedermayer
On Mon, Jun 17, 2024 at 09:07:23AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-17 01:08:29) > > Ive been told that someone at the BCN video tech meetup claimed to be the > > "release maintainer for FFmpeg". > > > > If you have any doubt who maintains releases, just do someth

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-17 Thread Andrew Sayers
On Mon, Jun 17, 2024 at 09:29:57PM +0200, Vittorio Giovara wrote: > On Mon, Jun 17, 2024 at 9:01 PM Nicolas George wrote: > > > Michael Niedermayer (12024-06-17): > > > also if you look at google trends, even today more people search for > > ffserver > > > than txproto. In fact at every point in

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-17 Thread Rémi Denis-Courmont
Le 17 juin 2024 20:34:39 GMT+02:00, Michael Niedermayer a écrit : >also if you look at google trends, even today more people search for ffserver >than txproto. In fact at every point in time more people searched for ffserver >than txproto. Nobody looks at txproto since it's (AFAIK) a one-perso

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 9:33 PM, James Almer wrote: > Personally I'd say yes, but other similar lavu APIs (Mastering, Ambient > Viewing) don't seem to bother with it, so maybe just leave it as 0 > unless someone else has a strong opinion about it. I'll leave it for consistency then. - Derek __

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread James Almer
On 6/17/2024 5:27 PM, Derek Buitenhuis wrote: On 6/17/2024 9:07 PM, James Almer wrote: nit: { 0, 1 }. If we set it to 0, 1 here, should it be set to that in the alloc function too? It'll be 0, 0 at alloc time due to use of av_mallocz. Personally I'd say yes, but other similar lavu APIs (Mast

[FFmpeg-devel] [PATCH] avutil/timestamp: avoid possible FPE when 0 is passed to av_ts_make_time_string2()

2024-06-17 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/timestamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timestamp.c b/libavutil/timestamp.c index 2a3e3012a4..6c231a517d 100644 --- a/libavutil/timestamp.c +++ b/libavutil/timestamp.c @@ -24,7 +24,7 @@ char *av_ts_make_t

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 9:07 PM, James Almer wrote: > nit: { 0, 1 }. If we set it to 0, 1 here, should it be set to that in the alloc function too? It'll be 0, 0 at alloc time due to use of av_mallocz. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 9:03 PM, James Almer wrote: > Missing APIChanges entry (no need to resend, you can just amend before > pushing). Done locally for this and previous commit. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/timestamp: introduce av_ts_make_time_string2 for better precision

2024-06-17 Thread Hendrik Leppkes
On Sat, Mar 23, 2024 at 12:14 PM Marton Balint wrote: > +char *av_ts_make_time_string2(char *buf, int64_t ts, AVRational tb) > +{ > +if (ts == AV_NOPTS_VALUE) { > +snprintf(buf, AV_TS_MAX_STRING_SIZE, "NOPTS"); > +} else { > +double val = av_q2d(tb) * ts; > +double

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread James Almer
On 6/17/2024 4:20 PM, Derek Buitenhuis wrote: This box is provided by files created by the Apple Vision Pro, as well as the iPhone 15+ when capture for Vision Pro is enabled. The boxes are a mix of things documented by Apple in some PDFs, their API docs, and reverse engineering. Ideally we will

Re: [FFmpeg-devel] [PATCH v2 2/2] avutil/macos_kperf: Fix assert which makes kperf failed to run

2024-06-17 Thread Martin Storsjö
On Tue, 18 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili On m1, kpc_get_counter_count(KPC_MASK) return 8 in my test. The exact value doesn't matter in our case, as long as we have a sufficiently large array Signed-off-by: Zhao Zhili --- libavutil/macos_kperf.c | 16 ++-- 1 file cha

Re: [FFmpeg-devel] [PATCH v3 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread James Almer
On 6/17/2024 4:20 PM, Derek Buitenhuis wrote: Based on what is in the files themselves, and what the API provides to users. URLs: * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye * https://developer.apple.com/documentation/videotoolbox/kvtcompres

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-17 Thread Vittorio Giovara
On Mon, Jun 17, 2024 at 9:01 PM Nicolas George wrote: > Michael Niedermayer (12024-06-17): > > also if you look at google trends, even today more people search for > ffserver > > than txproto. In fact at every point in time more people searched for > ffserver > > than txproto. > > > > https://tre

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-17 Thread Vittorio Giovara
On Mon, Jun 17, 2024 at 8:34 PM Michael Niedermayer wrote: > On Tue, Apr 30, 2024 at 07:42:53PM +0200, Michael Niedermayer wrote: > > On Mon, Apr 22, 2024 at 01:32:27PM +0200, Lynne wrote: > > > Apr 22, 2024, 13:07 by stefa...@gmail.com: > > > > > > > On date Sunday 2024-04-21 22:12:56 -0300, Jam

[FFmpeg-devel] [PATCH v3 5/5] avformat/mov: Add support for reading and exporting horizontal field of view

2024-06-17 Thread Derek Buitenhuis
These boxes are created by the Apple Vision Pro and the iPhone 15+ when capture for the Vision Pro is enabled. Based off of the swift API: * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis --- libavformat

[FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
This box is provided by files created by the Apple Vision Pro, as well as the iPhone 15+ when capture for Vision Pro is enabled. The boxes are a mix of things documented by Apple in some PDFs, their API docs, and reverse engineering. Ideally we will have a real spec one day. Links: * https://d

[FFmpeg-devel] [PATCH v3 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-17 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c| 8 tests/ref/fate/matroska-spherical-mono | 2 ++ tests/ref/fate/matroska-spherical-mono-remux | 4 tests/ref/fate/matroska-stereo_mode | 8 tests/ref/fate/matroska-vp8-alpha-r

[FFmpeg-devel] [PATCH v3 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
Based on what is in the files themselves, and what the API provides to users. URLs: * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_stereocamerabaseline * https://

[FFmpeg-devel] [PATCH v3 1/5] avutil/spherical: Add more spherical types

2024-06-17 Thread Derek Buitenhuis
These originate from the Apple Vision Pro, and are documented here: https://developer.apple.com/documentation/coremedia/cmprojectiontype Signed-off-by: Derek Buitenhuis --- libavutil/spherical.c | 5 + libavutil/spherical.h | 16 libavutil/version.h | 2 +- 3 files

[FFmpeg-devel] [PATCH v3 0/5] Vision Pro Spatial Data

2024-06-17 Thread Derek Buitenhuis
Changes since v2: * horizontal display adjustment is now a rational Derek Buitenhuis (5): avutil/spherical: Add more spherical types avutil/stereo3d: Fill out stereo info provided by Vision Pro files fftools/ffprobe: Print more Stereo 3D info from side data avformat/mov: Add support for ex

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-17 Thread Lynne via ffmpeg-devel
On 17/06/2024 21:01, Lynne wrote: On 17/06/2024 09:35, Anton Khirnov wrote: No tests? Tests for this particular part are tricky. We still have the SBR issue where we add a single sample of delay to the output, which the reference samples and their decodings do not. Adding a test would mean m

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 7:09 PM, James Almer wrote: > No, it's av_d2q(), av_q2d(), and av_rescale() as needed. Same as we do > for Mastering Display and Ambient Viewing Environment Metadata. > The reason to use AVRational is that in this specific spec the values > have a denominator of 1, but in others

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-17 Thread Lynne via ffmpeg-devel
On 17/06/2024 09:35, Anton Khirnov wrote: No tests? Tests for this particular part are tricky. We still have the SBR issue where we add a single sample of delay to the output, which the reference samples and their decodings do not. Adding a test would mean modifying the samples in a way wher

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-17 Thread Nicolas George
Michael Niedermayer (12024-06-17): > also if you look at google trends, even today more people search for ffserver > than txproto. In fact at every point in time more people searched for ffserver > than txproto. > > https://trends.google.com/trends/explore?date=all&q=txproto,ffserver > > So even

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-17 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 07:42:53PM +0200, Michael Niedermayer wrote: > On Mon, Apr 22, 2024 at 01:32:27PM +0200, Lynne wrote: > > Apr 22, 2024, 13:07 by stefa...@gmail.com: > > > > > On date Sunday 2024-04-21 22:12:56 -0300, James Almer wrote: > > > > > >> On 4/17/2024 10:58 AM, Michael Niedermaye

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread James Almer
On 6/17/2024 2:07 PM, Derek Buitenhuis wrote: On 6/17/2024 5:53 PM, James Almer wrote: Maybe this should be an AVRational then. While that is probably 'more correct', it does mean that in 100% places this could be used, it'll have to be converted back to the -1 to 1 range. Is there a s

Re: [FFmpeg-devel] [BROKEN] apad causes infinite hang

2024-06-17 Thread Nicolas George
Paul B Mahol (12024-06-17): > And once you close all buffersinks the EOF will and must propagate backward > to all not-closed filters and their in/out pads. Your analysis here is right, obviously. Closing a source for this bug makes no sense. Regards, -- Nicolas George ___

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-06-17 Thread Paul B Mahol
On Mon, Jun 17, 2024 at 4:52 PM Rémi Denis-Courmont wrote: > > > Le 17 juin 2024 13:18:11 GMT+02:00, Yigithan Yigit < > yigithanyigitde...@gmail.com> a écrit : > >--- > > libavfilter/af_volumedetect.c | 159 -- > > 1 file changed, 133 insertions(+), 26 deletions(-)

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

2024-06-17 Thread James Zern via ffmpeg-devel
On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer wrote: > > This or fifo needs to be freed on errors explicitly > I have not verified that its always safe to call vpx_free() this needs to be > checked before applying this > It should be safe to call into libvpx whether the encoder init succee

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 5:53 PM, James Almer wrote: > Maybe this should be an AVRational then. While that is probably 'more correct', it does mean that in 100% places this could be used, it'll have to be converted back to the -1 to 1 range. Is there a simple way to do that with an AVRational that doe

[FFmpeg-devel] [PATCH v2 2/2] avutil/macos_kperf: Fix assert which makes kperf failed to run

2024-06-17 Thread Zhao Zhili
From: Zhao Zhili On m1, kpc_get_counter_count(KPC_MASK) return 8 in my test. The exact value doesn't matter in our case, as long as we have a sufficiently large array Signed-off-by: Zhao Zhili --- libavutil/macos_kperf.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-)

[FFmpeg-devel] [PATCH v2 1/2] avutil/timer: Fix missing header for mach_absolute_time

2024-06-17 Thread Zhao Zhili
From: Zhao Zhili mach/mach_time.h was included only when CONFIG_MACOS_KPERF wasn't been defined. Signed-off-by: Zhao Zhili --- libavutil/timer.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/timer.h b/libavutil/timer.h index 6bd6a0c645..9fe6aa1385 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread James Almer
On 6/17/2024 10:41 AM, Derek Buitenhuis wrote: Based on what is in the files themselves, and what the API provides to users. URLs: * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye * https://developer.apple.com/documentation/videotoolbox/kvtcompre

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-06-17 Thread Rémi Denis-Courmont
Le 17 juin 2024 13:18:11 GMT+02:00, Yigithan Yigit a écrit : >--- > libavfilter/af_volumedetect.c | 159 -- > 1 file changed, 133 insertions(+), 26 deletions(-) > >diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c >index 327801a7f9..dbbcd0

[FFmpeg-devel] [PATCH] fate/lavf-container: add a hevc in ISOBMFF remux test

2024-06-17 Thread James Almer
Signed-off-by: James Almer --- tests/fate/lavf-container.mak | 2 ++ tests/ref/lavf-fate/hevc.mp4 | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 tests/ref/lavf-fate/hevc.mp4 diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index d84117c50f..56490c3369 10

[FFmpeg-devel] [PATCH 2/2] avformat/evc: fix writing reserved bits

2024-06-17 Thread James Almer
They are all zeroes, no ones. Signed-off-by: James Almer --- libavformat/evc.c | 4 ++-- tests/ref/lavf-fate/evc.mp4 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index 928ae1ff65..ff350aad21 100644 --- a/libavformat/evc.c

[FFmpeg-devel] [PATCH 1/2] avformat/evc: remove useless struct field

2024-06-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/evc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index 0b72a6441e..928ae1ff65 100644 --- a/libavformat/evc.c +++ b/libavformat/evc.c @@ -60,7 +60,6 @@ typedef struct EVCDecoderConfigurationRecord { uint8

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 2:41 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/mov.c | 279 ++ > 1 file changed, 279 insertions(+) Replaced by v3. - Derek ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
This box is provided by files created by the Apple Vision Pro, as well as the iPhone 15+ when capture for Vision Pro is enabled. The boxes are a mix of things documented by Apple in some PDFs, their API docs, and reverse engineering. Ideally we will have a real spec one day. Links: * https://d

[FFmpeg-devel] [PATCH v2 5/5] avformat/mov: Add support for reading and exporting horizontal field of view

2024-06-17 Thread Derek Buitenhuis
These boxes are created by the Apple Vision Pro and the iPhone 15+ when capture for the Vision Pro is enabled. Based off of the swift API: * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis --- libavformat

[FFmpeg-devel] [PATCH v2 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
This box is provided by files created by the Apple Vision Pro, as well as the iPhone 15+ when capture for Vision Pro is enabled. The boxes are a mix of things documented by Apple in some PDFs, their API docs, and reverse engineering. Ideally we will have a real spec one day. Links: * https://d

[FFmpeg-devel] [PATCH v2 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-17 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c| 8 tests/ref/fate/matroska-spherical-mono | 2 ++ tests/ref/fate/matroska-spherical-mono-remux | 4 tests/ref/fate/matroska-stereo_mode | 8 tests/ref/fate/matroska-vp8-alpha-r

[FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
Based on what is in the files themselves, and what the API provides to users. URLs: * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye * https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_stereocamerabaseline * https://

[FFmpeg-devel] [PATCH v2 1/5] avutil/spherical: Add more spherical types

2024-06-17 Thread Derek Buitenhuis
These originate from the Apple Vision Pro, and are documented here: https://developer.apple.com/documentation/coremedia/cmprojectiontype Signed-off-by: Derek Buitenhuis --- libavutil/spherical.c | 5 + libavutil/spherical.h | 16 libavutil/version.h | 2 +- 3 files

[FFmpeg-devel] [PATCH v2 0/5] Vision Pro Spatial Data

2024-06-17 Thread Derek Buitenhuis
* All comments applied from previous review. * Renamed rectangular to more industry standard rectilinear. Derek Buitenhuis (5): avutil/spherical: Add more spherical types avutil/stereo3d: Fill out stereo info provided by Vision Pro files fftools/ffprobe: Print more Stereo 3D info from side d

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

2024-06-17 Thread Nuo Mi
On Sun, Jun 16, 2024 at 11:26 PM Mark Thompson wrote: > On 15/06/2024 17:37, Frank Plowman wrote: > > n 15/06/2024 13:24, Nuo Mi wrote: > >> On Sat, Jun 15, 2024 at 2:35 PM Christophe Gisquet < > >> christophe.gisq...@gmail.com> wrote: > >> > >>> Le ven. 14 juin 2024, 11:39, Frank Plowman a > >>

Re: [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types

2024-06-17 Thread Derek Buitenhuis
On 6/14/2024 2:03 PM, Derek Buitenhuis wrote: > I think setting it to 0 (AV_STEREO3D_2D) is correct rather than this (and is > already > done), and I don't think we need to reorder. > > I had discussed this with Vittorio and it was decided that it was good to > disambiguate > between 2D (not ste

Re: [FFmpeg-devel] [PATCH 6/6] swscale/yuv2rgb/x86: remove mmx/mmxext yuv2rgb functions

2024-06-17 Thread Ramiro Polla
On Mon, Jun 17, 2024 at 1:16 AM James Almer wrote: > On 6/16/2024 7:28 PM, Ramiro Polla wrote: > > These functions are either slower or barely faster than the C LUT > > yuv2rgb code. > > --- > > libswscale/x86/yuv2rgb.c | 51 - > > libswscale/x86/yuv2rgb_template.c | 4

Re: [FFmpeg-devel] [PATCH v2] movenc: Add an option for hiding fragments at the end

2024-06-17 Thread Gyan Doshi via ffmpeg-devel
On 2024-06-17 04:08 pm, Martin Storsjö wrote: On Sat, 15 Jun 2024, Gyan Doshi wrote: On 2024-06-15 03:54 am, Dennis Sädtler via ffmpeg-devel wrote: On 2024-06-14 13:23, Gyan Doshi wrote: On 2024-06-14 04:35 pm, Timo Rothenpieler wrote: On 14/06/2024 12:44, Martin Storsjö wrote: On Fri, 1

Re: [FFmpeg-devel] [PATCH 2/2] avutil/macos_kperf: Fix assert which makes kperf failed to run

2024-06-17 Thread Zhao Zhili
> On Jun 17, 2024, at 19:10, Martin Storsjö wrote: > > On Wed, 12 Jun 2024, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> On m1, kpc_get_counter_count(KPC_MASK) return 8. The exact value >> doesn't matter in our case. > > This is somewhat unexpected, I had expected that this API was origina

Re: [FFmpeg-devel] [PATCH 1/2] avutil/timer: define macos kperf as AV_READ_TIME

2024-06-17 Thread Martin Storsjö
On Mon, 17 Jun 2024, Zhao Zhili wrote: On Jun 17, 2024, at 19:15, Martin Storsjö wrote: On Wed, 12 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili Firstly, make ff_kperf_cycles as an implementation of AV_READ_TIME avoids code duplication. Secondly, fix compilation error since 6a18c0bc87e

Re: [FFmpeg-devel] [PATCH 1/2] avutil/timer: define macos kperf as AV_READ_TIME

2024-06-17 Thread Zhao Zhili
> On Jun 17, 2024, at 19:15, Martin Storsjö wrote: > > On Wed, 12 Jun 2024, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> Firstly, make ff_kperf_cycles as an implementation of AV_READ_TIME >> avoids code duplication. >> >> Secondly, fix compilation error since 6a18c0bc87e when macos-kperf >

Re: [FFmpeg-devel] [PATCH 2/2] avutil/macos_kperf: Fix assert which makes kperf failed to run

2024-06-17 Thread J. Dekker
On Mon, Jun 17, 2024, at 13:10, Martin Storsjö wrote: > On Wed, 12 Jun 2024, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> On m1, kpc_get_counter_count(KPC_MASK) return 8. The exact value >> doesn't matter in our case. > > This is somewhat unexpected, I had expected that this API was originally >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/timer: define macos kperf as AV_READ_TIME

2024-06-17 Thread Martin Storsjö
On Mon, 17 Jun 2024, Martin Storsjö wrote: On Wed, 12 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili Firstly, make ff_kperf_cycles as an implementation of AV_READ_TIME avoids code duplication. Secondly, fix compilation error since 6a18c0bc87e when macos-kperf is enabled. mach_time.h is includ

[FFmpeg-devel] [PATCH 3/3] avfilter/af_volumedetect.c: reindent after last commit

2024-06-17 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 68 +-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index dbbcd037a5..b78b073c09 100644 --- a/libavfilter/af_volumedetect.c +++ b/libavfilter/af_vol

[FFmpeg-devel] [PATCH 2/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-06-17 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 159 -- 1 file changed, 133 insertions(+), 26 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 327801a7f9..dbbcd037a5 100644 --- a/libavfilter/af_volumedetect.c +++ b/libavfilter/af_vo

[FFmpeg-devel] [PATCH 1/3] avfilter/af_volumedetect.c: Move logdb function

2024-06-17 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 8b001d1cf2..327801a7f9 100644 --- a/libavfilter/af_volumedetect.c +++ b/libavfilter/af_volumedetect.c @@

[FFmpeg-devel] [PATCH 0/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-06-17 Thread Yigithan Yigit
This patchset adds 32bit float audio support to the volumedetect filter and fixes issue #9613. This work is part of my GSoC 2024 Qualification Task. I would greatly appreciate your review of this patcset. Thanks for your time and consideration. Yigithan Yigit (3): avfilter/af_volumedetect.c: M

Re: [FFmpeg-devel] [PATCH 1/2] avutil/timer: define macos kperf as AV_READ_TIME

2024-06-17 Thread Martin Storsjö
On Wed, 12 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili Firstly, make ff_kperf_cycles as an implementation of AV_READ_TIME avoids code duplication. Secondly, fix compilation error since 6a18c0bc87e when macos-kperf is enabled. mach_time.h is included only when CONFIG_MACOS_KPERF is 0. The err

Re: [FFmpeg-devel] [PATCH 2/2] avutil/macos_kperf: Fix assert which makes kperf failed to run

2024-06-17 Thread Martin Storsjö
On Wed, 12 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili On m1, kpc_get_counter_count(KPC_MASK) return 8. The exact value doesn't matter in our case. This is somewhat unexpected, I had expected that this API was originally tested on an m1. I guess it might depend on what OS version you're us

Re: [FFmpeg-devel] [PATCH 37/57] avcodec/mpegutils: Don't output wrong mb skip values

2024-06-17 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Jun 12, 2024 at 03:48:33PM +0200, Andreas Rheinhardt wrote: >> The earlier code had two problems: >> 1. For reference frames that are not directly output (happens unless >> low_delay is set), the mb skip values referred to the next reference >> frame to be decoded. >>

Re: [FFmpeg-devel] [PATCH v2] movenc: Add an option for hiding fragments at the end

2024-06-17 Thread Martin Storsjö
On Sat, 15 Jun 2024, Gyan Doshi wrote: On 2024-06-15 03:54 am, Dennis Sädtler via ffmpeg-devel wrote: On 2024-06-14 13:23, Gyan Doshi wrote: On 2024-06-14 04:35 pm, Timo Rothenpieler wrote: On 14/06/2024 12:44, Martin Storsjö wrote: On Fri, 14 Jun 2024, Gyan Doshi wrote: On 2024-06-14 02:

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-17 Thread Zhao Zhili
> On Jun 17, 2024, at 16:45, Hendrik Leppkes wrote: > > On Mon, Jun 17, 2024 at 10:03 AM Zhao Zhili wrote: >> >> >> >>> On Jun 17, 2024, at 15:05, Anton Khirnov wrote: >>> >>> Quoting Zhao Zhili (2024-06-17 07:19:26) From: Zhao Zhili When thread_count be zero, it will be

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-17 Thread Hendrik Leppkes
On Mon, Jun 17, 2024 at 10:03 AM Zhao Zhili wrote: > > > > > On Jun 17, 2024, at 15:05, Anton Khirnov wrote: > > > > Quoting Zhao Zhili (2024-06-17 07:19:26) > >> From: Zhao Zhili > >> > >> When thread_count be zero, it will be run on current thread like > >> !HAVE_THREADS. > > > > Other APIs tr

Re: [FFmpeg-devel] [PATCH v1] lavc/hevcdec: Put slice address checking after hwaccel decode slice

2024-06-17 Thread Anton Khirnov
Quoting fei.w.wang-at-intel@ffmpeg.org (2024-06-14 10:18:19) > From: Fei Wang > > Slice address tab only been updated in software decode slice data. > > Fixes hwaccel decoding after d725c737fe2a19091b481d4d115fd939e0a674b2. > > Signed-off-by: Fei Wang > --- > libavcodec/hevc/hevcdec.c | 1

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-17 Thread Zhao Zhili
> On Jun 17, 2024, at 15:05, Anton Khirnov wrote: > > Quoting Zhao Zhili (2024-06-17 07:19:26) >> From: Zhao Zhili >> >> When thread_count be zero, it will be run on current thread like >> !HAVE_THREADS. > > Other APIs treat zero to mean "auto". executor don’t detect cpu cores by itself. It

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/smcenc: width < 4 is unsupported

2024-06-17 Thread Paul B Mahol
On Mon, Jun 17, 2024 at 1:09 AM Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 68939/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMC_fuzzer-587804104884224 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [BROKEN] apad causes infinite hang

2024-06-17 Thread Paul B Mahol
On Mon, Jun 17, 2024 at 9:24 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2024-06-14 14:19:13) > > Just try with: > > > > ffmpeg -f lavfi -i sine=d=30 -af apad -f null - > > > > Pressing 'q' will not stop it at all, because current ffmpeg code will > try > > to flush all frames, but because pa

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-17 Thread Anton Khirnov
No tests? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

2024-06-17 Thread Paul B Mahol
On Mon, Jun 17, 2024 at 1:09 AM Michael Niedermayer wrote: > Ive been told that someone at the BCN video tech meetup claimed to be the > "release maintainer for FFmpeg". > > That is nothing, I see many claims in many such videos and on many platforms that they are developer/maintainer of FFmpeg w

Re: [FFmpeg-devel] [BROKEN] apad causes infinite hang

2024-06-17 Thread Anton Khirnov
Quoting Paul B Mahol (2024-06-14 14:19:13) > Just try with: > > ffmpeg -f lavfi -i sine=d=30 -af apad -f null - > > Pressing 'q' will not stop it at all, because current ffmpeg code will try > to flush all frames, but because pad filter never receives EOF from next > filter in chain (sink) it wil

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

2024-06-17 Thread Anton Khirnov
Quoting Mark Thompson (2024-06-16 17:26:26) > Is there some requirement in H.266 that in a single stream the PPS precedes > the SPS? > > Currently we effectively require that for a single stream because we use the > SPS to enforce constraints on the PPS in both H.265 and H.266, but I'm not > se

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-17 Thread Paul B Mahol
On Mon, Jun 17, 2024 at 9:05 AM Anton Khirnov wrote: > Quoting Zhao Zhili (2024-06-17 07:19:26) > > From: Zhao Zhili > > > > When thread_count be zero, it will be run on current thread like > > !HAVE_THREADS. > > Other APIs treat zero to mean "auto". > Agreed, this approach for 0 to mean do it

Re: [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

2024-06-17 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-17 01:08:29) > Ive been told that someone at the BCN video tech meetup claimed to be the > "release maintainer for FFmpeg". > > If you have any doubt who maintains releases, just do something like the > following and look at the output: > VER=5.1 > echo commit

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-17 Thread Anton Khirnov
Quoting Zhao Zhili (2024-06-17 07:19:26) > From: Zhao Zhili > > When thread_count be zero, it will be run on current thread like > !HAVE_THREADS. Other APIs treat zero to mean "auto". -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg