Re: [FFmpeg-devel] [PATCH v2] lavc/qsvdec: Add vvc_mp4toannexb bsf for QSV VVC decoder

2024-08-15 Thread Xiang, Haihao
On Do, 2024-08-15 at 10:19 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Fix error: > $ ffmpeg -hwaccel qsv -i input.mp4 -f null - > .. > [vvc_qsv @ 026890D966C0] Error decoding stream header: unknown error (-1) > [vvc_qsv @ 026890D966C0] Error decoding header > >

Re: [FFmpeg-devel] [PATCH] avfilter: inherit input color range for videotoolbox filters

2024-08-15 Thread Zhao Zhili
> On Aug 16, 2024, at 10:06, gnattu via ffmpeg-devel > wrote: > > The color range should be set to match the input when creating > the VideoToolbox context. Otherwise, the new context will default > to limited range, creates inconsistencies with full range inputs. LGTM, thanks. > > Signed-

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: always release supported_props

2024-08-15 Thread Zhao Zhili
> On Aug 15, 2024, at 22:02, Gnattu OC via ffmpeg-devel > wrote: > > > >> On Aug 15, 2024, at 19:59, Zhao Zhili wrote: >> >> >> >>> On Aug 10, 2024, at 14:06, gnattu via ffmpeg-devel >>> wrote: >>> >>> In vtenc_populate_extradata, supported_props should always be released >>> to avoid

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: correctly reset subtitle stream counter per-varstream

2024-08-15 Thread Steven Liu
Timo Rothenpieler 于2024年8月16日 周五08:03写道: > Without resetting it, if there was a previous set of varstreams with > subtitles, it would subtract from all the streams, leading to chaos and > segfaults when trying to access for example stream -1. > --- > libavformat/hlsenc.c | 2 +- > 1 file changed,

[FFmpeg-devel] [PATCH] avfilter: inherit input color range for videotoolbox filters

2024-08-15 Thread gnattu via ffmpeg-devel
The color range should be set to match the input when creating the VideoToolbox context. Otherwise, the new context will default to limited range, creates inconsistencies with full range inputs. Signed-off-by: Gnattu OC --- libavfilter/vf_scale_vt.c | 1 + libavfilter/vf_transpose_vt.c

[FFmpeg-devel] [PATCH] avformat/hlsenc: correctly reset subtitle stream counter per-varstream

2024-08-15 Thread Timo Rothenpieler
Without resetting it, if there was a previous set of varstreams with subtitles, it would subtract from all the streams, leading to chaos and segfaults when trying to access for example stream -1. --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavform

[FFmpeg-devel] [PATCH] web/index: Add news entry about coverity

2024-08-15 Thread Michael Niedermayer
Based on suggestion of Jonatas CC: "Jonatas L. Nogueira" --- src/index | 8 1 file changed, 8 insertions(+) diff --git a/src/index b/src/index index 73e9a4c..b44f384 100644 --- a/src/index +++ b/src/index @@ -35,6 +35,14 @@ News + August 15th, 2024, Coverity + + The numb

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add more fields based on the linux kernel MAINTAINERs

2024-08-15 Thread Michael Niedermayer
On Thu, Aug 15, 2024 at 07:38:50PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-08-15 09:33:07) > > Text was stolen from the linux kernel > > This is thus identical to the kernel just a different more compact format. > > I am very happy also to switch the file entirely to the for

Re: [FFmpeg-devel] MV-HEVC support for decoding of Apple's stereo video

2024-08-15 Thread Danny Hong
Quoting Anton Khirnov (2024-08-15 19:36:47) > Yes, it should be submitted to ML within a few months. Thank you for the info! This is great! We have experience with HEVC implementation and also with the layered use case. If there is anything we can help out with the development please let us kn

Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-08-15 Thread Niklas Haas
On Thu, 04 Jul 2024 16:30:57 +0200 Niklas Haas wrote: > From: Niklas Haas > > Based on my best understanding of what they do, given the source code. > --- > libswscale/swscale.h | 28 ++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/libswscale/sw

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add more fields based on the linux kernel MAINTAINERs

2024-08-15 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-08-15 09:33:07) > Text was stolen from the linux kernel > This is thus identical to the kernel just a different more compact format. > I am very happy also to switch the file entirely to the format of the linux > kernel maintainer list > if people prefer > > This

Re: [FFmpeg-devel] MV-HEVC support for decoding of Apple's stereo video

2024-08-15 Thread Anton Khirnov
Quoting Danny Hong (2024-08-15 17:57:20) > Hello, is there a plan to add the multiview extension to HEVC for full > stereo video decoding? Yes, it should be submitted to ML within a few months. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-deve

[FFmpeg-devel] MV-HEVC support for decoding of Apple's stereo video

2024-08-15 Thread Danny Hong
Hello, is there a plan to add the multiview extension to HEVC for full stereo video decoding? If not, is FFmpeg open to the idea of receiving contributions for the multiview extension? It seems like at least the parsing of Apple’s HEVC stereo video metadata and high level syntax for multilayer ha

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideoencdsp: add aarch64 pix_sum and pix_norm1

2024-08-15 Thread Ramiro Polla
On Tue, Aug 13, 2024 at 9:46 AM Rémi Denis-Courmont wrote: > Le 13 août 2024 10:45:15 GMT+03:00, "Rémi Denis-Courmont" a > écrit : > >Le 9 août 2024 14:27:27 GMT+03:00, Ramiro Polla a > >écrit : > >>checkasm --bench for Raspberry Pi 5 Model B Rev 1.0: > >>pix_norm1_c: 235.7 > >>pix_norm1_neon:

[FFmpeg-devel] [PATCH] avcodec/aarch64/me_cmp: add dotprod implementations of sse16 and vsse_intra16

2024-08-15 Thread Ramiro Polla
checkasm --bench for Raspberry Pi 5 Model B Rev 1.0: sse_0_c: 241.5 sse_0_neon: 37.2 sse_0_dotprod: 22.2 vsse_4_c: 148.7 vsse_4_neon: 31.0 vsse_4_dotprod: 15.7 --- libavcodec/aarch64/me_cmp_init_aarch64.c | 14 +++ libavcodec/aarch64/me_cmp_neon.S | 114 +++ 2 files ch

Re: [FFmpeg-devel] [PATCH v2 0/5] swscale/yuv2rgb: add yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-08-15 Thread Ramiro Polla
On Tue, Aug 6, 2024 at 12:51 PM Ramiro Polla wrote: > > Changes from v1: > - multi-planar rgb for YUV2RGBFUNC no longer uses an array in the stack, > since that gave an overall 1% slowdown because some variables would no > longer be stored in registers. > > Ramiro Polla (5): > swscale/yuv2rg

Re: [FFmpeg-devel] [PATCH 4/4] swscale/aarch64: add nv24/nv42 to yuv420p unscaled converter

2024-08-15 Thread Ramiro Polla
On Wed, Aug 14, 2024 at 7:21 PM Martin Storsjö wrote: > On Fri, 9 Aug 2024, Ramiro Polla wrote: > > checkasm --bench for Raspberry Pi 5 Model B Rev 1.0: > > nv24_yuv420p_128_c: 423.0 > > nv24_yuv420p_128_neon: 115.7 > > nv24_yuv420p_1920_c: 5939.5 > > nv24_yuv420p_1920_neon: 1339.7 > > nv42_yuv420

Re: [FFmpeg-devel] [PATCH 2/4] checkasm/yuv2yuv: add tests for semiplanar unscaled converters

2024-08-15 Thread Ramiro Polla
On Fri, Aug 9, 2024 at 1:26 PM Ramiro Polla wrote: > > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/sw_yuv2yuv.c | 131 > 4 files changed, 134 insertions(+), 1 deleti

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: always release supported_props

2024-08-15 Thread Gnattu OC via ffmpeg-devel
> On Aug 15, 2024, at 19:59, Zhao Zhili wrote: > > > >> On Aug 10, 2024, at 14:06, gnattu via ffmpeg-devel >> wrote: >> >> In vtenc_populate_extradata, supported_props should always be released >> to avoid memory leak. >> >> Regression from cd2f8a22e94700c68b1de7968df11e8bebfd315b >> >>

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/vvc/cabac: remove vvc_refill2

2024-08-15 Thread Nuo Mi
On Sun, Aug 11, 2024 at 4:33 AM wrote: > From: Wu Jianhua > > The vvc_refill2 is the same as the refill2 in cabac_functions. > Remove it to reduce duplicated codes. > > Signed-off-by: Wu Jianhua > --- > libavcodec/cabac_functions.h | 2 +- > libavcodec/vvc/cabac.c | 28 +

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: move frame tab memset from the main thread to worker threads

2024-08-15 Thread Nuo Mi
On Sun, Aug 11, 2024 at 10:01 PM Nuo Mi wrote: > > > On Sun, Jul 28, 2024 at 11:19 AM Nuo Mi wrote: > >> memset tables in the main thread can become a bottleneck for the decoder. >> For example, if it takes 1% of the processing time for one core, the >> maximum achievable FPS will be 100. >> Mov

Re: [FFmpeg-devel] [PATCH 3/3] checkasm: add tests for vvc dmvr

2024-08-15 Thread Nuo Mi
On Sun, Aug 11, 2024 at 10:00 PM Nuo Mi wrote: > will apply next week if there are no objections > Done. Thank you James for reviewing. > > On Fri, Jul 26, 2024 at 3:42 PM Nuo Mi wrote: > >> >> >> On Fri, Jul 26, 2024 at 9:36 AM James Almer wrote: >> >>> On 7/25/2024 10:35 AM, Nuo Mi wrote: >>

Re: [FFmpeg-devel] [PATCH 6/7] avutil/riscv/asm: add generic push/pop helpers

2024-08-15 Thread Niklas Haas
On Tue, 13 Aug 2024 18:55:24 +0300 Rémi Denis-Courmont wrote: > > > Le 13 août 2024 17:03:35 GMT+03:00, "J. Dekker" a écrit : > >From: Niklas Haas > > > >Generic helper macros to push/pop multiple registers at once. Expands to > >a single `addi` plus a sequence of XLEN-sized stores/loads. > >-

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB

2024-08-15 Thread Zhao Zhili
> On Aug 10, 2024, at 17:52, epira...@gmail.com wrote: > > On 10 Aug 2024, at 8:13, gnattu via ffmpeg-devel wrote: > >> Hardware frames with RGB colorspace will not have a YCbCrMatrixKey. >> Currently, it will spam the console with warning if rgb frame is >> uploaded. > > Thanks, LGTM Applie

Re: [FFmpeg-devel] [PATCH v1] libavdevice/gdigrab: change hwnd tail check fail logic to !=null

2024-08-15 Thread Zhao Zhili
> On Aug 8, 2024, at 23:46, Zhao Zhili wrote: > > >> On Aug 7, 2024, at 23:58, cyfdel-at-hotmail@ffmpeg.org wrote: >> >> From: eaphone >> >> --- >> libavdevice/gdigrab.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavdevice/gdigrab.c b/libavdevice/gdig

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: always release supported_props

2024-08-15 Thread Zhao Zhili
> On Aug 10, 2024, at 14:06, gnattu via ffmpeg-devel > wrote: > > In vtenc_populate_extradata, supported_props should always be released > to avoid memory leak. > > Regression from cd2f8a22e94700c68b1de7968df11e8bebfd315b > > Signed-off-by: gnattu > --- > libavcodec/videotoolboxenc.c | 13 +

Re: [FFmpeg-devel] [PATCH] libavcodec/arm/mlpdsp_armv5te: fix label format to work with binutils 2.43

2024-08-15 Thread Sebastian Ramacher
On 2024-08-13 23:24:06 +0300, Martin Storsjö wrote: > On Fri, 9 Aug 2024, Ross Burton wrote: > > > binutils 2.43 has stricter validation for labels[1] and results in errors > > when building ffmpeg for armv5: > > > > src/libavcodec/arm/mlpdsp_armv5te.S:232: Error: junk at end of line, first > >

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add more fields based on the linux kernel MAINTAINERs

2024-08-15 Thread Michael Niedermayer
Hi On Thu, Aug 15, 2024 at 11:24:31AM +0300, Rémi Denis-Courmont wrote: > > > Le 15 août 2024 10:33:07 GMT+03:00, Michael Niedermayer > a écrit : > >Text was stolen from the linux kernel > >This is thus identical to the kernel just a different more compact format. > >I am very happy also to sw

Re: [FFmpeg-devel] [PATCH] lavc/libx265: unbreak build for X265_BUILD >= 210

2024-08-15 Thread Gyan Doshi
On 2024-08-14 10:01 am, Gyan Doshi wrote: On 2024-08-11 04:03 pm, Gyan Doshi wrote: x265 added support for alpha starting with build 210. While doing so, x265_encoder_encode() changed its fifth arg to an array of pointers to x265_picture. This broke building lavc/libx265.c This patch simpl

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add more fields based on the linux kernel MAINTAINERs

2024-08-15 Thread Rémi Denis-Courmont
Le 15 août 2024 10:33:07 GMT+03:00, Michael Niedermayer a écrit : >Text was stolen from the linux kernel >This is thus identical to the kernel just a different more compact format. >I am very happy also to switch the file entirely to the format of the linux >kernel maintainer list >if people p

Re: [FFmpeg-devel] [PATCH v4 0/1] lavfi/vf_gopromax_opencl: add GoPor Max 360 video filter

2024-08-15 Thread TADANO Tokumei
ping On 2024/08/03 9:56, TADANO Tokumei wrote: This is updated patch of: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3943 I contacted to Ronan LE MEILLAT and agreed with him to submit new patch. Abstruct of GoPro Max .360 video file format is described in: https://gopro.com/news/ma

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

2024-08-15 Thread Rémi Denis-Courmont
Le 3 août 2024 13:30:34 GMT+03:00, u...@foxmail.com a écrit : >From: sunyuechi > > C908 X60 >avg_8_2x2_c:1.21.0 >avg_8_2x2_rvv_i32 :0.70.7 >avg_8_2x4_c

[FFmpeg-devel] [PATCH] MAINTAINERS: Add more fields based on the linux kernel MAINTAINERs

2024-08-15 Thread Michael Niedermayer
Text was stolen from the linux kernel This is thus identical to the kernel just a different more compact format. I am very happy also to switch the file entirely to the format of the linux kernel maintainer list if people prefer This allows tracking the status of each sub system, if it needs new

Re: [FFmpeg-devel] [PATCH] vulkan: remove AVClass * from the context, use a logging pointer

2024-08-15 Thread Lynne via ffmpeg-devel
On 14/08/2024 12:18, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: The issue is that VulkanContext mostly always used the AVClass * from its structure, which we don't set in decode. --- libavcodec/vulkan_decode.c| 2 ++ libavfilter/vf_avgblur_vulkan.c | 2 ++ libavfilter/vf_b

Re: [FFmpeg-devel] [PATCH 2/5] MAINTAINERS: some random updating

2024-08-15 Thread Michael Niedermayer
On Thu, Aug 15, 2024 at 12:09:51PM +0530, Gyan Doshi wrote: > > > On 2024-08-15 04:07 am, Michael Niedermayer wrote: > > Adding level to some of my entries > > Adding level to some random entries of other people who i have seen > > actively maintaining their code > > removing some people who hav