Re: [FFmpeg-devel] [PATCH 4/7] lavfi/avfilter: document AVFilterContext.is_disabled as private

2024-10-03 Thread Anton Khirnov
Quoting epira...@gmail.com (2024-10-03 21:47:59) > > > On 3 Oct 2024, at 21:31, Anton Khirnov wrote: > > > Ideally there should be three parts to the filter context - public, > > private to the filter, and private to generic code, but only the first > > and the last of these exist currently. Unt

Re: [FFmpeg-devel] RFC - Uncompressed MP4

2024-10-03 Thread martin schitter
On 04.10.24 01:33, Devon Sookhoo wrote: Once completed, I envision the following command to work: $ ffmpeg -i input.mp4 -c:v rawvideo output.mp4 Why do you choose the term "raw" instead of uncompressed? Using this format for "raw" bayer CFA data is just one possible application of ISO/

Re: [FFmpeg-devel] RFC - Uncompressed MP4

2024-10-03 Thread Devon Sookhoo
Sounds good, I will put together a complete implementation with crs tests for submission. Once completed, I envision the following command to work: $ ffmpeg -i input.mp4 -c:v rawvideo output.mp4 Does this warrant a new mpeg_rawenc.c file under /libavcodec? Or should an existing file be extende

Re: [FFmpeg-devel] [PATCH 4/7] lavfi/avfilter: document AVFilterContext.is_disabled as private

2024-10-03 Thread epirat07
On 3 Oct 2024, at 21:31, Anton Khirnov wrote: > Ideally there should be three parts to the filter context - public, > private to the filter, and private to generic code, but only the first > and the last of these exist currently. Until the second is implemented, > this is better than nothing. >

[FFmpeg-devel] [PATCH 3/7] lavfi/avfilter: move AVFilterContext.command_queue to FFFilterContext

2024-10-03 Thread Anton Khirnov
It is private to generic filtering code. --- libavfilter/avfilter.c | 13 +++-- libavfilter/avfilter.h | 4 libavfilter/avfilter_internal.h | 2 ++ libavfilter/avfiltergraph.c | 3 ++- 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/libavfilter

[FFmpeg-devel] [PATCH 7/7] fftools/ffmpeg_filter: stop setting a no-op option

2024-10-03 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 2ff7c4c4f4..28c5223c5d 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1586,15 +1586,9 @@ static int configure

[FFmpeg-devel] [PATCH 2/7] lavfi/avfilter: move AVFilterContext.{enable, var_values} to FFFilterContext

2024-10-03 Thread Anton Khirnov
They are private to generic filtering code. --- libavfilter/avfilter.c | 38 ++--- libavfilter/avfilter.h | 9 ++-- libavfilter/avfilter_internal.h | 5 + 3 files changed, 33 insertions(+), 19 deletions(-) diff --git a/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 4/7] lavfi/avfilter: document AVFilterContext.is_disabled as private

2024-10-03 Thread Anton Khirnov
Ideally there should be three parts to the filter context - public, private to the filter, and private to generic code, but only the first and the last of these exist currently. Until the second is implemented, this is better than nothing. --- libavfilter/avfilter.h | 7 ++- 1 file changed, 6

[FFmpeg-devel] [PATCH 1/7] lavfi/avfilter: move AVFilterContext.ready to FFFilterContext

2024-10-03 Thread Anton Khirnov
This field is private to the generic filtering code. --- libavfilter/avfilter.c | 9 ++--- libavfilter/avfilter.h | 7 --- libavfilter/avfilter_internal.h | 7 +++ libavfilter/avfiltergraph.c | 18 +++--- libavfilter/version_major.h | 1 + 5 fi

[FFmpeg-devel] [PATCH 6/7] lavfi/avfilter: drop ff_ prefixes from static functions

2024-10-03 Thread Anton Khirnov
--- libavfilter/avfilter.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 3295ffb18c..f7ab908599 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -522,7 +522,7 @@ static int64_t gue

[FFmpeg-devel] [PATCH 5/7] lavfi/avfilter: make ff_inlink_evaluate_timeline_at_frame() static

2024-10-03 Thread Anton Khirnov
It is not used outside of avfilter.c --- libavfilter/avfilter.c | 62 ++--- libavfilter/avfilter_internal.h | 8 - 2 files changed, 34 insertions(+), 36 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 86bf7773e1..3295ffb18c

[FFmpeg-devel] [PATCH v2] configure: suggest installing nasm before using --disable-x86asm

2024-10-03 Thread vipyne
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0247ea08d6..a9a4a0e286 100755 --- a/configure +++ b/configure @@ -6464,7 +6464,7 @@ EOF for program in $x86asmexe nasm yasm; do probe_x86asm $program && break

Re: [FFmpeg-devel] RFC - Uncompressed MP4

2024-10-03 Thread Tomas Härdin
> > As suggested, this next patch uses av_pix_fmt_desc_get() to get the > > nb_components > > > > What is considered sufficient for testing? Is this done by running > > fate? > > I mean adding tests to FATE. Are there any reference files we could > use? Wups, I forgot this is a muxer patch, so r

Re: [FFmpeg-devel] RFC - Uncompressed MP4

2024-10-03 Thread Tomas Härdin
tor 2024-10-03 klockan 10:52 -0600 skrev Devon Sookhoo: > >  "mov_write_uncC_tag() doesn't seem to be called from anywhere" > > Yes, I wanted to divide my contributions up into small sections that > are > easy to review. However, this means that each contribution isn't a > full > implementation wh

Re: [FFmpeg-devel] [PATCH v9 4/6] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-03 Thread Michael Niedermayer
On Mon, Sep 23, 2024 at 11:16:45AM +0200, Martin Schitter wrote: [...] > +static av_cold int dnxuc_decode_init(AVCodecContext *avctx) > +{ > +return 0; > +} unneeded [...] > +/* DNxUncompressed utilizes a very dense bitpack representation of 10bit and > 12bit pixel data. > + > +Lines of I

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ffv1enc: Correct error message about unsupported version

2024-10-03 Thread Michael Niedermayer
On Tue, Oct 01, 2024 at 10:31:24PM +0200, Michael Niedermayer wrote: > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF673

[FFmpeg-devel] [PATCH 2/2] avcodec/hevc/ps: print a more accurate message when parsing an SPS for an unsupported layer

2024-10-03 Thread James Almer
With multilayer001.heic: Before: [hevc @ ...] Scalability type 2 not supported [hevc @ ...] Ignoring unsupported VPS extension [hevc @ ...] The following bit-depths are currently specified: 8, 9, 10 and 12 bits, chroma_format_idc is 0, depth is 0 After: [hevc @ ...] Scalability type 2 not suppor

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc/ps: print the correct unsupported scalability value found

2024-10-03 Thread James Almer
With multilayer001.heic, which signals Spatial scalability: Before: [hevc @ ...] Scalability type 1 not supported [hevc @ ...] Ignoring unsupported VPS extension After: [hevc @ ...] Scalability type 2 not supported [hevc @ ...] Ignoring unsupported VPS extension Signed-off-by: James Almer ---

Re: [FFmpeg-devel] [External] Re: Question Regarding Removal of Blowfish from libavutil in FFmpeg

2024-10-03 Thread Michael Niedermayer
Hi On Wed, Oct 02, 2024 at 09:06:46AM +, Kumar, Rahul via ffmpeg-devel wrote: > Thank you for the prompt response. > > The primary reason for removing Blowfish from our codebase is to comply with > modern security guidelines and industry standards that discourage the use of > outdated crypt

[FFmpeg-devel] [PATCH] avcodec/mediacodecenc: Fix access of uninitialized value

2024-10-03 Thread Zhao Zhili
From: Zhao Zhili When crop is skipped, av_strlcatf will access `str` which isn't initialized properly. --- libavcodec/mediacodecenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index 6ca3968a24..e76ea81236 100644 --

[FFmpeg-devel] [PATCH v2 2/2] fftools: log unconnected filter output label

2024-10-03 Thread Marvin Scholz
--- fftools/ffmpeg_filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index ddcd18dd15..b1ca710999 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1410,7 +1410,9 @@ int fg_finalise_bindings(void)

[FFmpeg-devel] [PATCH v2 1/2] fftools: do not access out of bounds filtergraph

2024-10-03 Thread Marvin Scholz
The log message was logged for `filtergraphs[j]` which would cause a heap buffer overflow in certain circumstances. Correctly it should be logged for the current filtergraph, so just use `fg` here. --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fft

Re: [FFmpeg-devel] [PATCH 1/2] fftools: do not access out of bounds filtergraph

2024-10-03 Thread Anton Khirnov
Quoting Marvin Scholz (2024-10-01 02:57:11) > The log message was logged for `filtergraphs[j]` which would cause a > heap buffer overflow in certain circumstances. > > Correctly it should be logged for the current filtergraph, so just > use `fg` here. > --- > fftools/ffmpeg_filter.c | 2 +- > 1 f

Re: [FFmpeg-devel] RFC - Uncompressed MP4

2024-10-03 Thread Devon Sookhoo
> "mov_write_uncC_tag() doesn't seem to be called from anywhere" Yes, I wanted to divide my contributions up into small sections that are easy to review. However, this means that each contribution isn't a full implementation which is why mov_write_uncC_tag() isn't called yet. Is this an appropria

Re: [FFmpeg-devel] [PATCH 2/2] configure: allow mixed declarations and code for Objective-C

2024-10-03 Thread Zhao Zhili
> On Sep 26, 2024, at 07:43, Marvin Scholz wrote: > > Mixing declarations and code is quite common in Objective-C (as can be > seen by the number of warnings we have for this in Objective-C files) > and forcing to not do it usually results in worse code, with unnecessary > widely scoped variab

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/img2enc: Fix integer truncation when frame_pts is enabled

2024-10-03 Thread Zhao Zhili
> On Sep 30, 2024, at 00:06, Filip Mašić wrote: > >>> >>> On Sep 29, 2024, at 08:05, Michael Niedermayer >> wrote: >>> >>> On Tue, Sep 24, 2024 at 12:16:13AM +0800, Zhao Zhili wrote: From: Zhao Zhili --- libavformat/img2enc.c | 8 1 file changed, 4 insertio

[FFmpeg-devel] [PATCH] avcodec/ffv1: RCT is only possible with RGB

2024-10-03 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 2 +- libavcodec/ffv1enc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index da31b863da5..932b2de0ff7 100644 --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c

[FFmpeg-devel] [PATCH 5/5] Revert "x86/tx_float: set all operands for shufps"

2024-10-03 Thread Lynne via ffmpeg-devel
This reverts commit 74f5fb6db899dbc4fde9ccf77f37256ddcb9. --- libavutil/x86/tx_float.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/x86/tx_float.asm b/libavutil/x86/tx_float.asm index cec7465d6e..434ca60aae 100644 --- a/libavutil/x86/tx_float.asm +++ b/li

[FFmpeg-devel] [PATCH 4/5] Revert "x86/tx_float: add missing check for AVX2"

2024-10-03 Thread Lynne via ffmpeg-devel
This reverts commit f4097e4c1f1bb244cae78c363a69d5e84495b616. --- libavutil/x86/tx_float.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/x86/tx_float.asm b/libavutil/x86/tx_float.asm index 570dcb4c9c..cec7465d6e 100644 --- a/libavutil/x86/tx_float.asm +++ b/libavu

[FFmpeg-devel] [PATCH 3/5] Revert "x86/tx_float: add missing preprocessor wrapper for AVX2 functions"

2024-10-03 Thread Lynne via ffmpeg-devel
This reverts commit 750f378becf15c0552c45a66a66aca7cc506d490. --- libavutil/x86/tx_float.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/x86/tx_float.asm b/libavutil/x86/tx_float.asm index 16165580a6..570dcb4c9c 100644 --- a/libavutil/x86/tx_float.asm +++ b/libavu

[FFmpeg-devel] [PATCH 2/5] Revert "x86/tx_float: change a condition in a preprocessor check"

2024-10-03 Thread Lynne via ffmpeg-devel
This reverts commit 0d8f43c74d0b1039ba70aacb4c9c7768e8bebf9f. --- libavutil/x86/tx_float.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/x86/tx_float.asm b/libavutil/x86/tx_float.asm index 42006848f1..16165580a6 100644 --- a/libavutil/x86/tx_float.asm +++ b/libavu

[FFmpeg-devel] [PATCH 1/5] configure: drop yasm support

2024-10-03 Thread Lynne via ffmpeg-devel
We started defauling to nasm 8 years ago. We are still compatible with yasm 0.8.0, released in 2009. **15 years ago**. The time has more than come to remove support for it. Maintaining compatibility started cutting into writing new code long ago. We still can't have 2-argument instructions, prepro