[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: fix unused variable warning

2025-06-26 Thread Marvin Scholz
Resolves an unused variable warning when targeting a recent appleOS version. --- libavutil/hwcontext_videotoolbox.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 172683121f..102fa485e5 100644 --

[FFmpeg-devel] [PATCH v2] avcodec/vvc/refs: remove early return

2025-06-26 Thread Marvin Scholz
The ret value is checked later on again, so this check is redundant and would cause the frame to not be unrefd on failure as well. So remove this check and add one before av_frame_remove_side_data to ensure it is not called with an invalid frame. Fix CID 1648350 --- libavcodec/vvc/refs.c | 5 ++-

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/refs: remove dead code

2025-06-26 Thread Frank Plowman
On 27/06/2025 22:49, Marvin Scholz wrote: > The ret value is already checked earlier, making this condition > impossible to ever happen. > > Fix CID 1648350 > --- > libavcodec/vvc/refs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c > ind

Re: [FFmpeg-devel] [PATCH 2/2] fftools/textformat: renamings in print_unit_int for consistency (cosmetic)

2025-06-26 Thread Marvin Scholz
On 23 Jun 2025, at 0:10, softworkz . wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Nicolas Gaullier >> Sent: Freitag, 20. Juni 2025 13:08 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Nicolas Gaullier >> Subject: [FFmpeg-devel] [PATCH 2/2] fftools/textformat: renamings >>

Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers

2025-06-26 Thread Marvin Scholz
On 23 Jun 2025, at 0:04, softworkz . wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Nicolas Gaullier >> Sent: Freitag, 20. Juni 2025 13:08 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Nicolas Gaullier >> Subject: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print >>

Re: [FFmpeg-devel] [PATCH v2] configure: add -Wl when linker is called indirectly

2025-06-26 Thread Kacper Michajlow
On Fri, 20 Jun 2025 at 01:52, Kacper Michajłow wrote: > > It's possible to call linker indirectly through driver like Clang. In > which cases linker args has to be prefixed with -Wl. > > Signed-off-by: Kacper Michajłow > --- > configure | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-

Re: [FFmpeg-devel] [PATCH] tools: Remove libav-merge-next-commit

2025-06-26 Thread Alexander Strasser via ffmpeg-devel
--- Begin Message --- Hi Derek! On 2025-06-23 22:40 +0100, Derek Buitenhuis wrote: > Libav is no longer extant. ^ Seems I just learned a new English word... IMHO removal is OK. Should be no longer needed in this specific form. I see the tool is still mentioned in doc/libav-m

[FFmpeg-devel] [PATCH] avcodec/vvc/refs: remove dead code

2025-06-26 Thread Marvin Scholz
The ret value is already checked earlier, making this condition impossible to ever happen. Fix CID 1648350 --- libavcodec/vvc/refs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c index 79967b77d3..e52cc0c10d 100644 --- a/libavcodec/vvc/refs.c +

[FFmpeg-devel] [PATCH] fftools/textformat: remove unreachable code in tf_mermaid

2025-06-26 Thread Marvin Scholz
Integer writing is impossible here as the first branch was dead code, so remove it completely. Fix CID 1646948 --- fftools/textformat/tf_mermaid.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fftools/textformat/tf_mermaid.c b/fftools/textformat/tf_mermaid.c index 3d864c

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix condition for using default scaling factor

2025-06-26 Thread Frank Plowman
On 22/06/2025 02:27, Nuo Mi wrote: > On Sat, Jun 21, 2025 at 8:20 PM Frank Plowman wrote: > >> Add handling here for >> sps_scaling_matrix_for_alternative_colour_space_disabled_flag. >> >> Also add parentheses to make behaviour a little more explicit, >> where &&'s precedence over || was used imp

Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-26 Thread Michael Niedermayer
Hi Pavel On Thu, Jun 26, 2025 at 12:04:17AM -0700, Pavel Roslyy wrote: > On Wed, Jun 25, 2025 at 3:40 PM Michael Niedermayer > wrote: > > > > [...] > > > > bug found, not applying yet > > > > ret = ff_alloc_extradata(par, pkt_size + key_buf); > > > > pkt_size + key_buf can overflow i think > > I

Re: [FFmpeg-devel] [PATCH 2/2] avformat/whip: check the exchange sdp url is start with http

2025-06-26 Thread Marvin Scholz
On 9 Jun 2025, at 5:21, Jack Lau wrote: >> On Jun 6, 2025, at 11:02, Steven Liu wrote: >> >> Make sure the WHIP protocol performs the SDP offer/answer >> exchange with the WebRTC peer over HTTP. >> >> Signed-off-by: Steven Liu >> --- >> libavformat/whip.c | 8 >> 1 file changed, 8 inse

Re: [FFmpeg-devel] [PATCH 1/2] avformat/whip: Remove unnecessary pkt checks

2025-06-26 Thread Marvin Scholz
On 6 Jun 2025, at 5:02, Steven Liu wrote: > h264_annexb_insert_sps_pps (called after write_packet) > reorganizes PPS, SPS, and IDR packets in H.264 streams. > Since write_packet already validates pkt, > redundant null checks in h264_annexb_insert_sps_pps can be removed. > > Signed-off-by: Steve

[FFmpeg-devel] [PATCH] avformat/apvdec: add framerate option

2025-06-26 Thread James Almer
Based on code from rawvideo demuxer. Signed-off-by: James Almer --- libavformat/apvdec.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat/apvdec.c b/libavformat/apvdec.c index 1e5497bcd3..70f6babbb7 100644 --- a/libavformat/apvdec.c +++

Re: [FFmpeg-devel] [PATCH 12/12] avfilter/ffmpeg_filter: rate control all filter graphs

2025-06-26 Thread Marton Balint
On Wed, 25 Jun 2025, Michael Niedermayer wrote: On Tue, Jun 24, 2025 at 09:23:10PM +0200, Marton Balint wrote: It was never reliable to detect if a filtergraph have sources, because a filter can act as a source only after some time, for example the loop filter. So it is better to remove the

Re: [FFmpeg-devel] [PATCH] libavcodec/utils: Ensure allocated buffer is zero-initialized

2025-06-26 Thread Kacper Michajlow
n Thu, 26 Jun 2025 at 16:07, Zhao Zhili wrote: > > > > > On Jun 26, 2025, at 12:07, xjdeng wrote: > > > > In `av_fast_padded_mallocz`, the allocated buffer's zero-initialization is > > not guaranteed. > > This is because it calls `av_fast_malloc`, which in turn calls > > `fast_malloc` with `zer

Re: [FFmpeg-devel] [RFC] webp decoding

2025-06-26 Thread Michael Niedermayer
On Thu, Jun 26, 2025 at 10:33:43AM -0700, James Zern via ffmpeg-devel wrote: > Date: Thu, 26 Jun 2025 10:33:43 -0700 > From: James Zern > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] webp decoding > > On Thu, Jun 26, 2025 at 12:00 AM Hendrik Leppkes > wrote

Re: [FFmpeg-devel] [RFC] webp decoding

2025-06-26 Thread James Zern via ffmpeg-devel
--- Begin Message --- On Thu, Jun 26, 2025 at 12:00 AM Hendrik Leppkes wrote: > > On Thu, Jun 26, 2025 at 2:58 AM Michael Niedermayer > wrote: > > > > Hi > > > > some people use webp apparently, and we have no decoder > > > > libavcodec/webp.c is a decoder. > The missing piece is animated webp d

Re: [FFmpeg-devel] [PATCH] avcodec/aac_parser: fix aac profile probing

2025-06-26 Thread Baptiste Coudurier
Hi Nicolas > On Jun 26, 2025, at 4:06 AM, Nicolas Gaullier > wrote: > > On 6/17/25 13:41, Nicolas Gaullier wrote: >> Reverts 64bb91fd3b5a00a8849531c7e8dd207f2a626096 except the >> key_frame setting for aac. >> See also 696ea1c2236842572df88d573e24a39be3f19c98. >> Don't force the profile as it m

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tee: fix multiple bsfs in tee

2025-06-26 Thread Marvin Scholz
On 25 Jun 2025, at 11:56, Nicolas George wrote: > Marvin Scholz (HE12025-06-25): >> Since 155508c6e925f4f2f5e77087a7e1925b3de735ff specifying multiple >> bsfs for different streams was broken: >> >> "[bsfs/a=h264_metadata:bsfs/v=h264_metadata]out.mp4|..." >> >> This incorrectly only parsed the

Re: [FFmpeg-devel] [PATCH] ffprobe: add -codec: option

2025-06-26 Thread Marvin Scholz
On 26 Jun 2025, at 12:15, Maryla Ustarroz via ffmpeg-devel wrote: > ffplay also has the -acodec, -vcodec etc. variants which I didn't add > for simplicity. > And indeed ffmpeg also has the shorter -c:specifier version. > My reasoning was that ffmpeg and ffplay were already not consistent, > and it

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_d3d12va: added resource Flags support to command line

2025-06-26 Thread Dmitrii Ovchinnikov
--- libavutil/hwcontext_d3d12va.c | 22 +- libavutil/hwcontext_d3d12va.h | 6 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c index 6507cf69c1..b2b58ac6f8 100644 --- a/libavutil/hwcontext_d3d12

Re: [FFmpeg-devel] [PATCH] libavcodec/utils: Ensure allocated buffer is zero-initialized

2025-06-26 Thread Zhao Zhili
> On Jun 26, 2025, at 12:07, xjdeng wrote: > > In `av_fast_padded_mallocz`, the allocated buffer's zero-initialization is > not guaranteed. > This is because it calls `av_fast_malloc`, which in turn calls `fast_malloc` > with `zero_realloc=0`. > Consequently, the memory returned by the under

[FFmpeg-devel] [PATCH] avcodec/aac_parser: fix aac profile probing

2025-06-26 Thread Nicolas Gaullier
On 6/17/25 13:41, Nicolas Gaullier wrote: Reverts 64bb91fd3b5a00a8849531c7e8dd207f2a626096 except the key_frame setting for aac. See also 696ea1c2236842572df88d573e24a39be3f19c98. Don't force the profile as it may override the correct value set by the decoder (HE/HEv2). Fixes #11600 Signed-off-

Re: [FFmpeg-devel] [PATCH] ffprobe: add -codec: option

2025-06-26 Thread Maryla Ustarroz via ffmpeg-devel
--- Begin Message --- On Wed, Jun 25, 2025 at 9:23 PM James Zern wrote: > > On Tue, Jun 10, 2025 at 8:02 AM Maryla Ustarroz-Calonge via > ffmpeg-devel wrote: > > > > > > > > > > -- Forwarded message -- > > From: Maryla Ustarroz-Calonge > > To: ffmpeg-devel@ffmpeg.org > > Cc: > >

Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-26 Thread Pavel Roslyy
Hi Andreas, On Wed, Jun 25, 2025 at 5:42 PM Andreas Rheinhardt wrote: > > Pavel Roslyy: > > [...] > > > > +#define OFFSET(x) offsetof(USMDemuxContext, x) > > +#define FLAGS AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_DECODING_PARAM > > +static const AVOption usm_options[] = { > > +{ "hca_lowkey", >

Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-26 Thread Pavel Roslyy
Hi Michael, On Wed, Jun 25, 2025 at 3:13 PM Michael Niedermayer wrote: > > Hi > > [...] > > please submit a patch adding documentation for both hca / usmdec to doc/ > and also add a fate test It might take me a few days since I don't know what I'm doing, but I will try. Regarding the usm sample,

Re: [FFmpeg-devel] [RFC] webp decoding

2025-06-26 Thread Hendrik Leppkes
On Thu, Jun 26, 2025 at 2:58 AM Michael Niedermayer wrote: > > Hi > > some people use webp apparently, and we have no decoder > libavcodec/webp.c is a decoder. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l