Re: [FFmpeg-devel] [PATCH 6/6] avformat/whip: implement NACK and RTX suppport

2025-07-01 Thread Steven Liu
Jack Lau 于2025年7月2日周三 12:35写道: > > RTP retransmission described in RFC4588 (RTX) is an effective packet > loss recovery technique for real-time applications with relaxed delay bounds. > > This patch provides a minimal implementation for RTX and RTCP NACK (RFC3940) > and its associated SDP signalin

Re: [FFmpeg-devel] [PATCH 1/6] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-01 Thread Steven Liu
Jack Lau 于2025年7月2日周三 12:25写道: > > mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, > preventing “No route to host” errors on devices without IPv6 connectivity. > > Signed-off-by: Jack Lau > --- > libavformat/whip.c | 13 + > 1 file changed, 13 insertions(+) > > diff -

Re: [FFmpeg-devel] [PATCH 2/6] avformat/whip: reindent whip options

2025-07-01 Thread Steven Liu
Jack Lau 于2025年7月2日周三 12:25写道: > > Signed-off-by: Jack Lau > --- > libavformat/whip.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index be6ee9c951..8d1be90f32 100644 > --- a/libavformat/whip.c > +++ b/l

[FFmpeg-devel] [PATCH 6/6] avformat/whip: implement NACK and RTX suppport

2025-07-01 Thread Jack Lau
RTP retransmission described in RFC4588 (RTX) is an effective packet loss recovery technique for real-time applications with relaxed delay bounds. This patch provides a minimal implementation for RTX and RTCP NACK (RFC3940) and its associated SDP signaling and negotiation. Co-authored-by: Sergio

[FFmpeg-devel] [PATCH 4/6] avformat/whip: fix H264 profile_iop bit map for SDP

2025-07-01 Thread Jack Lau
AVCodecParameters::profile only contains constraint_set1_flag (AV_PROFILE_H264_CONSTRAINED 1<<9). So add H264 constraints flag fully parse refer to hlsenc write_codec_attr Signed-off-by: Jack Lau --- libavformat/whip.c | 47 -- 1 file changed, 16 inser

[FFmpeg-devel] [PATCH 5/6] WHIP: X509 cert serial number should be positive.

2025-07-01 Thread Jack Lau
From: winlin See RFC5280 4.1.2.2 Co-authored-by: winlin Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a3905891d..4733faec9c 100644 --- a/libavformat/tls_o

[FFmpeg-devel] [PATCH 3/6] avformat/whip: fix typos

2025-07-01 Thread Jack Lau
Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options descriptions Signed-off-by: Jack Lau --- libavformat/whip.c | 152 ++--- 1 file changed, 76 insertions(+), 76 deletions(-) diff --git a/libavf

[FFmpeg-devel] [PATCH 1/6] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-01 Thread Jack Lau
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/libavformat/whip.c ind

[FFmpeg-devel] [PATCH 2/6] avformat/whip: reindent whip options

2025-07-01 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/whip.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index be6ee9c951..8d1be90f32 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1904,13 +1904,20 @@ static in

[FFmpeg-devel] [PATCH 0/6] avformat/whip: avformat/whip: Add NACK and RTX support (depends on ignore_ipv6 patchset)

2025-07-01 Thread Jack Lau
The NACK and RTX implementation depends the ignore_ipv6 patchset https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/345948.html So send them all in this new patchset. I want to thank Sergio Garcia Murillo for his help in providing the initial simple NACK prototype. I’ve been improving and test

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-07-01 Thread James Almer
On 7/1/2025 3:49 PM, Timo Rothenpieler wrote: On 23.06.2025 17:44, Timo Rothenpieler wrote: On 16.06.2025 20:26, Andreas Rheinhardt wrote: Timo Rothenpieler: On 16.06.2025 14:55, James Almer wrote: On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/06/2025 16:07, Timo Rothenpieler wrote:

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-07-01 Thread Timo Rothenpieler
On 01.07.2025 22:37, James Almer wrote: On 7/1/2025 3:49 PM, Timo Rothenpieler wrote: On 23.06.2025 17:44, Timo Rothenpieler wrote: On 16.06.2025 20:26, Andreas Rheinhardt wrote: Timo Rothenpieler: On 16.06.2025 14:55, James Almer wrote: On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-07-01 Thread Timo Rothenpieler
On 23.06.2025 17:44, Timo Rothenpieler wrote: On 16.06.2025 20:26, Andreas Rheinhardt wrote: Timo Rothenpieler: On 16.06.2025 14:55, James Almer wrote: On 6/16/2025 9:38 AM, Timo Rothenpieler wrote: On 13/06/2025 16:07, Timo Rothenpieler wrote: On 10/06/2025 00:09, Andreas Rheinhardt wrote:

Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json"

2025-07-01 Thread Vittorio Giovara
On Wed, Jun 25, 2025 at 9:20 AM Michael Niedermayer wrote: > On Wed, Jun 25, 2025 at 12:14:15AM +0200, Kieran Kunhya via ffmpeg-devel > wrote: > > Date: Wed, 25 Jun 2025 00:14:15 +0200 > > From: Kieran Kunhya > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PA

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Add AVFMT_FLAG_ALLOW_CODEC_CHANGES (v2)

2025-07-01 Thread Scott Theisen
On 2025/07/01 01:39, Pavel Koshevoy wrote: On Mon, Jun 30, 2025, 21:46 Michael Niedermayer wrote: On Mon, Jun 30, 2025 at 07:32:36PM -0600, Pavel Koshevoy wrote: On Mon, Jun 30, 2025 at 3:46 PM Scott Theisen < scott.the.elm-at-gmail@ffmpeg.org> wrote: On 2025/06/29 23:55, Pavel Koshevoy

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Add AVFMT_FLAG_ALLOW_CODEC_CHANGES (v2)

2025-07-01 Thread Scott Theisen
On 2025/06/30 21:32, Pavel Koshevoy wrote: On Mon, Jun 30, 2025 at 3:46 PM Scott Theisen < scott.the.elm-at-gmail@ffmpeg.org> wrote: On 2025/06/29 23:55, Pavel Koshevoy wrote: Make midstream AVStream.codecpar updates optional and disabled by default, so that avformat API clients can enable

[FFmpeg-devel] [PATCH 2/2] avcodec/ohdec: Add h264/hevc OpenHarmony decoders

2025-07-01 Thread Zhao Zhili
From: Zhao Zhili --- Changelog | 1 + configure | 4 + libavcodec/Makefile| 3 + libavcodec/allcodecs.c | 2 + libavcodec/ohcodec.c | 71 libavcodec/ohcodec.h | 33 ++ libavcodec/ohdec.c | 788 + libavco

[FFmpeg-devel] [PATCH 1/2] avutil/hwcontext: Add ohcodec device and pixel format

2025-07-01 Thread Zhao Zhili
From: Zhao Zhili --- configure | 5 doc/APIchanges | 6 + libavutil/Makefile | 2 ++ libavutil/hwcontext.c | 4 +++ libavutil/hwcontext.h | 2 ++ libavutil/hwcontext_internal.h | 1 + libavutil/hwcontext_oh.c

Re: [FFmpeg-devel] [RFC] Introducing policies regarding "AI" contributions

2025-07-01 Thread Kacper Michajlow
On Tue, 1 Jul 2025 at 12:58, Alexander Strasser via ffmpeg-devel wrote: > > > > > -- Forwarded message -- > From: Alexander Strasser > To: ffmpeg-devel@ffmpeg.org > Cc: > Bcc: > Date: Tue, 1 Jul 2025 12:58:23 +0200 > Subject: [RFC] Introducing policies regarding "AI" contributions

Re: [FFmpeg-devel] [RFC] Introducing policies regarding "AI" contributions

2025-07-01 Thread Gyan Doshi
On 2025-07-01 04:28 pm, Alexander Strasser via ffmpeg-devel wrote: > Thus I want this thread to start a discussion, that eventually leads > to a policy about submitting and integrating "AI" generated content. In practice. unless a patch(set) is explicitly marked or has telltale signs of bein

[FFmpeg-devel] [RFC] Introducing policies regarding "AI" contributions

2025-07-01 Thread Alexander Strasser via ffmpeg-devel
--- Begin Message --- Hi all, I do not like the branding of the LLMs as AI, thus I will for now continue to call it "AI" in quotes. I'm open for better terms. It was just yesterday brought up on IRC in #ffmpeg-devel that there was at least one, marked attempt to include "AI" generated code[1]. A

Re: [FFmpeg-devel] [PATCH] avcodec/aac_parser: fix aac profile probing

2025-07-01 Thread Nicolas Gaullier
On 6/30/25 21:03, Baptiste Coudurier wrote: On Jun 30, 2025, at 11:08 AM, Nicolas Gaullier wrote: On 6/28/25 03:54, Baptiste Coudurier wrote: On Jun 27, 2025, at 5:01 AM, Nicolas Gaullier wrote: On 6/26/25 19:30, Baptiste Coudurier wrote: Hi Nicolas On Jun 26, 2025, at 4:06 AM, Nicolas G