Re: [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to setmax_packet_size

2025-07-30 Thread 1+1=10 via ffmpeg-devel
This modification references the max_packet_size assignment method in other protocols, such as the one in udp.c; This operation not only maintains the original setting but also adds custom settings; For example, when reading a local file, you can first set pkt_size using av_dict_set and then pas

Re: [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to setmax_packet_size

2025-07-30 Thread 1+1=10 via ffmpeg-devel
1+1=10 1441923...@qq.com This modification references the max_packet_size assignment method in other protocols, such as the one in udp.c; This operation not only maintains the original setting but also adds custom settings; For example, when reading a local file, you can first set pkt_

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

2025-07-30 Thread Zhao Zhili
> On Jul 31, 2025, at 10:13, Cai Fan wrote: > > Signed-off-by: Cai Fan > --- > libavformat/img2enc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > index 41638d92b8..a1eb0c688d 100644 > --- a/libavformat/img2enc.c

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/mov.c: Fix "statement will never be executed" warning

2025-07-30 Thread Zhao Zhili
> On Jul 31, 2025, at 09:27, zhaozhenghang <15083277...@163.com> wrote: > > Fix "statement will never be executed" warning that occurs when > CONFIG_H261_DECODER, CONFIG_H263_DECODER, and CONFIG_MPEG4_DECODER > are set to 0 by default. Pushed after rewords on the commit message, thanks. > >

[FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

2025-07-30 Thread Cai Fan
Signed-off-by: Cai Fan --- libavformat/img2enc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 41638d92b8..a1eb0c688d 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@ -180,7 +180,12 @@ static int writ

[FFmpeg-devel] [PATCH 1/1] libavformat/mov.c: Fix "statement will never be executed" warning

2025-07-30 Thread zhaozhenghang
Fix "statement will never be executed" warning that occurs when CONFIG_H261_DECODER, CONFIG_H263_DECODER, and CONFIG_MPEG4_DECODER are set to 0 by default. Signed-off-by: zhaozhenghang <15083277...@163.com> --- libavformat/mov.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Michael Niedermayer
Hi On Wed, Jul 30, 2025 at 09:53:26PM +0200, Nicolas George wrote: > Niklas Haas (HE12025-07-30): > > I disagree. Without this important context, the motivation behind the > > change is much less clear. > > It is not context, it is a dump of an exchange of mails that led to the It seems the comm

Re: [FFmpeg-devel] [flac] Fix integer-overflow in flac_lpc_33_c

2025-07-30 Thread Dale Curtis
Patchset updated with your suggestions. Thanks! On Wed, Jul 30, 2025 at 12:53 PM Michael Niedermayer wrote: > Hi Dale > > On Wed, Jul 30, 2025 at 09:36:51AM -0700, Dale Curtis wrote: > > On Wed, Jul 30, 2025 at 3:01 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > Hi Dale

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
Niklas Haas (HE12025-07-30): > What you pointed out is pointess nitpicking, and I could point you to > plenty of other comments by "experienced" FFmpeg developers who have done > the same in the past, presumably without having sat through diatribes. Where they argued that they were right instead o

Re: [FFmpeg-devel] [PATCH v2] ffprobe: add -codec: option

2025-07-30 Thread Stefano Sabatini
On date Friday 2025-06-27 10:23:56 +0200, ffmpeg-devel Mailing List wrote: > From: Maryla Ustarroz-Calonge > Subject: [PATCH v2] ffprobe: add -codec: option > Date: Fri, 27 Jun 2025 10:23:56 +0200 > To: ffmpeg-devel@ffmpeg.org > X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog > > And -c: var

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Niklas Haas
On Wed, 30 Jul 2025 23:39:18 +0200 Nicolas George wrote: > Kacper Michajlow (HE12025-07-30): > > Can we please find something more relevant to be upset about? > > Can you please stop behaving with such arrogance when somebody who has > 30 times as much experience as you in the project points you y

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-30 Thread Nicolas George
Kacper Michajlow (HE12025-07-27): > I'm talking about ffmpeg specifically. ffmpeg is not a Linux kernel, Nobody talked about the Linux kernel, I do not know what nonsense you are spewing here. But you do not seem tu realize that the best hackers in the project (not you) have nothing to do with th

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-30 Thread Nicolas George
Alexander Strasser via ffmpeg-devel (HE12025-07-30): > Also to make FFmpeg more attractive for new > contributors and hopefully maintainers as well. At some point, I hope you will realize how bad an idea it is to try to attract more newbies, dilettantes and vibe coders at the cost of making the pe

Re: [FFmpeg-devel] [PATCH] ffprobe: add -codec: option

2025-07-30 Thread Stefano Sabatini
On date Tuesday 2025-07-29 15:15:55 +0200, ffmpeg-devel Mailing List wrote: > On Mon, Jul 28, 2025 at 10:07 PM Stefano Sabatini wrote: > > > > Hi, sorry for the slow reply. > > [...] > > Please also add an update for the docs and a short explanation of the > > use case in the commit log. > In v2

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
Kacper Michajlow (HE12025-07-30): > Can we please find something more relevant to be upset about? Can you please stop behaving with such arrogance when somebody who has 30 times as much experience as you in the project points you you did something wrong? -- Nicolas George _

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Kacper Michajlow
On Wed, 30 Jul 2025 at 21:53, Nicolas George wrote: > > Niklas Haas (HE12025-07-30): > > I disagree. Without this important context, the motivation behind the > > change is much less clear. > > It is not context, it is a dump of an exchange of mails that led to the > patch. It should have been rew

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-30 Thread Alexander Strasser via ffmpeg-devel
Am 29. Juli 2025 22:59:22 MESZ schrieb Nicolas George : >Alexander Strasser via ffmpeg-devel (HE12025-07-29): >> You are looking at the overview with latest events for that PR. >> >> To see the the individual commits select >> that view at the top. Or if you want to see >> the combined diff, cl

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix ref_order_hint value for second slot

2025-07-30 Thread Dong, Ruijing via ffmpeg-devel
[AMD Official Use Only - AMD Internal Distribution Only] Without this fix, av1 vaapi encoding on navi3x (vcn4) is broken. Thanks, Ruijing -Original Message- From: ffmpeg-devel On Behalf Of David Rosca Sent: Thursday, July 24, 2025 6:04 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
Niklas Haas (HE12025-07-30): > I disagree. Without this important context, the motivation behind the > change is much less clear. It is not context, it is a dump of an exchange of mails that led to the patch. It should have been rewritten, “To my understanding” is not something that should appear

Re: [FFmpeg-devel] [flac] Fix integer-overflow in flac_lpc_33_c

2025-07-30 Thread Michael Niedermayer
Hi Dale On Wed, Jul 30, 2025 at 09:36:51AM -0700, Dale Curtis wrote: > On Wed, Jul 30, 2025 at 3:01 AM Michael Niedermayer > wrote: > > > Hi Dale > > > > On Tue, Jul 29, 2025 at 03:07:38PM -0700, Dale Curtis wrote: > > > This fix copies a couple of casts from surrounding functions. > > > See htt

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Niklas Haas
On Wed, 30 Jul 2025 19:52:59 +0200 Nicolas George wrote: > Kacper Michajłow (HE12025-07-30): > > > Note that BIO_get_new_index() can only be used 127 times before it > > > returns an error. > > > > We cannot call it repeatedly, because it will fail eventually. > > > > To my understanding the index

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Kacper Michajlow
On Wed, 30 Jul 2025 at 19:53, Nicolas George wrote: > > Kacper Michajłow (HE12025-07-30): > > > Note that BIO_get_new_index() can only be used 127 times before it > > > returns an error. > > > > We cannot call it repeatedly, because it will fail eventually. > > > > To my understanding the index is

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Nicolas George
Kacper Michajłow (HE12025-07-30): > > Note that BIO_get_new_index() can only be used 127 times before it > > returns an error. > > We cannot call it repeatedly, because it will fail eventually. > > To my understanding the index is not needed in our use and we could > safely use BIO_TYPE_NONE. Doc

Re: [FFmpeg-devel] [flac] Fix integer-overflow in flac_lpc_33_c

2025-07-30 Thread Dale Curtis
On Wed, Jul 30, 2025 at 3:01 AM Michael Niedermayer wrote: > Hi Dale > > On Tue, Jul 29, 2025 at 03:07:38PM -0700, Dale Curtis wrote: > > This fix copies a couple of casts from surrounding functions. > > See https://crbug.com/432528781 for stack trace details. > > > > Signed-off-by: Dale Curtis

Re: [FFmpeg-devel] [PATCH v2] avcodec/itut35: always check the provider code and country code together

2025-07-30 Thread Maryla Ustarroz via ffmpeg-devel
On Wed, Jun 25, 2025 at 5:55 PM Maryla Ustarroz-Calonge wrote: > > From: Maryla > > ITU-T T.35 provider codes are attributed by national bodies and it's > possible to have collisions across countries. This is why the country code > must always be checked as well. > > Use if statements rather than

Re: [FFmpeg-devel] [PATCH] avcodec/apv: align APV color format support with latest liboapv version

2025-07-30 Thread d.frankiewic
-Original Message- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Wednesday, July 30, 2025 1:41 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/apv: align APV color format support with latest liboapv version >On Tue, Jul 29, 2025 a

Re: [FFmpeg-devel] STF 2025 grant request (2025-09-01 target)

2025-07-30 Thread Lynne
On 30/07/2025 06:20, Pierre-Anthony Lemieux wrote: Hi all, As with last year, Michael asked me to help coordinate the creation of grant request to the STF: https://trac.ffmpeg.org/wiki/SponsoringPrograms/STF/2025 The objective remains to unlock funds for individuals that are interested in cont

[FFmpeg-devel] [PATCH] avformat/mov: prevent excessive allocation in mov_read_udta_string

2025-07-30 Thread Sanjay Jangid
Signed-off-by: Sanjay Jangid --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index c935bbf..725a9fa 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -459,6 +459,10 @@ retry: data_type = avio_rb32(pb); // type

[FFmpeg-devel] [PATCH 1/1] libavformat/mov.c : rm 'statement will never be executed' warning

2025-07-30 Thread zhaozhenghang
When CONFIG_H261_DECODER, CONFIG_H263_DECODER, and CONFIG_MPEG4_DECODER are set to 0 by default, resulting in a "statement will never be executed" warning during compilation. To enhance code robustness, this patch fixes the warning. Signed-off-by: zhaozhenghang <15083277...@163.com> --- libavfo

Re: [FFmpeg-devel] [flac] Fix integer-overflow in flac_lpc_33_c

2025-07-30 Thread Michael Niedermayer
Hi Dale On Tue, Jul 29, 2025 at 03:07:38PM -0700, Dale Curtis wrote: > This fix copies a couple of casts from surrounding functions. > See https://crbug.com/432528781 for stack trace details. > > Signed-off-by: Dale Curtis > flacdsp.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

2025-07-30 Thread Zhao Zhili
> On Jul 30, 2025, at 11:43, Cai Fan wrote: > > Signed-off-by: Cai Fan > --- > libavformat/img2enc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > index 41638d92b8..f7d983ec54 100644 > --- a/libavformat/img2enc.c > +++ b/libavfor