[FFmpeg-devel] Please feel free to take my patch, modify and apply it

2016-10-12 Thread Alexey Eromenko
Dear ffmpeg community, I don't have too much time to spend on this (Apple) issue, but I did my best, including providing test material, bug report and a possible patch. If you modify, you can change name to your own, of course. Best wishes, -- -Alexey Eromenko "T

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
On Tuesday, 11 October 2016, Carl Eugen Hoyos wrote: > Hi! > > > Am 11.10.2016 um 19:24 schrieb Alexey Eromenko >: > > > > -if (track->mode == MODE_MOV > > This change is not acceptable: > The problem only affects mov, not isom. > Mentioni

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
>>> +unsigned int timescale_new = (unsigned >>> int)((double)(st->time_base.den) >>> +* 1000 / (double)(st->time_base.num)); >> >> You surely don't need all these casts. > > Unless I'm guaranteed to get int64 on ALL platforms, I don't see > how-to write this code wit

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
On Tue, Oct 11, 2016 at 8:29 PM, Josh de Kock wrote: > On 11/10/2016 18:24, Alexey Eromenko wrote: >> >> --- >> libavformat/movenc.c | 14 +- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/movenc.c b/libavfo

[FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Alexey Eromenko
*** BLURB HERE *** Alexey Eromenko (1): Apple Quicktime fix libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) -- 2.9.3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

[FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
--- libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8b4aa5f..0e2fc55 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5666,16 +5666,20 @@ static int mov_write_header(AVFormatCo

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
fy it, and there is a way to manually enforce some other value via a parameter. Patch submitted. Thanks for your cooperation, -Alexey Eromenko "Technologov" ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
== AV_CODEC_ID_RAWVIDEO && track->tag == MKTAG('r','a','w',' ')) { enum AVPixelFormat pix_fmt = track->par->format; if (pix_fmt == AV_PIX_FMT_NONE && track->par->bits_per_coded_sample == 1) pix_fmt = AV_PIX_FMT_MONOWHITE; -- -Alexey Eromenko "Technologov" ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
In which cases a large timebase would help ? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
GMail disallows me to paste unwrapped text, so I will use good-old pastebin plain text. http://pastebin.com/SPUF4NTS ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
I have written a different patch, which should auto-fix the problem, but I can't compile and test it now (due to build system issues): movenc.c affects both MP4 and MOV containers, right ? --- ./movenc.c.orig 2016-10-11 06:24:44.328730759 -0400 +++ ./ffmpeg-3.1.3/ffmpeg-3.1.3/libavformat

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
Josh, thanks for your efforts. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
Would it be useful to print the max duration (do we know what it would > be?), and possibly even the present timebase? > > Moritz > _______ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- -Alexey Eromenko "Technologov" ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Developer "cehoyos" closed my bug without any explanation, and without solving it

2016-10-10 Thread Alexey Eromenko
Hello all, Bug #5882; Certain x264 videos do not play on Apple decoders (Quicktime/iTunes/iPad) Today was closed by developer "cehoyos" without any explanation, and without any resolution. He treats all bugs like that ? Worse yet; he treats all people like bugs ? -- -Alexe