Re: [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: increase precision of Sleep() on Windows

2024-09-09 Thread Araz
> > > I took a look at this using AMD's AMF EncoderLatency sample and found > that > > setting the QUERY_TIMEOUT option to 50 ms (as is default for the new AMF > > HQ and HQLL usage values) results in latency that is better than the > > current AMF code in FFmpeg *and* this patch without having to

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix HEVC/AV1 colorspace assumptions

2024-09-09 Thread Araz
> -if (color_depth == AMF_COLOR_BIT_DEPTH_8) { > -/// Color Transfer Characteristics (AMF matches ISO/IEC) > -AMF_ASSIGN_PROPERTY_INT64(res, ctx->encoder, AMF_VIDEO_ENCODER_AV1_OUTPUT_TRANSFER_CHARACTERISTIC, AMF_COLOR_TRANSFER_CHARACTERISTIC_BT709); > -/// Color Primari

Re: [FFmpeg-devel] [PATCH 1/4, v2] avcodec/amfenc: Fixes the color information in the output.

2024-09-09 Thread Araz
> Apologies for missing this prior to merge, but you can't safely make these > assumptions about primaries and TRC just based on the input bit depth. Just > because it's 8-bit content doesn't mean it will be BT.709 and likewise for > 10-bit and BT.2020+SMPTE 2084 PQ. > > Why doesn't amfenc_hevc (an

[FFmpeg-devel] [PATCH, v2] avcodec/amfenc: increase precision of Sleep() on Windows

2024-08-19 Thread Araz Iusubov
From: Evgeny Pavlov This commit increase precision of Sleep() function on Windows. This fix reduces the sleep time on Windows to improve AMF encoding performance on low resolution input videos. Fix for issue #10622 We evaluated CreateWaitableTimerExW with CREATE_WAITABLE_TIMER_HIGH_RESOLUTION f

Re: [FFmpeg-devel] [PATCH] avcodec/amf_enc: new encoder features support

2024-08-14 Thread Araz
Can anyone take a look at this patch please? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/4, v2] avcodec/amfenc: Fixes the color information in the output.

2024-08-01 Thread Araz
> > +AV_PIX_FMT_P010, > > AV_PIX_FMT_NONE > >}; > > > > @@ -72,6 +73,7 @@ static const FormatMap format_map[] = > >{ > >{ AV_PIX_FMT_NONE, AMF_SURFACE_UNKNOWN }, > >{ AV_PIX_FMT_NV12, AMF_SURFACE_NV12 }, > > +{ AV_PIX_FMT_P010, AMF_SURFACE_

[FFmpeg-devel] [PATCH 4/4, v2] avcodec/amfenc: GPU driver version check

2024-08-01 Thread Araz Iusubov
Implemented gpu driver check. 10-bit patch works incorrectly on driver version lower than 23.30. --- libavcodec/amfenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 49dd91c4e0..41eaef9758 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 3/4, v2] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-08-01 Thread Araz Iusubov
From: Evgeny Pavlov v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov Co-authored-by: Araz Iusubov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 28 +++- 2 files changed, 29 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 2/4,v2] avcodec/amfenc: HDR metadata.

2024-08-01 Thread Araz Iusubov
From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 1/4, v2] avcodec/amfenc: Fixes the color information in the output.

2024-08-01 Thread Araz Iusubov
t - 10bit file v2 - lost line returned in ff_amf_pix_fmts v3 - fixes after review v4 - extract duplicated code, fix incorrect processing of 10-bit input for h264 v5 - non-functional changes after review Co-authored-by: Evgeny Pavlov Co-authored-by: Araz Iusubov --- libavcodec/amfenc.c

[FFmpeg-devel] [PATCH] avcodec/amf_enc: av1 cropping support

2024-07-25 Thread Araz Iusubov
--- libavcodec/amfenc.c | 6 libavcodec/amfenc.h | 3 ++ libavcodec/amfenc_av1.c | 64 - 3 files changed, 72 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 061859f85c..93925854e0 100644 --- a/libavco

[FFmpeg-devel] [PATCH] avcodec/amf_enc: av1 cropping support

2024-07-23 Thread Araz Iusubov
--- libavcodec/amfenc_av1.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index d40c71cb33..27599b9fbe 100644 --- a/libavcodec/amfenc_av1.c +++ b/libavcodec/amfenc_av1.c @@ -22,6 +22,9

[FFmpeg-devel] [PATCH] avcodec/amf_enc: new encoder features support

2024-07-17 Thread Araz Iusubov
Implemented: New usage modes for AV1 encoder. Latency mode for H264, HEVC and AV1 encoders. Adaptive Quantization (AQ) mode in AV1 encoder. --- libavcodec/amfenc.h | 2 ++ libavcodec/amfenc_av1.c | 24 +++- libavcodec/amfenc_h264.c | 5 + libavcodec/amfenc_hevc.c |

[FFmpeg-devel] [PATCH 4/4] avcodec/amfenc: GPU driver version check

2024-07-15 Thread Araz Iusubov
Implemented gpu driver check. 10-bit patch works incorrectly on driver version lower than 23.30. --- libavcodec/amfenc_av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index a8629d74b0..cfa319f933 100644 --- a/libavcodec/amfenc_av1.c +++

[FFmpeg-devel] [PATCH 3/4] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-07-15 Thread Araz Iusubov
v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 27 +++ 2 files changed, 29 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 068bb53002.

[FFmpeg-devel] [PATCH 2/4] avcodec/amfenc: HDR metadata.

2024-07-15 Thread Araz Iusubov
v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -36,6 +36,57 @@

[FFmpeg-devel] [PATCH 1/4] avcodec/amfenc: Fixes the color information in the output.

2024-07-15 Thread Araz Iusubov
added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by AMF. command - ffmpeg.exe -hide_banner

[FFmpeg-devel] [PATCH 1/2] libavcodec/amfenc: Update AMF release version

2024-06-13 Thread Araz Iusubov
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8101b4fce6..23b140dc78 100755 --- a/configure +++ b/configure @@ -7364,7 +7364,7 @@ fi enabled amf && check_cpp_condition amf "AMF/core/Version.h" \ -"(AMF_VERSION_MAJOR <<

[FFmpeg-devel] [PATCH 2/2] libavcodec/amfenc: Update AMF encoder options

2024-06-13 Thread Araz Iusubov
Encoder options have been updated to the current version of the AMF. Signed-off-by: Araz Iusubov --- libavcodec/amfenc_av1.c | 108 +++-- libavcodec/amfenc_h264.c | 146 +-- libavcodec/amfenc_hevc.c | 143

Re: [FFmpeg-devel] [PATCH, v2] libavcodec/amfenc: Update AMF encoder options

2024-05-27 Thread Araz
That patch is a key part to support new features of amd next generation gpu product. Please review the attached patch and provide your feedback. > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH, v2] libavcodec/amfenc: Update AMF encoder options

2024-05-20 Thread Araz
Please review the attached patch and provide your feedback. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "un

[FFmpeg-devel] [PATCH, v2] libavcodec/amfenc: Update AMF encoder options

2024-04-27 Thread Araz Iusubov
Encoder options have been updated to the current version of the AMF. Signed-off-by: Araz Iusubov --- libavcodec/amfenc_av1.c | 108 +++-- libavcodec/amfenc_h264.c | 146 +-- libavcodec/amfenc_hevc.c | 143

[FFmpeg-devel] [PATCH 4/4] avcodec/amfenc: GPU driver version check

2024-04-15 Thread Araz Iusubov
Implemented gpu driver check. 10-bit patch works incorrectly on driver version lower than 23.30. --- libavcodec/amfenc_av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index 634eeea48f..7463251529 100644 --- a/libavcodec/amfenc_av1.c +++

[FFmpeg-devel] [PATCH 3/4] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-04-15 Thread Araz Iusubov
From: Evgeny Pavlov v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 2/4] avcodec/amfenc: HDR metadata.

2024-04-15 Thread Araz Iusubov
From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 1/4] avcodec/amfenc: Fixes the color information in the output.

2024-04-15 Thread Araz Iusubov
From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-04-03 Thread Araz
> On Mon, Apr 1, 2024 at 9:33 PM Mark Thompson wrote: > It is not necessary to copy exactly the same field layout. > Are you sure that there is never a meaningful non-power-of-two-bytes case? > Given that this is defining new public API to libavutil we don't want to be artificially constrained to

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-27 Thread Araz
>>On Fri, Mar 22, 2024 at 11:35 AM Anton Khirnov wrote: >>Why this unnecessary complication? Just use two ints, or two uint8_t's >>if you really need to save space, though that also seems unncessary as >>this struct is allocated rarely and usually does not live long. https://github.com/intel/libv

[FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-21 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by: Araz Iusubov --- libavcodec

[FFmpeg-devel] [PATCH] [FFmpeg-devel, v3] avcodec/vaapi_encode: add customized surface alignment

2024-03-21 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by: Araz Iusubov --- libavcodec

[FFmpeg-devel] [PATCH] [FFmpeg-devel, v2] avcodec/vaapi_encode: add customized surface alignment

2024-03-21 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by: Araz Iusubov --- libavcodec

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Update AMF encoder options

2024-03-14 Thread Araz Iusubov
The encoder options have been updated to the current version of the AMF. Signed-off-by: Araz Iusubov --- libavcodec/amfenc.c | 1 + libavcodec/amfenc.h | 4 + libavcodec/amfenc_av1.c | 154 +- libavcodec/amfenc_h264.c | 155

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode: add customized surface alignment

2024-03-06 Thread Araz Iusubov
This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customzied surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0. To: primeadv...@gmail.com Signed-off-by: Araz Iusubov