Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-06 Thread Banana M.
> Is it intended that this doesnt list a human name ? > (its no problem but jb tends to be unhappy if there are no names in the log > so i try to ask people if they really intend to not list their name or if > its a unintended mistake) It's the nick/mail I use in github and other places, it's corr

Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2018-10-06 Thread Banana M.
> This will/would require several fate tests to be updated > at least these apparently: > make: *** [fate-wmav1-encode] Error 1 > make: *** [fate-wmav2-encode] Error 1 > make: *** [fate-flcl1905] Error 1 I'm not sure if I can and how to modify those, somebody could lend a hand? I can run the tests

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-09 Thread Banana M.
I've sent the patch again with some tweaks and fixed the test, please check if it is satisfactory now. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-10 Thread Banana M.
> Can you confirm that if you break the decoder intentionally, the test > (still) fails? > > Thank you, Carl Eugen It does. Since file now writes 1 extra packet (as intended) so it'll always differ SIZE_TOLERANCE at min, so decoder changes will go over than value, I think. I tried -frames:a 108 (

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-10 Thread Banana M.
> No, you need to set this during init. > You should also set avctx->delay to the same value. This value is part of the bitstream, so theoretically can appear in any packet after the first. Can you confirm it doesn't? How could it be set on init? You'd need to read the bitstream then rewind? And

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-26 Thread Banana M.
Ignore this patch, I've submitted a new one that hopefully has a better chance. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve XMA missing samples

2018-10-27 Thread Banana M.
> You can set final number of samples in output frame directly: > frame->nb_samples = X. I was told I shouldn't do that (even though other codecs do it?). I quote: >> No, this is wrong. Codecs don't need to do this manually, this is done by >> libavcodec/decode.c, based on the packet's AV_PKT_DATA

Re: [FFmpeg-devel] [PATCH] lavf/bink: fix latest header and add all existing revisions

2017-08-20 Thread Banana M.
Yes, it's my github handle, thanks. 2017-08-20 3:00 GMT+02:00 Michael Niedermayer : > On Sun, Aug 20, 2017 at 01:51:07AM +0200, Michael Niedermayer wrote: > > On Fri, Aug 18, 2017 at 07:45:16PM +0200, bananaman...@gmail.com wrote: > > > From: bnnm > > > > > > KB2 'i' found in Life is Strange (Xb

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: support multichannel XMA stream configurations

2017-10-05 Thread Banana M.
Here are samples of many stream configurations, generated with Microsoft's encoder: https://mega.nz/#!aQRUnTIT!gWUAfGNLIP62VKV2JEOGoyQ1jbVc3M7_qu7ChXQwb7w For real XMA used in games, I've only seen 2ch+..+2ch+1/2ch (usual, what FFmpeg supported before) and 1ch+..+1ch (rare, what motivates this pat

Re: [FFmpeg-devel] [PATCH] avformat/msf: fix codec 4 (joint stereo ATRAC3) and align

2017-01-30 Thread Banana M.
It should work with all proper MSF. Here is my test suite, which includes most MSF variations (including some not yet supported by FFmpeg) https://www.sendspace.com/file/omvv8s For example, there is no 1ch ATRAC3-codec4 test MSF because the encoder only outputs joint stereo I'm afraid I don't know