This way we can pass explicit modifiers in. Sometimes the
modifier matters for the number of memory planes that
libva accepts, in particular when dealing with
driver-compressed textures. Furthermore the driver might
not actually be able to determine the implicit modifier
if all the buffer-passing
A friendly ping on reviewing this series. Thanks!
On Sat, Nov 14, 2020 at 12:15 AM Bas Nieuwenhuizen
wrote:
>
> The kernel defaults to initializing the field to 0 when modifiers
> are not used and this happens to be linear. If we end up actually
> passing the modifier to a driver, t
The kernel defaults to initializing the field to 0 when modifiers
are not used and this happens to be linear. If we end up actually
passing the modifier to a driver, tiling issues happen.
So if the kernel doesn't return a modifier set it explicitly to
INVALID. That way later processing knows
This way we can pass explicit modifiers in. Sometimes the
modifier matters for the number of memory planes that
libva accepts, in particular when dealing with
driver-compressed textures. Furthermore the driver might
not actually be able to determine the implicit modifier
if all the buffer-passing
As we get a new set of objects each frame anyway, we
do not gain anything by keeping the modifier constant.
This helps with capturing when switching your setup a
bit, e.g. from ingame to desktop or from X11 to wayland.
---
libavdevice/kmsgrab.c | 7 ---
1 file changed, 7 deletions(-)
diff
On Wed, Nov 4, 2020 at 12:52 AM Mark Thompson wrote:
>
> On 03/11/2020 23:17, Bas Nieuwenhuizen wrote:
> > The kernel defaults to initializing the field to 0 when modifiers
> > are not used and this happens to be linear. If we end up actually
> > passing the modifier to
On Wed, Nov 4, 2020 at 1:21 AM Bas Nieuwenhuizen
wrote:
>
> On Wed, Nov 4, 2020 at 12:52 AM Mark Thompson wrote:
> >
> > On 03/11/2020 23:17, Bas Nieuwenhuizen wrote:
> > > The kernel defaults to initializing the field to 0 when modifiers
> > > are not used
On Wed, Nov 4, 2020 at 1:09 AM Mark Thompson wrote:
>
> On 03/11/2020 23:17, Bas Nieuwenhuizen wrote:
> > As we get a new set of objects each frame anyway, we
> > do not gain anything by keeping the modifier constant.
> >
> > This helps with capturing when switc
This way we can pass explicit modifiers in. Sometimes the
modifier matters for the number of memory planes that
libva accepts, in particular when dealing with
driver-compressed textures. Furthermore the driver might
not actually be able to determine the implicit modifier
if all the buffer-passing
The kernel defaults to initializing the field to 0 when modifiers
are not used and this happens to be linear. If we end up actually
passing the modifier to a driver, tiling issues happen.
So if the kernel doesn't return a modifier set it explicitly to
INVALID. That way later processing knows
As we get a new set of objects each frame anyway, we
do not gain anything by keeping the modifier constant.
This helps with capturing when switching your setup a
bit, e.g. from ingame to desktop or from X11 to wayland.
---
libavdevice/kmsgrab.c | 7 ---
1 file changed, 7 deletions(-)
diff
11 matches
Mail list logo
