Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-10-03 Thread Ching-Yi Chan
2015-10-04 7:37 GMT+08:00 Michael Niedermayer : > On Sat, Oct 03, 2015 at 01:14:26AM +0800, Ching-Yi Chan wrote: > > iam not sure changing the format flags is a great idea, i think no > other demuxer does that > that said, the documentation does not say that only the user can &

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-10-02 Thread Ching-Yi Chan
Here is a new patch: 1. fix compilation warning 2. remove ff_ prefix on my patch 3. toggle AVFMT_FLAG_FAST_SEEK when no seektalbe in the flac metadata (this will disable flac_seek when no seekpoint) 0001-avformat-flacdec-support-fast-seek.patch Description: Binary data __

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-10-02 Thread Ching-Yi Chan
no seektable 2. use priv_class and keep the state in it 3. use a static varible to keep the state in flacdec.c Need a suggestion for implementation. 2015-10-01 20:31 GMT+08:00 Michael Niedermayer : > On Fri, Sep 25, 2015 at 11:58:31AM +0800, Ching-Yi Chan wrote: > > Thanks for checking.

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-10-02 Thread Ching-Yi Chan
2015-10-01 20:31 GMT+08:00 Michael Niedermayer : > On Fri, Sep 25, 2015 at 11:58:31AM +0800, Ching-Yi Chan wrote: > > Thanks for checking. > > > > I also check the AVFMT_FLAG_FAST_SEEK flag with parsing headers, > > to fill the seektable into index entries only if

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-09-24 Thread Ching-Yi Chan
: > On Fri, Sep 25, 2015 at 09:22:41AM +0800, Ching-Yi Chan wrote: > > I do it with AVFMT_FLAG_FAST_SEEK flag. > > > > > > 2015-09-24 23:47 GMT+08:00 wm4 : > > > > > On Thu, 24 Sep 2015 23:41:03 +0800 > > > Ching-Yi Chan wrote: > > >

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-09-24 Thread Ching-Yi Chan
I do it with AVFMT_FLAG_FAST_SEEK flag. 2015-09-24 23:47 GMT+08:00 wm4 : > On Thu, 24 Sep 2015 23:41:03 +0800 > Ching-Yi Chan wrote: > > > Is it acceptable to provide an option for different methods > > between accuracy seek and fast but inaccurate. > > > > F

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-09-24 Thread Ching-Yi Chan
Is it acceptable to provide an option for different methods between accuracy seek and fast but inaccurate. For example, mp3dec having "usetoc" option to seek by toc. 2015-09-24 22:02 GMT+08:00 Hendrik Leppkes : > On Thu, Sep 24, 2015 at 2:44 PM, Ching-Yi Chan > wrote:

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-09-24 Thread Ching-Yi Chan
I found the generic seek will invoke the flac_read_timestamp function. It read exta packet will slow down the seek time https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/flacdec.c#L224 2015-09-24 17:27 GMT+08:00 Ching-Yi Chan : > Hi Hendrik, > > I move the index data into AVSt

Re: [FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-09-24 Thread Ching-Yi Chan
Hi Hendrik, I move the index data into AVStream, but seeking is slow. (it try to download many data). Is there something wrong ? 2015-09-24 16:09 GMT+08:00 Hendrik Leppkes : > On Thu, Sep 24, 2015 at 9:08 AM, Ching-Yi Chan > wrote: > > flacdec is not supported fast-seek yet. >

[FFmpeg-devel] [PATCH] avformat/flacdec: support fast-seek

2015-09-24 Thread Ching-Yi Chan
flacdec is not supported fast-seek yet. changes: 1. parse the seekpoint from metadata block 2. add seek callback to look up seek position 0001-avformat-flacdec-support-fast-seek.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel