On Sun, Dec 11, 2022 at 2:34 PM Chris Ribble wrote:
>
> This looks great and I've confirmed it fixes the issue. I see the
> warning on STDERR about ignoring the trun box: "Ignoring trun box with
> zero sized samples", which is great.
>
Actually, this introd
On Sun, Dec 11, 2022 at 5:55 AM Marton Balint wrote:
>
> Patch 03d81a044ad587ea83567f75dc36bc3d64278199 disallowed zero sample sizes,
> but there are some files in the wild which have zero sized samples (e.g.
> no audio in some part of a live recording).
>
> Fix this by simply ignoring a trun box
On Mon, Dec 5, 2022 at 12:04 PM Marton Balint wrote:
>
> Share the sample please. If the patch I proposed does not fix it, I am not
> sure what is the best approach here.
>
Sure, I will send you the URL to the file so that you can try it.
___
ffmpeg-dev
> More strict enforcement of sample size was introduced to avoid DOS/Timeout
> with crafted (fuzzed) files and disallow emitting zero sized packets.
>
> Invalid file support is not something that is always worth doing, there
> are other, more important factors, like limiting code complexity or
> im
On Thu, Dec 1, 2022 at 4:51 PM Marton Balint wrote:
>
> Can you explain why those files are considered valid, or why it makes
> sense to generate such files?
>
> Thanks,
> Marton
>
As far as I can tell, the file that a user provided with this problem
was generated by an encoder (running FFmpeg 3.
This reverts commit 03d81a044ad587ea83567f75dc36bc3d64278199.
This change broke the ability to read mp4 files which contain a trun
atom with a sample of size zero (FFmpeg exits while parsing the moof).
Signed-off-by: Chris Ribble
---
libavformat/mov.c | 2 --
1 file changed, 2 deletions
Fix ticket: 8693
Based on implementation in hlsenc.c
Signed-off-by: Chris Ribble
---
libavformat/dashenc.c | 67 ++-
1 file changed, 53 insertions(+), 14 deletions(-)
diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index 81a5c2b452..593c416850
ADTS frames may contain up to 768 bytes per channel. With 16 channels,
this is 12k, which cannot fit into the maximum 8k buffer.
Signed-off-by: Chris Ribble
---
libavformat/adtsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/adtsenc.c b/libavformat
> Hello Chris Ribble
>
>
>
> Looks you are working for http patch ,
>
> Can you share a test script for it ?
>
There is a description of the problem in the Trac ticket along with an
example of how to reproduce the issue:
https://trac.ffmpeg.org/ticket/8693
Let m
On Tue, Jun 2, 2020 at 12:22 AM Siyuan Huang
wrote:
> Hello Chris Ribble
>
>
>
> Looks you are working for http patch ,
>
> Can you share a test script for it ?
>
>
Siyuan Huang,
There is a description of the problem in the Trac ticket along with an
example of how to
Fix ticket: 8693
Based on implementation in hlsenc.c
Signed-off-by: Chris Ribble
---
libavformat/dashenc.c | 67 ++-
1 file changed, 53 insertions(+), 14 deletions(-)
diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index 00a37b175d..a45d9bc7d0
11 matches
Mail list logo
