On Mon, Jan 21, 2019 at 1:55 PM Moritz Barsnick wrote:
> On Mon, Jan 21, 2019 at 12:38:58 -0500, FeRD (Frank Dana) wrote:
>
> > After applying both patches, 'make fate' succeeds and ffmpeg is still
> > functional.
>
> You're not allowed to break fate (or co
On Mon, Jan 21, 2019 at 3:54 PM James Almer wrote:
> On 1/21/2019 4:09 PM, FeRD (Frank Dana) wrote:
> > diff --git a/libavutil/common.h b/libavutil/common.h
> > index 8db0291170..0bff7f8f72 100644
> > --- a/libavutil/common.h
> > +++ b/libavutil/common.h
> &
On Tue, Jan 22, 2019 at 8:15 AM Moritz Barsnick wrote:
> On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote:
> > Well... not *purely* cosmetic. See [1] for an example of one issue.
> Ruby's
>
> > `ruby/config.h` header also defines an `RSHIFT` macro, with different
(due to a conflict with
the RSHIFT macro in the Ruby source, which does perform a
standard bitwise right-shift) can be found at [1].
[1]: https://github.com/OpenShot/libopenshot/issues/164
Signed-off-by: FeRD (Frank Dana)
___
ffmpeg-devel mailing list
ff
Three files in libavcodec/ use the RSHIFT macro from libavutil:
- mpeg4videodec.c
- vp3.c
- vp56.c
All instances of RSHIFT are updated to follow the name-change
in libavutil/common.h (previous commit).
Signed-off-by: FeRD (Frank Dana)
---
libavcodec/mpeg4videodec.c | 4 ++--
libavcodec/vp3.c
on without rounding (see e.g. FORTRAN, IBM XL C/C++), this
seems needlessly confusing.
This change renames RSHIFT to ROUNDED_RSHIFT, matching the naming
style of the ROUNDED_DIV macro.
Signed-off-by: FeRD (Frank Dana)
---
libavutil/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The compiled libavcodec/tests/codec_desc was left out of that dir's
.gitignore when the test was added, so it shows up in 'git status'
as an untracked file if it's been built.
Signed-off-by: FeRD (Frank Dana)
---
libavcodec/tests/.gitignore | 1 +
1 file changed, 1 insert
renames RSHIFT to ROUNDED_RSHIFT, then updates all
uses of the macro to use the new name. (These are all located
in three codec files under libavcodec/.)
Signed-off-by: FeRD (Frank Dana)
---
libavcodec/mpeg4videodec.c | 4 ++--
libavcodec/vp3.c | 16
libavcodec/vp56.c
