On Mon, 2017-07-03 at 11:59 +0200, Paul B Mahol wrote:
>
>
> You are comparing pointer with same pointer increased by some value.
>
> This is wrong way to fix it.
Urgh, you're right, of course. I don't know what I was thinking.
___
ffmpeg-devel mailin
On Mon, 2017-07-03 at 11:43 +0200, Paul B Mahol wrote:
> On 7/2/17, Hein-Pieter van Braam wrote:
> > Fixes: 6503 crash with fuzzed file
> >
> > Signed-off-by: Hein-Pieter van Braam
> > ---
> > libavcodec/interplayvideo.c | 8
> > 1 file changed
Fixes: 6503 crash with fuzzed file
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c
index d6f484a..86530e6 100644
--- a/libavcodec/interplayvideo.c
+++ b
On Sun, 2017-07-02 at 23:24 +0200, Hein-Pieter van Braam wrote:
> Fixes: 6503 crash with fuzzed file
> ---
I messed this up, I'll try to be more careful next time. v2 coming.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http:/
Fixes: 6503 crash with fuzzed file
---
libavcodec/interplayvideo.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c
index d6f484a..4b0e36d 100644
--- a/libavcodec/interplayvideo.c
+++ b/libavcodec/interplayvideo.c
@@ -972,6 +972,
ed on the skip map.
The skip map's encoding is a little convulted, I'll refer to the code
for details.
Values in the decoding map are the same as in format 0x06.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 182 ++
Signed-off-by: Hein-Pieter van Braam
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index 4f46eda..24d2255 100644
--- a/Changelog
+++ b/Changelog
@@ -24,6 +24,7 @@ version :
- roberts video filter
- The x86 assembler default switched from yasm to nasm
ago on it when decoding starts.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 125
libavformat/ipmovie.c | 15 --
2 files changed, 126 insertions(+), 14 deletions(-)
diff --git a/libavcodec/interplayvideo.c b
Interplay MVE can contain up to three different frame formats. They
require different streams of information to render a frame. This patch
changes the IP packet format to prepare for the extra frame formats.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 33
Changes since V1:
* Implemented fixes suggested by Moritz Barsnick (if/else whitespace)
* Strict checking on overread of the IP packet data
* Fixed checking the size of the IP packet header size (6 vs 8)
Changes since V2:
* Correct the header size check found by Paul B Mahol
This patch series
being emitted.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 15 +--
libavformat/ipmovie.c | 16 +++-
2 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c
index df3314d..7c
On Wed, 2017-06-21 at 22:28 +0200, Paul B Mahol wrote:
>
>
> Checks only for 2 bytes.
>
> >
> > +send_buffer = AV_RL8(avpkt->data);
> > +
> > /* decoding map contains 4 bits of information per 8x8 block
> > */
> > -s->decoding_map_size = AV_RL16(avpkt->data);
> > +s->decoding_m
ago on it when decoding starts.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 125
libavformat/ipmovie.c | 15 --
2 files changed, 126 insertions(+), 14 deletions(-)
diff --git a/libavcodec/interplayvideo.c b
ed on the skip map.
The skip map's encoding is a little convulted, I'll refer to the code
for details.
Values in the decoding map are the same as in format 0x06.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 182 ++
Signed-off-by: Hein-Pieter van Braam
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index a893efa..bb02a62 100644
--- a/Changelog
+++ b/Changelog
@@ -22,6 +22,7 @@ version :
- headphone audio filter
- superequalizer audio filter
- roberts video filter
Interplay MVE can contain up to three different frame formats. They
require different streams of information to render a frame. This patch
changes the IP packet format to prepare for the extra frame formats.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 33
being emitted.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 13 -
libavformat/ipmovie.c | 16 +++-
2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c
index df3314d..9f
Changes since V1:
* Implemented fixes suggested by Moritz Barsnick (if/else whitespace)
* Strict checking on overread of the IP packet data
* Fixed checking the size of the IP packet header size (6 vs 8)
This patch series implement the previously unknown opcodes 0x06, 0x0E,
and 0x010 for Interp
I've resubmitted the patch in a more reviewable format here:
http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212532.html
having said that:
On Mon, 2017-06-19 at 14:22 +0200, Moritz Barsnick wrote:
> On Sat, Jun 17, 2017 at 19:13:52 +0200, Hein-Pieter van Braam wrote:
> >
ed on the skip map.
The skip map's encoding is a little convulted, I'll refer to the code
for details.
Values in the decoding map are the same as in format 0x06.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 179 ++
Signed-off-by: Hein-Pieter van Braam
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index cd91f63..c05b6ef 100644
--- a/Changelog
+++ b/Changelog
@@ -20,6 +20,7 @@ version :
- sofalizer filter switched to libmysofa
- Gremlin Digital Video demuxer and
ago on it when decoding starts.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 125
libavformat/ipmovie.c | 15 --
2 files changed, 126 insertions(+), 14 deletions(-)
diff --git a/libavcodec/interplayvideo.c b
Interplay MVE can contain up to three different frame formats. They
require different streams of information to render a frame. This patch
changes the IP packet format to prepare for the extra frame formats.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 28
This patch series implement the previously unknown opcodes 0x06, 0x0E,
and 0x010 for Interplay MVE movies.
With this series every MVE sample[0] plays correctly, but I have some
doubts as to the implementation of the extra two AVFrames necessary for
format 0x10. If someone has a better idea on how
being emitted.
Signed-off-by: Hein-Pieter van Braam
---
libavcodec/interplayvideo.c | 13 -
libavformat/ipmovie.c | 16 +++-
2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c
index df3314d..9f
Interplay movies signal the end of the stream, currently decoding
continues and eventually returns AVERROR_INVALIDDATA.
This honors the MVE CHUNK_END and CHUNK_SHUTDOWN types.
Signed-off-by: Hein-Pieter van Braam
---
libavformat/ipmovie.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
s!
- HPFrom e8a45ce4748e395e829c664c61b57e3c2e9d9fc8 Mon Sep 17 00:00:00 2001
From: Hein-Pieter van Braam
Date: Fri, 16 Jun 2017 22:02:43 +0200
Subject: [PATCH] Implement support for interplay MVE 0x06 and 0x10
---
libavcodec/interplayvideo.c | 276 +---
libavform
lso fixed reading garbage data from the 'last frame' on the very
first frame.
- HP
On Sat, 2017-06-17 at 15:08 +0200, Hein-Pieter van Braam wrote:
> Hi all,
>
> This patch implements support for 3 previously unknown Interplay MVE
> opcodes. These opcodes together implement
aling that the end of the file has been reached. I've made no
attempt to fix that in this patch. I'll create a separate patch to fix
this issue.
- HPFrom 1f6d7a95748bb9f567c9cb97f2be3ff5c43140ea Mon Sep 17 00:00:00 2001
From: Hein-Pieter van Braam
Date: Fri, 16 Jun 2017 22:02:43 +0200
Sub
29 matches
Mail list logo
