[FFmpeg-devel] [PATCH] avformat/rtsp: fix wrong codec setup for some sdp

2019-10-28 Thread Hyun Yoo
s same for 'm=' and 'a=' but it is unsupported codec then st->codecpar->id will be the next one in 'a='(if it's supported) Signed-off-by: Hyun Yoo --- libavformat/rtsp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtsp.c b/libavforma

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-20 Thread Hyun Yoo
2019년 9월 20일 (금) 오후 10:49, Nicolas George 님이 작성: > Hyun Yoo (12019-09-20): > > So non-free codec should be in ffmpeg internally/externally > > and fdk-aac is an exception. got it. > > No, you did not get it. fdk-aac is not an exception, it is open-source. > Sorry for ty

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-20 Thread Hyun Yoo
On Thu, Sep 19, 2019 at 4:10 PM Tomas Härdin wrote: > > tor 2019-09-19 klockan 13:58 +0900 skrev Hyun Yoo: > > On Thu, Sep 19, 2019 at 7:28 AM Carl Eugen Hoyos wrote: > > > Am Di., 17. Sept. 2019 um 02:37 Uhr schrieb Hyun Yoo > > > : > > > >

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Hyun Yoo
On Thu, Sep 19, 2019 at 7:28 AM Carl Eugen Hoyos wrote: > > Am Di., 17. Sept. 2019 um 02:37 Uhr schrieb Hyun Yoo : > > > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > > as external lib like libilbc, libspeex(ex. configure --enable-libg7

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-17 Thread Hyun Yoo
According to wiki, g.722.1 is not variants of G.722 and they use different patented compression technologies. There is a reference code in ITU-T https://www.itu.int/rec/T-REC-G.722.1-200505-I/en and the freeswitch version is a wrapper with cleaner api. (I recently contacted the freeswitch guy and

[FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-16 Thread Hyun Yoo
I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) (https://github.com/traviscross/freeswitch/tree/master/libs/libg722_1) But I'm not sure about the license issue because g.722.1 is licensed by Polycom(royalty-

[FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-08 Thread Hyun Yoo
From: EaseTheWorld rtsp_st->sdp_payload_type is the first codec in 'm=' tag st->codecpar->id is the first supported codec in 'a=' tag the two is not guaranteed to be same for example when 1) the order between attributes is random(rfc4566 doesn't force it) 2) the first codec is same for 'm=' and '

Re: [FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-07 Thread Hyun Yoo
il commit the same patch again? 2019년 9월 8일 (일) 오전 4:28, Michael Niedermayer 님이 작성: > On Sat, Sep 07, 2019 at 07:23:13PM +0900, Hyun Yoo wrote: > > From: Hyun Yoo > > > > rtsp_st->sdp_payload_type is the first codec in 'm=' tag > > st->codecpar->id is t

[FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-07 Thread Hyun Yoo
From: Hyun Yoo rtsp_st->sdp_payload_type is the first codec in 'm=' tag st->codecpar->id is the first supported codec in 'a=' tag the two is not guaranteed to be same for example when 1) the order between attributes is random(rfc4566 doesn't force it) 2) the f