Re: [FFmpeg-devel] [PATCH] avcodec/amf_enc: av1 cropping support

2024-07-23 Thread James Almer
On 7/23/2024 6:53 PM, Araz Iusubov wrote: --- libavcodec/amfenc_av1.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index d40c71cb33..27599b9fbe 100644 ---

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread James Almer
On 7/23/2024 1:24 PM, Paul B Mahol wrote: On Tue, Jul 23, 2024 at 6:17 PM Paul B Mahol wrote: On Tue, Jul 23, 2024 at 5:17 PM James Almer wrote: On 7/19/2024 12:31 PM, Paul B Mahol wrote: Internal/private filter structures/API changes does not need be mentioned in that file, isn't

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread James Almer
On 7/19/2024 12:31 PM, Paul B Mahol wrote: Internal/private filter structures/API changes does not need be mentioned in that file, isn't that fact obvious even for average Joe? There's no reason to be condescending or aggressive over something so irrelevant. Is it so hard to just state the

Re: [FFmpeg-devel] [PATCH 2/2] web: move 4.1 to olddownloads

2024-07-22 Thread James Almer
On 7/21/2024 10:50 AM, Michael Niedermayer wrote: No distros are listed on downstreams that are not EOL that use 4.1 --- src/download| 37 - src/olddownload | 37 + 2 files changed, 37 insertions(+), 37 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] web: move 6.0 to olddownloads

2024-07-22 Thread James Almer
On 7/21/2024 10:50 AM, Michael Niedermayer wrote: Only ubuntu 23.10 uses 6.0 according to downstreams and that is EOL in a few days also 23.10 users will probably upgrade to 24.04 LTS so shouldnt affect anyone --- src/download| 36 src/olddownload |

Re: [FFmpeg-devel] [PATCH 2/4 v2] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-21 Thread James Almer
On 7/21/2024 9:02 PM, Lynne via ffmpeg-devel wrote: On 22/07/2024 00:53, James Almer wrote: Signed-off-by: James Almer ---   libavcodec/h2645_sei.c | 37 +   libavcodec/h2645_sei.h |  5 +   libavcodec/itut35.h    |  2 ++   3 files changed, 44 insertions

[FFmpeg-devel] [PATCH 4/4 v2] avcodec/h264dec: add support for LCEVC enhancement

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- configure | 2 +- libavcodec/avcodec.h | 5 + libavcodec/h264_picture.c | 1 + libavcodec/h264_slice.c | 15 ++ libavcodec/h264dec.c | 41 --- libavcodec/h264dec.h | 3 +++ 6

[FFmpeg-devel] [PATCH 3/4 v2] avcodec: add LCEVC decoding support via LCEVCdec

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- configure | 3 + doc/general_contents.texi | 13 ++ libavcodec/Makefile | 1 + libavcodec/lcevcdec.c | 276 ++ libavcodec/lcevcdec.h | 44 ++ 5 files changed, 337 insertions(+) create mode

[FFmpeg-devel] [PATCH 2/4 v2] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 37 + libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed, 44 insertions(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 7c83747cd0..61d18e14b3 100644

[FFmpeg-devel] [PATCH 1/4 v2] avutil/frame: add an LCEVC enhancement data payload side data type

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 1 + libavutil/frame.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 673a9afb3b..8da5eb28c8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -46,6 +46,7 @@ static const

Re: [FFmpeg-devel] [PATCH 2/4] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-20 Thread James Almer
On 7/20/2024 8:38 PM, Michael Niedermayer wrote: On Sat, Jul 20, 2024 at 09:45:08AM -0300, James Almer wrote: Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 36 libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed

[FFmpeg-devel] [PATCH 4/4] avcodec/h264dec: add support for LCEVC enhancement

2024-07-20 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile | 2 +- libavcodec/avcodec.h | 5 libavcodec/h264_picture.c | 1 + libavcodec/h264_slice.c | 19 libavcodec/h264dec.c | 48 --- libavcodec/h264dec.h | 3 +++ 6

[FFmpeg-devel] [PATCH 3/4] avcodec: add LCEVC decoding support via LCEVCdec

2024-07-20 Thread James Almer
Signed-off-by: James Almer --- configure | 5 +- doc/general_contents.texi | 13 ++ libavcodec/h264dec.c | 1 + libavcodec/lcevcdec.c | 276 ++ libavcodec/lcevcdec.h | 39 ++ 5 files changed, 333 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 2/4] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-20 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 36 libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed, 43 insertions(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 7c83747cd0..90e59df781 100644

[FFmpeg-devel] [PATCH 1/4] avutil/frame: add an LCEVC enhancement data payload side data type

2024-07-20 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 1 + libavutil/frame.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 0775e2abd9..246634967c 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -46,6 +46,7 @@ static const

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Check extradata in mov_read_iacb()

2024-07-19 Thread James Almer
On 7/19/2024 5:10 AM, Michael Niedermayer wrote: On Thu, Jul 18, 2024 at 07:19:17PM -0300, James Almer wrote: On 7/18/2024 7:16 PM, Michael Niedermayer wrote: Fixes: MemLeak Fixes: 69853/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4660448545275904 Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

2024-07-19 Thread James Almer
On 7/10/2024 11:54 AM, Andrew Sayers wrote: On Wed, Jul 10, 2024 at 04:01:44PM +0200, Paul B Mahol wrote: tile and untile are wrong How so? I think it's better to just make those filters use ints than changing what the API is documented to handle.

[FFmpeg-devel] [PATCH] avformat/iamf_parse: sanitize audio_roll_distance values

2024-07-18 Thread James Almer
Ensure the values are spec complaint and that no integer overflow can happen. Signed-off-by: James Almer --- libavformat/iamf_parse.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c index a176c7d13a

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Check extradata in mov_read_iacb()

2024-07-18 Thread James Almer
On 7/18/2024 7:16 PM, Michael Niedermayer wrote: Fixes: MemLeak Fixes: 69853/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4660448545275904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_demux: don't insert the crop filter if frame cropping side data defines no cropping

2024-07-17 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg_demux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 528e02149f..6f7d78c896 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1014,7 +1014,8 @@ int

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: use the correct specifier for crop arguments

2024-07-17 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 097bd2ed48..b562e8417c 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1703,7 +1703,7

[FFmpeg-devel] [PATCH 1/2] avformat/mov: don't export frame cropping stream side data when the clap box is a no-op

2024-07-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ce95842ce5..20efc74f00 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1262,6 +1262,9 @@ static int mov_read_clap(MOVContext *c

Re: [FFmpeg-devel] [PATCH 12/39] lavc/ffv1: drop redundant FFV1Context.quant_table

2024-07-17 Thread James Almer
On 7/17/2024 7:37 PM, Michael Niedermayer wrote: On Tue, Jul 16, 2024 at 07:11:27PM +0200, Anton Khirnov wrote: In all cases except decoding version 1 it's either not used, or contains a copy of a table from quant_tables, which we can just as well use directly. When decoding version 1, we can

Re: [FFmpeg-devel] [PATCH 1/4] avformat/movenc: fix channel count and samplerate fields for IAMF tracks

2024-07-17 Thread James Almer
On 7/17/2024 3:18 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-17 03:49:22) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2bea55e33d..5de188f4cf 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1399,6 +1399,11 @@ static int mov_write_audio_tag

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/videotoolboxenc: Fix variable type of AV_OPT_TYPE_BOOL

2024-07-16 Thread James Almer
On 7/16/2024 11:53 AM, Rémi Denis-Courmont wrote: Le tiistaina 16. heinäkuuta 2024, 17.46.53 EEST Zhao Zhili a écrit : From: Zhao Zhili --- libavcodec/videotoolboxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c

Re: [FFmpeg-devel] [PATCH] avformat/mov: sanity check count in IPRP

2024-07-16 Thread James Almer
On 7/16/2024 10:19 AM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 69230/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6540512101203968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h265: fix range of sps_max_sub_layers_minus1

2024-07-15 Thread James Almer
On 7/13/2024 11:58 AM, James Almer wrote: The VPS referenced by the SPS must always be present as the max value for sps_max_sub_layers_minus1 is vps_max_sub_layers_minus1. This replaces a buggy custom range check for the aforementioned field. Also, add the missing conformance check

Re: [FFmpeg-devel] [PATCH 5/5] avformat/iamf: Check substreams in ff_iamf_free_audio_element()

2024-07-15 Thread James Almer
On 6/23/2024 8:01 PM, Michael Niedermayer wrote: Fixes: member access within null pointer of type 'IAMFSubStream' (aka 'struct IAMFSubStream') Fixes: 69795/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-6216287009701888 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add support for 3D Reference Displays Information SEI

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 6 libavcodec/cbs_h265.h | 16 ++ libavcodec/cbs_h265_syntax_template.c | 42 +++ 3 files changed, 64 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec

[FFmpeg-devel] [PATCH 3/4] avcodec/cbs_h265: reindent after the previous commit

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 124 +- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 2f8ee0db10..1826950e8e 100644

[FFmpeg-devel] [PATCH 2/4] avcodec/cbs_h265: add partial support for Multilayer extension fields in parameter set NALUs

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 3 +- libavcodec/cbs_h265.h | 44 ++ libavcodec/cbs_h265_syntax_template.c | 113 +- libavcodec/hevc/ps.h | 4 +- 4 files changed, 159 insertions(+), 5

[FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h265: fix range of sps_max_sub_layers_minus1

2024-07-13 Thread James Almer
-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 37 +++ 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 86ca00a0c9..c6db439b3b 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH v2] avcodec/bsf/showinfo: print packet data checksum

2024-07-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bsf/showinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c index 4e31e0b5cb..715b160b60 100644 --- a/libavcodec/bsf/showinfo.c +++ b/libavcodec/bsf/showinfo.c @@ -23,6

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

2024-07-13 Thread James Almer
On 7/13/2024 10:46 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-12 02:33:06) Same as the framecrc muxer. IOW obfuscated and user-hostile. Please don't. You mean to not implement this in any form, or try to make it more user friendly? I could remove the flags (which is admittedly

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

2024-07-12 Thread James Almer
On 7/12/2024 4:34 PM, Michael Niedermayer wrote: On Fri, Jul 12, 2024 at 01:57:43PM -0300, James Almer wrote: On 7/12/2024 1:53 PM, Michael Niedermayer wrote: On Thu, Jul 11, 2024 at 01:31:23PM +, James Almer wrote: ffmpeg | branch: master | James Almer | Mon Jul 8 20:50:18 2024 -0300

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

2024-07-12 Thread James Almer
On 7/12/2024 1:53 PM, Michael Niedermayer wrote: On Thu, Jul 11, 2024 at 01:31:23PM +, James Almer wrote: ffmpeg | branch: master | James Almer | Mon Jul 8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer avformat/mov: export cropping values from

[FFmpeg-devel] [PATCH] fate/lavf-container: add a test for L-HEVC remuxing

2024-07-12 Thread James Almer
Signed-off-by: James Almer --- tests/fate-run.sh | 4 ++-- tests/fate/lavf-container.mak | 28 +++- tests/ref/lavf-fate/mv_hevc.mp4 | 3 +++ 3 files changed, 20 insertions(+), 15 deletions(-) create mode 100644 tests/ref/lavf-fate/mv_hevc.mp4 diff

[FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum

2024-07-11 Thread James Almer
Signed-off-by: James Almer --- libavcodec/bsf/showinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c index 0899263545..57da3fc73c 100644 --- a/libavcodec/bsf/showinfo.c +++ b/libavcodec/bsf/showinfo.c @@ -23,6

[FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

2024-07-11 Thread James Almer
Same as the framecrc muxer. This will allow callers to analize changes in these values between filters within a list. Signed-off-by: James Almer --- libavcodec/bsf/showinfo.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

2024-07-11 Thread James Almer
On 7/11/2024 6:00 PM, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:54 AM, Martin Storsjö wrote: On Thu, 11 Jul 2024, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

2024-07-11 Thread James Almer
On 7/11/2024 10:54 AM, Martin Storsjö wrote: On Thu, 11 Jul 2024, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300

[FFmpeg-devel] [PATCH] x86/intreadwrite: add missing casts to pointer arguments

2024-07-11 Thread James Almer
Should make strict compilers happy. Also, make AV_COPY128 use integer operations while at it. Signed-off-by: James Almer --- libavutil/x86/intreadwrite.h | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavutil/x86/intreadwrite.h b/libavutil/x86

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

2024-07-11 Thread James Almer
On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300| [bd1bcb07e0f29c135103a402d71b343a09ad1690] | committer: James Almer x86/intreadwrite: use intrinsics instead of inline asm

Re: [FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR

2024-07-11 Thread James Almer
On 7/9/2024 5:32 PM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/vf_crop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 6361209941..d4966323f5 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure pasp box derived SAR is used if present

2024-07-11 Thread James Almer
On 7/9/2024 2:21 PM, James Almer wrote: It's meant to override any codec specific (but container level) information, but its position is not guaranteed, so apply the values after the entire trak structure has been parsed. Also, replace the ugly roundabout int -> double -> int method to s

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: export cropping values from clap boxes

2024-07-11 Thread James Almer
On 7/8/2024 10:55 PM, James Almer wrote: Addresses part of ticket #7437. Signed-off-by: James Almer --- libavformat/mov.c | 78 + tests/ref/fate/aic | 32 +- tests/ref/fate/prores-transparency | 4 +- tests

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: use a bprint buffer for the crop filter arguments

2024-07-10 Thread James Almer
Should ensure no truncation ocurrs. The input sample aspect ratio applies to the pre-cropping dimensions, so update it. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check

2024-07-10 Thread James Almer
On 7/9/2024 5:43 AM, epira...@gmail.com wrote: On 8 Jul 2024, at 8:30, Zhao Zhili wrote: From: Zhao Zhili --- libavutil/hwcontext_videotoolbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure pasp box derived SAR is used if present

2024-07-10 Thread James Almer
On 7/10/2024 1:02 PM, Leo Izen wrote: On 7/9/24 1:21 PM, James Almer wrote: It's meant to override any codec specific (but container level) information, but its position is not guaranteed, so apply the values after the entire trak structure has been parsed. Also, replace the ugly roundabout

Re: [FFmpeg-devel] [PATCH v2] avutil/imgutils: av_image_check_size2() ensure width and height fit in 32bit

2024-07-10 Thread James Almer
On 7/10/2024 12:49 PM, Michael Niedermayer wrote: width and height > 32bit is not supported and its easier to check in a central place Signed-off-by: Michael Niedermayer --- libavutil/imgutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/imgutils.c

[FFmpeg-devel] [PATCH 2/2] doc/demuxers: mention support for Image File Format

2024-07-10 Thread James Almer
Signed-off-by: James Almer --- doc/demuxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 04293c4813..986c427b1f 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -853,9 +853,9 @@ Range is from 1000 to INT_MAX

[FFmpeg-devel] [PATCH 1/2] avcodec/packet: mention an example source for frame cropping information

2024-07-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/packet.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index 13667ffa36..fa73edaf85 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -328,7 +328,8 @@ enum AVPacketSideDataType

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: set keep_aspect to true for the crop filter

2024-07-10 Thread James Almer
On 7/10/2024 5:29 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-09 21:06:26) The input sample aspect ratio applies to the pre-cropping dimensions, so update it. I don't understand this reasoning, why should cropping a video change pixel aspect ratio? You're right, this patch

[FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR

2024-07-09 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_crop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 6361209941..d4966323f5 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter/vf_crop.c @@ -206,7 +206,7 @@ static int

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: set keep_aspect to true for the crop filter

2024-07-09 Thread James Almer
The input sample aspect ratio applies to the pre-cropping dimensions, so update it. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 097bd2ed48..0d85c30aba 100644

[FFmpeg-devel] [PATCH] avformat/mov: ensure pasp box derived SAR is used if present

2024-07-09 Thread James Almer
while at it. Signed-off-by: James Almer --- libavformat/isom.h | 2 ++ libavformat/mov.c | 16 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index a0498f45e5..5b6125a908 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: support writing cropping values

2024-07-08 Thread James Almer
Finishes implementing ticket #7437. Signed-off-by: James Almer --- libavformat/movenc.c| 56 +++-- tests/ref/fate/copy-trac236 | 16 +-- 2 files changed, 50 insertions(+), 22 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c

[FFmpeg-devel] [PATCH 1/2] avformat/mov: export cropping values from clap boxes

2024-07-08 Thread James Almer
Addresses part of ticket #7437. Signed-off-by: James Almer --- libavformat/mov.c | 78 + tests/ref/fate/aic | 32 +- tests/ref/fate/prores-transparency | 4 +- tests/ref/fate/prores-transparency_skip | 4 +- 4

Re: [FFmpeg-devel] [PATCH 3/4] avformat/matroskaenc: Only write useful cropping values

2024-07-08 Thread James Almer
On 7/8/2024 2:52 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 4b91283119..a98d33abf3 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: Fix and simplify check for invalid crop values

2024-07-08 Thread James Almer
On 7/8/2024 2:24 PM, Andreas Rheinhardt wrote: The check "left >= INT_MAX - right" is supposed to check for whether left + right does not overflow/wraparound, but given that left and top are uint32_t INT_MAX - right can already wraparound for big values of right (and ordinary 32-bit ints): If

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Fix potential stack-buffer-overflow

2024-07-08 Thread James Almer
On 7/8/2024 2:09 PM, Andreas Rheinhardt wrote: Forgotten in f194f291d8082134cdce625b0ca3548067428ea9 Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: Fix member access within null pointer

2024-07-08 Thread James Almer
On 7/8/2024 12:58 PM, Andreas Rheinhardt wrote: This "works" because the public AVCodecHWConfig is at the beginning of AVCodecHWConfigInternal. Fixes libavcodec/decode.c:1035:61: runtime error: member access within null pointer of type 'const struct AVCodecHWConfigInternal'. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 6/6] avfilter/af_surround: Check av_channel_layout_channel_from_index() stays within the fixed array used

2024-07-07 Thread James Almer
On 7/7/2024 6:59 PM, Michael Niedermayer wrote: On Sun, Jul 07, 2024 at 09:12:06PM +0200, Andreas Rheinhardt wrote: Andreas Rheinhardt: Michael Niedermayer: Fixes: CID1516994 Out-of-bounds access Fixes: CID1516996 Out-of-bounds access Fixes: CID1516999 Out-of-bounds access Sponsored-by:

[FFmpeg-devel] [PATCH] avcodec/cbs_h265: fix range of sps_max_sub_layers_minus1

2024-07-07 Thread James Almer
-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 37 +++ 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 86ca00a0c9..c6db439b3b 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-07 Thread James Almer
On 7/7/2024 12:43 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/mov.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a3951a6942..30e8086855 100644

Re: [FFmpeg-devel] [PATCH 04/11] avformat/hevc: don't write NALUs with nuh_layer_id > 0 in hvcC boxes

2024-07-07 Thread James Almer
On 7/7/2024 12:46 PM, Andreas Rheinhardt wrote: James Almer: hvcC should only contain nuh_layer_id == 0 NALUs. Support for a box meant to contain higher layer NALUs will be added in a following patch. To achieve this, all sources are parsed and filtered, including hvcC source that until now

Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-07 Thread James Almer
On 7/3/2024 6:26 PM, James Almer wrote: Signed-off-by: James Almer --- libavformat/mov.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a3951a6942..30e8086855 100644 --- a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_tiltandshift: fix buffer offset for yuv422p input

2024-07-06 Thread James Almer
On 7/4/2024 2:58 PM, James Almer wrote: Fixes ticket #10950. Signed-off-by: James Almer --- libavfilter/vf_tiltandshift.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshift.c index 85cce84fc3..b49a713339

Re: [FFmpeg-devel] [PATCH 3/6] avformat/matroskadec: export cropping values

2024-07-05 Thread James Almer
On 6/1/2024 8:24 AM, Kacper Michajlow wrote: On Wed, 29 May 2024 at 23:47, James Almer wrote: Signed-off-by: James Almer --- libavformat/matroskadec.c | 53 +++ 1 file changed, 43 insertions(+), 10 deletions(-) diff --git a/libavformat/matroskadec.c b

Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff

2024-07-05 Thread James Almer
On 7/5/2024 2:18 PM, Martin Storsjö wrote: On Fri, 5 Jul 2024, James Almer wrote: On 7/5/2024 2:38 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-04 22:45:28) On 7/4/2024 4:04 PM, Anton Khirnov wrote: Filter output is not bitexact. --- Reference file at https://up.khirnov.net/7r.pcm

Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff

2024-07-05 Thread James Almer
On 7/5/2024 2:38 AM, Anton Khirnov wrote: Quoting James Almer (2024-07-04 22:45:28) On 7/4/2024 4:04 PM, Anton Khirnov wrote: Filter output is not bitexact. --- Reference file at https://up.khirnov.net/7r.pcm, please put it in filter-reference/atempo.pcm How did you create it? x86_32 uses

Re: [FFmpeg-devel] [PATCH 3/3] lavf: deprecate avformat_transfer_internal_stream_timing_info()

2024-07-05 Thread James Almer
On 7/5/2024 7:42 AM, Anton Khirnov wrote: And av_stream_get_codec_timebase(). They were both added for ffmpeg CLI, which no longer calls either of them. Furthermore the notion of "internal stream timing info" that needs to be transferred with a special magic API function is fundamentally flawed

Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff

2024-07-04 Thread James Almer
On 7/4/2024 4:04 PM, Anton Khirnov wrote: Filter output is not bitexact. --- Reference file at https://up.khirnov.net/7r.pcm, please put it in filter-reference/atempo.pcm How did you create it? x86_32 uses x87 floats which are a lot more precise than sse ones, for example, so it's best to

[FFmpeg-devel] [PATCH 2/2] fate/filter-video: tests more pixel formats with the tiltandshift filter

2024-07-04 Thread James Almer
Signed-off-by: James Almer --- tests/fate/filter-video.mak| 4 +- tests/ref/fate/filter-tiltandshift-422 | 55 ++ tests/ref/fate/filter-tiltandshift-444 | 55 ++ 3 files changed, 113 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_tiltandshift: fix buffer offset for yuv422p input

2024-07-04 Thread James Almer
Fixes ticket #10950. Signed-off-by: James Almer --- libavfilter/vf_tiltandshift.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshift.c index 85cce84fc3..b49a713339 100644 --- a/libavfilter/vf_tiltandshift.c

Re: [FFmpeg-devel] Sorry state of AVOptions

2024-07-04 Thread James Almer
On 7/4/2024 11:44 AM, Paul B Mahol wrote: The AVOptions state is extremely ugly. It is insane to request from library users to convert non-strings option values from/to strings to be able to read/change them, it is ugly, av_opt_{get,set,eval}_{int,double,etc}? inefficient, and slow. This

[FFmpeg-devel] [PATCH 11/11] avformat/movenc: add support for writting hfov boxes

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 500ea25731..5f4c1cb6ea 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2195,6 +2195,17 @@ static inline

[FFmpeg-devel] [PATCH 10/11] avformat/movenc: add support for writting vexu boxes

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 159 +-- 1 file changed, 154 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 26a67e6e47..500ea25731 100644 --- a/libavformat/movenc.c +++ b/libavformat

[FFmpeg-devel] [PATCH 08/11] avformat/hevc: add a function to write a lhvC box

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 163 +++-- libavformat/hevc.h | 17 + 2 files changed, 145 insertions(+), 35 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index f3e5542699..69e6f719e5 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 07/11] avformat/hevc: store parameter set and layer IDs in HVCCNALUnit

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index 6fe701032b..f3e5542699 100644 --- a/libavformat/hevc.c +++ b/libavformat/hevc.c @@ -45,6 +45,8 @@ enum

[FFmpeg-devel] [PATCH 09/11] avformat/movenc: add support for writing lhvC boxes

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index f8eb6fadf7..26a67e6e47 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1557,6

[FFmpeg-devel] [PATCH 06/11] avformat/hevc: use a single array for per-PS NALUs

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index 40f46668f9..6fe701032b 100644 --- a/libavformat/hevc.c +++ b/libavformat/hevc.c @@ -40,15 +40,20

[FFmpeg-devel] [PATCH 05/11] avformat/hevc: don't write the same array values per nal addition

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index 651c3b4b1d..40f46668f9 100644 --- a/libavformat/hevc.c +++ b/libavformat/hevc.c @@ -672,11 +672,9

[FFmpeg-devel] [PATCH 04/11] avformat/hevc: don't write NALUs with nuh_layer_id > 0 in hvcC boxes

2024-07-03 Thread James Almer
reference files now have ps_array_completeness set to 0 instead of 1 for some non-PS NALUs. Signed-off-by: James Almer --- libavformat/hevc.c | 140 - libavformat/hevc.h | 3 +- tests/ref/fate/enhanced-flv-hevc | 4

[FFmpeg-devel] [PATCH 03/11] avformat/mov: Mark streams with a layered HEVC box as multilayer

2024-07-03 Thread James Almer
From: Derek Buitenhuis Signed-off-by: Derek Buitenhuis Signed-off-by: Anton Khirnov Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 30e8086855..b27666f50f 100644 --- a/libavformat/mov.c +++ b

[FFmpeg-devel] [PATCH 02/11] avformat: Add a new stream disposition for multilayer video

2024-07-03 Thread James Almer
From: Derek Buitenhuis This lets us detect when a container has flagged a stream as multilayer. Signed-off-by: Derek Buitenhuis Signed-off-by: Anton Khirnov Signed-off-by: James Almer --- doc/ffprobe.xsd | 1 + libavformat/avformat.h

[FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a3951a6942..30e8086855 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8157,6 +8157,53

[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: add mixxing codec type to some options

2024-07-02 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 910e4a336b..b0dae46beb 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1495,9 +1495,6 @@ const

Re: [FFmpeg-devel] [PATCH 5/6 v3] fftools/ffmpeg: support applying container level cropping

2024-07-02 Thread James Almer
On 7/2/2024 2:55 PM, Anton Khirnov wrote: Quoting James Almer (2024-07-02 18:49:36) Signed-off-by: James Almer --- doc/ffmpeg.texi | 16 fftools/ffmpeg.h| 15 +++ fftools/ffmpeg_demux.c | 26 ++ fftools/ffmpeg_filter.c

[FFmpeg-devel] [PATCH 5/6 v3] fftools/ffmpeg: support applying container level cropping

2024-07-02 Thread James Almer
Signed-off-by: James Almer --- doc/ffmpeg.texi | 16 fftools/ffmpeg.h| 15 +++ fftools/ffmpeg_demux.c | 26 ++ fftools/ffmpeg_filter.c | 10 ++ fftools/ffmpeg_opt.c| 25 + 5 files changed

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-07-01 Thread James Almer
On 7/1/2024 8:42 PM, Michael Niedermayer wrote: On Sun, Jun 30, 2024 at 08:07:28PM -0300, James Almer wrote: On 6/29/2024 8:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 09:52:44PM -0300, James Almer wrote: On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: remove unused parameter from ff_mjpeg_decode_frame_from_buf

2024-07-01 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mjpegdec.c | 4 ++-- libavcodec/mjpegdec.h | 2 +- libavcodec/sp5xdec.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 7daec649bc..ace25af90e 100644 --- a/libavcodec/mjpegdec.c

Re: [FFmpeg-devel] [PATCH, v2] avformat/mov: get heif image rotation from irot box

2024-07-01 Thread James Almer
On 5/27/2024 12:22 PM, Hacene Bouaroua wrote: parse irot box to get the transformative heif item rotation angle. Signed-off-by: Hacene Bouaroua --- libavformat/avformat.h | 5 + libavformat/isom.h | 1 + libavformat/mov.c | 25 + 3 files changed, 31

[FFmpeg-devel] [PATCH 4/4] avformat/mov: add more checks for infe atom size

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9f6752b492..ba33e52086 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8510,6 +8510,8 @@ static int mov_read_infe(MOVContext *c

[FFmpeg-devel] [PATCH 3/4] avformat/mov: check for EOF inside the infe list parsing loop

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3aa2398386..9f6752b492 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8580,6 +8580,8 @@ static int mov_read_iinf(MOVContext *c

[FFmpeg-devel] [PATCH 2/4] avformat/mov: check extent_offset calculation for overflow

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index fd78d5f59c..3aa2398386 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8482,7 +8482,8 @@ static int mov_read_iloc

[FFmpeg-devel] [PATCH 1/4] avformat/mov: check that iloc offset values fit on an int64_t

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a2e187ff2f..fd78d5f59c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8388,7 +8388,7 @@ static int mov_read_SAND

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-30 Thread James Almer
On 6/29/2024 8:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 09:52:44PM -0300, James Almer wrote: On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328 Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH 2/2] avformat/mov: check that child boxes of trak are only present inside it

2024-06-28 Thread James Almer
Based on the check done for the stco box. Signed-off-by: James Almer --- libavformat/mov.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ba5f85e7e3..a2e187ff2f 100644 --- a/libavformat/mov.c +++ b/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/mov: check that sample and chunk count is 1 for HEIF

2024-06-28 Thread James Almer
Fixes NULL pointer dereference in broken/fuzzed streams. Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 14f43bf906..ba5f85e7e3 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -9904,6

  1   2   3   4   5   6   7   8   9   10   >