On 7/14/21, 7:46 PM, "Kevin LaFlamme" wrote:
>Any feedback on this?
Thanks for the reminder. I have pushed this patch alone from this series.
I had some concerns on v2 of this series, to which I have replied separately.
Thanks and Regards,
Karthick
>On Jun 24, 2021, 8:58 AM -0400, Kevin LaFla
On 6/24/21, 6:28 PM, "Kevin LaFlamme" wrote:
>In streaming mode when using a segment list, the current segment should
>be listed so that clients can immediately request it even before
>complete. Without this, even though the segment is being written in a
>way that it can be requested while sti
On 6/11/21, 9:31 PM, "Kevin LaFlamme" wrote:
>Does my last explanation make sense or if not could you point me to
>where this reasoning is incorrect?
Your reasoning is perfectly fine. Since I haven't heard any objections to your
reply, I have pushed this patch. Thanks.
>
>Kevin LaFlamme
>Dire
From: Limin Wang
>
>Signed-off-by: Limin Wang
>---
>libavformat/dashenc.c | 16 +++-
>1 file changed, 3 insertions(+), 13 deletions(-)
Pushed.
Thanks,
Karthick
>
>diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>index 8a626c1..b7622bc 100644
>--- a/libavformat/dashenc.c
>++
>
>
>On 6/7/21, 12:01 PM, "Valerii Zapodovnikov" wrote:
>
>This reverts commit d6d407d2d758b404af0ce6a8ff46bf164db020a1.
>Hack not needed after a2b1dd0ce301450a47c972745a6b33c4c273aa5d.
>Will fix #7480 and #8904.
>This will include e.g. CODECS="hvc1.2.4.L123.B0" into m3u8.
Pushed.
Thanks, Karthic
>On 5/31/21, 6:00 PM, "Przemysław Sobala" wrote:
>
>Could any maintainer take a look at that?
Pushed with minor indentation changes.
Thanks,
Karthick
>--
>Best regards
>Przemysław Sobala
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://f
On 8/31/20, 9:47 AM, "Chris Miceli" wrote:
>
>In ticket #8754 there is discourse surrounding the error
>message which is printed upon a mismatched aspect ratio in
>derived encodings. This should make it clearer to the user
>as to the issues which they are experiencing.
>---
> libavformat/dashenc.c
On 6/30/20 11:16 AM, Siyuan Huang wrote:
>
> Soory for wrong commit messge
>
> Update to no file mode modify at version2
>
> From efd83d91a9bd9a485bcda6799f5f681c203a7449 Mon Sep 17 00:00:00 2001
> From: Siyuan Huang
> Date: Tue, 30 Jun 2020 13:44:01 +0800
> Subject: [PATCH] libavformat/dashenc.
Pushed the patch, with minor change to commit message.
Thanks,
Karthick
On 6/30/20 11:14 AM, Siyuan Huang wrote:
> Update with no file mode changes :
>
>
>
> From 818095d4f0aa50dfee3cb0622146a2180801c5fe Mon Sep 17 00:00:00 2001
>
> From: Siyuan Huang
>
> Date: Tue, 30 Jun 2020 13:41:46 +0800
>
On 6/22/20 2:13 AM, Przemysław Sobala wrote:
>
> On Wed, Jun 17, 2020 at 1:58 PM Jeyapal, Karthick wrote:
>
>
> On 6/17/20 5:20 PM, Przemysław Sobala wrote:
> > If stream's bitrate is not specified:
> > - for static manifest: an average bit
On 6/17/20 5:20 PM, Przemysław Sobala wrote:
> If stream's bitrate is not specified:
> - for static manifest: an average bitrate will be calculated and used,
> - for dynamic manifest: first segment's bitrate will be calculated and used,
> as before,
> for bandwidth setting in adaptation sets.
> -
Thanks for sending the revised patch. One more comment inline.
On 6/17/20 4:23 PM, Przemysław Sobala wrote:
> If stream's bitrate is not specified:
> - for static manifest: an average bitrate will be calculated and used,
> - for dynamic manifest: first segment's bitrate will be calculated and used
On 6/16/20 6:02 PM, Przemysław Sobala wrote:
> If stream's bitrate is not specified:
> - for static manifest: an average bitrate will be calculated and used,
> - for dynamic manifest: first segment's bitrate will be calculated and used,
> as before,
> for bandwidth setting in adaptation sets.
>
>
On 6/14/20 8:43 PM, Przemysław Sobala wrote:
> Any comments about that?
>
> --
> Best regards
> Przemysław Sobala
>
> On Wed, Jun 10, 2020 at 1:15 PM Przemysław Sobala <
> przemyslaw.sob...@gmail.com> wrote:
>
>> ---
>> doc/muxers.texi | 4 +++-
>> libavformat/dashenc.c | 8 +---
>> 2 f
On 6/4/20 1:29 PM, Przemysław Sobala wrote:
> On Tue, Jun 2, 2020 at 10:19 AM Przemysław Sobala <
> przemyslaw.sob...@gmail.com> wrote:
>
>> On Mon, Jun 1, 2020 at 3:30 PM Jeyapal, Karthick
>> wrote:
>>
>>>
>>> On 6/1/20 5:24 PM, Przemysław
On 6/1/20 5:24 PM, Przemysław Sobala wrote:
> On Mon, Jun 1, 2020 at 10:06 AM Anton Khirnov wrote:
>
>> Quoting Przemysław Sobala (2020-05-27 17:07:22)
>>> ---
>>> libavformat/dashenc.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/dashenc.c b/libavfo
On 5/27/20 8:37 PM, Przemysław Sobala wrote:
> ---
> libavformat/dashenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 0cf0df50ef..00a37b175d 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@
On 4/26/20 5:34 PM, Jeyapal, Karthick wrote:
>
> On 4/26/20 3:19 PM, lance.lmw...@gmail.com wrote:
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>> ---
>> libavformat/dashenc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
On 4/26/20 3:19 PM, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavformat/dashenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 96c0ea3..e3e187c 100644
> --- a/libavfo
On 4/26/20 3:19 PM, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavformat/dashenc.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 5fbe4dd..96c0ea3 100644
On 4/26/20 3:19 PM, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavformat/dashenc.c | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index b082536.
On 3/5/20 9:02 PM, Alfred E. Heggestad wrote:
>
>
> On 05/03/2020 15:37, Carl Eugen Hoyos wrote:
>> Am Do., 5. März 2020 um 11:08 Uhr schrieb Alfred E. Heggestad
>> :
>>
>>> -int64_t update_period = c->last_duration / AV_TIME_BASE;
>>> +double update_period = (double)c->last_durati
On 3/1/20 6:08 PM, Jun Zhao wrote:
> From: Jun Zhao
>
> Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile
> to dash demuxer probe.
>
> Signed-off-by: Jun Zhao
> ---
> libavformat/dashdec.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/libavforma
On 2/20/20 7:19 AM, James Almer wrote:
> On 2/19/2020 9:33 PM, Jeyapal, Karthick wrote:
>>
>> On 2/19/20 7:05 PM, James Almer wrote:
>>> On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote:
>>>>
>>>> On 2/19/20 4:21 PM, Thilo Borgmann wrote:
>
On 2/19/20 7:05 PM, James Almer wrote:
> On 2/19/2020 8:50 AM, Jeyapal, Karthick wrote:
>>
>> On 2/19/20 4:21 PM, Thilo Borgmann wrote:
>>> Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick:
>>>>
>>>> On 2/18/20 9:43 PM, Jam
On 2/19/20 4:21 PM, Thilo Borgmann wrote:
> Am 19.02.20 um 06:18 schrieb Jeyapal, Karthick:
>>
>> On 2/18/20 9:43 PM, James Almer wrote:
>>> Signed-off-by: James Almer
>>> ---
>>> libavformat/dashenc.c | 5 +
>>> 1 file changed, 5 inserti
On 2/18/20 9:43 PM, James Almer wrote:
> Signed-off-by: James Almer
> ---
> libavformat/dashenc.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index b910cc22d0..045d2f4df6 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/da
On 1/30/20 3:28 PM, Alfred E. Heggestad wrote:
> this usecase will cause a division by zero trap:
>
> 1. dashenc has received one frame
> 2. os->max_pts and os->start_pts have same value
> 3. delta between max_pts and start_pts is 0
> 4. av_rescale_q(0, x, y) returns 0
> 5. this value is used as d
On 1/8/20 5:53 AM, Marton Balint wrote:
> ff_rename always logs the error message.
>
> Signed-off-by: Marton Balint
> ---
> libavformat/dashenc.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index b84736881f..
On 1/7/20 7:25 PM, Andreas Rheinhardt wrote:
> The Dash muxer uses submuxers and when one such submuxer has been allocated,
> it is initially only stored in a temporary variable. Therefore it leaks
> if an error happens between the allocation and storing it permanently.
> This commit changes this.
On 11/29/19 11:08 AM, Steven Liu wrote:
>
>
>> 在 2019年11月29日，13:35，Jeyapal, Karthick 写道：
>>
>>
>> On 11/29/19 10:45 AM, Steven Liu wrote:
>>> Signed-off-by: Steven Liu
>>> ---
>>> libavformat/dashenc.c | 3 +--
>>> 1 file change
On 11/29/19 10:45 AM, Steven Liu wrote:
> Signed-off-by: Steven Liu
> ---
> libavformat/dashenc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index a462876c13..8c28fb6b6e 100644
> --- a/libavformat/dashenc.c
> +++ b/l
On 7/19/19 1:13 PM, leozhang wrote:
> Signed-off-by: leozhang
> ---
> Removed remarks which are not part of commit message. Thanks reminder
>
> doc/muxers.texi | 4
> libavformat/dashenc.c | 27 +++
> 2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff
On 7/19/19 8:38 AM, leozhang wrote:
> change history:
> 1. Use normal descriptor string instead of base64 encoded
> 2. Add example to muxers.texi
> 3. Change descriptor char * and allocate it dynamically
>
> Please review, thanks
Thanks for sending the revised patch. LGTM.
I will wait for 3 days a
On 7/17/19 10:21 AM, Tao Zhang wrote:
> Jeyapal, Karthick 于2019年7月17日周三 上午10:46写道：
>>
>>
>> On 7/15/19 8:41 AM, leozhang wrote:
>>> change history:
>>> 1. remove unnecessary cast.
>>> 2. add some braces.
>>>
>>> Please comme
On 7/15/19 8:41 AM, leozhang wrote:
> change history:
> 1. remove unnecessary cast.
> 2. add some braces.
>
> Please comment, Thanks
Thanks for sending the patch. Please find some of my comments inlined below.
>
> Signed-off-by: leozhang
> ---
> doc/muxers.texi | 3 +++
> libavformat/dash
On 6/24/19 4:23 PM, Alfred E. Heggestad wrote:
> On 24/06/2019 11:24, Jeyapal, Karthick wrote:
>>
>> On 6/20/19 3:00 PM, Alfred E. Heggestad wrote:
>>>
>>>
>>> On 20/06/2019 05:19, Jeyapal, Karthick wrote:
>>>>
>>>> On 6/19/19 3:08
On 6/20/19 3:00 PM, Alfred E. Heggestad wrote:
>
>
> On 20/06/2019 05:19, Jeyapal, Karthick wrote:
>>
>> On 6/19/19 3:08 PM, Alfred E. Heggestad wrote:
>>> On 19/06/2019 07:21, Jeyapal, Karthick wrote:
>>>>
>>>> On 6/18/19 1:48 PM, Alfred E.
On 6/19/19 3:08 PM, Alfred E. Heggestad wrote:
> On 19/06/2019 07:21, Jeyapal, Karthick wrote:
>>
>> On 6/18/19 1:48 PM, Alfred E. Heggestad wrote:
>>> On 18/06/2019 04:02, Steven Liu wrote:
>>>> Alfred E. Heggestad 于2019年6
On 6/18/19 1:48 PM, Alfred E. Heggestad wrote:
> On 18/06/2019 04:02, Steven Liu wrote:
>> Alfred E. Heggestad 于2019年6月17日周一 下午4:02写道：
>>>
>>> From 923da82598bddd1ed05750427dbc71e607d296a2 Mon Sep 17 00:00:00 2001
>>> From: "Alfred E. Heggestad"
>>> Date: Mon, 17 Jun 2019 09:59:04 +0200
>>> Su
On 6/4/19 1:15 PM, Alfred E. Heggestad wrote:
>
>
>
> From 885abee797458936e39b4a252e96836d3d6e3213 Mon Sep 17 00:00:00 2001
> From: "Alfred E. Heggestad"
> Date: Tue, 4 Jun 2019 09:39:59 +0200
> Subject: [PATCH] dashenc: fix typo in seg_duration description
>
> ---
> libavformat/dashenc.c | 2 +
On 5/14/19 4:34 PM, Michael Niedermayer wrote:
> The return code is 64bit, so this is more correct, especially in case it
> actually would be a file of such large size
>
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/dashenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On Sun, Apr 28, 2019 at 4:02 PM Marton Balint wrote:
> Hi All,
>
> There has been discussion on the mailing list several times about the
> inclusion of support for closed source components (codecs, formats,
> filters, etc) in the main ffmpeg codebase.
>
> Also the removal of libNDI happened with
On 4/25/19 1:15 PM, Jun Li wrote:
>
>
>
> On Wed, Apr 24, 2019 at 11:07 PM Jeyapal, Karthick
> wrote:
>
>
> On 4/24/19 11:30 PM, Jun Li wrote:
> > On Sun, Apr 21, 2019 at 5:51 PM Jun Li wrote:
> >
> >> Fix #7144.
> >>
On 4/24/19 11:30 PM, Jun Li wrote:
> On Sun, Apr 21, 2019 at 5:51 PM Jun Li wrote:
>
>> Fix #7144.
>> The current packet duration calculation is heuristic, which uses the
>> historical durtion as current duration. This commit adds the option
>> to buffer one packet and calcuate its duration when
On 4/17/19 11:28 AM, Karthick J wrote:
> This bug was introduced in the commit 951561b64ee6c11f01daedd9dcf73276cc1e765b
> ---
> libavformat/dashenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 5f1333e436..b88d4b34
On 4/10/19 12:09 PM, Karthick J wrote:
> Currently streaming for webm output doesn't work.
> Disabling explicitly will make sure that the manifest will get generated
> correctly.
> ---
> libavformat/dashenc.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavformat/dashenc.c b/l
On 4/8/19 6:23 PM, joepadmiraal wrote:
> ---
> libavformat/dashenc.c | 19 ++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index f8d71166d4..4585a46202 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/d
On 4/8/19 7:37 PM, Andreas Rheinhardt via ffmpeg-devel wrote:
> Karthick J via ffmpeg-devel:
>> ---
>> libavformat/dashenc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>> index f8d71166d4..9dd520787f 100644
>> ---
On 3/24/19 6:00 PM, Karthick J wrote:
> ---
> doc/muxers.texi | 3 ++
> libavformat/dashenc.c | 119 --
> 2 files changed, 84 insertions(+), 38 deletions(-)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index aac7d94edf..83ae017d6c 100644
> -
On 3/27/19 2:08 AM, joepadmiraal wrote:
> ---
> libavformat/dashenc.c | 17 -
> 1 file changed, 16 insertions(+), 1 deletion(-)
Sorry for the delayed reply. Thanks for submitting a patch for a very useful
optimization. Here are my review comments.
Please add a prefix "libavforma
On 3/27/19 2:38 PM, Zenon Mousmoulas wrote:
> Add experimental support for LHLS (low-latency HLS), following what
> was introduced to lavf/dashenc in f22fcd4483f.
> ---
> doc/muxers.texi | 6 +
> libavformat/dashenc.c | 2 +-
> libavformat/hlsenc.c | 63
> +++
On 3/5/19 8:07 PM, joepadmiraal wrote:
> ---
> libavformat/dashenc.c | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index c5e882f4ae..6bcdc9ba36 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat
On 3/1/19 2:56 PM, joepadmiraal wrote:
> ---
> libavformat/dashenc.c | 23 ---
> 1 file changed, 20 insertions(+), 3 deletions(-)
Thanks for sending this revised patch. Now the patch looks fine overall.
There are two minor suggestions though.
>
> diff --git a/libavformat/dashe
On 2/22/19 12:25 PM, joepadmiraal wrote:
> From: joepadmiraal
>
> ---
> libavformat/dashenc.c | 29 -
> 1 file changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 37a7547b12..d0d0d6f030 100644
> --- a/libavf
On 2/19/19 12:18 PM, Karthick J wrote:
> The master playlist can be published at a specified interval with this option
> ---
> doc/muxers.texi | 3 +++
> libavformat/dashenc.c | 9 -
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/doc/muxers.texi b/doc/muxers.tex
On 1/31/19 7:08 AM, myp...@gmail.com wrote:
> On Thu, Jan 24, 2019 at 2:01 PM Karthick J wrote:
>>
>> In streaming mode mp4 trailer is not required for playout.
>> ---
>> libavformat/dashenc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/dashenc.c b/lib
On 1/24/19 11:31 AM, Karthick J wrote:
> In streaming mode mp4 trailer is not required for playout.
> ---
> libavformat/dashenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 9c90cf17e5..6299e179c2 100644
> --- a/li
On 1/24/19 12:46 PM, Liu Steven wrote:
>
>
>> 在 2019年1月24日，下午2:01，Karthick J 写道：
>>
>> In streaming mode mp4 trailer is not required for playout.
>> ---
>> libavformat/dashenc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.
On 1/17/19 2:35 PM, Karthick J wrote:
> For low latency streaming even milliseconds matter!
> ---
> libavformat/dashenc.c | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index cfd0f601d4..9c90cf17e5 100644
>
>On 12/31/18, 1:08 PM, "Karthick J" wrote:
>
>From: Karthick Jeyapal
>
>Fixes bug id : 7638
>---
> libavformat/file.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> [...]
Pushed
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
h
On 12/12/18 9:50 PM, Karthick J wrote:
> Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks
> are
> trying to standardize a open LHLS spec. The draft spec is available in
> https://github.com/video-dev/hlsjs-rfcs/blob/lhls-spec/proposals/0001-lhls.md
> This option will a
On 12/12/18 9:10 PM, Moritz Barsnick wrote:
> On Wed, Dec 12, 2018 at 12:48:21 +0530, Karthick J wrote:
>> Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks
>> are
>> trying to standardize a open LHLS spec. The draft spec is available in
>> https://github.com/video-dev/
On 12/11/18, 9:07 AM, "Ronak" wrote:
>
>> On Dec 6, 2018, at 4:47 AM, Tobias Rapp wrote:
>>
>> On 06.12.2018 08:28, Karthick J wrote:
>>> ---
>>> [...]
>>
>> Looks OK now, no more comments from my side.
>
>I actually was going to submit a patch that would remove sidx atoms being
>written
On 12/5/18, 11:49 AM, "Karthick J" wrote:
>
>Anyways the intended behaviour was to disable SIDX atom.
>---
> libavformat/dashenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> [...]
Pushed.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmp
On 12/6/18, 3:18 PM, "Tobias Rapp" wrote:
>
>On 06.12.2018 08:28, Karthick J wrote:
>> ---
>> doc/muxers.texi | 4
>> libavformat/movenc.c | 12 ++--
>> libavformat/movenc.h | 1 +
>> 3 files changed, 15 insertions(+), 2 deletions(-)
>>
>> [...]
>
>Looks OK now, no m
On 12/5/18, 6:10 PM, "Tobias Rapp" wrote:
>
>On 05.12.2018 07:18, Karthick J wrote:
>> [...]
>> +if (mov->flags & FF_MOV_FLAG_GLOBAL_SIDX && s->flags &
>> FF_MOV_FLAG_SKIP_SIDX) {
>> +av_log(s, AV_LOG_WARNING, "Global SIDX enabled; Ignoring skip_sidx
>> option\n");
>> +
On 12/4/18, 2:18 PM, "Gyan Doshi" wrote:
>On 04-12-2018 02:11 PM, Karthick J wrote:
>
>> [...]
>> +@item -movflags no_sidx
>> +Don't write sidx atom.
>
>Append a short note advising when this is required or recommended and
>when not.
Thanks for your comment. I have added more details in PATCH v2
On 12/4/18, 4:25 PM, "Tobias Rapp" wrote:
>>On 04.12.2018 09:41, Karthick J wrote:
>>[...]
>> Run a second pass moving the index (moov atom) to the beginning of the
>> file.
>> This operation can take a while, and will not work in various situations
>> such
>
>What about naming the option
On 11/29/18 8:28 PM, Andrey Semashev wrote:
> On 11/28/18 7:25 PM, Jeyapal, Karthick wrote:
>>
>> On 11/28/18 4:41 PM, Andrey Semashev wrote:
>>> The global_sidx flag causes errors like the following in movenc when media
>>> segment removal is enabled
On 12/1/18 12:01 AM, Michael Niedermayer wrote:
> On Fri, Nov 30, 2018 at 05:52:35AM +0000, Jeyapal, Karthick wrote:
> >
> > On 11/29/18 11:08 PM, Michael Niedermayer wrote:
> > > On Wed, Nov 28, 2018 at 09:45:24PM +0530, Karthick J wrote:
> > >> When moven
On 12/3/18 4:48 PM, Andrey Semashev wrote:
> This commit ensures that all (potentially, long) filesystem activity is
> performed when the user calls av_write_trailer on the DASH libavformat
> context, not when freeing the context. Also, this defers media segment
> deletion until after the media tr
On 11/30/18 11:42 AM, Jeyapal, Karthick wrote:
>
> On 11/29/18 11:58 PM, Andrey Semashev wrote:
>> This commit ensures that all (potentially, long) filesystem activity is
>> performed when the user calls av_write_trailer on the DASH libavformat
>> context, not when freeing
On 11/30/18 10:55 AM, Karthick J wrote:
> ---
> libavformat/dashenc.c | 19 +--
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 04218af6a6..09207dcf44 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat
On 11/30/18 2:33 PM, Andrey Semashev wrote:
> This fixes incorrect handling of file pseudo-URIs (i.e. when the filename
> starts with "file:").
> ---
> libavformat/dashenc.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashe
>On 12/1/18, 5:27 AM, "Ronak" wrote:
>
>Hey all,
>
>Is there a reason why ffmpeg only uses the MPEG DASH LIVE profile? Even if I
>want to do VOD, it reports that profile in the manifest files.
>
>I'm thinking of adding support to provide the 4 profiles that MPEG DASH
>supports, and use the sa
On 11/28/18 10:36 PM, Karthick J wrote:
> When dashenc has to run for long duration(say 24x7 live stream), one can
> enable this option to ignore the io failure of few segment's upload due to an
> intermittent network issues.
> When the network connection recovers dashenc will continue with the
On 11/28/18 10:28 PM, Jeyapal, Karthick wrote:
>
> On 11/28/18 5:06 PM, Andrey Semashev wrote:
>> This fixes HLS manifests being left behind if remove_at_exit is set.
>> ---
>> libavformat/dashenc.c | 12
>> 1 file changed, 12 insertions(+)
>>
>
On 11/29/18 11:58 PM, Andrey Semashev wrote:
> This commit ensures that all (potentially, long) filesystem activity is
> performed when the user calls av_write_trailer on the DASH libavformat
> context, not when freeing the context. Also, this defers media segment
> deletion until after the media
On 11/29/18 11:49 PM, Andrey Semashev wrote:
> On 11/29/18 2:17 PM, Andrey Semashev wrote:
>> On 11/29/18 2:15 PM, Andrey Semashev wrote:
>>> On 11/28/18 7:47 PM, Jeyapal, Karthick wrote:
>>>>
>>>> On 11/28/18 4:46 PM, Andrey Semashev wrote:
>>>&
On 11/29/18 11:48 PM, Andrey Semashev wrote:
> This fixes incorrect handling of file URIs (i.e. when the filename starts
> with "file:", possibly followed by URI authority).
> ---
> libavformat/dashenc.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/libavform
On 11/29/18 11:08 PM, Michael Niedermayer wrote:
> On Wed, Nov 28, 2018 at 09:45:24PM +0530, Karthick J wrote:
>> When movenc is used by other segmenting muxers such as dashenc, url field is
>> always empty.
>> In such cases it is better to not write sidx, instead of throwing errors.
>> ---
>> l
On 11/29/18 8:28 PM, Andrey Semashev wrote:
> On 11/28/18 7:25 PM, Jeyapal, Karthick wrote:
>>
>> On 11/28/18 4:41 PM, Andrey Semashev wrote:
>>> The global_sidx flag causes errors like the following in movenc when media
>>> segment removal is enabled
On 11/29/18 8:07 PM, Andrey Semashev wrote:
> On 11/28/18 8:06 PM, Karthick J wrote:
>> When dashenc has to run for long duration(say 24x7 live stream), one can
>> enable this option to ignore the io failure of few segment's upload due to
>> an intermittent network issues.
>> When the network co
On 11/28/18 5:13 PM, Andrey Semashev wrote:
> This commit ensures that all (potentially, long) filesystem activity is
> performed when the user calls av_write_trailer on the DASH libavformat
> context, not when freeing the context. Also, this defers media segment
> deletion until after the media t
On 11/27/18 9:52 PM, Carl Eugen Hoyos wrote:
> 2018-11-26 11:25 GMT+01:00, Karthick J :
> > When dashenc has to run for long duration(say 24x7 live stream), one can
> > enable this option to ignore the io failure of few segment's upload due to
> > an intermittent network issues.
> > When the netwo
On 11/28/18 5:06 PM, Andrey Semashev wrote:
> This fixes HLS manifests being left behind if remove_at_exit is set.
> ---
> libavformat/dashenc.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index a7d8c4e237..af3f0ee167 1006
On 11/28/18 5:06 PM, Andrey Semashev wrote:
> The only native HLS implementation in the wild (Safari browser) doesn't
> support WebM. And at least some MSE-based players (e.g. shaka-player)
> cannot handle WebM media segments when playing HLS. So just skip non-mp4
> streams from HLS manifests. Not
On 11/28/18 4:46 PM, Andrey Semashev wrote:
> The URI used to open the output streams may be an actual URI with "file"
> scheme,
> according to https://tools.ietf.org/html/rfc8089. This commit makes file
> deletion routine recognize file URIs and extract the actual filesystem path
> from it.
Ther
On 11/28/18 4:41 PM, Andrey Semashev wrote:
> The global_sidx flag causes errors like the following in movenc when media
> segment removal is enabled via windos_size or remove_at_exit:
>
> Non-consecutive fragments, writing incorrect sidx
> Unable to re-open output file for the second pass (fasts
>On 11/28/18, 8:19 PM, "Moritz Barsnick" wrote:
>
>On Wed, Nov 28, 2018 at 20:10:11 +0530, Karthick J wrote:
>> +// If url is an empty string("") don't write sidx atom.
>> +if (s->url[0] == '\0')
>> +return res;
>
>Probably clearer if you return 0, as res h
On 11/26/18 4:31 PM, Andrey Semashev wrote:
> On Wed, Nov 21, 2018 at 3:45 PM Jeyapal, Karthick wrote:
> > On 11/20/18 6:01 PM, Andrey Semashev wrote:
> > > On 11/18/18 1:55 PM, Jeyapal, Karthick wrote:
> > > > Thanks for sending these excellent patches. The entir
On 11/22/18 7:33 PM, Jeyapal, Karthick wrote:
>
> On 11/22/18 6:35 PM, Carl Eugen Hoyos wrote:
>> 2018-11-22 7:43 GMT+01:00, Jeyapal, Karthick :
>>>
>>> On 11/20/18 11:03 PM, Andrey Semashev wrote:
>>>> When stream time bases are very fine grained (e.g.
On 11/22/18 6:35 PM, Carl Eugen Hoyos wrote:
> 2018-11-22 7:43 GMT+01:00, Jeyapal, Karthick :
>>
>> On 11/20/18 11:03 PM, Andrey Semashev wrote:
>>> When stream time bases are very fine grained (e.g. nanoseconds), 32-bit
>>> segment duration may overflow for even
On 11/20/18 11:03 PM, Andrey Semashev wrote:
> When stream time bases are very fine grained (e.g. nanoseconds), 32-bit
> segment duration may overflow for even for rather small segment duration
> (about 4 seconds long). Therefore we use 64-bit values for segment duration.
> ---
> libavformat/dash
Pushed the patchset.
On 11/16/18 2:27 PM, Karthick J wrote:
> ---
> libavformat/dashenc.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index d151921175..2c1cce0c92 100644
> --- a/libavformat/dashenc.c
> +++ b/l
On 11/20/18 6:01 PM, Andrey Semashev wrote:
> On 11/18/18 1:55 PM, Jeyapal, Karthick wrote:
> > Thanks for sending these excellent patches. The entire patchset looks good
> > to me.
> > Also, many thanks for your patience and taking the earlier review comments
> > in
Thanks for sending these excellent patches. The entire patchset looks good to
me.
Also, many thanks for your patience and taking the earlier review comments in
the right spirit.
Regards,
Karthick
On 11/17/18 11:10 PM, Andrey Semashev wrote:
> ---
> libavformat/dashenc.c | 13 +++--
> 1
On 11/14/18 1:41 PM, Andrey Semashev wrote:
> On 11/12/18 3:55 PM, Andrey Semashev wrote:
> > On 11/12/18 3:12 PM, Jeyapal, Karthick wrote:
> >>
> >> On 11/12/18 5:20 PM, Andrey Semashev wrote:
> >>> On 11/12/18 8:20 AM, Jeyapal, Karthick wrote:
> >&g
On 11/12/18 5:20 PM, Andrey Semashev wrote:
> On 11/12/18 8:20 AM, Jeyapal, Karthick wrote:
>>
>> On 11/8/18 10:27 PM, Andrey Semashev wrote:
>>> This commit restores the ability to create DASH streams with codecs
>>> that require different cont
1 - 100 of 260 matches
Mail list logo
