Re: [FFmpeg-devel] [PATCH 2/2] Advertise current segment in streaming mode

2021-07-14 Thread Kevin LaFlamme
Any feedback on this? On Jun 24, 2021, 8:58 AM -0400, Kevin LaFlamme , wrote: > In streaming mode when using a segment list, the current segment should > be listed so that clients can immediately request it even before > complete. Without this, even though the segment is being written i

Re: [FFmpeg-devel] [PATCH 1/2] Fix double write of DASH manifest in streaming mode

2021-07-14 Thread Kevin LaFlamme
Thanks! Yes I saw your comment on v2 and agree that patch can be closed/ignored. On Jul 14, 2021, 10:47 AM -0400, Jeyapal, Karthick , wrote: > > > On 7/14/21, 7:46 PM, "Kevin LaFlamme" wrote: > > > Any feedback on this? > Thanks for the reminder. I have pushed th

Re: [FFmpeg-devel] [PATCH 2/2] Advertise current segment in streaming mode

2021-07-14 Thread Kevin LaFlamme
Ah I didn’t realize the SegmentTemplate was actually required in the spec for streaming mode. This should be closed then, thanks. On Jul 14, 2021, 10:45 AM -0400, Jeyapal, Karthick , wrote: > > > On 6/24/21, 6:28 PM, "Kevin LaFlamme" wrote: > > > In streaming mode wh

Re: [FFmpeg-devel] [PATCH 1/2] Fix double write of DASH manifest in streaming mode

2021-07-14 Thread Kevin LaFlamme
Any feedback on this? On Jun 24, 2021, 8:58 AM -0400, Kevin LaFlamme , wrote: > When streaming mode is enabled, the DASH manifest is written on the > first packet for the segment so that the segment can be advertised > immediately to clients. It was also still writing the manifest at the

[FFmpeg-devel] [PATCH 2/2] Advertise current segment in streaming mode

2021-06-24 Thread Kevin LaFlamme
In streaming mode when using a segment list, the current segment should be listed so that clients can immediately request it even before complete. Without this, even though the segment is being written in a way that it can be requested while still writing, clients won't know it's available. --- li

[FFmpeg-devel] [PATCH 1/2] Fix double write of DASH manifest in streaming mode

2021-06-24 Thread Kevin LaFlamme
When streaming mode is enabled, the DASH manifest is written on the first packet for the segment so that the segment can be advertised immediately to clients. It was also still writing the manifest at the end of the segment leading to two duplicate writes. --- libavformat/dashenc.c | 7 +-- 1

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-11 Thread Kevin LaFlamme
Does my last explanation make sense or if not could you point me to where this reasoning is incorrect? Kevin LaFlamme Director of Engineering (Front End) 774.265.0382 (m) aiera.com On Jun 8, 2021, 8:52 PM -0400, Kevin LaFlamme , wrote: > I just realized there’s probably a more straightforw

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
the spec and the behaviors I've witnessed so far. Kevin LaFlamme Director of Engineering (Front End) 774.265.0382 (m) aiera.com On Jun 8, 2021, 4:03 PM -0400, Kevin LaFlamme , wrote: > To serve it in a truly streaming way does require some special purpose server > or configuration, but th

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
manifest), the client wouldn’t be respecting the DASH spec. Kevin LaFlamme Director of Engineering (Front End) 774.265.0382 (m) aiera.com On Jun 8, 2021, 3:34 PM -0400, Timo Rothenpieler , wrote: > On 08.06.2021 21:24, Kevin LaFlamme wrote: > > For streaming mode with fragmented MP4 the int

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
ent with the “-lhls” handling below, but happy to make changes if there is something else I’m missing. Kevin LaFlamme Director of Engineering (Front End) 774.265.0382 (m) aiera.com On Jun 8, 2021, 3:10 PM -0400, Timo Rothenpieler , wrote: > On 08.06.2021 21:03, Kevin LaFlamme wrote: > > Wh

[FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
When streaming mode is enabled with fMP4/CMAF for DASH output, the segment files are available to read by players as soon as the first byte is written instead of only after the file is fully written. The DASH manifest currently only gets written when the final write to the segment file occurs. This