Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_libvmaf: Add metadata propagation support

2024-09-19 Thread Kyle Swanson
Hi, On Wed, Sep 11, 2024 at 5:41 PM Yigithan Yigit wrote: > Yes, metadata callbacks are not coming in order. I looked libavutil and I > couldn’t find a data structure for this use case. I am open to suggestions If > we don’t prefer to use this data structure. Could we somehow get the AVFrame p

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_libvmaf: Add metadata propagation support

2024-08-29 Thread Kyle Swanson
Hi, On Mon, Aug 26, 2024 at 10:51=E2=80=AFAM Yigithan Yigit wrote: > > --- > libavfilter/vf_libvmaf.c | 328 ++- > 1 file changed, 326 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index f655092b20..e6707

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add qrencodesrc source

2023-12-11 Thread Kyle Swanson
Hi, On Sat, Dec 9, 2023 at 10:14 AM Stefano Sabatini wrote: > > On date Thursday 2023-11-30 01:49:14 +0100, Stefano Sabatini wrote: > > --- > > configure | 4 + > > libavfilter/Makefile| 1 + > > libavfilter/allfilters.c| 1 + > > libavfilter/vsrc_qrencode.c |

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-08 Thread Kyle Swanson
On Wed, Dec 6, 2023 at 9:54 AM Kyle Swanson wrote: > Will push this tomorrow. Pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-06 Thread Kyle Swanson
Hi, On Mon, Dec 4, 2023 at 7:59 AM Nil Fons Miret via ffmpeg-devel wrote: > > The libvmaf filter was doing substring checks in place of string > equality comparisons. This led to a bug when the user specified the > pooling method "harmonic_mean", since "mean" was checked first and the > substring

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: small cleanup for style, whitespace, unused

2023-12-04 Thread Kyle Swanson
On Fri, Dec 1, 2023 at 1:57 PM Kyle Swanson wrote: > Small cleanup patch for vf_libvmaf.c. Will apply soon. Pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

[FFmpeg-devel] [PATCH] avfilter/libvmaf: small cleanup for style, whitespace, unused

2023-12-01 Thread Kyle Swanson
Hi, Small cleanup patch for vf_libvmaf.c. Will apply soon. Thanks, Kyle 0001-avfilter-libvmaf-small-cleanup-for-style-whitespace-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-12-01 Thread Kyle Swanson
Hi, On Fri, Dec 1, 2023 at 2:37 AM Paul B Mahol wrote: > Keeping old code will not make patch any prettier. It's not really about pretty, it's about splitting up the patch so we can do things one at a time. I think the change to use f_ebur128.c loudness computation might have some advantages, bu

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-30 Thread Kyle Swanson
Hi, On Thu, Nov 30, 2023 at 2:43 PM Paul B Mahol wrote: > But how you could refactor code if one filter shares nothing with another > filter code? > > Its not possible. You all seem to not understand problem at all. I get that this patch swaps the libebur128 loudness computation with the f_ebur1

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-30 Thread Kyle Swanson
Hi, On Thu, Nov 30, 2023 at 1:36 PM Paul B Mahol wrote: > > Loudnorm filter is big pile of hacks, I wanted to move forward and I > improved it. > > I received nothing in return just some politics talks. > > I will apply this soon unless technical comments arise. > > Why would I spend on this more

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-30 Thread Kyle Swanson
Hi, On Thu, Nov 30, 2023 at 6:11 AM Paul B Mahol wrote: > > I tested this a lot, and its great move forward. > > Make more useful testing and review next time, I'm sure you are quite > capable person. Paul, I agree with Anton. Refactoring the code (i.e. changing filter behavior) and combining it

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Kyle Swanson
Hi, On Mon, Nov 27, 2023 at 10:15 AM Gyan Doshi wrote: > Do you mean in the lib? Because in ffmpeg git master, in the wrapper, > the option remains available and undeprecated. > > Regards, > Gyan Oops, you're right. Ignore everything I just said, sorry for the noise. Thanks, Kyle __

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Kyle Swanson
Hi, On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi wrote: > > Will push soon. This filter can take any number of models now, each defining their own pooling methods. Looking at the docs now, I can see that it's not clear how to do this, I'll need to send a patch on that. The global `pool` option has

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-21 Thread Kyle Swanson
Hi, On Sun, Nov 19, 2023 at 3:48 AM Paul B Mahol wrote: > > On Fri, Nov 17, 2023 at 7:38 AM Kyle Swanson wrote: > > > Hi, > > > > On Wed, Nov 15, 2023 at 12:39 PM Paul B Mahol wrote: > > > > > > Attached. > > > > Only had a few minutes t

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-16 Thread Kyle Swanson
Hi, On Wed, Nov 15, 2023 at 12:39 PM Paul B Mahol wrote: > > Attached. Only had a few minutes to look at this. Seems like more than just merging two filters, I see a bunch of new filter options for example. Can you explain? Thanks, Kyle ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: fix broken cuda build

2023-10-27 Thread Kyle Swanson
On Tue, Oct 24, 2023 at 1:56 PM Kyle Swanson wrote: > I broke the libvmaf_cuda build after > 6028728bb829c04cc68c66c846c75a70bf4c0613. Fix is attached. I will > merge this patch soon. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

[FFmpeg-devel] [PATCH] avfilter/libvmaf: fix broken cuda build

2023-10-24 Thread Kyle Swanson
Hi, I broke the libvmaf_cuda build after 6028728bb829c04cc68c66c846c75a70bf4c0613. Fix is attached. I will merge this patch soon. Thanks, Kyle 0001-avfilter-libvmaf-fix-broken-cuda-build.patch Description: Binary data ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] VMAF is now propagated to the AVFrame coming from the graph

2023-10-16 Thread Kyle Swanson
Hi, On Fri, Oct 13, 2023 at 11:01 PM wrote: > > From: ichlubna > > Related to my ticket here: https://trac.ffmpeg.org/ticket/10586 > VMAF score was not propagated to AVFormat like SSIM or PSNR in the result of > the filter graph. I have fixed this to make the usage consistent and possible > to

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: update pix_fmts

2023-10-12 Thread Kyle Swanson
Hi, On Tue, Oct 10, 2023 at 1:02 PM Kyle Swanson wrote: > This patch adds 12/16-bit support to the libvmaf filter. Unless there > are questions/reviews, I'll push tomorrow. Patch attached. Merged. Thanks, Kyle ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avfilter/libvmaf: update pix_fmts

2023-10-10 Thread Kyle Swanson
Hi, This patch adds 12/16-bit support to the libvmaf filter. Unless there are questions/reviews, I'll push tomorrow. Patch attached. Thanks, Kyle 0001-avfilter-libvmaf-update-pix_fmts.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: remove deprecated options

2023-10-10 Thread Kyle Swanson
Hi, On Mon, Oct 9, 2023 at 10:17 AM Kyle Swanson wrote: > On Thu, Oct 5, 2023 at 1:19 PM Kyle Swanson wrote: > > Removal of deprecated libvmaf filter options. These options have been > > deprecated since 3d29724c008d8f27fecf85757152789b074e8ef9 (Jan 23, > > 2022). Patch at

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: remove deprecated options

2023-10-09 Thread Kyle Swanson
Hi, On Thu, Oct 5, 2023 at 1:19 PM Kyle Swanson wrote: > Removal of deprecated libvmaf filter options. These options have been > deprecated since 3d29724c008d8f27fecf85757152789b074e8ef9 (Jan 23, > 2022). Patch attached. I'll push this tomorrow.

[FFmpeg-devel] [PATCH] avfilter/libvmaf: remove deprecated options

2023-10-05 Thread Kyle Swanson
Hi, Removal of deprecated libvmaf filter options. These options have been deprecated since 3d29724c008d8f27fecf85757152789b074e8ef9 (Jan 23, 2022). Patch attached. Thanks, Kyle 0001-avfilter-libvmaf-remove-deprecated-options.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-27 Thread Kyle Swanson
Hi, On Mon, Sep 25, 2023 at 9:10 AM Timo Rothenpieler wrote: > lgtm > Pushed. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-25 Thread Kyle Swanson
Hi, On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler wrote: > On 23.09.2023 11:50, Kyle Swanson wrote: > > Hi, > > > > On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler < > t...@rothenpieler.org> > > wrote: > >> Or it needs to be a sub-fe

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/vf_libvmaf: add warning when color ranges differ

2023-09-23 Thread Kyle Swanson
Hi, On Mon, Apr 17, 2023 at 10:14 PM Chema Gonzalez wrote: > Hi Kyle, > > Thanks for your answer. > > I couldn't find how to access the color range from the filter_frame > function. I checked other filters that access `AVFrame.color_range`, > and all of them do it in the filter_frame function, n

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-23 Thread Kyle Swanson
Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler wrote: > Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled, > support for CUDA is checked for, and then the vmaf_cuda filter needs to > depend on that check. This previous patch should do just that [0]. What's missing?

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-20 Thread Kyle Swanson
Hi, On Mon, Sep 18, 2023 at 2:39 PM Kyle Swanson wrote: > > Hi, > > On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler > wrote: > > On 18.09.2023 21:21, Marvin Scholz wrote: > > > I am far from an expert with the configure script but won't that cause

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-18 Thread Kyle Swanson
Hi, On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler wrote: > On 18.09.2023 21:21, Marvin Scholz wrote: > > I am far from an expert with the configure script but won't that cause > > --enable-libvmaf to fail when > > libvmaf is built without cuda support? Which seems undesirable to me… > > Yea

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-18 Thread Kyle Swanson
Hi, On Fri, Sep 15, 2023 at 3:34 PM Timo Rothenpieler wrote: > I don't see why it wouldn't work. It doesn't matter what it is, it's > just the name of the dependency. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-15 Thread Kyle Swanson
Hi, On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler wrote: > This looks more complicated than necessary to me. > > My idea would have been to change, in the previous original patch, > > > libvmaf_cuda_filter_deps="libvmaf ffnvcodec" > > to > > > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-14 Thread Kyle Swanson
Hi, On Mon, Sep 11, 2023 at 11:51 AM Timo Rothenpieler wrote: > > On 11.09.2023 19:53, Kyle Swanson wrote: > > Hi, > > > > On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote: > >> I'll merge this in a few days. > > > > Not merged yet because I

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-11 Thread Kyle Swanson
Hi, On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote: > I'll merge this in a few days. Not merged yet because I noticed a bug in the configure script. Setting only `--enable-libvmaf` will enable both `libvmaf` and `libvmaf_cuda`. Anyone familiar with the configure script know why

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-05 Thread Kyle Swanson
Hi, On Thu, Aug 31, 2023 at 11:39 AM Kyle Swanson wrote: > On Wed, Aug 30, 2023 at 9:44 AM Kyle Swanson wrote: > > Fixed in the attached patch. > > Any other reviews, or is this one OK to merge now? I'll merge this in a few

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-31 Thread Kyle Swanson
Hi, On Wed, Aug 30, 2023 at 9:44 AM Kyle Swanson wrote: > Fixed in the attached patch. Any other reviews, or is this one OK to merge now? Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-30 Thread Kyle Swanson
Hi, On Tue, Aug 29, 2023 at 3:13 PM Andreas Rheinhardt wrote: > The CONFIG_* variables are always defined; you need to check via "#if", > not "#ifdef". Fixed in the attached patch. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data _

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-29 Thread Kyle Swanson
Hi, On Mon, Aug 28, 2023 at 1:16 PM Kyle Swanson wrote: > Ah, you're right, I think ffnvcodec is the right option to use, I'll > switch this in the next patch version. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Descript

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-28 Thread Kyle Swanson
Hi, On Mon, Aug 28, 2023 at 11:59 AM Timo Rothenpieler wrote: > > +libvmaf_cuda_filter_deps="libvmaf cuda_nvcc" > > Does this really depend on nvcc? > Does it not work with only ffnvcodec? > Ah, you're right, I think ffnvcodec is the right option to use, I'll switch this in the next patch versio

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-28 Thread Kyle Swanson
Hi, Added filter docs, new patch attached. Unless there are any other reviews I will plan on pushing this in a few days. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-23 Thread Kyle Swanson
Hi, Thank you Timo for the review. Took your suggestions, updated patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-14 Thread Kyle Swanson
Hi, On Mon, Aug 7, 2023 at 10:50 AM Kyle Swanson wrote: > Adds the new avfilter `libvmaf_cuda`, integrating the new vmaf_cuda_* > apis in libvmaf. Patch attached. Anyone interested in reviewing this? Would be appreciated. Thanks, Kyle ___

[FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-07 Thread Kyle Swanson
Hi, Adds the new avfilter `libvmaf_cuda`, integrating the new vmaf_cuda_* apis in libvmaf. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description

2022-09-16 Thread Kyle Swanson
Hi, On Wed, Sep 14, 2022 at 2:27 PM Kyle Swanson wrote: > Thanks for the fix, I will apply this soon. > Pushed. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsub

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description

2022-09-14 Thread Kyle Swanson
Hi, On Fri, Sep 9, 2022 at 10:58 AM Yondon Fu wrote: > Update description for ssim and ms_ssim libvmaf options to specify > feature=float_ssim and feature=float_ms_ssim which are used to request > ssim and ms_ssim values in the latest versions of libvmaf. > > Signed-off-by: Yondon Fu > --- > l

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Kyle Swanson
On Wed, Sep 14, 2022 at 12:02 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Would it actually be possible to avoid the memcpy altogether? > There's no libvmaf API for user buffers yet, so no, not at this moment. ___ ffmpeg-devel maili

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Kyle Swanson
Hi, On Wed, Sep 14, 2022 at 9:52 AM wrote: > > Sure. sorry for that. Please find attached the patch file. > Was about to test / review, but it looks like this is already pushed by Paul. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-23 Thread Kyle Swanson
Hi, On Thu, Jan 20, 2022 at 1:06 PM Kyle Swanson wrote: > > Hi, > > On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson wrote: > > > > Hi, > > > > On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > > > > > Hi, > > > > &g

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-20 Thread Kyle Swanson
Hi, On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson wrote: > > Hi, > > On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > > > Hi, > > > > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt > > wrote: > > > 1. FFmpeg uses the ancient C90 r

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-19 Thread Kyle Swanson
Hi, On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > Hi, > > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt > wrote: > > 1. FFmpeg uses the ancient C90 rule that only allows variable > > declarations at the beginning of a block (before all statements). Y

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-13 Thread Kyle Swanson
Hi, On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt wrote: > 1. FFmpeg uses the ancient C90 rule that only allows variable > declarations at the beginning of a block (before all statements). You > should actually have received a compiler warning because of the above > code (unless you use Cla

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-08 Thread Kyle Swanson
Hi, On Mon, Jan 3, 2022 at 2:32 PM Kyle Swanson wrote: > > Hi, > > On Sun, Jan 2, 2022 at 9:21 PM Andreas Rheinhardt > wrote: > > > > > > static const AVOption libvmaf_options[] = { > > > -{"model_path", "Set the model to be use

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-03 Thread Kyle Swanson
Hi, On Sun, Jan 2, 2022 at 9:21 PM Andreas Rheinhardt wrote: > > > > static const AVOption libvmaf_options[] = { > > -{"model_path", "Set the model to be used for computing vmaf.", > > OFFSET(model_path), AV_OPT_TYPE_STRING, > > {.str="/usr/local/share/model/vmaf_v0.6.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-02 Thread Kyle Swanson
Hi, On Thu, Dec 30, 2021 at 5:03 PM Kyle Swanson wrote: > > Hi, > > On Sat, Dec 25, 2021 at 1:24 AM Paul B Mahol wrote: > > > > On Fri, Dec 24, 2021 at 9:52 PM Kyle Swanson wrote: > > > > > Hi, > > > > > > Never followed through on

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-30 Thread Kyle Swanson
Hi, On Sat, Dec 25, 2021 at 1:24 AM Paul B Mahol wrote: > > On Fri, Dec 24, 2021 at 9:52 PM Kyle Swanson wrote: > > > Hi, > > > > Never followed through on this vf_libvmaf patch from last June, and > > I've had several people asking about its status lately.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-30 Thread Kyle Swanson
Hi, On Fri, Dec 24, 2021 at 12:54 PM Timo Rothenpieler wrote: > > On Wed, Jun 30, 2021 at 6:55 AM Moritz Barsnick wrote: > >> > >> Hi, > >> > >>> -enabled libvmaf && require_pkg_config libvmaf "libvmaf >= > >>> 1.5.2" libvmaf.h compute_vmaf > >>> +enabled libvmaf && require_

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-24 Thread Kyle Swanson
Hi, Never followed through on this vf_libvmaf patch from last June, and I've had several people asking about its status lately. Rebased patch attached. It's been a while, so I guess let's start the review again. Would be nice if we could get this in before 5.0. Thanks, Kyle On Wed, Jun 30, 2021

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-06-28 Thread Kyle Swanson
Hi, Updated patch attached. Thank you to Christopher Degawa for testing and providing feedback. Kyle 0001-avfilter-vf_libvmaf-update-filter-for-libvmaf-v2.0.0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-06-16 Thread Kyle Swanson
Hi, Patch attached. This is an update to the libvmaf avfilter to use the new libvmaf v2.* API which was released about 6 months ago. High level: the filter should be simpler to use now for basic users, but also more flexible for power users. libvmaf can be configured with one or many vmaf models,

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-07-02 Thread Kyle Swanson
On Tue, Jun 30, 2020 at 11:55 AM Kyle Swanson wrote: > > On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos wrote: > > No objections. > > Thanks. I will merge in 24 hours or so, when the next libvmaf minor > release is cut. Pushed. Thanks. _

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-30 Thread Kyle Swanson
On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos wrote: > No objections. Thanks. I will merge in 24 hours or so, when the next libvmaf minor release is cut. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-29 Thread Kyle Swanson
On Mon, Jun 29, 2020 at 12:14 PM Derek Buitenhuis wrote: > You'll need to update the pkg-config check too if you want to > to this, since it's at >= 1.3.9 right now. > > - Derek Thanks. Updated patch attached. 0001-configure-remove-libvmaf-from-EXTERNAL_LIBRARY_VERSI.patch Description: Binary d

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-29 Thread Kyle Swanson
Hi, On Mon, Jun 29, 2020 at 10:05 AM Kyle Swanson wrote: > > since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent > > Signed-off-by: Kyle Swanson > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index

[FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-29 Thread Kyle Swanson
since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent Signed-off-by: Kyle Swanson --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 7495f35faa..e0b76ac1ea 100755 --- a/configure +++ b/configure @@ -1741,7 +1741,6

Re: [FFmpeg-devel] [PATCH] avfilter/af_loudnorm: Don't mix dB and linear values when calculating linear offset with inputs <3s

2020-05-01 Thread Kyle Swanson
Hi, On Tue, Apr 28, 2020 at 12:58 AM Paul B Mahol wrote: > > On 4/26/20, Sebastian Dröge wrote: > > From: Sebastian Dröge > > > > s->target_i and global are in dB but s->target_tp and true_peak are > > linear. Instead of mixing these in the calculations, convert the former > > first to have all

Re: [FFmpeg-devel] [PATCH v1 1/4] avfilter/af_loudnorm: Add file option for the measured stats

2020-04-09 Thread Kyle Swanson
Hi, On Thu, Apr 9, 2020 at 10:57 AM Nicolas George wrote: > There is JSON-specific code in af_loudnorm.c, there should not be, I > think we should start here. > > My opinion is we should rework ffprobe's writers and move them to lavu. > That would be the first step. Is there already a helper API

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

2019-11-14 Thread Kyle Swanson
Hi, On Wed, Nov 13, 2019 at 10:36 PM Limin Wang wrote: > Please ignore the patch, I haven't used the old version. As vmaf library use > libvmaf.pc, it better to keep it filename same, so let waiting vmaf to fix > it. Merged your PR over on the VMAF repo. This FFmpeg patch should be ignored. Tha

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-06 Thread Kyle Swanson
Hi, On Wed, Feb 6, 2019 at 1:43 PM Helmut K. C. Tessarek wrote: > Anyhow, I don't think that adding a formula to the ffmpeg src tree is > the right approach. I don't think that's the suggestion. Separate Github repo belonging to the FFmpeg Github organization. Thanks, Kyle _

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-06 Thread Kyle Swanson
Hi, On Wed, Feb 6, 2019 at 1:20 PM Reto Kromer wrote: > > Werner Robitza wrote: > > >I propose that FFmpeg maintains its own ffmpeg formula under > >its GitHub organization > > I second the idea. +1 > > (Homebrew works now on any modern x86_64 architecture running > Linux, macOS and Windows with

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-11 Thread Kyle Swanson
Hi, On Fri, Jan 11, 2019 at 11:05 AM Nicolas George wrote: > > Kyle Swanson (12019-01-11): > > Lots of people get paid to work on OSS. It's not a conspiracy, that's > > just the way it is. If someone gets paid to write a patch that does > > something useful, g

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-11 Thread Kyle Swanson
Hi, On Fri, Jan 11, 2019 at 10:21 AM Nicolas George wrote: > > Rationale: > > * This requirement should offset a little the incentive to neglect > design, code quality and politeness during the review process when > done for money. > > * The review process itself and future maintenance burden

Re: [FFmpeg-devel] Add alternative delogo algorithm for my donation

2018-12-12 Thread Kyle Swanson
Hi, On 12/11/18, uwe.fre...@gmx.de wrote: > Hello, > > I would like that the delogo filter is improved by an alternative way of > removing the logo. It's the "UGLARM" mode known from Virtual Dub's > DeLogo filter and ffdshow. > I used it many years (under Windows), but now moving to Linux miss it

Re: [FFmpeg-devel] [PATCH] libvmaf: update docs

2018-11-26 Thread Kyle Swanson
Hi, On 10/22/18, Kyle Swanson wrote: > From: Kyle Swanson > > For context: https://github.com/Netflix/vmaf/issues/237 > > Signed-off-by: Kyle Swanson > --- > > I'll push this sometime in the next 24hrs unless someone has an issue. Almost forgot about this. Push

[FFmpeg-devel] [PATCH] libvmaf: update docs

2018-10-22 Thread Kyle Swanson
From: Kyle Swanson For context: https://github.com/Netflix/vmaf/issues/237 Signed-off-by: Kyle Swanson --- I'll push this sometime in the next 24hrs unless someone has an issue. doc/filters.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH v2] avcodec: libdav1d AV1 decoder wrapper.

2018-10-01 Thread Kyle Swanson
Hi, On Sun, Sep 30, 2018 at 5:08 PM James Almer wrote: > From: Ronald S. Bultje > > Originally written by Ronald S. Bultje, with fixes, optimizations and > improvements by James Almer. > > Signed-off-by: James Almer > --- > Updated with some refactoring and to use a few new public facing field

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Kyle Swanson
Hi, On Mon, Aug 13, 2018 at 11:56 AM, Carl Eugen Hoyos wrote: > 2018-08-08 0:37 GMT+02:00, Kyle Swanson : > > > +{"n_threads", "Set number of threads to be used when computing > vmaf.", > > OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-10 Thread Kyle Swanson
Hi, > On Aug 9, 2018, at 10:10 AM, Kyle Swanson wrote: > > Hi, > >> On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: >> From: Kyle Swanson >> >> Signed-off-by: Kyle Swanson >> --- >> configure| 2 +- >> libavfi

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-09 Thread Kyle Swanson
Hi, On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: > From: Kyle Swanson > > Signed-off-by: Kyle Swanson > --- > configure| 2 +- > libavfilter/vf_libvmaf.c | 9 - > 2 files changed, 9 insertions(+), 2 deletions(-) > > I'll updat

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread Kyle Swanson
Hi, On Tue, Aug 7, 2018 at 8:02 PM, James Almer wrote: > On 8/7/2018 7:37 PM, Kyle Swanson wrote: > > From: Kyle Swanson > > > > Signed-off-by: Kyle Swanson > > --- > > configure| 2 +- > > libavfilter/vf_libvmaf.c | 9 - &

[FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread Kyle Swanson
From: Kyle Swanson Signed-off-by: Kyle Swanson --- configure| 2 +- libavfilter/vf_libvmaf.c | 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 15a58935de..e718c1531c 100755 --- a/configure +++ b/configure @@ -6089,7

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/segafilmenc: Do not mix variable declaration and code.

2018-04-09 Thread Kyle Swanson
On Mon, Apr 9, 2018 at 3:50 PM, Carl Eugen Hoyos wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Tue Apr > 10 00:50:01 2018 +0200| [4d1d7263d8ff32e67710b41f24fe485818c87211] | > committer: Carl Eugen Hoyos > > lavf/segafilmenc: Do not mix variable declaration and code. > > Fixes two warnin

Re: [FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-04-09 Thread Kyle Swanson
Hi, On Sun, Apr 8, 2018 at 6:27 PM, wrote: > From: Misty De Meo > > --- > libavformat/segafilm.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c > index 4c0cca0140..e72c26b144 100644 > --- a/libavformat/segafilm.c >

Re: [FFmpeg-devel] [PATCH] vf_libvmaf: Fix memory leak

2018-03-31 Thread Kyle Swanson
Hi, On Sun, Mar 25, 2018 at 9:44 AM, enctac wrote: > Fixes ticket #6967 > --- > libavfilter/vf_libvmaf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index dfe474c40c..42c6b66b69 100644 > --- a/libavfilter/vf_libvmaf.c > +++ b/

Re: [FFmpeg-devel] [PATCH] avfilter: add drmeter audio filter

2018-03-09 Thread Kyle Swanson
> > > +@section drmeter > +Measure audio dynamic range. > Can you add a short description here explaining this flavor of dynamic range? + > +The filter accepts the following options: > + > +@table @option > +@item length > +Set window lenght in seconds used to split audio into segments of equal >

Re: [FFmpeg-devel] [PATCH] avfilter: add drmeter audio filter

2018-03-09 Thread Kyle Swanson
Hi, On Wed, Mar 7, 2018 at 3:15 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 11 +++ > libavfilter/Makefile | 1 + > libavfilter/af_drmeter.c | 233 ++ > + > libavfilter/allfilters.c | 1 + > 4 fil

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-20 Thread Kyle Swanson
Hi, On Fri, Jan 19, 2018 at 5:03 PM, Michael Niedermayer wrote: > On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote: >> Hi, >> >> > >> > Ping. Unless text needs to be rescaled as well, this patch is ready for >> >

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-19 Thread Kyle Swanson
Hi, > > Ping. Unless text needs to be rescaled as well, this patch is ready for > review. > > > Regards, > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel LGTM as-is. I'll push this so

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-12 Thread Kyle Swanson
Hi, On Thu, Jan 11, 2018 at 5:42 AM, Gyan Doshi wrote: > The no-op commit e496c45 from Libav introduced an option which allowed the > user to relocate text to fit within the frame if it was going out of bounds. > > For some reason, when the merge commit b479e01 was applied, the option was > adde

Re: [FFmpeg-devel] [PATCH v2] avfilter: add dumpwave filter.

2018-01-11 Thread Kyle Swanson
Hi, Make sure you go back and read our comments. There were several things you didn't address in your most recent patch. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-10 Thread Kyle Swanson
Hi, For this to be a part of libavfilter the output needs to be more generic than the just the Soundcloud format. If we want this to be generally useful it should probably just output an array of floats between 0.0 and 1.0. The consumer of this data (JS library, or whatever) can use this in whatev

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-09 Thread Kyle Swanson
Hi, On Tue, Jan 9, 2018 at 3:49 PM, wrote: > From: Dmytro Humeniuk > > Signed-off-by: Dmytro Humeniuk > --- > Changelog | 1 + > doc/filters.texi | 23 > libavfilter/Makefile | 1 + > libavfilter/af_dumpwave.c | 285 +

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

2018-01-08 Thread Kyle Swanson
Hi, Can you provide some context for this? Please add docs as well. Can't really test this because it segfaults for me: ./ffmpeg -f lavfi -i anoisesrc -af dumpwave -f null - On Sun, Jan 7, 2018 at 4:36 PM, wrote: > > From: Dmytro Humeniuk > > Signed-off-by: Dmytro Humeniuk > --- > Changelog

Re: [FFmpeg-devel] order T-shirts

2017-12-19 Thread Kyle Swanson
Hi, Yeah, got mine too! Arrived safely in the USA. Thanks Thilo! Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] order T-shirts

2017-10-24 Thread Kyle Swanson
Hi, On Sun, Sep 4, 2016 at 2:34 PM, Thomas Volkert wrote: > Hi, > > Some guys at the VDD asked for FFmpeg T-shirts. > I'd like to do a new T-shirt order. The shirts could be given to > multimedia devs who stop at one of our next booths. > > My idea is to order 25 shirts: > > 1*S > 5*M > 10*L > 7

Re: [FFmpeg-devel] filters.texi: explain audio upsampling in loudnorm

2017-08-17 Thread Kyle Swanson
On Thu, Aug 17, 2017 at 1:27 PM, Lou Logan wrote: > On Wed, 16 Aug 2017 13:33:24 +0200 > Werner Robitza wrote: > >> From 35b49e497cac452c76ead8da4d618ab93216ad15 Mon Sep 17 00:00:00 2001 >> From: Werner Robitza >> Date: Wed, 16 Aug 2017 13:27:19 +0200 >> Subject: [PATCH] filters.texi: explain au

Re: [FFmpeg-devel] [PATCH] avcodec/g722enc: force mono channel layout

2017-06-26 Thread Kyle Swanson
On Fri, Jun 23, 2017 at 5:46 PM, Paul B Mahol wrote: > On 6/23/17, Kyle Swanson wrote: > > Signed-off-by: Kyle Swanson > > --- > > libavcodec/g722enc.c | 27 +++ > > 1 file changed, 11 insertions(+), 16 deletions(-) > > > > Shoul

Re: [FFmpeg-devel] [PATCH] avcodec/g722enc: force mono channel layout

2017-06-23 Thread Kyle Swanson
On Fri, Jun 23, 2017 at 5:46 PM, Paul B Mahol wrote: > On 6/23/17, Kyle Swanson wrote: >> Signed-off-by: Kyle Swanson >> --- >> libavcodec/g722enc.c | 27 +++ >> 1 file changed, 11 insertions(+), 16 deletions(-) >> > > Shoul

[FFmpeg-devel] [PATCH] avcodec/g722enc: force mono channel layout

2017-06-23 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavcodec/g722enc.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index 01a3db26fd..473646f45c 100644 --- a/libavcodec/g722enc.c +++ b/libavcodec/g722enc.c @@ -61,11

Re: [FFmpeg-devel] FFmpeg 3.3.1

2017-05-24 Thread Kyle Swanson
Hi, On Sun, May 14, 2017 at 5:15 AM, Michael Niedermayer wrote: > On Sun, May 14, 2017 at 11:05:42AM +0200, Hendrik Leppkes wrote: >> On Sun, May 14, 2017 at 3:18 AM, Michael Niedermayer >> wrote: >> > Hi all >> > >> > ill make 3.3.1 soon (likely within 24h) and releases from other >> > maintain

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Kyle Swanson
Hi, On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: > On Tue, 2 May 2017 16:16:35 +0200 > Nicolas George wrote: > >> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >> > This is all one big mess. >> >> It is, but I will not take responsibility when it is not mine. >> >> Libavfilter was in need

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Kyle Swanson
Hi, On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: > On 4/30/17, Nicolas George wrote: >> Le primidi 11 floreal, an CCXXV, Muhammad Faiz a ecrit : >>> Are you working on these? Because currently I'm not. >> >> There is nothing to work on yet: the message you answer to is raising a >> questi

  1   2   >