Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Lucas Cooper
I realized that I missed the indentation. I've fixed it in the latest patch. On 27 April 2017 at 09:52, Lucas Cooper wrote: > find_fps attempts to infer framerate from AVCodec's timebase. When this > results in a frame rate that isn't explicitly m

[FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Lucas Cooper
find_fps attempts to infer framerate from AVCodec's timebase. When this results in a frame rate that isn't explicitly marked as supported in av_timecode_check_frame_rate, find_fps returns the AVStream's avg_frame_rate, which, per avformat.h, _may_ be set (or not). mov_get_mpeg2_xdcam_codec_tag, mo

[FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Lucas Cooper
find_fps attempts to infer framerate from AVCodec's timebase. When this results in a frame rate that isn't explicitly marked as supported in av_timecode_check_frame_rate, find_fps returns the AVStream's avg_frame_rate, which, per avformat.h, _may_ be set (or not). mov_get_mpeg2_xdcam_codec_tag, mo

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-26 Thread Lucas Cooper
Just pinging in case this got lost somewhere. On 21 April 2017 at 00:01, Lucas Cooper wrote: > Does this need any more work or explanation? > > On 19 Apr. 2017 7:32 am, "Lucas Cooper" wrote: > >> Michael's right. The problem is that NaN is casted to an

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-21 Thread Lucas Cooper
Does this need any more work or explanation? On 19 Apr. 2017 7:32 am, "Lucas Cooper" wrote: > Michael's right. The problem is that NaN is casted to an int, resulting in > rate having undefined value. Not sure how I neglected to add that part. > > On 19 Apr. 2017 2:

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-19 Thread Lucas Cooper
On Wed, Apr 19, 2017 at 12:34 AM, Lucas Cooper > > wrote: > > > find_fps attempts to infer framerate from AVCodec's timebase. When this > > > results in a frame rate that isn't explicitly marked as supported in > > > av_timecode_check_frame_rate, find_fps

[FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-18 Thread Lucas Cooper
find_fps attempts to infer framerate from AVCodec's timebase. When this results in a frame rate that isn't explicitly marked as supported in av_timecode_check_frame_rate, find_fps returns the AVStream's avg_frame_rate, which, per avformat.h, _may_ be set (or not). mov_get_mpeg2_xdcam_codec_tag, mo

[FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-31 Thread Lucas Cooper
This allows retroactive calculation/aggregation of PSNR from the stats log. --- doc/filters.texi | 10 ++ libavfilter/vf_psnr.c | 20 2 files changed, 30 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 8cef0a0..92a49e6 100644 --- a/doc/filter

Re: [FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-29 Thread Lucas Cooper
llowup patch once this one is finalized or would you prefer them both in the same patch? On 27 August 2016 at 03:13, Michael Niedermayer wrote: > On Fri, Aug 26, 2016 at 12:10:17PM -0700, Lucas Cooper wrote: > > This allows retroactive calculation/aggregation of PSNR from th

[FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-26 Thread Lucas Cooper
This allows retroactive calculation/aggregation of PSNR from the stats log. --- libavfilter/vf_psnr.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 3bec747..9ad1423 100644 --- a/libavfilter/vf_psnr.c +++ b/libavfilter/vf_ps

[FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-11 Thread Lucas Cooper
This allows retroactive calculation/aggregation of PSNR from the stats log. --- libavfilter/vf_psnr.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 3bec747..de5cc8f 100644 --- a/libavfilter/vf_psnr.c +++ b/libavfilter/vf_ps

Re: [FFmpeg-devel] [PATCH] avfilter: Add new format for PSNR stats log

2016-08-01 Thread Lucas Cooper
it's unclear whether there's an existing reference + transcode pair of videos I can use and how/where to output the log and specify what it should be compared against. On 29 July 2016 at 15:10, Michael Niedermayer wrote: > On Mon, Jul 25, 2016 at 11:54:37AM -0700, Lucas Cooper wrote: >

[FFmpeg-devel] [PATCH] Add stats_version documentation to PSNR filter

2016-08-01 Thread Lucas Cooper
--- doc/filters.texi | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index c47dfee..923d481 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10692,13 +10692,31 @@ The description of the accepted parameters follows

[FFmpeg-devel] [PATCH] avfilter: Add new format for PSNR stats log

2016-07-25 Thread Lucas Cooper
Add an AVOption stats_version with a new header for V2 stats, which specifies the stats log version and lists the fields that will be present in the log (to ease parsing). The primary motivation is to facilitate the addition of optional fields to the log without breaking backwards compatibility, w

Re: [FFmpeg-devel] [PATCH] avfilter: Add max stats to PSNR log

2016-07-21 Thread Lucas Cooper
cerned though that for large videos the logs could become quite large with the raw numbers included, which is why I think they should be optional. On 20 July 2016 at 17:10, Michael Niedermayer wrote: > On Tue, Jul 19, 2016 at 10:49:20AM -0700, Lucas Cooper wrote: > > This allows retroacti

[FFmpeg-devel] [PATCH] avfilter: Add max stats to PSNR log

2016-07-19 Thread Lucas Cooper
This allows retroactive aggregation of the PSNR statistics (e.g. calculating average PSNR for entire video or a segment of the video). --- libavfilter/vf_psnr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 89acd3c..f3dff62 100644 ---

[FFmpeg-devel] [PATCH] avfilter: Add max stats to PSNR log

2016-07-15 Thread Lucas Cooper
This allows retroactive aggregation of the PSNR statistics (e.g. calculating average PSNR for entire video or a segment of the video). --- libavfilter/vf_psnr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 89acd3c..fd9019e 100644 ---

[FFmpeg-devel] [PATCH] Add encoder stats to the NVENC codec.

2016-03-07 Thread Lucas Cooper
--- libavcodec/nvenc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index a3b02fa..5489610 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1167,6 +1167,8 @@ static int process_output_surface(AVCodecCon

Re: [FFmpeg-devel] [PATCH] Add encoder stats to the NVENC codec.

2016-03-07 Thread Lucas Cooper
Ping. On 2 March 2016 at 15:21, Lucas Cooper wrote: > --- > libavcodec/nvenc.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index a3b02fa..67232c7 100644 > --- a/libavcodec/nvenc

[FFmpeg-devel] [PATCH] Add encoder stats to the NVENC codec.

2016-03-02 Thread Lucas Cooper
--- libavcodec/nvenc.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index a3b02fa..67232c7 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1208,31 +1208,35 @@ static int process_output_surface(AVCodecCo