[FFmpeg-devel] [PATCH] movenc: add m4b to ipod format extensions

2017-10-29 Thread Lukas Stabe
m4b is commonly used as extension for m4a audiobook files. The format is exactly the same. The only thing that differs is the extension. --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index a34987a7dc..a920eb

Re: [FFmpeg-devel] [PATCH] avformat: fix id3 chapters

2017-10-05 Thread Lukas Stabe
> On 5. Oct 2017, at 10:51, wm4 wrote: > > On Thu, 5 Oct 2017 03:34:19 +0200 > Lukas Stabe wrote: > >> These changes store id3 chapter data in ID3v2ExtraMeta and introduce >> ff_id3v2_parse_chapters to parse them into the format context if needed. >> >&

Re: [FFmpeg-devel] [PATCH] avformat: fix id3 chapters

2017-10-05 Thread Lukas Stabe
> On 5. Oct 2017, at 09:08, Paul B Mahol wrote: > > On 10/5/17, Lukas Stabe wrote: >> These changes store id3 chapter data in ID3v2ExtraMeta and introduce >> ff_id3v2_parse_chapters to parse them into the format context if needed. >> >> Encoders using ff_id

[FFmpeg-devel] [PATCH] avformat: fix id3 chapters

2017-10-04 Thread Lukas Stabe
These changes store id3 chapter data in ID3v2ExtraMeta and introduce ff_id3v2_parse_chapters to parse them into the format context if needed. Encoders using ff_id3v2_read, which previously parsed chapters into the format context automatically, were adjusted to call ff_id3v2_parse_chapters. ---

Re: [FFmpeg-devel] [PATCH] libavformat: Add format context parameter to ff_id3v2_read_dict

2017-09-26 Thread Lukas Stabe
> Kind of worried what happens if the ID3 information conflicts with the > normal container information. As you know, libavformat accepts even mp4 > or mkv files with ID3v2 header. > > Do you think this is a potential issue? I'm quite new to the ffmpeg source, but if I'm reading things correctly,

[FFmpeg-devel] [PATCH] libavformat: Add format context parameter to ff_id3v2_read_dict

2017-09-26 Thread Lukas Stabe
The format context (when not NULL) is used to store chapter information, which was not previously supported by ff_id3v2_read_dict. This fixes https://trac.ffmpeg.org/ticket/6558 --- libavformat/hls.c | 2 +- libavformat/id3v2.c | 4 ++-- libavformat/id3v2.h | 6 -- libavformat/utils.c | 2 +