Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
e for FFMPEGv6 Sent: Wednesday, April 27, 2022 at 4:18 PM From: "Timo Rothenpieler" To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] Guidance needed for a semi-breaking change On 27.04.2022 16:07, MCC CS wrote: > The default for AAC_AT is to produce highest quality audi

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
The default for AAC_AT is to produce highest quality audio, which I'll keep undoubtedly in the same direction. However, the question is this: Should the one who explicitly set `-aac_at_quality 0` (highest quality available) be moved from HIGH to MAX, HOWEVER causing the side effect of moving eve

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
I wasn't considering a breaking change, those using -aac_at_quality 0 or -aac_at_quality 2 would continue to use those. However, would moving -aac_at_quality 0 from HIGH (currently highest used by FFMPEG) to MAX be welcome? I'd assume that those using -aac_at_quality 0 do so to use the highest qual

[FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
Hi, It's my first time writing an (original) patch for ffmpeg, so I would like your help. I’m planning to propose a diff to an encoder param for aac_at, which is, as currently listed by "ffmpeg -h encoder=aac_at”: -aac_at_qualityE...A.. quality vs speed control (from 0 to 2)

Re: [FFmpeg-devel] 2nd ping

2022-04-25 Thread MCC CS
Nicely applied, many thanks!   Sent: Sunday, April 24, 2022 at 11:04 PM From: "James Almer" To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avdevice/dshow: reuse unused variables. On 4/19/2022 5:13 AM, Diederick Niehorster wrote: > Fix for f125c504d8fece6420bb97767f9e72414c26312a,

[FFmpeg-devel] 2nd ping

2022-04-21 Thread MCC CS
It would be great if anyone who reads this could review this small patch (original: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295351.html): This is a repost of the patch by Chris Snowhill who originally sent this patch on 31 December - which didn't receive any replies. As you can see o

[FFmpeg-devel] ping, ping, just 5 lines

2022-04-18 Thread MCC CS
The patch "avcodec/audiotoolboxdec: fix missing decoder out properties" hasn't been reviewed. Could anyone with some time, please, review this patch? Audiotoolbox decoder on macOS desperately needs this to be useful. ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] avcodec/audiotoolboxdec: fix missing decoder out properties

2022-04-13 Thread MCC CS
Resubmit: fix title. This is a repost of the patch by Chris Snowhill who originally sent this patch on 31 December - which didn't receive any replies. As you can see on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works perfectly. I have rebased it and recompiled it. Original comm

[FFmpeg-devel] Audiotoolbox fix missing decoder out properties

2022-04-13 Thread MCC CS
This is a repost of the patch by Chris Snowhill who originally sent this patch on 31 December - which didn't receive any replies. As you can see on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works perfectly. I have rebased it and recompiled it. Original commit description: Monte