[FFmpeg-devel] [PATCH v2 2/2] fftools: log unconnected filter output label

--- fftools/ffmpeg_filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index ddcd18dd15..b1ca710999 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1410,7 +1410,9 @@ int fg_finalise_bindings(void)

[FFmpeg-devel] [PATCH v2 1/2] fftools: do not access out of bounds filtergraph

The log message was logged for `filtergraphs[j]` which would cause a heap buffer overflow in certain circumstances. Correctly it should be logged for the current filtergraph, so just use `fg` here. --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fft

[FFmpeg-devel] [PATCH 1/2] fftools: do not access out of bounds filtergraph

The log message was logged for `filtergraphs[j]` which would cause a heap buffer overflow in certain circumstances. Correctly it should be logged for the current filtergraph, so just use `fg` here. --- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fft

[FFmpeg-devel] [PATCH 2/2] fftools: log unconnected filter output label

--- fftools/ffmpeg_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index e9271e74ed..01e3c087dd 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1410,7 +1410,7 @@ int fg_finalise_bindings(void)

[FFmpeg-devel] [PATCH 2/2] configure: allow mixed declarations and code for Objective-C

Mixing declarations and code is quite common in Objective-C (as can be seen by the number of warnings we have for this in Objective-C files) and forcing to not do it usually results in worse code, with unnecessary widely scoped variables, which in turn makes variable shadowing and accidentally usin

[FFmpeg-devel] [PATCH 1/2] configure: fix passing Objective-C flags

Passing Objective-C flags from configure to the Makefiles was broken, as configure incorrectly used the OBJCCFLAGS instead of OBJCFLAGS variable which was then later overwritten in the common.mak: OBJCCFLAGS = $(CPPFLAGS) $(CFLAGS) $(OBJCFLAGS) The fix for this is simple, analogous to how it i

[FFmpeg-devel] [PATCH] configure: do not use interval regexp operators with awk

Some awk implementations like mawk (used on Ubuntu) do not support these. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d872213af7a..d568739bf90 100755 --- a/configure +++ b/configure @@ -6150,11 +6150,11 @@ enable_weak_pic() { enabl

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h265: fix missing slice_block_cols assignment

Instead of assigning to unit_opts.slice_block_cols, the slice_block_cols value from the context was incorrectly assigned to slice_block_rows. Regression from 12f158ca8f2ecc172f27569af88426d0e39ce995 Fixes CID1619479 Unused value --- libavcodec/vaapi_encode_h265.c | 2 +- 1 file changed, 1 insert

[FFmpeg-devel] [PATCH v2 2/2] doc: add styles for good/bad code examples

Makes it easier to immediately see if the code examples given in the style documentation are good or bad examples, making it harder to accidentally confuse a bad example for a good one. --- doc/style.min.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/style.min.css b/do

[FFmpeg-devel] [PATCH v2 1/2] doc/developer: add examples to clarify code style

Given the frequency that new developers, myself included, get the code style wrong, it is useful to add some examples to clarify how things should be done. --- doc/developer.texi | 101 - 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/doc

Re: [FFmpeg-devel] [PATCH] lavc: Fix epirats suggestions

> Signed-off-by: Petro Mozil […] Thanks, Marvin Scholz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v3 2/2] configure: correctly set sanitizer toolchain compilers

Previously only the C compiler was set, which would lead to confusing situations where even though clang-asan was selected, it would still use g++ for C++ code, failing because configure does not support mixing compilers in this way (which is a separate issue not addressed by this commit). --- con

[FFmpeg-devel] [PATCH v3 1/2] configure: fix symbol prefix detection

The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to onl

[FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: fix leaks on error

In case of errors in this function, the allocated context was not properly freed in several cases. --- libavdevice/decklink_dec.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9a817daf187..418701

[FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: fix leak on error

In the early return when both draw_bars and signal_loss_action options are used, the context allocated previously was not properly freed. Introduced in 9bcb86b0fa58f1a5a2a8613065349e26abadb329 Fixes CID1619296 --- libavdevice/decklink_dec.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/l

[FFmpeg-devel] [PATCH v2] configure: fix symbol prefix detection

The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to o

[FFmpeg-devel] [PATCH] configure: fix symbol prefix detection

The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to o

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as vf_xfade_vulkan maintainer

Ruiling Song vf_yadif.c[2] Michael Niedermayer + vf_xfade_vulkan.c [2] Marvin Scholz (CC ) Sources: vsrc_mandelbrot.c [2] Michael Niedermayer base-commit: a15d2fdfd96c0ce711e0be3fe6c2f47b5a39b931 -- 2.39.3 (Apple Git-146

[FFmpeg-devel] [PATCH] lavfi/af_channelmap: fix channelmap_init error handling

The channelmap_init function was returning success even on error after 7dc81d33c241b9e176ea85956e8317f29bc9e3c0 due to shadowing of the outer ret variable. Fixes CID1619297 Logically dead code --- libavfilter/af_channelmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liba

[FFmpeg-devel] [PATCH 60/60] avfilter/drawutils: fix variable shadowing

--- libavfilter/drawutils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c index 95525d38b4..b29d3e565e 100644 --- a/libavfilter/drawutils.c +++ b/libavfilter/drawutils.c @@ -156,7 +156,6 @@ int ff_draw_init(FFDrawContext *dr

[FFmpeg-devel] [PATCH 59/60] avformat/apetag: fix variable shadowing

--- libavformat/apetag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/apetag.c b/libavformat/apetag.c index 0989fcb094..84645607de 100644 --- a/libavformat/apetag.c +++ b/libavformat/apetag.c @@ -81,7 +81,7 @@ static int ape_tag_read_field(AVFormatContext *s)

[FFmpeg-devel] [PATCH 58/60] avformat/avio: fix variable shadowing

--- libavformat/avio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index d109f3adff..fd767c9ba9 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -57,7 +57,7 @@ static void *urlcontext_child_next(void *obj, void *prev)

[FFmpeg-devel] [PATCH 57/60] avformat/bonk: fix variable shadowing

--- libavformat/bonk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/bonk.c b/libavformat/bonk.c index 44de8e2087..d5eacfdc91 100644 --- a/libavformat/bonk.c +++ b/libavformat/bonk.c @@ -63,7 +63,7 @@ static int bonk_read_header(AVFormatContext *s) const

[FFmpeg-devel] [PATCH 56/60] avformat/http: fix variable shadowing

--- libavformat/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index ec60bc0b17..22e4126790 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -150,7 +150,7 @@ typedef struct HTTPContext { #define E AV_OPT_FLAG_ENCOD

[FFmpeg-devel] [PATCH 55/60] avformat/img2enc: fix variable shadowing

--- libavformat/img2enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 526a11e5ee..ae239d27ea 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@ -224,7 +224,7 @@ static int write_packet(AVFormatContext *s, AV

[FFmpeg-devel] [PATCH 54/60] avformat/matroskadec: fix variable shadowing

--- libavformat/matroskadec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index c8741ff2af..60b20e9658 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -1281,8 +1281,8 @@ static int

[FFmpeg-devel] [PATCH 53/60] avformat/nsvdec: fix variable shadowing

--- libavformat/nsvdec.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c index dd01765d7d..a55da05226 100644 --- a/libavformat/nsvdec.c +++ b/libavformat/nsvdec.c @@ -380,7 +380,7 @@ static int nsv_parse_

[FFmpeg-devel] [PATCH 52/60] avformat/mxfdec: narrow variable scopes

--- libavformat/mxfdec.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index eb7d301444..8a83bdfa04 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -482,9 +482,7 @@ static int kl

[FFmpeg-devel] [PATCH 51/60] avformat/mxfdec: fix variable shadowing

--- libavformat/mxfdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index ac63c0d5ad..eb7d301444 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -871,16 +871,16 @@ static int mxf_read_partition_

[FFmpeg-devel] [PATCH 50/60] avformat/rawdec: fix variable shadowing

--- libavformat/rawdec.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c index d0c829dc42..c7c18f9aac 100644 --- a/libavformat/rawdec.c +++ b/libavformat/rawdec.c @@ -161,12 +161,11 @@ const FFInputFormat ff_data_demuxer = { #i

[FFmpeg-devel] [PATCH 48/60] avformat/tee: fix variable shadowing

--- libavformat/tee.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index 1a2a8ead82..7ec9ab4800 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -65,7 +65,7 @@ static const char *const slave_bsfs_spec_sep = "/"; static cons

[FFmpeg-devel] [PATCH 49/60] avformat/srtpproto: fix variable shadowing

--- libavformat/srtpproto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/srtpproto.c b/libavformat/srtpproto.c index 02cf156327..cf6064625c 100644 --- a/libavformat/srtpproto.c +++ b/libavformat/srtpproto.c @@ -37,7 +37,7 @@ typedef struct SRTPProtoContext {

[FFmpeg-devel] [PATCH 47/60] avformat/yuv4mpegdec: fix variable shadowing

--- libavformat/yuv4mpegdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c index 2b66a1e596..61b5a9e17b 100644 --- a/libavformat/yuv4mpegdec.c +++ b/libavformat/yuv4mpegdec.c @@ -36,7 +36,7 @@ static int yuv4_read_hea

[FFmpeg-devel] [PATCH 46/60] avformat/vividas: narrow variable scopes

--- libavformat/vividas.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 4cad6c6456..e984dd0b21 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -282,7 +282,7 @@ static uint8_t *read_

[FFmpeg-devel] [PATCH 45/60] avformat/vividas: fix variable shadowing

--- libavformat/vividas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index 130b81ebbe..4cad6c6456 100644 --- a/libavformat/vividas.c +++ b/libavformat/vividas.c @@ -417,7 +417,7 @@ static int track_header(VividasDemuxContext *v

[FFmpeg-devel] [PATCH 44/60] avformat/vorbiscomment: fix variable shadowing

--- libavformat/vorbiscomment.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/vorbiscomment.c b/libavformat/vorbiscomment.c index abe12fd586..af51c237e6 100644 --- a/libavformat/vorbiscomment.c +++ b/libavformat/vorbiscomment.c @@ -62,7 +62,7 @@ int64_t ff

[FFmpeg-devel] [PATCH 43/60] avformat/webmdashenc: fix variable shadowing

--- libavformat/webmdashenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 3d9badc0d3..a4940dd1c5 100644 --- a/libavformat/webmdashenc.c +++ b/libavformat/webmdashenc.c @@ -382,11 +382,11 @@ static int writ

[FFmpeg-devel] [PATCH 42/60] avformat/webpenc: fix variable shadowing

--- libavformat/webpenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c index ce0d046aa9..5d0eed5a8e 100644 --- a/libavformat/webpenc.c +++ b/libavformat/webpenc.c @@ -163,7 +163,6 @@ static int webp_write_packet(AVFormatContext *s, AVPacket *pkt

[FFmpeg-devel] [PATCH 41/60] avcodec/ac3dec: fix variable shadowing

--- libavcodec/ac3dec.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index 0a4d3375ee..5cc47a6b1d 100644 --- a/libavcodec/ac3dec.c +++ b/libavcodec/ac3dec.c @@ -1492,7 +1492,7 @@ static int ac3_decode_frame(AVCo

[FFmpeg-devel] [PATCH 40/60] avcodec/alac: fix variable shadowing

--- libavcodec/alac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index f91288e97c..7916a006c2 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -331,7 +331,7 @@ static int decode_element(AVCodecContext *avctx, AVFrame *frame,

[FFmpeg-devel] [PATCH 39/60] avcodec/atrac3plus: fix variable shadowing

--- libavcodec/atrac3plus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/atrac3plus.c b/libavcodec/atrac3plus.c index f17ed0cbb5..8ca6989c07 100644 --- a/libavcodec/atrac3plus.c +++ b/libavcodec/atrac3plus.c @@ -75,7 +75,7 @@ static av_cold void build_cano

[FFmpeg-devel] [PATCH 38/60] avcodec/elbg: narrow variable scopes

--- libavcodec/elbg.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c index 22219f9a6f..c1b8d16cd2 100644 --- a/libavcodec/elbg.c +++ b/libavcodec/elbg.c @@ -74,8 +74,8 @@ typedef struct ELBGContext { st

[FFmpeg-devel] [PATCH 37/60] avcodec/elbg: fix variable shadowing

--- libavcodec/elbg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c index 84043af4fd..22219f9a6f 100644 --- a/libavcodec/elbg.c +++ b/libavcodec/elbg.c @@ -158,7 +158,7 @@ static int simple_lbg(ELBGContext *elbg,

[FFmpeg-devel] [PATCH 36/60] avcodec/eatgq: narrow variable scopes

--- libavcodec/eatgq.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/libavcodec/eatgq.c b/libavcodec/eatgq.c index b760f29243..f17802f5e8 100644 --- a/libavcodec/eatgq.c +++ b/libavcodec/eatgq.c @@ -59,9 +59,9 @@ static av_cold int tgq_decode_init(

[FFmpeg-devel] [PATCH 35/60] avcodec/eatgq: fix variable shadowing

--- libavcodec/eatgq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/eatgq.c b/libavcodec/eatgq.c index d326c05390..b760f29243 100644 --- a/libavcodec/eatgq.c +++ b/libavcodec/eatgq.c @@ -154,19 +154,19 @@ static void tgq_idct_put_mb_dconly(TgqContext *s, AVF

[FFmpeg-devel] [PATCH 34/60] avcodec/dv_tablegen: narrow variable scope

--- libavcodec/dv_tablegen.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/dv_tablegen.h b/libavcodec/dv_tablegen.h index 6d3e200a01..ee604b1cfe 100644 --- a/libavcodec/dv_tablegen.h +++ b/libavcodec/dv_tablegen.h @@ -51,7 +51,6 @@ static struct dv_vlc_pair d

[FFmpeg-devel] [PATCH 33/60] avcodec/dv_tablegen: fix variable shadowing

--- libavcodec/dv_tablegen.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dv_tablegen.h b/libavcodec/dv_tablegen.h index 7f0ab53fa7..6d3e200a01 100644 --- a/libavcodec/dv_tablegen.h +++ b/libavcodec/dv_tablegen.h @@ -51,7 +51,7 @@ static struct dv_vlc_pair dv

[FFmpeg-devel] [PATCH 32/60] avcodec/dvdec: fix variable shadowing

--- libavcodec/dvdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c index 8297b6d2f3..7ca891e93a 100644 --- a/libavcodec/dvdec.c +++ b/libavcodec/dvdec.c @@ -155,10 +155,10 @@ static av_cold void dv_init_static(void) VLC dv_vl

[FFmpeg-devel] [PATCH 31/60] avcodec/exr: narrow variable scope and fix shadowing

--- libavcodec/exr.c | 103 --- 1 file changed, 53 insertions(+), 50 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 4bac0be89b..0f7c7b8546 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -989,7 +989,7 @@ static int dwa_uncom

[FFmpeg-devel] [PATCH 30/60] avcodec/ffv1enc: fix shadowing and narrow variable scopes

--- libavcodec/ffv1enc.c | 113 +- libavcodec/ffv1enc_template.c | 19 +++--- 2 files changed, 63 insertions(+), 69 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 23d757e5c6..f054ef0974 100644 --- a/libavcodec/ffv1enc.c +++ b/

[FFmpeg-devel] [PATCH 29/60] avcodec/fix: narrow variable scopes

--- libavcodec/fic.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/libavcodec/fic.c b/libavcodec/fic.c index 4763fab689..8f4277b4e1 100644 --- a/libavcodec/fic.c +++ b/libavcodec/fic.c @@ -113,25 +113,24 @@ static av_always_inlin

[FFmpeg-devel] [PATCH 28/60] avcodec/fix: fix variable shadowing

--- libavcodec/fic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/fic.c b/libavcodec/fic.c index ec26e3154d..4763fab689 100644 --- a/libavcodec/fic.c +++ b/libavcodec/fic.c @@ -191,8 +191,6 @@ static int fic_decode_slice(AVCodecContext *avctx, void *tdata) for (y = 0

[FFmpeg-devel] [PATCH 27/60] avcodec/flacenc: fix variable shadowing and narrow scopes

--- libavcodec/flacenc.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index 3a9578f5cd..83b3f5e324 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -952,7 +952,7 @@ static int lpc_encode_

[FFmpeg-devel] [PATCH 26/60] avcodec/g2meet: fix variable shadowing

--- libavcodec/g2meet.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c index 7ae987ec40..f952a06f12 100644 --- a/libavcodec/g2meet.c +++ b/libavcodec/g2meet.c @@ -1052,7 +1052,6 @@ static int kempf_decode_tile(G2MContext *

[FFmpeg-devel] [PATCH 25/60] avcodec/mjpegdec: fix variable shadowing

--- libavcodec/mjpegdec.c| 15 +++ libavcodec/mjpegenc_common.c | 13 ++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 7daec649bc..86ec58713c 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mj

[FFmpeg-devel] [PATCH 24/60] avcodec/libx264: fix variable shadowing

--- libavcodec/libx264.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index d07a65a103..fc0f182bf4 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -564,12 +564,12 @@ static int setup_frame(AVCodecContext *ctx,

[FFmpeg-devel] [PATCH 23/60] fftools/ffmpeg_demux: narrow variable scope

--- fftools/ffmpeg_demux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 18938f1f12..0b639f2b60 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1888,9 +1888,7 @@ int ifile_open(const OptionsContext

[FFmpeg-devel] [PATCH 22/60] fftools/ffmpeg_demux: fix variable shadowing

--- fftools/ffmpeg_demux.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 039ee0c785..18938f1f12 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1597,7 +1597,7 @@ int ifile_open(const Options

[FFmpeg-devel] [PATCH 21/60] fftools/ffmpeg_mux_init: fix variable shadowing

--- fftools/ffmpeg_mux_init.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 8d475f5b45..c2867192ee 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -661,11 +661,9 @@ static

[FFmpeg-devel] [PATCH 20/60] fftools/ffmpeg_mux_init: remove unused variable

This dict is declared and freed but nothing is ever written to it. --- fftools/ffmpeg_mux_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 37d626add6..8d475f5b45 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_i

[FFmpeg-devel] [PATCH 19/60] avdevice/jack: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavdevice/jack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavdevice/jack.c b/libavdevice/jack.c index d52bb06822..bb06971fe6 100644 --- a/libavdevice/

[FFmpeg-devel] [PATCH 18/60] avutil/file: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavutil/file.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavutil/file.c b/libavutil/file.c index 2d1063b6a2..db8507286b 100644 --- a/libavutil/

[FFmpeg-devel] [PATCH 17/60] avformat/crypto: fix variable shadowing

--- libavformat/crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/crypto.c b/libavformat/crypto.c index cd462e7b9d..868f6ddc25 100644 --- a/libavformat/crypto.c +++ b/libavformat/crypto.c @@ -62,7 +62,7 @@ typedef struct CryptoContext { #define OFFSET(x)

[FFmpeg-devel] [PATCH 16/60] avformat/dashdec: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavformat/dashenc.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index d4a6fe0304..df9d

[FFmpeg-devel] [PATCH 15/60] avformat/network: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavformat/network.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index 6db82b6d26..2eabd0c

[FFmpeg-devel] [PATCH 10/60] lavfi/vf_vmafmotion: narrow variable scopes

--- libavfilter/vf_vmafmotion.c | 53 + 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/libavfilter/vf_vmafmotion.c b/libavfilter/vf_vmafmotion.c index a8adc67019..3f1bd1a6e2 100644 --- a/libavfilter/vf_vmafmotion.c +++ b/libavfilter/vf_vmafmotio

[FFmpeg-devel] [PATCH 14/60] lavfi/vf_signature: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/vf_signature.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index f205f6919f..f419522

[FFmpeg-devel] [PATCH 09/60] lavfi/vf_vmafmotion: fix variable shadowing

--- libavfilter/vf_vmafmotion.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_vmafmotion.c b/libavfilter/vf_vmafmotion.c index f9315e56b6..a8adc67019 100644 --- a/libavfilter/vf_vmafmotion.c +++ b/libavfilter/vf_vmafmotion.c @@ -90,11 +90,10 @@ static void

[FFmpeg-devel] [PATCH 08/60] lavfi/vf_vmafmotion: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/vf_vmafmotion.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_vmafmotion.c b/libavfilter/vf_vmafmotion.c index 7bc73416e8..f9315e56b

[FFmpeg-devel] [PATCH 13/60] lavfi/f_metadata: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/f_metadata.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c index 1a72284790..abdfb1802b 100644

[FFmpeg-devel] [PATCH 07/60] lavfi/vf_psnr: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/vf_psnr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 1f02811806..4a5db5df23 100644 --- a/lib

[FFmpeg-devel] [PATCH 12/60] lavfi/vf_ssim: narrow variable scopes

--- libavfilter/vf_ssim.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index 54e28d43bd..52b22a6870 100644 --- a/libavfilter/vf_ssim.c +++ b/libavfilter/vf_ssim.c @@ -194,9 +194,8 @@ static float ssim_end1(int s1,

[FFmpeg-devel] [PATCH 06/60] fftools/cmdutils: fix variable shadowing

--- fftools/cmdutils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index f725c31c12..a9a7ff4194 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -802,7 +802,7 @@ int split_commandline(OptionParseContext *octx, int arg

[FFmpeg-devel] [PATCH 11/60] lavfi/vf_ssim: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/vf_ssim.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index 97bffcf70c..54e28d43bd 100644 --- a/lib

[FFmpeg-devel] [PATCH 05/60] lavfi/vf_ssim360: fix variable shadowing

--- libavfilter/vf_ssim360.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c index 68bd7b4d78..42632bcd85 100644 --- a/libavfilter/vf_ssim360.c +++ b/libavfilter/vf_ssim360.c @@ -1132,7 +1132,7 @@ static int

[FFmpeg-devel] [PATCH 04/60] lavfi/vf_ssim360: use av_err2str to simplify code

No need to explicitly specify the buffer here as it is only ever passed to av_log, so av_err2str can be used. --- libavfilter/vf_ssim360.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c index 57da2f3938..68bd7b4d78 100644

[FFmpeg-devel] [PATCH 03/60] fftools/opt_common: use av_err2str instead of strerror

The strerror function must not be used here, as the error is a AVERROR errno, which depending on the platform no longer corresponds to the actual errno that can be handled by strerror. --- fftools/opt_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/opt_common.c

[FFmpeg-devel] [PATCH 02/60] fftools/opt_common: fix variable shadowing

--- fftools/opt_common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fftools/opt_common.c b/fftools/opt_common.c index 9d2d5184a0..059f7a53d2 100644 --- a/fftools/opt_common.c +++ b/fftools/opt_common.c @@ -553,15 +553,15 @@ static void show_help_filter(const c

[FFmpeg-devel] [PATCH 01/60] fftools/ffmpeg_opt: fix variable shadowing

--- fftools/ffmpeg_opt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 3cbf0795ac..1aa187f706 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -87,8 +87,6 @@ int recast_media = 0; static void uninit_opt

[FFmpeg-devel] [PATCH] lavu/opt: av_opt_set_array: fix uninitialised return

In one failure path for av_opt_set_array, the ret variable was declared again, shadowing the outer one and writing the return value to the wrong one and then after the goto returning the uninitialized one instead. Introduced in 450a3f58edb22d28912a5e65dc08d9e2fb805066 Fixes: CID1619242 Uninitiali

[FFmpeg-devel] [PATCH] lavfi/avfiltergraph: fix leak on error

Introduced in eddffbedb3443d5a4fe642de6e35b9e6a35cfda7 Fixes: CID1618897 Resource leak --- libavfilter/avfiltergraph.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index c84dd3cf25..3946f04b53 100644 --- a/libavfi

[FFmpeg-devel] [RFC] [PATCH] avcodec/cbs_h266: Fix copy paste mistake

The us macro expect the range_max here, which seems should be MAX_UINT_BITS(hlen) here. Fix CID1618757 Copy-paste error --- This code is non-trivial to understand so I might be wrong about this, it would be great if someone actually familiar with this can have a look if my assesment is correct he

[FFmpeg-devel] [PATCH] avformat/iamf_parse: Fix return of uninitialized value

The ret value here is not yet intialized so the return would return uninitialized data. What was probably meant to be checked here was the return value of ffio_read_size, which can return an error. Introduced in 38bcb3ba7b3424abd772c72f8bdf445d75285e88 Fixes: CID1618758 --- libavformat/iamf_pars

[FFmpeg-devel] [PATCH] lavu/opt: Fix return of uninitialised value

In one of the failure paths of av_opt_get_array, the ret variable was accidentally declared again, shadowing the outer one and once when jumping to the fail label would return the still uninitialised outer one. To fix this simply remove the local declaration of ret that shadowed the outer one. In

[FFmpeg-devel] [PATCH] MAINTAINERS: add CC preference for myself

Ronald S. Bultje udp.c Luca Abeni - icecast.c Marvin Scholz + icecast.c Marvin Scholz (CC ) libswresample base-commit: 7ad937f0c8cb9f120c50f3e792a699076923768e -- 2.39.3 (Apple Git-146

[FFmpeg-devel] [PATCH] fftools/ffmpeg: remove useless error check

When ret is checked here, it was never assigned anything, making this check useless, as highlighted by Coverity. It seems to be a copy paste mistake given that opt_match_per_stream_str does not return an error code that could be checked and the previous value assigned to ret is already checked abo

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

> On 24. Jul 2024, at 00:10, Michael Niedermayer wrote: > > On Tue, Jul 23, 2024 at 12:17:43PM -0300, James Almer wrote: >>> On 7/19/2024 12:31 PM, Paul B Mahol wrote: >>> Internal/private filter structures/API changes does not need be mentioned >>> in that file, isn't that fact obvious even fo

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

The previous fix was not sufficient. To make things easier to reason about, split the function and add the guards there instead of complicating the call site more. --- libavutil/hwcontext_videotoolbox.c | 51 +++--- 1 file changed, 39 insertions(+), 12 deletions(-) diff --

[FFmpeg-devel] [PATCH] ffbuild: add METALCC and METALLIB to BRIEF

--- ffbuild/common.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffbuild/common.mak b/ffbuild/common.mak index 87a3ffd2b0..023adb8567 100644 --- a/ffbuild/common.mak +++ b/ffbuild/common.mak @@ -18,7 +18,7 @@ BIN2C = $(BIN2CEXE) ifndef V Q = @ ECHO = printf "$(1

[FFmpeg-devel] [PATCH 3/3] avcodec/pcm-dvdenc: use av_assert_unreachable

Fixes a compiler warning about quant possibly being uninitialised. --- libavcodec/pcm-dvdenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index 71e9b6915a..f553d8076a 100644 --- a/libavcodec/pcm-dvdenc.c +++ b/libavcodec/pc

[FFmpeg-devel] [PATCH 2/3] avfilter/af_afftdn: use av_assert_unreachable

Fixes a compiler warning about mag possibly being uninitialised. --- libavfilter/af_afftdn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_afftdn.c b/libavfilter/af_afftdn.c index a2e6ca6107..f26b620cfb 100644 --- a/libavfilter/af_afftdn.c +++ b/libavfilter/af_

[FFmpeg-devel] [PATCH 1/3] avutil/avassert: Add av_assert_unreachable()

--- libavutil/avassert.h | 12 1 file changed, 12 insertions(+) diff --git a/libavutil/avassert.h b/libavutil/avassert.h index 1895fb7551..cdab912fe4 100644 --- a/libavutil/avassert.h +++ b/libavutil/avassert.h @@ -75,4 +75,16 @@ */ void av_assert0_fpu(void); +/** + * Assert thi

[FFmpeg-devel] [PATCH 11/11] avfilter/yadif_common: fix mixed declaration and code

Fix a "mixing declarations and code is incompatible with standards before C99" warning. --- libavfilter/vf_yadif_videotoolbox.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_yadif_videotoolbox.m b/libavfilter/vf_yadif_videotoolbox.m index eb7026395e..5cc7585

[FFmpeg-devel] [PATCH 10/11] avfilter/yadif_common: remove unused variable

--- libavfilter/vf_yadif_videotoolbox.m | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_yadif_videotoolbox.m b/libavfilter/vf_yadif_videotoolbox.m index c47d3edfb8..eb7026395e 100644 --- a/libavfilter/vf_yadif_videotoolbox.m +++ b/libavfilter/vf_yadif_videotoolbox.m @@ -172,7 +1

[FFmpeg-devel] [PATCH 09/11] avfilter/vf_coreimage: silence AVFrame deprecation warnings

Deprecation warning need to be disabled here as we set deprecated fields. --- libavfilter/vf_coreimage.m | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m index 38355414bd..45b16cc48a 100644 --- a/libavfilter/vf_core

[FFmpeg-devel] [PATCH 08/11] avfilter/vf_coreimage: simplify list_filters code

Use fast-enumeration and get rid of unnecessary intermediate variables. --- libavfilter/vf_coreimage.m | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m index bfc17764b5..38355414bd 100644 --- a/libavfilter/vf_

[FFmpeg-devel] [PATCH 07/11] avfilter/vf_coreimage: fix mixed declaration and code

Fix several "mixing declarations and code is incompatible with standards before C99" warnings. --- libavfilter/vf_coreimage.m | 60 ++ 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m index 4

[FFmpeg-devel] [PATCH 06/11] lavfi/metal: simplify fallback

Instead of using a fallback variable, just do an early return. --- libavfilter/metal/utils.m | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/metal/utils.m b/libavfilter/metal/utils.m index d5c85e619d..6a9e5ef7cf 100644 --- a/libavfilter/metal/utils.m +++ b/li

[FFmpeg-devel] [PATCH 05/11] lavfi/metal: fix mixed declaration and code

Fix a "mixing declarations and code is incompatible with standards before C99" warning. --- libavfilter/metal/utils.m | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavfilter/metal/utils.m b/libavfilter/metal/utils.m index f365d3ceea..d5c85e619d 100644 --- a/lib

[FFmpeg-devel] [PATCH 04/11] avdevice/avfoundation: remove write-only variable

The block_buffer was only ever written to but then never used in the following code, making it unnecessary. Fixes a "variable 'block_buffer' set but not used" compiler warning. --- libavdevice/avfoundation.m | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavde

  1   2   3   4   5   >