[FFmpeg-devel] [RFC] libpostproc splitout

2024-11-06 Thread Michael Niedermayer
Hi all Should libpostproc be split out into a seperate source repository ? Several people did over the years want libpostproc removed, and such a task was part of the submitted and approved STF 2024 projects. But when i recently started posting related work, tomas questioned if spliting libpostpr

Re: [FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-06 Thread Michael Niedermayer
On Wed, Nov 06, 2024 at 01:18:43PM +0100, Michael Niedermayer wrote: > On Tue, Nov 05, 2024 at 06:59:57AM +0800, Steven Liu wrote: > > Michael Niedermayer 于2024年11月5日 周二04:34写道: > > > > > Hi all > > > > > > I think, in general most fixed issues (both b

Re: [FFmpeg-devel] root access voting

2024-11-06 Thread Michael Niedermayer
Hi [...] > > > I hope there is noone who belives one can remove a persons admin powers for > > no reason, put oneself in power instead and have that person still be > > a volunteer working in that project afterwards. > > > > ronald, you are someone knowing about buisness, I think you know this. If

Re: [FFmpeg-devel] root access voting

2024-11-06 Thread Michael Niedermayer
Hi There are several different topics in your mail so i will try to reply to them one at a time On Wed, Nov 06, 2024 at 09:56:47AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-11-06 00:55:59) > > This community has just a few months ago managed to loose the 2n

Re: [FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-06 Thread Michael Niedermayer
On Tue, Nov 05, 2024 at 06:59:57AM +0800, Steven Liu wrote: > Michael Niedermayer 于2024年11月5日 周二04:34写道: > > > Hi all > > > > I think, in general most fixed issues (both bugs and features) > > should have a test added to fate. > > > > To make that actu

Re: [FFmpeg-devel] root access voting

2024-11-06 Thread Michael Niedermayer
Hi [...] > > > And having an all inclusive meeting, there is no remote participation, no > > recording, Even the developer with the most commits in FFmpeg has no option > > to participate. > > You DO have an option to participate, you just choose not to use it. > Besides, people have tried for man

Re: [FFmpeg-devel] root access voting

2024-11-05 Thread Michael Niedermayer
On Tue, Nov 05, 2024 at 04:51:30PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Nov 3, 2024 at 11:37 AM Michael Niedermayer > wrote: > > > On Sun, Nov 03, 2024 at 08:56:36PM +0900, Rémi Denis-Courmont wrote: > > > Le 2 novembre 2024 20:34:30 GMT+09:00,

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-04 Thread Michael Niedermayer
Fixes: Use of uninitialised value of size 8 Fixes: 368725676/clusterfuzz-testcase-minimized-fuzzer_protocol_file-6022251122589696-cut Fixes: 42537758/clusterfuzz-testcase-minimized-fuzzer_protocol_file-5818969469026304-cut Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by: Michael

[FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-04 Thread Michael Niedermayer
Hi all I think, in general most fixed issues (both bugs and features) should have a test added to fate. To make that actually happen i suggest to introduce a state like "fixed_and_fate_test" to trac That way we can track if a closed issue has had a fate test added (using the existing "fixed" to

[FFmpeg-devel] [PATCH 5/5] avformat/vividas: Check avio_read() for failure

2024-11-03 Thread Michael Niedermayer
Fixes: use of uninitialized value (untested) Fixes: 42537627/clusterfuzz-testcase-minimized-fuzzer_loadfile_direct-5505802505355264 Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 4/5] avformat/ilbc: Check avio_read() for failure

2024-11-03 Thread Michael Niedermayer
Fixes: use of uninitialized value Fixes: 42537627/clusterfuzz-testcase-minimized-fuzzer_protocol_memory-6656646223298560-cut Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by: Michael Niedermayer --- libavformat/ilbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 3/5] avformat/nistspheredec: Clear buffer

2024-11-03 Thread Michael Niedermayer
Fixes: use-of-uninitialized-value Fixes: 42537627/clusterfuzz-testcase-minimized-fuzzer_protocol_memory-6515855798632448-cut Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by: Michael Niedermayer --- libavformat/nistspheredec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[FFmpeg-devel] [PATCH 2/5] avformat/mccdec: Initialize and check rate.den

2024-11-03 Thread Michael Niedermayer
Fixes: Assertion c > 0 failed at libavutil/mathematics.c:61 Fixes: use-of-uninitialized-value Fixes: 42537627/clusterfuzz-testcase-minimized-fuzzer_protocol_memory-5939605805793280 Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by: Michael Niedermayer --- libavformat/mccdec.c

[FFmpeg-devel] [PATCH 1/5] avformat/rpl: check channels

2024-11-03 Thread Michael Niedermayer
Fixes: 42537199/clusterfuzz-testcase-minimized-fuzzer_loadfile_direct-5447162658357248 Fixes: runtime error: signed integer overflow: -3330498059201358222 * 4 cannot be represented in type 'int64_t' (aka 'long') Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Tighter maxsize

2024-11-03 Thread Michael Niedermayer
On Sun, Oct 27, 2024 at 12:46:17AM +0200, Michael Niedermayer wrote: > This allows using smaller buffers > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 17 + > 1 file changed, 13 insertions(+), 4 del

Re: [FFmpeg-devel] [PATCH] INSTALL: explain the circular dependency issue and solution

2024-11-03 Thread Michael Niedermayer
On Sat, Nov 02, 2024 at 02:45:39PM -0300, James Almer wrote: > On 11/2/2024 2:24 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > INSTALL.md | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/INSTAL

Re: [FFmpeg-devel] root access voting

2024-11-03 Thread Michael Niedermayer
Hi On Sun, Nov 03, 2024 at 08:56:36PM +0900, Rémi Denis-Courmont wrote: [...] > >Thats besides the root admins should generally be professional admins and not > >"popular politicans". > > You have blocked Josh and Marvin, neither of whom strike me as popular > politicians (sorry, no offence inte

Re: [FFmpeg-devel] root access voting

2024-11-03 Thread Michael Niedermayer
Hi Remi On Sun, Nov 03, 2024 at 08:56:36PM +0900, Rémi Denis-Courmont wrote: > Hi, > > Le 2 novembre 2024 20:34:30 GMT+09:00, Michael Niedermayer > a écrit : > >At teh current videolan developer days there where several surprise votes on > >FFmpegs > >infractruct

[FFmpeg-devel] [PATCH] avformat/icodec: fix integer overflow with nb_pal

2024-11-03 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow Fixes: 42536949/clusterfuzz-testcase-minimized-fuzzer_loadfile-6199846684393472 Found-by: ossfuzz Reported-by: Kacper Michajlow Tested-by: Kacper Michajlow Signed-off-by: Michael Niedermayer --- libavformat/icodec.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 00/19] fate: fix several dependencies

2024-11-02 Thread Michael Niedermayer
On Sun, Oct 27, 2024 at 02:09:16AM +0200, Nicolas Gaullier wrote: > It is impossible to double check every single test case. > With my default basic setup, fate-list is unchanged, which is a good start... > Nothing extraordinary, but here is a limited setup I used: > https://pastebin.com/GZ72Qz7r

Re: [FFmpeg-devel] [PATCH 11/15] avformat/flacdec:Return correct error-codes on read-failure

2024-11-02 Thread Michael Niedermayer
On Wed, Oct 30, 2024 at 11:44:37AM +0100, Tomas Härdin wrote: > tis 2024-10-29 klockan 18:42 +0100 skrev Michael Niedermayer: > > On Tue, Oct 29, 2024 at 03:50:05PM +0100, Tomas Härdin wrote: > > > Reasonable enough. Might want a sample > > &

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check entropy_decoder_read_symbol return value

2024-11-02 Thread Michael Niedermayer
Hi On Fri, Nov 01, 2024 at 01:50:38PM +0100, Kacper Michajłow wrote: > Found by OSS-Fuzz. > > Signed-off-by: Kacper Michajłow > --- > libavcodec/jpegxl_parser.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) patch makes sense, ill leave to Leo Izen to apply, as its his code but

[FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-02 Thread Michael Niedermayer
Hi Should we move to a different development system ? I dont know, but I belive we should carefully consider if we want to move to a gitlab like system that is a commercal / corporate and not community driven system that we can get stuck in. Companies get sold change owner/leader, and in no time g

Re: [FFmpeg-devel] [PATCH V6] Patch to add interlaced HEVC decoding to HEVCDEC

2024-11-02 Thread Michael Niedermayer
On Thu, Oct 31, 2024 at 01:45:12PM -0500, Jose Santiago wrote: [...] > hevcdec.c | 24 +++ > hevcdec.h | 13 + > refs.c| 417 > -- > sei.c | 16 -- > sei.h | 129 ++- > 5 files changed, 574 insertions

[FFmpeg-devel] [PATCH] INSTALL: explain the circular dependency issue and solution

2024-11-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- INSTALL.md | 8 1 file changed, 8 insertions(+) diff --git a/INSTALL.md b/INSTALL.md index 3b220bc6ff2..4398ca12fa1 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -15,3 +15,11 @@ NOTICE -- - Non system dependencies (e.g. libx264, libvpx) are

[FFmpeg-devel] root access voting

2024-11-02 Thread Michael Niedermayer
Hi At teh current videolan developer days there where several surprise votes on FFmpegs infractructure. And to the best of my knowledge no remote participation and no recording. So let me try to reply to the idea of the general assembly choosing who has root access. We have seen a raise of incr

Re: [FFmpeg-devel] [PATCH] libavutil/ppc: Include the hardware feature flags like the other archs

2024-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2024 at 01:45:46AM -0400, Brad Smith wrote: > ping. it builds on my old cross compile environment on ubuntu but i have no real ppc here to test beyond that thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level lan

Re: [FFmpeg-devel] [PATCH] avformat/vpk: fix divide by zero

2024-11-01 Thread Michael Niedermayer
Hi On Fri, Nov 01, 2024 at 02:20:33PM +0100, Kacper Michajlow wrote: > On Sat, 10 Aug 2024 at 18:49, Kacper Michajlow wrote: > > > > On Sat, 10 Aug 2024 at 11:25, Andreas Rheinhardt > > wrote: > > > > > > Kacper Michajlow: > > > > On Fri, 9 Aug

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-11-01 Thread Michael Niedermayer
On Thu, Oct 31, 2024 at 04:13:38PM -0300, James Almer wrote: > On 10/31/2024 3:34 PM, Michael Niedermayer wrote: > > On Tue, Oct 29, 2024 at 04:50:47PM -0300, James Almer wrote: > > > On 10/29/2024 4:29 PM, Michael Niedermayer wrote: > > > > On Tue, Oct 29, 202

Re: [FFmpeg-devel] [PATCH] swscale/output: add full chroma interpolation support for x2rgb10

2024-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2024 at 10:29:07AM -0300, James Almer wrote: > On 11/1/2024 8:27 AM, Michael Niedermayer wrote: > > On Wed, Oct 30, 2024 at 12:20:19PM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libs

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate/vvc: Add a sample which lose frames before 5c66a3

2024-11-01 Thread Michael Niedermayer
On Fri, Nov 01, 2024 at 09:11:47AM +, Zhao Zhili wrote: > ffmpeg | branch: master | Zhao Zhili | Wed Sep 18 > 14:56:22 2024 +0800| [1864025458021a2d2c542f56e268ee1106f84460] | committer: > Zhao Zhili > > fate/vvc: Add a sample which lose frames before 5c66a3 > > Signed-off-by: Zhao Zhili

Re: [FFmpeg-devel] [PATCH] swscale/output: fix x2rbg10/x2bgr10 output

2024-11-01 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 07:19:13PM -0300, James Almer wrote: > Checking for AV_PIX_FMT_X2RGB10 means the condition will succeed only for the > version matching the host's endinaness, when only LE is supported, and thus > the wrong path will be taken on BE systems. > > Signed-off-by: James Almer >

Re: [FFmpeg-devel] [PATCH 1/2] vsrc_testsrc: add support for x2rgb10le to rgbtestsrc

2024-11-01 Thread Michael Niedermayer
On Wed, Oct 30, 2024 at 10:25:41AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vsrc_testsrc.c | 11 +++ > 1 file changed, 11 insertions(+) mips is unhappy before and after this patch --- src/tests/ref/fate/filter-pixdesc-x2bgr10le 2024-10-26 22:34:14.53245

Re: [FFmpeg-devel] [PATCH 2/2] fate/filter-video: add more rgbtestsrc tests

2024-11-01 Thread Michael Niedermayer
On Wed, Oct 30, 2024 at 10:25:42AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/filter-video.mak| 12 > tests/ref/fate/filter-rgbtestsrc-gbrp | 10 ++ > tests/ref/fate/filter-rgbtestsrc-gbrp10| 10 ++ > tests/ref/f

Re: [FFmpeg-devel] [PATCH] swscale/output: add full chroma interpolation support for x2rgb10

2024-11-01 Thread Michael Niedermayer
On Wed, Oct 30, 2024 at 12:20:19PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/output.c | 25 + > libswscale/utils.c | 4 +++- > tests/ref/fate/filter-pixfmts-scale | 4 ++-- > 3 files changed, 30 insertions(

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-31 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 04:50:47PM -0300, James Almer wrote: > On 10/29/2024 4:29 PM, Michael Niedermayer wrote: > > On Tue, Oct 29, 2024 at 01:03:21PM +0100, Michael Niedermayer wrote: > > > On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: > > > >

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: fix crash when vk renderer is null

2024-10-31 Thread Michael Niedermayer
On Thu, Oct 31, 2024 at 02:40:57PM +0100, Leandro Santiago wrote: > When vulkan rendering is requested by the user and fails, ffplay should > exit graciously instead of crash due to a null pointer deref. > > Signed-off-by: Leandro Santiago > --- > fftools/ffplay.c | 5 + > 1 file changed, 5

Re: [FFmpeg-devel] [RFC] libavutil split out

2024-10-31 Thread Michael Niedermayer
Hi On Thu, Oct 31, 2024 at 10:12:57AM +0100, Tomas Härdin wrote: > tor 2024-10-31 klockan 01:08 +0100 skrev Michael Niedermayer: [...] > > , well iam sure > > you see this doesnt work > > build ffmpeg first, theres no libmycodec, > > build libmycodec first, theres no

Re: [FFmpeg-devel] [PATCH V3] Patch to add interlaced HEVC decoding to HEVCDEC

2024-10-31 Thread Michael Niedermayer
On Wed, Oct 30, 2024 at 01:31:35PM -0500, Jose Santiago wrote: > From d55b49766d5e0256685c4874568db002d3dd7889 Mon Sep 17 00:00:00 2001 > From: Jose Santiago > Date: Wed, 30 Oct 2024 12:28:35 -0500 > Subject: [PATCH] [PATCH V3] Patch to add interlaced HEVC decoding to > HEVCDEC > > --- > libav

[FFmpeg-devel] [RFC] libavutil split out

2024-10-30 Thread Michael Niedermayer
Hi Theres a problem with libavutil, or maybe more than one a library implementing a codec that tries do use libavutil and itself is used by libavcodec. Creates a (build) dependancy like this libavutil -> libmycodec -> libavcodec Thats ok if libavutil is a seperate source but if libavutil and liba

Re: [FFmpeg-devel] [PATCH v2] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-10-29 Thread Michael Niedermayer
On Sun, Oct 27, 2024 at 04:28:27PM +0200, IndecisiveTurtle wrote: > Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets > and should work with all wavelet depths. > > Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 > minutes with the cpu encoder

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-29 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 01:03:21PM +0100, Michael Niedermayer wrote: > On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: > > On 10/25/2024 7:18 PM, Michael Niedermayer wrote: > > > On Wed, Oct 23, 2024 at 04:36:44PM -0300, James Almer wrote: > > > &

Re: [FFmpeg-devel] [PATCH 11/15] avformat/flacdec:Return correct error-codes on read-failure

2024-10-29 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 03:50:05PM +0100, Tomas Härdin wrote: > Reasonable enough. Might want a sample > > Spotify comments > > Unexpected EOF is treated as invalid data > > /Tomas > flacdec.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > 8cf

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-29 Thread Michael Niedermayer
On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: > On 10/25/2024 7:18 PM, Michael Niedermayer wrote: > > On Wed, Oct 23, 2024 at 04:36:44PM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libswscal

Re: [FFmpeg-devel] [PATCH v4 00/13] major refactor and new scaling API

2024-10-29 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 12:25:10PM +0200, Niklas Haas wrote: > Changes since v3: > - Make SwsInternal a superset of SwsContext, instead of a separate struct > - Fix minor bug in the calculation of SWS_STRICT > > I overall prefer this version, it simplifies things and allows us to split > apart the

Re: [FFmpeg-devel] [PATCH v4 01/13] swscale: rename SwsContext to SwsInternal

2024-10-29 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 12:25:11PM +0200, Niklas Haas wrote: > From: Niklas Haas > > And preserve the public SwsContext as separate name. The motivation here > is that I want to turn SwsContext into a public struct, while keeping the > internal implementation hidden. Additionally, I also want to

Re: [FFmpeg-devel] [PATCH v4 13/13] avfilter/vf_scale: switch to new swscale API

2024-10-29 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 12:25:23PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Most logic from this filter has been co-opted into swscale itself, > allowing the resulting filter to be substantially simpler as it no > longer has to worry about context initialization, interlacing, etc. > > S

Re: [FFmpeg-devel] [PATCH] Allow linking to an external libpostproc

2024-10-28 Thread Michael Niedermayer
On Mon, Oct 28, 2024 at 04:40:25PM -0300, James Almer wrote: > On 10/28/2024 3:28 PM, Michael Niedermayer wrote: > > Hi everyone > > > > On Mon, Oct 28, 2024 at 01:24:48AM +0100, Michael Niedermayer wrote: > > > Sponsored-by: Sovereign Tech Fund > >

Re: [FFmpeg-devel] [PATCH] Allow linking to an external libpostproc

2024-10-28 Thread Michael Niedermayer
Hi everyone On Mon, Oct 28, 2024 at 01:24:48AM +0100, Michael Niedermayer wrote: > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > Makefile | 3 +-- > configure| 18 -- > fftools/ffprobe.c| 1 - >

[FFmpeg-devel] [PATCH] Allow linking to an external libpostproc

2024-10-28 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 +-- configure| 18 -- fftools/ffprobe.c| 1 - fftools/opt_common.c | 1 - 4 files changed, 9 insertions(+), 14 deletions(-) diff --git a/Makefile b/Makefile

[FFmpeg-devel] [PATCH] avcodec/ffv1enc: Tighter maxsize

2024-10-26 Thread Michael Niedermayer
This allows using smaller buffers Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index a32059886c0..7a6c718b41b

Re: [FFmpeg-devel] [PATCH 1/5] swscale/rgb2rgb_template: Fix ff_rgb24toyv12_c() with odd height

2024-10-25 Thread Michael Niedermayer
On Thu, Oct 10, 2024 at 02:18:28AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 368143798/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6475823425585152 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Support slice coding mode 1 with golomb rice

2024-10-25 Thread Michael Niedermayer
On Fri, Oct 25, 2024 at 04:24:04AM +0200, Lynne via ffmpeg-devel wrote: > On 25/10/2024 03:57, Michael Niedermayer wrote: > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ffv1dec.c | 20 ++

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-25 Thread Michael Niedermayer
On Wed, Oct 23, 2024 at 04:36:44PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/output.c | 37 +++- > libswscale/utils.c | 4 +-- > tests/ref/fate/filter-pixdesc-xv48be | 1 + > tests/ref/fate/filter

Re: [FFmpeg-devel] [PATCH 2/7] swscale/input: add XV48 input support

2024-10-25 Thread Michael Niedermayer
On Wed, Oct 23, 2024 at 04:36:43PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/input.c | 40 > libswscale/utils.c | 2 ++ > 2 files changed, 34 insertions(+), 8 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint

Re: [FFmpeg-devel] [PATCH] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-10-25 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 02:03:27AM +0300, IndecisiveTurtle wrote: > Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets > and should work with all wavelet depths. > > Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 > minutes with the cpu encoder

[FFmpeg-devel] [PATCH] avcodec/ffv1: Support slice coding mode 1 with golomb rice

2024-10-24 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 20 ++-- libavcodec/ffv1dec_template.c | 3 +++ libavcodec/ffv1enc.c | 23 --- 3 files changed, 25 insertions(+), 21 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ffv1: Implement new slice tiling

2024-10-24 Thread Michael Niedermayer
On Tue, Oct 01, 2024 at 10:31:26PM +0200, Michael Niedermayer wrote: > This fixes corner cases (requires version 4 or a spec update) > > Fixes: Ticket5548 > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > l

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: constrain supported YUV color spaces

2024-10-24 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 10:55:40AM +0200, Niklas Haas wrote: > On Thu, 24 Oct 2024 02:44:34 +0200 Michael Niedermayer > wrote: > > On Fri, Feb 09, 2024 at 08:14:46PM +, Niklas Haas wrote: > > > ffmpeg | branch: master | Niklas Haas | Mon Feb 5 >

Re: [FFmpeg-devel] [PATCH v3 09/18] swscale/internal: use static_assert for enforcing offsets

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:18PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Instead of sprinkling av_assert0 into random init functions. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale_internal.h | 11 +++ > libswscale/utils.c

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/ffv1enc: Prevent generation of files with broken slices

2024-10-23 Thread Michael Niedermayer
On Fri, Oct 11, 2024 at 09:39:14AM +0200, Lynne via ffmpeg-devel wrote: > On 01/10/2024 22:31, Michael Niedermayer wrote: [...] > > +int i = width * (int64_t)(num_h_slices - 1) / num_h_slices; > > + > > +return width % mpw && (width - i) % mpw == 0;

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: constrain supported YUV color spaces

2024-10-23 Thread Michael Niedermayer
On Fri, Feb 09, 2024 at 08:14:46PM +, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Mon Feb 5 19:28:04 > 2024 +0100| [c619d20906d039060efbeaa822daf8e949f3ef24] | committer: Niklas > Haas > > fftools/ffplay: constrain supported YUV color spaces > > SDL supports only these th

Re: [FFmpeg-devel] [PATCH v3 04/18] swscale: add sws_free_context()

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:13PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Merely a convenience wrapper around sws_freeContext(). The name change is for > parity with the other sws_* functions. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swsc

Re: [FFmpeg-devel] [PATCH v3 10/18] swscale/x86: use dedicated int for self-modifying MMX dstW

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:19PM +0200, Niklas Haas wrote: > From: Niklas Haas > > I want to pull options out of SwsInternal, so we need to make this field > a dedicated int that gets updated as appropriate in ff_swscale(). > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas >

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/rangecoder: only perform renorm check/loop for callers that need it

2024-10-23 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 09:49:48PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/rangecoder.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611E

Re: [FFmpeg-devel] [PATCH v3 07/18] swscale: add sws_is_noop()

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:16PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Exactly what it says on the tin. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale.h | 6 ++ > libswscale/utils.c | 14 ++ > 2 files changed, 20 i

Re: [FFmpeg-devel] [PATCH v3 06/18] swscale: add new frame testing API

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:15PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Replacing the old sws_isSupported* API with a more consistent family > of functions that follows the same signature and naming convention, > including a placeholder for testing the color space parameters that > w

Re: [FFmpeg-devel] [PATCH v3 05/18] swscale/utils: add SwsFormat abstraction and helpers

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:14PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Groups together all relevant color metadata from an AVFrame. While we could > use AVFrame directly, keeping it a separate struct has three advantages: > > 1. Functions accepting an SwsFormat will definitely not

Re: [FFmpeg-devel] [PATCH 3/6] swscale/output: add Y216LE output support

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 09:48:44AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/output.c | 44 > libswscale/utils.c | 2 +- > tests/ref/fate/filter-pixdesc-y216le | 1 + > tests/ref/fate/filter-

Re: [FFmpeg-devel] [PATCH 2/6] swscale/input: add Y216LE input support

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 09:48:43AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/input.c | 7 +++ > libswscale/utils.c | 1 + > 2 files changed, 8 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There wil

Re: [FFmpeg-devel] Add support for LJ92 compressed MLV files

2024-10-23 Thread Michael Niedermayer
On Mon, Oct 21, 2024 at 07:44:47PM +0100, South East wrote: > ffmpeg has existing support for MLV raw video files; libavformat/mlvdec.c. > Since this was added, MLV has been extended to support LJ92 compressed > image data. These patches build on lossless DNG support in 7.2-dev to > enable handlin

Re: [FFmpeg-devel] [PATCH v3 11/18] swscale: expose SwsContext publicly

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:20PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This commit does the ardous work of splitting the options out of SwsInternal. > To avoid having to change leaf functions too much in one commit, we simply > leave behind a pointer to the main context, and replace

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 04:22:06PM +0200, Lynne via ffmpeg-devel wrote: > On 16/10/2024 15:26, Michael Niedermayer wrote: > > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression > > with rawlsb=4 > > > > Please test and comment > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: silently ignore APPx stubs

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 11:25:58AM +0200, Ramiro Polla wrote: > On Mon, Oct 21, 2024 at 1:41 AM Michael Niedermayer > wrote: > > On Thu, Oct 17, 2024 at 01:00:12PM +0200, Ramiro Polla wrote: > > > Consider APPx fields that are too short to contain an id field (32-bit) > &g

Re: [FFmpeg-devel] GSoC Mentor Summit Reimbursement Request

2024-10-23 Thread Michael Niedermayer
On Thu, Oct 10, 2024 at 07:29:32PM +0100, Frank Plowman wrote: > Hello, > > I would like to request reimbursement for the following expenses > incurred attending the Google Summer of Code mentor summit. > > Description | Amount >

Re: [FFmpeg-devel] [PATCH 1/1] Output .lrc with correct end time

2024-10-23 Thread Michael Niedermayer
On Wed, Oct 23, 2024 at 03:50:54PM +0800, Lu Renjia wrote: [...] > @@ -91,6 +101,8 @@ static int lrc_write_packet(AVFormatContext *s, > AVPacket *pkt) > while(line) { patch corrupted by a linebreak: Applying: Output .lrc with correct end time error: corrupt patch at line 38 error: could

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-22 Thread Michael Niedermayer
On Mon, Oct 21, 2024 at 04:40:41PM +0200, Jerome Martinez wrote: > Le 16/10/2024 à 22:53, Michael Niedermayer a écrit : > > what are you testing? > > the new code is faster than the old code. > > There is something not right here, the range coder based implementation > >

Re: [FFmpeg-devel] [PATCH v12 3/9] avutil/swscale: add YUV444F16 and UYVYF16 pixel format and input support

2024-10-21 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 12:30:42AM +0200, Michael Niedermayer wrote: > On Mon, Oct 21, 2024 at 09:57:16PM +0200, Martin Schitter wrote: > > --- > > libavutil/pixdesc.c | 48 > > libavutil/pixfmt.h | 6 ++ > > libswscale

Re: [FFmpeg-devel] [PATCH v12 3/9] avutil/swscale: add YUV444F16 and UYVYF16 pixel format and input support

2024-10-21 Thread Michael Niedermayer
On Mon, Oct 21, 2024 at 09:57:16PM +0200, Martin Schitter wrote: > --- > libavutil/pixdesc.c | 48 > libavutil/pixfmt.h | 6 ++ > libswscale/input.c | 99 > libswscale/utils.c | 4 ++ > tests

Re: [FFmpeg-devel] libavfilter: integral images and minkowski pooling for SSIM - ping

2024-10-21 Thread Michael Niedermayer
On Mon, Oct 21, 2024 at 07:32:20PM +0200, AndreaMastroberti wrote: > --- > doc/filters.texi | 14 +++ > libavfilter/ssim.h| 6 + > libavfilter/version.h | 4 +- > libavfilter/vf_ssim.c | 277 -- > 4 files changed, 291 insertions(+), 10 deletions(-)

Re: [FFmpeg-devel] [PATCH 5/6] swscale/swscale_unscaled: clear the low bits in planar8ToP01xleWrapper

2024-10-20 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 08:56:07PM -0300, James Almer wrote: > On 10/20/2024 8:52 PM, Michael Niedermayer wrote: > > On Fri, Oct 18, 2024 at 11:34:47PM -0300, James Almer wrote: > > > This makes the unscaled output of p010le and p016le match the generic > > > path.

Re: [FFmpeg-devel] [PATCH v4 2/6] avutil/pixdesc: add alpha component information to pixfmts with reserved but undefined alpha bits

2024-10-20 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 11:34:44PM -0300, James Almer wrote: > This can be useful to simplify certain processes that need to know how many > reserved bits there are and where they are placed, even if they are ultimately > unused, as will be shown in the next commit. > For any other case where the u

Re: [FFmpeg-devel] [PATCH v2 3/6] avfilter/vsrc_testsrc: use the alpha component information for XV3{0, 6} and V30X

2024-10-20 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 11:34:45PM -0300, James Almer wrote: > And add a few more tests to ensure all the pixfmts affected by this change > are tested. > > Signed-off-by: James Almer > --- > libavfilter/vsrc_testsrc.c | 7 ++- > tests/fate/filter-video.mak | 6

Re: [FFmpeg-devel] [PATCH 4/6] avfilter/vf_pixdesctest: also take into account undefined alpha components

2024-10-20 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 11:34:46PM -0300, James Almer wrote: > Ensure those bits are copied, which will result in the output being the same > as > the input, where swscale set them to the equivalent of fully opaque. > > Signed-off-by: James Almer > --- > libavfilter/vf_pixdesctest.c

Re: [FFmpeg-devel] [PATCH 5/6] swscale/swscale_unscaled: clear the low bits in planar8ToP01xleWrapper

2024-10-20 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 11:34:47PM -0300, James Almer wrote: > This makes the unscaled output of p010le and p016le match the generic path. > > Signed-off-by: James Almer > --- > libswscale/swscale_unscaled.c | 6 +++--- > tests/ref/fate/filter-pixdesc-p010le| 2 +- > tests/ref/fate

Re: [FFmpeg-devel] [PATCH 6/6] fate/filter-video: make fate-filter-pixdesc compare the hashed output with and without pixdesctest filtering

2024-10-20 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 11:34:48PM -0300, James Almer wrote: > This helps detecting inconsistencies in swscale input/output code and > a av_read_image_line()/av_write_image_line() pass. > > Signed-off-by: James Almer > --- > tests/fate-run.sh | 21 + > tests/fate/fi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: silently ignore APPx stubs

2024-10-20 Thread Michael Niedermayer
On Thu, Oct 17, 2024 at 01:00:12PM +0200, Ramiro Polla wrote: > Consider APPx fields that are too short to contain an id field (32-bit) > as stubs, and silently ignore them. > > This has been seen in the MJPEG output from some webcams (such as the > Logitech C270 and C920) and the JPEG images embe

Re: [FFmpeg-devel] [PATCH] tests/fate/filter-video: don't convert owdenoise test to mpeg range

2024-10-20 Thread Michael Niedermayer
Hi Ramiro On Thu, Oct 17, 2024 at 01:13:39PM +0200, Ramiro Polla wrote: > On Sun, Sep 29, 2024 at 5:38 PM Ramiro Polla wrote: > > > > --- > > The new owdenoise-scenwin-jpeg.raw reference file is available at > > https://0x0.st/XguT.raw > > > > tests/fate/filter-video.mak | 4 ++-- > > 1 file ch

Re: [FFmpeg-devel] [PATCH] lavu/common: Fix AV_CEIL_RSHIFT for unsigned LHS

2024-10-20 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 06:48:40PM +0100, Frank Plowman wrote: > On 15/10/2024 21:23, Frank Plowman wrote: > > On 14/10/2024 23:26, Michael Niedermayer wrote: > >> On Sat, Oct 05, 2024 at 03:38:05PM -0700, Frank Plowman wrote: > >>> The first branch of this ternary ex

Re: [FFmpeg-devel] [PATCH] Added support to enable VBV-End feature with x265 encode

2024-10-20 Thread Michael Niedermayer
On Thu, Oct 17, 2024 at 02:29:36PM +0530, Yaswanth Sastry wrote: > Hi Michael, > Here is the updated patch to support Vbv-end Feature,the API in the patch > is expected to work with X265_BUILD >= 213 only. [...] > fftools/ffmpeg_enc.c |2 ++ > libavcodec/avcodec.h |1 + > libavcodec/libx

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-20 Thread Michael Niedermayer
On Sat, Oct 19, 2024 at 07:22:23PM -0300, James Almer wrote: > On 10/19/2024 7:09 PM, Michael Niedermayer wrote: > > On Sat, Oct 19, 2024 at 10:33:58AM -0300, James Almer wrote: > > > As there's no guarantee that the output will be exactly the same across > > > i

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread Michael Niedermayer
On Sat, Oct 19, 2024 at 10:33:58AM -0300, James Almer wrote: > As there's no guarantee that the output will be exactly the same across > implementations, > just don't test it at all. > > Signed-off-by: James Almer not objecting to this patch but inflate is 550 lines of code "Entire inflater (i

Re: [FFmpeg-devel] [PATCH v2 02/19] swscale: rename SwsContext to SwsInternal

2024-10-19 Thread Michael Niedermayer
On Thu, Oct 17, 2024 at 02:28:54PM +0200, Niklas Haas wrote: > On Mon, 14 Oct 2024 20:58:31 +0200 Michael Niedermayer > wrote: > > On Mon, Oct 14, 2024 at 08:33:50PM +0200, Niklas Haas wrote: > > > On Mon, 14 Oct 2024 19:49:21 +0200 Michael Niedermayer > > > wrote

[FFmpeg-devel] [PATCH 2/2] avformat/dxa: check bpc

2024-10-18 Thread Michael Niedermayer
Fixes: integer overflow: -2147483648 - 1 cannot be represented in type 'int' Fixes: 373971762/clusterfuzz-testcase-minimized-ffmpeg_dem_DXA_fuzzer-4880491112103936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 1/2] swscale/slice: clear allocated memory in alloc_lines()

2024-10-18 Thread Michael Niedermayer
Fixes: use of uninitialized memory in hScale16To15_c() Fixes: 373924007/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-5841199968092160 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libswscale

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-18 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 02:02:48PM +0200, Alexander Strasser via ffmpeg-devel wrote: > This is as subject notes an RFC. I wanted to send it out quickly. > Didn't actually test on zlib systems yet (old and new). > > So it is not that heavily tested yet and maybe has rough edges I > didn't notice.

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-18 Thread Michael Niedermayer
On Fri, Oct 18, 2024 at 03:55:58PM +0100, Derek Buitenhuis wrote: > On 10/18/2024 1:02 PM, Alexander Strasser via ffmpeg-devel wrote: [...] > For a lossles encoder, especially one that uses external deps, but this > applies to internal ones too, almost no value is provided by ensuring > that its o

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-17 Thread Michael Niedermayer
On Thu, Oct 17, 2024 at 11:05:31AM +0200, Anton Khirnov wrote: > Quoting Niklas Haas (2024-10-16 14:30:47) > > On Tue, 15 Oct 2024 18:12:21 +0200 Michael Niedermayer > > wrote: > > > Hi all > > > > > > This is a quick RFC about peoples oppinions on

Re: [FFmpeg-devel] nuv1 in avi

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 12:39:14AM +0300, Andrew Randrianasulu wrote: > вс, 13 окт. 2024 г., 14:40 Anton Khirnov : > > > Quoting Andrew Randrianasulu (2024-10-08 14:03:13) > > > I was experimenting with mencoder > > > > > > > > > > > > what do you think? ;) > > > > why oh oh god why? > > > >

Re: [FFmpeg-devel] [PATCH 10/20] swscale/output: add VYU444 output support

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 09, 2024 at 02:03:28PM -0300, James Almer wrote: > On 10/8/2024 4:56 PM, Michael Niedermayer wrote: > > On Mon, Oct 07, 2024 at 09:29:45AM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libswscal

  1   2   3   4   5   6   7   8   9   10   >