Re: [FFmpeg-devel] [PATCH] hevc: fix WPP mode

Hi Christophe, the fix looks weird to me. There is something else underlying. Mickaël 2015-09-23 16:53 GMT+02:00 Ronald S. Bultje : > Hi, > > On Wed, Sep 23, 2015 at 10:33 AM, Christophe Gisquet < > christophe.gisq...@gmail.com> wrote: > > > Hi, > > > > under

Re: [FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

Looks better to me. Mickaël Le mardi 17 février 2015, Christophe Gisquet christophe.gisq...@gmail.com a écrit : 2015-02-17 8:28 GMT+01:00 Mickaël Raulet mrau...@insa-rennes.fr javascript:;: It seems to me that you are affecting 8 when it is avx2 instead of 11. Shouldn't it be the opposite

Re: [FFmpeg-devel] hevc : support deinterlacing inside the decoder

be wrong) nb_output = s-sps-temporal_layer[s-sps-max_sub_layers - 1]. num_reorder_pics + s-interlaced +1 2015-02-08 20:09 GMT+01:00 Carl Eugen Hoyos ceho...@ag.or.at: Kacper Michajłow kasper93 at gmail.com writes: 2015-02-08 10:48 GMT+01:00 Carl Eugen Hoyos: Mickaël Raulet mraulet

[FFmpeg-devel] DSP function ARM NEON patches for hevc

Michael, Please find some commits that can be cherry picked from https://github.com/OpenHEVC/FFmpeg/commits/ffmpeg_patch Optimized deblocking filter (8bits only) 1b9ee47d2f43b0a029a9468233626102eb1473b8 Optimzed transform functions (4x4, 8x8, transform add 8bits only)

[FFmpeg-devel] hevc : support deinterlacing inside the decoder

As we can consider, we won't have 4k interlaced content, copying a field into a frame should be ok. This is what has been done in this implementation. Commit hash from ffmpeg/openhevc: 6b93a7a175fb500d1f5d4d671b2fab73798ca7b6 Comments welcome! Mickaël

Re: [FFmpeg-devel] [PATCH 5/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

LGTM Mickael 2015-02-04 13:39 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com : Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: Original x86 intrinsics code and initial yasm port by Pierre-Edouard Lepere. Refactoring and optimizations by James Almer. Add your

Re: [FFmpeg-devel] [PATCH 6/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_{10, 12}_{sse2, avx2}

LGTM. Mickael 2015-02-04 13:51 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com : Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_1)= { 0x0001000100010001ULL, 0x0001000100010001ULL }; -DECLARE_ALIGNED(16, const

Re: [FFmpeg-devel] [PATCH 2/6] hevcdsp: simplified sao_edge_filter

OK too. 2015-02-04 8:04 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: +int a_stride, b_stride; +int src_offset = 0; +int dst_offset = 0; Could maybe use ptrdiff_t type, like the other strides? With

Re: [FFmpeg-devel] [PATCH 4/6] hevcdsp: replace the SAOParams struct parameter from sao_edge_filter

lgtm. Mickael 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: As with sao_band_filter, pass instead the two variables from the struct needed in the function. This simplifies writing asm optimized versions. Signed-off-by: James Almer jamr...@gmail.com ---

Re: [FFmpeg-devel] [PATCH 3/6] hevcdsp: further simplify sao_edge_filter

ok. 2015-02-04 8:07 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: [...] Ok, no need to resend a refreshed patch if patch 2/6 changes. -- Christophe ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

I will check it this evening. Mickaël 2015-02-03 15:15 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com : 2015-02-03 12:57 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: Actually, 940300945 does need to be reverted for the patch to work, as Mickael stated. It

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

it works now for me. Thanks, Mickaël Le 3 févr. 2015 à 15:28, Mickaël Raulet mrau...@insa-rennes.fr a écrit : I will check it this evening. Mickaël 2015-02-03 15:15 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: 2015-02-03 12:57 GMT+01:00 Christophe Gisquet christophe.gisq

[FFmpeg-devel] support for monochrome sequences in hevc decoder

Hi here is a commit that support monochrome sequences! https://github.com/OpenHEVC/FFmpeg/commit/8e50557707d2ec11ccad657470b2e140f314348e Commit hash: 8e50557707d2ec11ccad657470b2e140f314348e Mickael ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] support for monochrome sequences in hevc decoder

I did it first :) 2015-02-02 16:47 GMT+01:00 Michael Niedermayer michae...@gmx.at: On Mon, Feb 02, 2015 at 04:11:33PM +0100, Mickaël Raulet wrote: Hi here is a commit that support monochrome sequences! https://github.com/OpenHEVC/FFmpeg/commit/8e50557707d2ec11ccad657470b2e140f314348e

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

PL Lepere is the original author and I did some improvements on top of it. Mickael 2015-02-02 18:11 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com : Hi, 2015-02-02 17:16 GMT+01:00 Mickaël Raulet mrau...@insa-rennes.fr: https://github.com/OpenHEVC/FFmpeg/commit

Re: [FFmpeg-devel] [PATCH 3/3] x86/hevc: add ff_hevc_sao_band_filter_{8, 10, 12}_{sse2, avx2}

LGTM. Mickaël Le samedi 31 janvier 2015, Christophe Gisquet christophe.gisq...@gmail.com a écrit : Hi, 2015-01-30 19:50 GMT+01:00 James Almer jamr...@gmail.com javascript:;: +%macro HEVC_SAO_BAND_FILTER_COMPUTE 3 +psraw %2, %3, %1-5 +pcmpeqw m10, %2, m0 +

Re: [FFmpeg-devel] [PATCH 2/5] x86: hevc_mc: correct unneeded use of SSE4 code

this commit might help to solve the issue with SSE4 https://github.com/OpenHEVC/FFmpeg/commit/df8ebe304df453f26c28ff8f11d607f49b90a4c2 Mickaël Le 24 août 2014 à 11:52, Michael Niedermayer michae...@gmx.at a écrit : On Sun, Aug 24, 2014 at 08:46:31AM +, Christophe Gisquet wrote: ---

Re: [FFmpeg-devel] [PATCH 0/2] x86: hevc_mc: port to SSSE3

For 10bits and 12bits, they should stay sse4 as well because of packusdw. You need some instructions to convert it to ssse3 see below static av_always_inline __m128i _MM_PACKUS_EPI32( __m128i a, __m128i b ) { a = _mm_slli_epi32 (a, 16); a = _mm_srai_epi32 (a, 16); b =

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

Patch okay. Mickaël Le 4 août 2014 à 10:31, Christophe Gisquet christophe.gisq...@gmail.com a écrit : Hi, 2014-08-02 14:48 GMT+02:00 Michael Niedermayer michae...@gmx.at: seems to fail with libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol `MAX_PB_SIZE' in

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

for the whole patchset. Mickaël Le 22 août 2014 à 13:25, Michael Niedermayer michae...@gmx.at a écrit : On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote: Patch okay. patch applied just to make sure i dont misunderstand, that okay was just for this patch or the whole

Re: [FFmpeg-devel] [PATCH] x86/hecv_res_add: add ff_hevc_transform_add{8, 16, 32}_8_avx

Patch ok Mickael Le mercredi 20 août 2014, James Almer jamr...@gmail.com a écrit : ~15% faster than sse2 Signed-off-by: James Almer jamr...@gmail.com javascript:; --- libavcodec/x86/hevc_res_add.asm | 15 +++ libavcodec/x86/hevcdsp.h| 4

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: do cleanup in case of unsupported bit depth

Ok. Mickael Le mercredi 20 août 2014, Timothy Gu timothyg...@gmail.com a écrit : On Tue, Aug 19, 2014 at 6:49 PM, Michael Niedermayer michae...@gmx.at javascript:; wrote: Fixes memleak Fixes CID1231989 Signed-off-by: Michael Niedermayer michae...@gmx.at javascript:; ---

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi Le 10 août 2014 à 15:16, Christophe Gisquet christophe.gisq...@gmail.com a écrit : Hi, 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje rsbul...@gmail.com: Are we using the checked bitstream reader? If we are, we're fine already... I think we are. On the other hand, it seems the top

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi Le 10 août 2014 à 15:48, Michael Niedermayer michae...@gmx.at a écrit : On Sun, Aug 10, 2014 at 03:16:23PM +0200, Christophe Gisquet wrote: Hi, 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje rsbul...@gmail.com: Are we using the checked bitstream reader? If we are, we're fine already... I

Re: [FFmpeg-devel] [PATCH] hevc_deblock: change tc type

Patch ok Mickael Le mercredi 6 août 2014, Christophe Gisquet christophe.gisq...@gmail.com a écrit : Hi, this patch is mostly cosmetical. I don't like seeing arrays passed to dsp functions being of a type whose length may not be fixed, though it's a small matter here. -- Christophe

Re: [FFmpeg-devel] [PATCH 1/3] x86/hevc_mc: remove an unnecessary pxor

Patch ok. Mickael Le lundi 4 août 2014, James Almer jamr...@gmail.com a écrit : Signed-off-by: James Almer jamr...@gmail.com javascript:; --- libavcodec/x86/hevc_mc.asm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm

Re: [FFmpeg-devel] [PATCH] hevc_mc: reduce stride for bidir temp buffers

Hi Christophe hevc.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) 2445ba15d38b2472f8f1b24aa75e63c089971480 0012-hevc_mc-reduce-stride-for-bidir-temp-buffers.patch From 126adf820bc54c2d00f794629595ad6310fbfc37 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet